60726 2011-05-12 14:06:11 -0700 REGRESSION (WebKit2): Flash 9 never uses windowless mode 2011-05-13 06:45:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 46399 1 bweinstein bweinstein aroben oldest_to_newest 403134 0 bweinstein 2011-05-12 14:06:11 -0700 Versions of flash before 10 only request windowless plugins if we return a Mozilla user agent. We should add that quirk. 403138 1 bweinstein 2011-05-12 14:09:07 -0700 To test: Install Flash version < 10 (http://kb2.adobe.com/cps/142/tn_14266.html) and test at http://communitymx.com/content/source/E5141/wmodetrans.htm. You should see a star behind the bouncing ball. 403144 2 93337 bweinstein 2011-05-12 14:11:33 -0700 Created attachment 93337 [PATCH] Fix 403151 3 93337 aroben 2011-05-12 14:14:29 -0700 Comment on attachment 93337 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=93337&action=review > Source/WebKit2/Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:126 > + // Pre Flash v10 only requests windowless plugins if we use a Mozilla user agent. > + > + // To test: Install Flash version < 10 (http://kb2.adobe.com/cps/142/tn_14266.html) > + // and test at http://communitymx.com/content/source/E5141/wmodetrans.htm. You should > + // see a star behind the bouncing ball. I'd move these comments inside the if (mimeTypes[i].type == ...) test. That way they are closer to the code that is actually dealing with Flash. I think it would be a little better to put the test case info in the bug and have the comment just reference the bug. > Source/WebKit2/Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:129 > + if (mimeTypes[i].type == "application/x-shockwave-flash") { You could add a FIXME here saying that it's a little strange to assume that any plugin that handles this MIME type needs this quirk. (Maybe we should be checking the plugin's name instead, e.g.) > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:137 > +#if PLUGIN_ARCHITECTURE(MAC) > + "Macintosh; U; Intel Mac OS X;" I don't think Apple's Mac port ever had this behavior before. (Only Qt/mac and GTK+/mac did.) We should test to make sure it's really desired. 403154 4 93337 aroben 2011-05-12 14:15:29 -0700 Comment on attachment 93337 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=93337&action=review >> Source/WebKit2/Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:126 >> + if (mimeTypes[i].type == "application/x-shockwave-flash") { > > I'd move these comments inside the if (mimeTypes[i].type == ...) test. That way they are closer to the code that is actually dealing with Flash. > > I think it would be a little better to put the test case info in the bug and have the comment just reference the bug. Sorry, this comment was from the older patch attached to bug 46399. >> Source/WebKit2/Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:129 >> + > > You could add a FIXME here saying that it's a little strange to assume that any plugin that handles this MIME type needs this quirk. (Maybe we should be checking the plugin's name instead, e.g.) This one too. 403521 5 aroben 2011-05-13 06:45:03 -0700 Committed r86380: <http://trac.webkit.org/changeset/86380> 93337 2011-05-12 14:11:33 -0700 2011-05-12 14:15:29 -0700 [PATCH] Fix quirk_flash_v9.patch text/plain 4615 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2Mzc2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDUtMTIgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IEltcGxlbWVudCBwbHVnaW4gcXVpcmsg Zm9yIE1vemlsbGEgdXNlciBhZ2VudCBmb3Igb2xkZXIgRmxhc2gKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNzI2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS84NDcwODI0PgorICAgICAgICAKKyAgICAgICAgSW1wbGVtZW50IHRoZSBxdWlyayBmb3Ig dmVyc2lvbnMgb2YgRmxhc2ggYmVmb3JlIHYxMCB0aGF0IG9ubHkgcmVxdWVzdCB3aW5kb3dsZXNz IHBsdWdpbnMKKyAgICAgICAgaWYgd2UgdXNlIGEgTW96aWxsYSB1c2VyIGFnZW50LgorCisgICAg ICAgICogU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUvd2luL05ldHNjYXBlUGx1Z2luTW9kdWxlV2lu LmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmRldGVybWluZVF1 aXJrcyk6IElmIHdlIGhhdmUgYSBwbHVnaW4gdGhhdCBoYW5kbGVzIHRoZQorICAgICAgICAgICAg ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBNSU1FIHR5cGUgd2l0aCBhIHZlcnNpb24g bGVzcyB0aGFuIDEwLCB0ZWxsIGl0IHRvIHVzZQorICAgICAgICAgICAgdGhlIE1vemlsbGEgdXNl ciBhZ2VudC4KKyAgICAgICAgKiBTaGFyZWQvUGx1Z2lucy9QbHVnaW5RdWlya3MuaDoKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwOgorICAg ICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6dXNlckFnZW50KTogQWRkIGFuIGVhcmx5IHJl dHVybiBpZiB0aGUgcGx1Z2luIHVzZXMgdGhlIE1vemlsbGEgdXNlcgorICAgICAgICAgICAgYWdl bnQuCisgICAgICAgICogd2luL1dlYktpdDIudmNwcm9qOiBBZGQgUGx1Z2luUXVpcmtzLmguCisK IDIwMTEtMDUtMTIgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9Q bHVnaW5zL1BsdWdpblF1aXJrcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9QbHVnaW5zL1BsdWdpblF1aXJrcy5oCShyZXZpc2lvbiA4NjM3MykKKysrIFNvdXJjZS9XZWJL aXQyL1NoYXJlZC9QbHVnaW5zL1BsdWdpblF1aXJrcy5oCSh3b3JraW5nIGNvcHkpCkBAIC02MSw2 ICs2MSw5IEBAIHB1YmxpYzoKICAgICAgICAgLy8gTlBOX0dldFZhbHVlIGV2ZW4gd2hlbiBpdCBp cyBhIGxpZS4KICAgICAgICAgUmVxdWlyZXNHVEtUb29sS2l0LAogI2VuZGlmCisgICAKKyAgICAg ICAgV2FudHNNb3ppbGxhVXNlckFnZW50LAorCiAgICAgICAgIE51bVBsdWdpblF1aXJrcwogICAg IH07CiAgICAgCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OZXRzY2FwZS93 aW4vTmV0c2NhcGVQbHVnaW5Nb2R1bGVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1NoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRzY2FwZVBsdWdpbk1vZHVsZVdpbi5j cHAJKHJldmlzaW9uIDg2MzczKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0 c2NhcGUvd2luL05ldHNjYXBlUGx1Z2luTW9kdWxlV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTE2LDYgKzExNiwyNSBAQCBib29sIE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpnZXRQbHVnaW5JbmZv CiAKIHZvaWQgTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmRldGVybWluZVF1aXJrcygpCiB7CisgICAg UGx1Z2luSW5mb1N0b3JlOjpQbHVnaW4gcGx1Z2luOworICAgIGdldFBsdWdpbkluZm8obV9wbHVn aW5QYXRoLCBwbHVnaW4pOworCisgICAgVmVjdG9yPE1pbWVDbGFzc0luZm8+IG1pbWVUeXBlcyA9 IHBsdWdpbi5pbmZvLm1pbWVzOworICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbWltZVR5cGVz LnNpemUoKTsgKytpKSB7CisgICAgICAgIC8vIEZJWE1FOiBJdCBzZWVtcyBzdHJhbmdlIHRvIGFz c3VtZSB0aGF0IGFueSBwbHVnaW4gdGhhdCBoYW5kbGVzIHRoaXMgTUlNRSB0eXBlIG5lZWRzIHRo aXMgcXVpcmsuIFNob3VsZAorICAgICAgICAvLyB3ZSBiZSBiZSBjaGVja2luZyB0aGUgcGx1Z2lu J3MgbmFtZSBpbnN0ZWFkPworICAgICAgICBpZiAobWltZVR5cGVzW2ldLnR5cGUgPT0gImFwcGxp Y2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIikgeworICAgICAgICAgICAgdWludDY0X3QgZmxhc2hU ZW5WZXJzaW9uID0gZmlsZVZlcnNpb24oMHgwMDAwMDAwMCwgMHgwMDBhMDAwMCk7CisgICAgICAg ICAgICB1aW50NjRfdCB2ZXJzaW9uID0gcGx1Z2luLmZpbGVWZXJzaW9uOworCisgICAgICAgICAg ICAvLyBQcmUgRmxhc2ggdjEwIG9ubHkgcmVxdWVzdHMgd2luZG93bGVzcyBwbHVnaW5zIGlmIHdl IHVzZSBhIE1vemlsbGEgdXNlciBhZ2VudC4KKyAgICAgICAgICAgIC8vIEZvciB0ZXN0aW5nIGlu Zm9ybWF0aW9uLCBzZWU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDcyNi4KKyAgICAgICAgICAgIGlmICh2ZXJzaW9uIDwgZmxhc2hUZW5WZXJzaW9uKQorICAgICAg ICAgICAgICAgIG1fcGx1Z2luUXVpcmtzLmFkZChQbHVnaW5RdWlya3M6OldhbnRzTW96aWxsYVVz ZXJBZ2VudCk7CisKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgfQogfQogCiB9 IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcAkocmV2 aXNpb24gODYzNzMpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUvTmV0c2NhcGVQbHVnaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIsOCArMTMyLDI2IEBA IGNvbnN0IGNoYXIqIE5ldHNjYXBlUGx1Z2luOjp1c2VyQWdlbnQoTlAKICAgICByZXR1cm4gMDsK IH0KIAorc3RhdGljIGNvbnN0IGNoYXIqIE1vemlsbGFVc2VyQWdlbnQgPSAiTW96aWxsYS81LjAg KCIKKyNpZiBQTFVHSU5fQVJDSElURUNUVVJFKE1BQykKKyAgICAgICAgIk1hY2ludG9zaDsgVTsg SW50ZWwgTWFjIE9TIFg7IgorI2VsaWYgUExVR0lOX0FSQ0hJVEVDVFVSRShXSU4pCisgICAgICAg ICJXaW5kb3dzOyBVOyBXaW5kb3dzIE5UIDUuMTsiCisjZWxpZiBQTFVHSU5fQVJDSElURUNUVVJF KFgxMSkKKy8vIFRoZSBHdGsgcG9ydCB1c2VzIFgxMSBwbHVnaW5zIGluIE1hYy4KKyNpZiBPUyhE QVJXSU4pICYmIFBMQVRGT1JNKEdUSykKKyAgICAiWDExOyBVOyBJbnRlbCBNYWMgT1MgWDsiCisj ZWxzZQorICAgICJYMTE7IFU7IExpbnV4IGk2ODY7IgorI2VuZGlmCisjZW5kaWYKKyAgICAgICAg IiBlbi1VUzsgcnY6MS44LjEpIEdlY2tvLzIwMDYxMDEwIEZpcmVmb3gvMi4wIjsKKwogY29uc3Qg Y2hhciogTmV0c2NhcGVQbHVnaW46OnVzZXJBZ2VudCgpCiB7CisgICAgaWYgKHF1aXJrcygpLmNv bnRhaW5zKFBsdWdpblF1aXJrczo6V2FudHNNb3ppbGxhVXNlckFnZW50KSkKKyAgICAgICAgcmV0 dXJuIE1vemlsbGFVc2VyQWdlbnQ7CisKICAgICBpZiAobV91c2VyQWdlbnQuaXNOdWxsKCkpIHsK ICAgICAgICAgbV91c2VyQWdlbnQgPSBtX3BsdWdpbkNvbnRyb2xsZXItPnVzZXJBZ2VudCgpLnV0 ZjgoKTsKICAgICAgICAgQVNTRVJUKCFtX3VzZXJBZ2VudC5pc051bGwoKSk7CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi93aW4vV2ViS2l0Mi52Y3Byb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvd2luL1dlYktpdDIudmNwcm9qCShyZXZpc2lvbiA4NjM3MykKKysrIFNvdXJjZS9XZWJLaXQy L3dpbi9XZWJLaXQyLnZjcHJvagkod29ya2luZyBjb3B5KQpAQCAtMTQwMSw2ICsxNDAxLDEwIEBA CiAJCQk8RmlsdGVyCiAJCQkJTmFtZT0iUGx1Z2lucyIKIAkJCQk+CisJCQkJPEZpbGUKKwkJCQkJ UmVsYXRpdmVQYXRoPSIuLlxTaGFyZWRcUGx1Z2luc1xQbHVnaW5RdWlya3MuaCIKKwkJCQkJPgor CQkJCTwvRmlsZT4KIAkJCQk8RmlsdGVyCiAJCQkJCU5hbWU9Ik5ldHNjYXBlIgogCQkJCQk+Cg==