6072 2005-12-13 21:42:38 -0800 Remove dead _frameForDataSource: method from WebView 2005-12-13 22:13:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 25927 0 mjs 2005-12-13 21:42:38 -0800 The _frameForDataSource: method on WebView is not used anywhere in WebKit. I have a patch to remove it. 25928 1 5070 mjs 2005-12-13 21:45:17 -0800 Created attachment 5070 Remove the offending method 5070 2005-12-13 21:45:17 -0800 2005-12-13 21:49:32 -0800 Remove the offending method dead-code.patch.txt text/plain 3520 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNDAyCmRpZmYgLXUgLXAgLXIxLjM0MDIg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMTQgRGVjIDIwMDUgMDE6MTQ6MTQgLTAwMDAJMS4zNDAy CisrKyBDaGFuZ2VMb2cJMTQgRGVjIDIwMDUgMDU6Mjc6MzIgLTAwMDAKQEAgLTEsMyArMSwxMiBA QAorMjAwNS0xMi0xMyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJLSByZW1vdmUgdGhlIGRlYWQgX2Zy YW1lRm9yRGF0YVNvdXJjZTogbWV0aG9kIChXZWJEYXRhU291cmNlIG5vdyBrbm93cyBpdHMgV2Vi RnJhbWUpCisKKyAgICAgICAgKiBXZWJWaWV3LnN1YnByb2ovV2ViVmlldy5tOgorICAgICAgICAq IFdlYlZpZXcuc3VicHJvai9XZWJWaWV3UHJpdmF0ZS5oOgorCiA9PT0gU2FmYXJpLTUyMX41ID09 PQogCiAyMDA1LTEyLTEyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KSW5k ZXg6IFdlYlZpZXcuc3VicHJvai9XZWJWaWV3Lm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L1dlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViVmlldy5tLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjMxNgpkaWZmIC11IC1wIC1yMS4zMTYgV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubQotLS0g V2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubQkxMCBEZWMgMjAwNSAyMDo0MDozNSAtMDAwMAkxLjMx NgorKysgV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubQkxNCBEZWMgMjAwNSAwNToyNzozNCAtMDAw MApAQCAtODg1LDQxICs4ODUsNiBAQCBzdGF0aWMgYm9vbCBkZWJ1Z1dpZGdldCA9IHRydWU7CiAg ICAgcmV0dXJuIF9wcml2YXRlLT5zY3JpcHREZWJ1Z0RlbGVnYXRlRm9yd2FyZGVyOwogfQogCi0t IChXZWJGcmFtZSAqKV9mcmFtZUZvckRhdGFTb3VyY2U6IChXZWJEYXRhU291cmNlICopZGF0YVNv dXJjZSBmcm9tRnJhbWU6IChXZWJGcmFtZSAqKWZyYW1lCi17Ci0gICAgTlNBcnJheSAqZnJhbWVz OwotICAgIGludCBpLCBjb3VudDsKLSAgICBXZWJGcmFtZSAqcmVzdWx0LCAqYUZyYW1lOwotCi0g ICAgaWYgKFtmcmFtZSBkYXRhU291cmNlXSA9PSBkYXRhU291cmNlKQotICAgICAgICByZXR1cm4g ZnJhbWU7Ci0KLSAgICBpZiAoW2ZyYW1lIHByb3Zpc2lvbmFsRGF0YVNvdXJjZV0gPT0gZGF0YVNv dXJjZSkKLSAgICAgICAgcmV0dXJuIGZyYW1lOwotCi0gICAgLy8gSXQncyBzYWZlIHRvIHVzZSB0 aGUgaW50ZXJuYWwgdmVyc2lvbiBiZWNhdXNlIHdlIGtub3cgdGhpcwotICAgIC8vIGZ1bmN0aW9u IHdpbGwgbm90IGNoYW5nZSB0aGUgc2V0IG9mIGZyYW1lcwotICAgIGZyYW1lcyA9IFtmcmFtZSBf aW50ZXJuYWxDaGlsZEZyYW1lc107Ci0gICAgY291bnQgPSBbZnJhbWVzIGNvdW50XTsKLSAgICBm b3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKyl7Ci0gICAgICAgIGFGcmFtZSA9IFtmcmFtZXMgb2Jq ZWN0QXRJbmRleDogaV07Ci0gICAgICAgIHJlc3VsdCA9IFtzZWxmIF9mcmFtZUZvckRhdGFTb3Vy Y2U6IGRhdGFTb3VyY2UgZnJvbUZyYW1lOiBhRnJhbWVdOwotICAgICAgICBpZiAocmVzdWx0KQot ICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKLSAgICB9Ci0KLSAgICByZXR1cm4gbmlsOwotfQot Ci0KLS0gKFdlYkZyYW1lICopX2ZyYW1lRm9yRGF0YVNvdXJjZTogKFdlYkRhdGFTb3VyY2UgKilk YXRhU291cmNlCi17Ci0gICAgV2ViRnJhbWUgKmZyYW1lID0gW3NlbGYgbWFpbkZyYW1lXTsKLQot ICAgIHJldHVybiBbc2VsZiBfZnJhbWVGb3JEYXRhU291cmNlOiBkYXRhU291cmNlIGZyb21GcmFt ZTogZnJhbWVdOwotfQotCi0KIC0gKFdlYkZyYW1lICopX2ZyYW1lRm9yVmlldzogKFdlYkZyYW1l VmlldyAqKWFWaWV3IGZyb21GcmFtZTogKFdlYkZyYW1lICopZnJhbWUKIHsKICAgICBOU0FycmF5 ICpmcmFtZXM7CkluZGV4OiBXZWJWaWV3LnN1YnByb2ovV2ViVmlld1ByaXZhdGUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJWaWV3UHJp dmF0ZS5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE1MApkaWZmIC11IC1wIC1yMS4xNTAgV2Vi Vmlldy5zdWJwcm9qL1dlYlZpZXdQcml2YXRlLmgKLS0tIFdlYlZpZXcuc3VicHJvai9XZWJWaWV3 UHJpdmF0ZS5oCTE5IE5vdiAyMDA1IDAxOjI3OjA2IC0wMDAwCTEuMTUwCisrKyBXZWJWaWV3LnN1 YnByb2ovV2ViVmlld1ByaXZhdGUuaAkxNCBEZWMgMjAwNSAwNToyNzozNCAtMDAwMApAQCAtMTQw LDI0ICsxNDAsNyBAQCB0eXBlZGVmIGVudW0gewogKi8KICsgKE5TU3RyaW5nICopc3VnZ2VzdGVk RmlsZUV4dGVuc2lvbkZvck1JTUVUeXBlOiAoTlNTdHJpbmcgKilNSU1FVHlwZTsKIAotLyohCi0g ICAgQG1ldGhvZCBmcmFtZUZvckRhdGFTb3VyY2U6Ci0gICAgQGFic3RyYWN0IFJldHVybiB0aGUg ZnJhbWUgYXNzb2NpYXRlZCB3aXRoIHRoZSBkYXRhIHNvdXJjZS4KLSAgICBAZGlzY3Vzc2lvbiBU cmF2ZXJzZXMgdGhlIGZyYW1lIHRyZWUgdG8gZmluZCB0aGUgZnJhbWUgYXNzb2NpYXRlZAotICAg IHdpdGggYSBkYXRhc291cmNlLgotICAgIEBwYXJhbSBkYXRhc291cmNlIFRoZSBkYXRhc291cmNl IHRvICBtYXRjaCBhZ2FpbnN0IGVhY2ggZnJhbWUuCi0gICAgQHJlc3VsdCBUaGUgZnJhbWUgdGhh dCBoYXMgdGhlIGFzc29jaWF0ZWQgZGF0YXNvdXJjZS4KLSovCi0tIChXZWJGcmFtZSAqKV9mcmFt ZUZvckRhdGFTb3VyY2U6IChXZWJEYXRhU291cmNlICopZGF0YVNvdXJjZTsKLQotICAgIC8qIQot ICAgICAgICAgICAgQG1ldGhvZCBmcmFtZUZvclZpZXc6Ci0gICAgIEBhYnN0cmFjdCBSZXR1cm4g dGhlIGZyYW1lIGFzc29jaWF0ZWQgd2l0aCB0aGUgdmlldy4KLSAgICAgQGRpc2N1c3Npb24gVHJh dmVyc2VzIHRoZSBmcmFtZSB0cmVlIHRvIGZpbmQgdGhlIHZpZXcuCi0gICAgIEBwYXJhbSBhVmll dyBUaGUgdmlldyB0byBtYXRjaCBhZ2FpbnN0IGVhY2ggZnJhbWUuCi0gICAgIEByZXN1bHQgVGhl IGZyYW1lIHRoYXQgaGFzIHRoZSBhc3NvY2lhdGVkIHZpZXcuCi0gICAgICovCi0tIChXZWJGcmFt ZSAqKV9mcmFtZUZvclZpZXc6IChXZWJGcmFtZVZpZXcgKilhVmlldzsKKy0gKFdlYkZyYW1lICop X2ZyYW1lRm9yVmlldzooV2ViRnJhbWVWaWV3ICopdmlldzsKIAogLSAoV2ViRnJhbWUgKilfY3Jl YXRlRnJhbWVOYW1lZDooTlNTdHJpbmcgKiluYW1lIGluUGFyZW50OihXZWJGcmFtZSAqKXBhcmVu dCBhbGxvd3NTY3JvbGxpbmc6KEJPT0wpYWxsb3dzU2Nyb2xsaW5nOwogCg==