60715 2011-05-12 11:36:27 -0700 [Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be modified 2011-05-17 10:25:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED EasyFix, LayoutTestFailure, Qt, QtTriaged P2 Normal --- 0 ramakrishna.sakamuri webkit-unassigned benjamin commit-queue laszlo.gombos ossy ramakrishna.sakamuri webkit.review.bot oldest_to_newest 403021 0 ramakrishna.sakamuri 2011-05-12 11:36:27 -0700 These four storage layout tests are currently listed in skipped list for Qt platform but are passing on Qt-Linux. LayoutTests/storage/database-lock-after-reload.html LayoutTests/storage/empty-statement.html LayoutTests/storage/execute-sql-args.html LayoutTests/storage/hash-change-with-xhr.html Platform details: Linux desktop on Ubuntu 10.04 Linux version 2.6.32-31-generic Qt 4.7.2 WebKit version r86351 I will submit a patch for the updated skip list. 403056 1 93322 ramakrishna.sakamuri 2011-05-12 12:06:13 -0700 Created attachment 93322 removed the passed test from Qt skipped list 403477 2 93322 benjamin 2011-05-13 04:53:17 -0700 Comment on attachment 93322 removed the passed test from Qt skipped list View in context: https://bugs.webkit.org/attachment.cgi?id=93322&action=review There is something very weird with your patch. The diff does not make much sense. > LayoutTests/ChangeLog:5 > + [Qt] [Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be modified [Qt] [Qt] ? 404647 3 93681 ramakrishna.sakamuri 2011-05-16 11:59:47 -0700 Created attachment 93681 updated patch/changelog submited 404669 4 webkit.review.bot 2011-05-16 13:08:18 -0700 Attachment 93681 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 405060 5 93681 cshu 2011-05-17 08:12:36 -0700 Comment on attachment 93681 updated patch/changelog submited View in context: https://bugs.webkit.org/attachment.cgi?id=93681&action=review >> LayoutTests/ChangeLog:6 >> + https://bugs.webkit.org/show_bug.cgi?id=60715 > > Line contains tab character. [whitespace/tab] [5] Please fix the tab issue. 405104 6 93782 ramakrishna.sakamuri 2011-05-17 09:53:27 -0700 Created attachment 93782 fixed tab issue in previous patch submited 405132 7 93782 commit-queue 2011-05-17 10:25:26 -0700 Comment on attachment 93782 fixed tab issue in previous patch submited Clearing flags on attachment: 93782 Committed r86682: <http://trac.webkit.org/changeset/86682> 405134 8 commit-queue 2011-05-17 10:25:31 -0700 All reviewed patches have been landed. Closing bug. 93322 2011-05-12 12:06:13 -0700 2011-05-16 11:59:47 -0700 removed the passed test from Qt skipped list patch_60715_v1.patch text/plain 1271 ramakrishna.sakamuri SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg2MzY3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMTIgIFNha2FtdXJpIFJhbWFrcmlz aG5hICA8cmFtYWtyaXNobmEuc2FrYW11cmlAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICBbUXRdIFtRdF0gNCBvZiB0aGUgc2tpcHBlZCBzdG9y YWdlIGxheW91dCB0ZXN0cyBwYXNzIG9uIFF0IExpbnV4IC0gc2tpcCBsaXN0IHRvIGJlIG1vZGlm aWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDcx NQorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwpJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAoKLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJ KHJldmlzaW9uIDg2MzUyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29y a2luZyBjb3B5KQotc3RvcmFnZS9kYXRhYmFzZS1sb2NrLWFmdGVyLXJlbG9hZC5odG1sCi1zdG9y YWdlL2VtcHR5LXN0YXRlbWVudC5odG1sCi1zdG9yYWdlL2V4ZWN1dGUtc3FsLWFyZ3MuaHRtbAot c3RvcmFnZS9oYXNoLWNoYW5nZS13aXRoLXhoci5odG1sCgo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CjIwMTEtMDUtMTIg IEFuZHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBleHBlY3RhdGlvbnMgdXBkYXRlIGZvciBjaHJvbWl1bS4KCgpAQCAtNTE2LDEwICs1MTYs NiBAQCBodHRwL3Rlc3RzL2Nvb2tpZXMvc2ltcGxlLWNvb2tpZXMtZXhwaXJlCiBodHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3dvcmtlcnMvY2xvc2UuaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItY2xvc2UuaHRtbAogCiB0cmFuc2l0aW9ucy9jaGFu Z2UtdmFsdWVzLWR1cmluZy10cmFuc2l0aW9uLmh0bWwKIAogIyBodHRwL3Rlc3RzL2luc3BlY3Rv ci9yZXNvdXJjZS1oYXItY29udmVyc2lvbi5odG1sIGlzIGZhaWxpbmcgb24gdGhlIHJlbGVhc2Ug Ym90IGFmdGVyIHI2MzE5MQo= 93681 2011-05-16 11:59:47 -0700 2011-05-17 09:53:27 -0700 updated patch/changelog submited patch_60715_v1.patch text/plain 1249 ramakrishna.sakamuri SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg2NTkzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMTYgIFNha2FtdXJpIFJhbWFrcmlz aG5hICA8cmFtYWtyaXNobmEuc2FrYW11cmlAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gNCBvZiB0aGUgc2tpcHBlZCBzdG9y YWdlIGxheW91dCB0ZXN0cyBwYXNzIG9uIFF0IExpbnV4IC0gc2tpcCBsaXN0IHRvIGJlIG1vZGlm aWVkCisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNzE1CisKKyAg ICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTA1LTE2ICBQYXZlbCBQb2Rpdmls b3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkg U2VtaWtoYXRza3kuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlzaW9uIDg2NTkz KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAt NDI4LDEwICs0MjgsNiBAQCBodHRwL3Rlc3RzL2Nvb2tpZXMvc2ltcGxlLWNvb2tpZXMtZXhwaXJl CiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3dvcmtlcnMvY2xvc2UuaHRtbAogaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItY2xvc2UuaHRtbAogCi1zdG9y YWdlL2RhdGFiYXNlLWxvY2stYWZ0ZXItcmVsb2FkLmh0bWwKLXN0b3JhZ2UvZW1wdHktc3RhdGVt ZW50Lmh0bWwKLXN0b3JhZ2UvZXhlY3V0ZS1zcWwtYXJncy5odG1sCi1zdG9yYWdlL2hhc2gtY2hh bmdlLXdpdGgteGhyLmh0bWwKIHRyYW5zaXRpb25zL2NoYW5nZS12YWx1ZXMtZHVyaW5nLXRyYW5z aXRpb24uaHRtbAogCiAjIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLWhhci1jb252ZXJz aW9uLmh0bWwgaXMgZmFpbGluZyBvbiB0aGUgcmVsZWFzZSBib3QgYWZ0ZXIgcjYzMTkxCg== 93782 2011-05-17 09:53:27 -0700 2011-05-17 10:25:26 -0700 fixed tab issue in previous patch submited patch_60715_v2.patch text/plain 1273 ramakrishna.sakamuri SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg2NjczKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMTcgIFNha2FtdXJpIFJhbWFrcmlz aG5hICA8cmFtYWtyaXNobmEuc2FrYW11cmlAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gNCBvZiB0aGUgc2tpcHBlZCBzdG9y YWdlIGxheW91dCB0ZXN0cyBwYXNzIG9uIFF0IExpbnV4LSBza2lwIGxpc3QgdG8gYmUgbW9kaWZp ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNzE1 CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTA1LTE3ICBKZXNzaWUg QmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBuZWVkcyBsYXlv dXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UuCkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQJKHJldmlzaW9uIDg2NjcxKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp cHBlZAkod29ya2luZyBjb3B5KQpAQCAtNDI1LDEwICs0MjUsNiBAQCBodHRwL3Rlc3RzL2Nvb2tp ZXMvc2ltcGxlLWNvb2tpZXMtZXhwaXJlCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3dvcmtl cnMvY2xvc2UuaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC93b3JrZXJzL3NoYXJlZC13 b3JrZXItY2xvc2UuaHRtbAogCi1zdG9yYWdlL2RhdGFiYXNlLWxvY2stYWZ0ZXItcmVsb2FkLmh0 bWwKLXN0b3JhZ2UvZW1wdHktc3RhdGVtZW50Lmh0bWwKLXN0b3JhZ2UvZXhlY3V0ZS1zcWwtYXJn cy5odG1sCi1zdG9yYWdlL2hhc2gtY2hhbmdlLXdpdGgteGhyLmh0bWwKIHRyYW5zaXRpb25zL2No YW5nZS12YWx1ZXMtZHVyaW5nLXRyYW5zaXRpb24uaHRtbAogCiAjIGh0dHAvdGVzdHMvaW5zcGVj dG9yL3Jlc291cmNlLWhhci1jb252ZXJzaW9uLmh0bWwgaXMgZmFpbGluZyBvbiB0aGUgcmVsZWFz ZSBib3QgYWZ0ZXIgcjYzMTkxCg==