60710 2011-05-12 10:58:30 -0700 JavaScriptGlue should compile with -Wmissing-prototypes 2014-04-24 16:45:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer ggaren oliver webkit.review.bot oldest_to_newest 402961 0 93305 ddkilzer 2011-05-12 10:58:30 -0700 Created attachment 93305 Patch Reviewed by NOBODY (OOPS!). Enabling -Wmissing-prototypes fixes an Xcode 4 project warning. This also fixes the following compiler warning: JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3] JSGlobalData* getThreadGlobalData() ^ * Configurations/Base.xcconfig: Set GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES. * JSUtils.cpp: (getThreadGlobalData): Made static. --- 3 files changed, 21 insertions(+), 2 deletions(-) 402962 1 webkit.review.bot 2011-05-12 11:01:14 -0700 Attachment 93305 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptGlue/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptGlue/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 402991 2 93305 ggaren 2011-05-12 11:21:30 -0700 Comment on attachment 93305 Patch r=me 403051 3 ddkilzer 2011-05-12 12:05:59 -0700 *** Bug 60704 has been marked as a duplicate of this bug. *** 403053 4 ddkilzer 2011-05-12 12:06:02 -0700 *** Bug 60705 has been marked as a duplicate of this bug. *** 403055 5 ddkilzer 2011-05-12 12:06:06 -0700 *** Bug 60706 has been marked as a duplicate of this bug. *** 403239 6 ddkilzer 2011-05-12 16:36:47 -0700 Committed r86396: <http://trac.webkit.org/changeset/86396> 1003857 7 darin 2014-04-24 16:45:22 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 93305 2011-05-12 10:58:30 -0700 2011-05-12 11:21:29 -0700 Patch 20110512105828.patch text/plain 2324 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogODYyMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 R2x1ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdEdsdWUvQ2hhbmdlTG9nCmluZGV4IGQ4 YTdiODAzYTdkNzdhNmI2ZjUzOWNhNDk2NTczYWM2MjVhY2QzMjYuLjlkODY1ZjU2MmEzZTJjMTY4 OTIxNmQ1ZmJmNWIxNGRkOGMwMTJlOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0R2x1 ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRHbHVlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIyIEBACisyMDExLTA1LTEyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CisKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMDAwMDA+IEphdmFTY3JpcHRHbHVlIHNo b3VsZCBjb21waWxlIHdpdGggLVdtaXNzaW5nLXByb3RvdHlwZXMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGluZyAtV21pc3NpbmctcHJvdG90 eXBlcyBmaXhlcyBhbiBYY29kZSA0IHByb2plY3Qgd2FybmluZy4KKworICAgICAgICBUaGlzIGFs c28gZml4ZXMgdGhlIGZvbGxvd2luZyBjb21waWxlciB3YXJuaW5nOgorCisgICAgICAgICAgICBK YXZhU2NyaXB0R2x1ZS9KU1V0aWxzLmNwcDo0MDc6MTU6IGVycm9yOiBubyBwcmV2aW91cyBwcm90 b3R5cGUgZm9yIGZ1bmN0aW9uICdnZXRUaHJlYWRHbG9iYWxEYXRhJyBbLVdlcnJvciwtV21pc3Np bmctcHJvdG90eXBlcywzXQorICAgICAgICAgICAgIEpTR2xvYmFsRGF0YSogZ2V0VGhyZWFkR2xv YmFsRGF0YSgpCisgICAgICAgICAgICAgICAgICAgICAgICAgICBeCisKKyAgICAgICAgKiBDb25m aWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOiBTZXQKKyAgICAgICAgR0NDX1dBUk5fQUJPVVRfTUlT U0lOR19QUk9UT1RZUEVTID0gWUVTLgorICAgICAgICAqIEpTVXRpbHMuY3BwOgorICAgICAgICAo Z2V0VGhyZWFkR2xvYmFsRGF0YSk6IE1hZGUgc3RhdGljLgorCiAyMDExLTA1LTA2ICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBHQ0Nf RU5BQkxFX0ZJWF9BTkRfQ09OVElOVUUgYW5kIFpFUk9fTElOSyBzZXR0aW5ncwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRHbHVlL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcgYi9T b3VyY2UvSmF2YVNjcmlwdEdsdWUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwppbmRleCAy N2QwODRlYzQ3NjhhZTQ2OGRiNTNmZGY0ZDhhYTZiZDdiYTM3OTM5Li4xZDA4ZWU4ZDEwMGZkZTVk ZGIxOTlkZmE2ZDJmZmJhYTg2YTMzNDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdEds dWUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdEds dWUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwpAQCAtNDIsNyArNDIsNyBAQCBHQ0NfVEhS RUFEU0FGRV9TVEFUSUNTID0gTk87CiBHQ0NfVFJFQVRfV0FSTklOR1NfQVNfRVJST1JTID0gWUVT OwogR0NDX1dBUk5fQUJPVVRfREVQUkVDQVRFRF9GVU5DVElPTlMgPSBOTzsKIEdDQ19XQVJOX0FC T1VUX01JU1NJTkdfTkVXTElORSA9IFlFUzsKLUdDQ19XQVJOX0FCT1VUX01JU1NJTkdfUFJPVE9U WVBFUyA9IE5POworR0NDX1dBUk5fQUJPVVRfTUlTU0lOR19QUk9UT1RZUEVTID0gWUVTOwogR0ND X1dBUk5fTk9OX1ZJUlRVQUxfREVTVFJVQ1RPUiA9IFlFUzsKIExJTktFUl9ESVNQTEFZU19NQU5H TEVEX05BTUVTID0gWUVTOwogUFJFQklORElORyA9IE5POwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRHbHVlL0pTVXRpbHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRHbHVlL0pTVXRpbHMu Y3BwCmluZGV4IDdkYjY1MGYxNjc3ZGI4NmNiMDJkMDUwYzMyZmQ2ZWM0MmNiNjVkNzUuLjFhODI2 YzEzMTdiODhjZjcyNmE1YmI4NmM4NWNmNWJmMzVhYWU2YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0R2x1ZS9KU1V0aWxzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdEdsdWUvSlNV dGlscy5jcHAKQEAgLTQwNCw3ICs0MDQsNyBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXplR2xvYmFs T2JqZWN0S2V5KCkKICAgICBwdGhyZWFkX2tleV9jcmVhdGUoJmdsb2JhbE9iamVjdEtleSwgdW5w cm90ZWN0R2xvYmFsT2JqZWN0KTsKIH0KIAotSlNHbG9iYWxEYXRhKiBnZXRUaHJlYWRHbG9iYWxE YXRhKCkKK3N0YXRpYyBKU0dsb2JhbERhdGEqIGdldFRocmVhZEdsb2JhbERhdGEoKQogewogICAg IHJldHVybiAmSlNHbG9iYWxEYXRhOjpzaGFyZWRJbnN0YW5jZSgpOwogfQo=