60709 2011-05-12 10:52:00 -0700 Assertion failure when requesting that storage be deleted for an origin without storage 2011-05-12 14:31:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jberlin jberlin abarth adauria beidson eric jberlin webkit.review.bot oldest_to_newest 402955 0 jberlin 2011-05-12 10:52:00 -0700 ASSERTION FAILED: !path.isEmpty() /Volumes/Data/jessieberlin/src/Safari/OpenSource/Source/WebCore/storage/StorageTracker.cpp(458) : void WebCore::StorageTracker::syncDeleteOrigin(const WTF::String&) 1 WebCore::StorageTracker::syncDeleteOrigin(WTF::String const&) 2 WebCore::LocalStorageTask::performTask() 3 WebCore::LocalStorageThread::threadEntryPoint() 4 WebCore::LocalStorageThread::threadEntryPointCallback(void*) 5 WTF::threadEntryPoint(void*) 6 _pthread_start 7 thread_start 402958 1 adauria 2011-05-12 10:56:23 -0700 This assertion is too strict. Requesting StorageTracker to delete local storage for an origin that has no local storage is not a misuse of the API. 402971 2 93308 jberlin 2011-05-12 11:07:06 -0700 Created attachment 93308 Patch 403083 3 93308 jberlin 2011-05-12 12:41:53 -0700 Comment on attachment 93308 Patch Thanks for the review, Darin! Commited in http://trac.webkit.org/changeset/86371 403164 4 webkit.review.bot 2011-05-12 14:31:28 -0700 http://trac.webkit.org/changeset/86371 might have broken Leopard Intel Debug (Tests) The following tests are not passing: fast/lists/003-vertical.html fonts/cursive.html 93308 2011-05-12 11:07:06 -0700 2011-05-12 12:41:53 -0700 Patch removeAssertionHitWhenDeletingOriginWithoutStorage.patch text/plain 1635 jberlin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MzU3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMTIgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBc3NlcnRpb24gZmFpbHVyZSB3aGVuIHJlcXVlc3RpbmcgdGhh dCBzdG9yYWdlIGJlIGRlbGV0ZWQgZm9yIGFuIG9yaWdpbiB3aXRob3V0IHN0b3JhZ2UuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDcwOQorCisgICAg ICAgICogc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdG9y YWdlVHJhY2tlcjo6c3luY0RlbGV0ZU9yaWdpbik6CisgICAgICAgIElmIHRoZSBwYXRoIHRvIHRo ZSBzdG9yYWdlIGxvY2F0aW9uIGZvciB0aGUgZ2l2aW4gb3JpZ2luIGlzIGVtcHR5LCByZXR1cm4g ZWFybHkgaW5zdGVhZCBvZgorICAgICAgICBhc3NlcnRpbmcuCisKIDIwMTEtMDUtMTIgIEx1a2Ug TWFjcGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3Jh Z2VUcmFja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3Jh Z2VUcmFja2VyLmNwcAkocmV2aXNpb24gODYzNDEpCisrKyBTb3VyY2UvV2ViQ29yZS9zdG9yYWdl L1N0b3JhZ2VUcmFja2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUyLDEwICs0NTIsMTMgQEAg dm9pZCBTdG9yYWdlVHJhY2tlcjo6c3luY0RlbGV0ZU9yaWdpbihjbwogICAgIG9wZW5UcmFja2Vy RGF0YWJhc2UoZmFsc2UpOwogICAgIGlmICghbV9kYXRhYmFzZS5pc09wZW4oKSkKICAgICAgICAg cmV0dXJuOwotICAgIAotICAgIFN0cmluZyBwYXRoID0gZGF0YWJhc2VQYXRoRm9yT3JpZ2luKG9y aWdpbklkZW50aWZpZXIpOwogCi0gICAgQVNTRVJUKCFwYXRoLmlzRW1wdHkoKSk7CisgICAgU3Ry aW5nIHBhdGggPSBkYXRhYmFzZVBhdGhGb3JPcmlnaW4ob3JpZ2luSWRlbnRpZmllcik7CisgICAg aWYgKHBhdGguaXNFbXB0eSgpKSB7CisgICAgICAgIC8vIEl0IGlzIHBvc3NpYmxlIHRvIGdldCBh IHJlcXVlc3QgZnJvbSB0aGUgQVBJIHRvIGRlbGV0ZSB0aGUgc3RvcmFnZSBmb3IgYW4gb3JpZ2lu IHRoYXQKKyAgICAgICAgLy8gaGFzIG5vIHN1Y2ggc3RvcmFnZS4KKyAgICAgICAgcmV0dXJuOwor ICAgIH0KICAgICAKICAgICBTUUxpdGVTdGF0ZW1lbnQgZGVsZXRlU3RhdGVtZW50KG1fZGF0YWJh c2UsICJERUxFVEUgRlJPTSBPcmlnaW5zIHdoZXJlIG9yaWdpbj0/Iik7CiAgICAgaWYgKGRlbGV0 ZVN0YXRlbWVudC5wcmVwYXJlKCkgIT0gU1FMUmVzdWx0T2spIHsK