60703 2011-05-12 09:14:14 -0700 CSS: Fast path for 'px' lengths should be case-insensitive. 2011-05-16 05:42:54 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling ian oldest_to_newest 402884 0 kling 2011-05-12 09:14:14 -0700 The fast-path for 'px' lengths added on bug 57964 only handles 'px' when in lowercase. 1px, 1PX, 1Px, etc are all valid CSS lengths, and we can easily support them in the fast-path. 402886 1 93293 kling 2011-05-12 09:18:33 -0700 Created attachment 93293 Proposed patch 402911 2 93293 darin 2011-05-12 09:59:26 -0700 Comment on attachment 93293 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=93293&action=review > Source/WebCore/css/CSSParser.cpp:380 > + && (characters[length - 2] == 'p' || characters[length - 2] == 'P') > + && (characters[length - 1] == 'x' || characters[length - 1] == 'X')) { Another version would be: if (length > 2 && (characters[length - 2] | 0x20) == 'p' && (characters[length - 1] | 0x20) == 'x') { This is more efficient on platforms where branches are expensive. We use this idiom elsewhere in CSSParser.cpp for rgb and we even have a function for it in KURL.cpp (isLetterMatchIgnoringCase) and LinkHash.cpp (matchLetter). 404431 3 kling 2011-05-16 05:42:54 -0700 Committed r86561: <http://trac.webkit.org/changeset/86561> 93293 2011-05-12 09:18:33 -0700 2011-05-12 09:59:26 -0700 Proposed patch bug-60703.diff text/plain 1445 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYTgwN2RkLi44NzUyNzY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDUtMTIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENTUzogRmFzdCBwYXRo IGZvciAncHgnIGxlbmd0aHMgc2hvdWxkIGJlIGNhc2UtaW5zZW5zaXRpdmUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDcwMworCisgICAgICAgIE5v IG5ldyB0ZXN0cywgdGhpcyBpcyBhbiBvcHRpbWl6YXRpb24gdGhhdCBhdm9pZHMgY3JlYXRpbmcK KyAgICAgICAgYSBmdWxsIENTU1BhcnNlciB0byBwYXJzZSB0aGUgdmFsdWUuCisKKyAgICAgICAg KiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhcnNlU2ltcGxlTGVuZ3Ro VmFsdWUpOgorCiAyMDExLTA1LTExICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBIYWppbWUgTW9yaXRhLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcAppbmRleCAxOTcxMWQyLi42YjAwOTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApA QCAtMzc1LDcgKzM3NSw5IEBAIHN0YXRpYyBib29sIHBhcnNlU2ltcGxlTGVuZ3RoVmFsdWUoQ1NT TXV0YWJsZVN0eWxlRGVjbGFyYXRpb24qIGRlY2xhcmF0aW9uLCBpbnQKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgQ1NTUHJpbWl0aXZlVmFsdWU6OlVuaXRUeXBlcyB1bml0ID0gQ1NTUHJp bWl0aXZlVmFsdWU6OkNTU19OVU1CRVI7Ci0gICAgaWYgKGxlbmd0aCA+IDIgJiYgY2hhcmFjdGVy c1tsZW5ndGggLSAyXSA9PSAncCcgJiYgY2hhcmFjdGVyc1tsZW5ndGggLSAxXSA9PSAneCcpIHsK KyAgICBpZiAobGVuZ3RoID4gMgorICAgICAgICAmJiAoY2hhcmFjdGVyc1tsZW5ndGggLSAyXSA9 PSAncCcgfHwgY2hhcmFjdGVyc1tsZW5ndGggLSAyXSA9PSAnUCcpCisgICAgICAgICYmIChjaGFy YWN0ZXJzW2xlbmd0aCAtIDFdID09ICd4JyB8fCBjaGFyYWN0ZXJzW2xlbmd0aCAtIDFdID09ICdY JykpIHsKICAgICAgICAgbGVuZ3RoIC09IDI7CiAgICAgICAgIHVuaXQgPSBDU1NQcmltaXRpdmVW YWx1ZTo6Q1NTX1BYOwogICAgIH0gZWxzZSBpZiAobGVuZ3RoID4gMSAmJiBjaGFyYWN0ZXJzW2xl bmd0aCAtIDFdID09ICclJykgewo=