<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60690</bug_id>
          
          <creation_ts>2011-05-11 22:21:49 -0700</creation_ts>
          <short_desc>Avoid increasing required alignment of target type warning on ARM</short_desc>
          <delta_ts>2012-01-15 19:25:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>55368</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryuan Choi">ryuan.choi</reporter>
          <assigned_to name="Ryuan Choi">ryuan.choi</assigned_to>
          <cc>barraclough</cc>
    
    <cc>eric</cc>
    
    <cc>ggaren</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>leo.yang</cc>
    
    <cc>loic.yhuel</cc>
    
    <cc>loki</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>oliver</cc>
    
    <cc>ossy</cc>
    
    <cc>paroga</cc>
    
    <cc>rakuco</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>402662</commentid>
    <comment_count>0</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-11 22:21:49 -0700</bug_when>
    <thetext>-Wcast-align make too many warnings on arm build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402667</commentid>
    <comment_count>1</comment_count>
      <attachid>93246</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-11 22:29:59 -0700</bug_when>
    <thetext>Created attachment 93246
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402808</commentid>
    <comment_count>2</comment_count>
      <attachid>93246</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2011-05-12 06:36:40 -0700</bug_when>
    <thetext>Comment on attachment 93246
Patch

Are you removing the option for arm builds or generally?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402946</commentid>
    <comment_count>3</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-05-12 10:38:26 -0700</bug_when>
    <thetext>It looks like the patch unconditionally removes the flag when CMake is used. IMO, removing this warning can potentially end up hiding places which should ideally be fixed.

Ryuan, are these flags causing any trouble besides polluting your compilation output?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403328</commentid>
    <comment_count>4</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-12 19:14:36 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 93246 [details])
&gt; Are you removing the option for arm builds or generally?

OK, My hope is removing this option for arm builds.
I&apos;ll prepare new patch to check it.

(In reply to comment #3)
&gt; It looks like the patch unconditionally removes the flag when CMake is used. IMO, removing this warning can potentially end up hiding places which should ideally be fixed.
&gt; 
&gt; Ryuan, are these flags causing any trouble besides polluting your compilation output?

Below is warning message of a file.
Those warnings, which generated by almost files, make it difficult to detect important warnings and errors(if exist).

In file included from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObject.h:31:0,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.h:29,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSFunction.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Executable.h:30,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/EvalCodeCache.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/CodeBlock.h:33,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSActivation.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.cpp:26:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSCell.h: In member function &apos;void* JSC::MarkedBlock::allocate()&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSCell.h:410:78: warning: cast from &apos;char (*)[8]&apos; to &apos;JSC::JSCell*&apos; increases required alignment of target type
In file included from /workspace/git/webkit-efl/Source/JavaScriptCore/collector/handles/Handle.h:29:0,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/collector/handles/HandleHeap.h:30,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Heap.h:25,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalData.h:33,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/interpreter/CallFrame.h:26,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/ArgList.h:25,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObject.h:26,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.h:29,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSFunction.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Executable.h:30,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/EvalCodeCache.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/CodeBlock.h:33,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSActivation.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.cpp:26:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::JSGlobalObject]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/ScopeChain.h:76:86:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSGlobalObject*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::JSFunction]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalObject.h:185:70:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSFunction*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::StringPrototype]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalObject.h:193:81:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::StringPrototype*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrIn file included from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObject.h:31:0,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.h:29,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSFunction.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Executable.h:30,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/EvalCodeCache.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/CodeBlock.h:33,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSActivation.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.cpp:26:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSCell.h: In member function &apos;void* JSC::MarkedBlock::allocate()&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSCell.h:410:78: warning: cast from &apos;char (*)[8]&apos; to &apos;JSC::JSCell*&apos; increases required alignment of target type
In file included from /workspace/git/webkit-efl/Source/JavaScriptCore/collector/handles/Handle.h:29:0,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/collector/handles/HandleHeap.h:30,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Heap.h:25,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalData.h:33,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/interpreter/CallFrame.h:26,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/ArgList.h:25,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObject.h:26,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.h:29,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSFunction.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Executable.h:30,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/EvalCodeCache.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/bytecode/CodeBlock.h:33,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSActivation.h:32,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.h:27,
                 from /workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.cpp:26:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::JSGlobalObject]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/ScopeChain.h:76:86:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSGlobalObject*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::JSFunction]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalObject.h:185:70:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSFunction*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::StringPrototype]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalObject.h:193:81:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::StringPrototype*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::NumberPrototype]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalObject.h:194:81:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::NumberPrototype*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::JSActivation]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.cpp:260:133:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSActivation*&apos; increases required alignment of target type
ierBase&lt;T&gt;::get() const [with T = JSC::NumberPrototype]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/JSGlobalObject.h:194:81:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::NumberPrototype*&apos; increases required alignment of target type
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h: In member function &apos;T* JSC::WriteBarrierBase&lt;T&gt;::get() const [with T = JSC::JSActivation]&apos;:
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/Arguments.cpp:260:133:   instantiated from here
/workspace/git/webkit-efl/Source/JavaScriptCore/runtime/WriteBarrier.h:89:56: warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSActivation*&apos; increases required alignment of target type</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403370</commentid>
    <comment_count>5</comment_count>
      <attachid>93400</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-12 21:47:07 -0700</bug_when>
    <thetext>Created attachment 93400
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403380</commentid>
    <comment_count>6</comment_count>
      <attachid>93400</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2011-05-12 22:05:22 -0700</bug_when>
    <thetext>Comment on attachment 93400
Patch

Lucas?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403491</commentid>
    <comment_count>7</comment_count>
      <attachid>93400</attachid>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-05-13 05:29:29 -0700</bug_when>
    <thetext>Comment on attachment 93400
Patch

It warns only on ARM because on x86 integers can be accessed other than on 4-byte boundaries. This means this warning is irrelevant on x86.

I&apos;m wondering if we shouldn&apos;t fix these casts instead of removing the warnings. A quick grep reveals that both GTK and QT use -Wcast-align:

$ find . -name &apos;*.pri&apos; -exec grep Wall {} \;
*-g++*:QMAKE_CXXFLAGS += -Wall -Wextra -Wreturn-type -fno-strict-aliasing -Wcast-align -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self

$ find . -name GNUmakefile.am -exec grep -B1 -A5 Wall {} \;
global_cppflags += \
	-Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type \
	-Wformat -Wformat-security -Wno-format-y2k -Wundef \
	-Wmissing-format-attribute -Wpointer-arith -Wwrite-strings \
	-Wno-unused-parameter -Wno-parentheses \
	-fno-exceptions -DENABLE_GLIB_SUPPORT=1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403513</commentid>
    <comment_count>8</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2011-05-13 06:38:15 -0700</bug_when>
    <thetext>That is an intesresting point. Ossy, have you seen and fixed it on Qt (arm builds)? We see this a lot on our BlackBerry port as well, so a fix would not be so bad :)

(In reply to comment #7)
&gt; (From update of attachment 93400 [details])
&gt; It warns only on ARM because on x86 integers can be accessed other than on 4-byte boundaries. This means this warning is irrelevant on x86.
&gt; 
&gt; I&apos;m wondering if we shouldn&apos;t fix these casts instead of removing the warnings. A quick grep reveals that both GTK and QT use -Wcast-align:
&gt; 
&gt; $ find . -name &apos;*.pri&apos; -exec grep Wall {} \;
&gt; *-g++*:QMAKE_CXXFLAGS += -Wall -Wextra -Wreturn-type -fno-strict-aliasing -Wcast-align -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self
&gt; 
&gt; $ find . -name GNUmakefile.am -exec grep -B1 -A5 Wall {} \;
&gt; global_cppflags += \
&gt;     -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type \
&gt;     -Wformat -Wformat-security -Wno-format-y2k -Wundef \
&gt;     -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings \
&gt;     -Wno-unused-parameter -Wno-parentheses \
&gt;     -fno-exceptions -DENABLE_GLIB_SUPPORT=1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403527</commentid>
    <comment_count>9</comment_count>
    <who name="Gabor Loki">loki</who>
    <bug_when>2011-05-13 06:59:00 -0700</bug_when>
    <thetext>Well, we should try to fix the alignment warnings before landing such a patch.

If you make sure the cast is OK, you can use the reinterpret_cast_ptr feature which was landed in bug 38045 . Otherwise that could be a real problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407836</commentid>
    <comment_count>10</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-23 02:38:02 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; Well, we should try to fix the alignment warnings before landing such a patch.
&gt; 
&gt; If you make sure the cast is OK, you can use the reinterpret_cast_ptr feature which was landed in bug 38045 . Otherwise that could be a real problem.

Thank you for your comment.

I don&apos;t know it too much. but I prepared a patch like you mentioned.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407839</commentid>
    <comment_count>11</comment_count>
      <attachid>94390</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-05-23 02:40:32 -0700</bug_when>
    <thetext>Created attachment 94390
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407880</commentid>
    <comment_count>12</comment_count>
    <who name="Gabor Loki">loki</who>
    <bug_when>2011-05-23 05:05:59 -0700</bug_when>
    <thetext>&gt; Created an attachment (id=94390)

Although it looks good to me, it would be nice to do the following as well:
- do a Debug build and check the usual tests
- check weather unvalidatedGet causes any alignment warning in WriteBarrier.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>432593</commentid>
    <comment_count>13</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-05 20:41:25 -0700</bug_when>
    <thetext>The JIT ninjas would know.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>432612</commentid>
    <comment_count>14</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-07-05 21:23:38 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; &gt; Created an attachment (id=94390) [details]
&gt; 
&gt; Although it looks good to me, it would be nice to do the following as well:
&gt; - do a Debug build and check the usual tests
&gt; - check weather unvalidatedGet causes any alignment warning in WriteBarrier.h

Default debug build should hit unvalidatedGet()

That said this warning has always irked me as it seems hellbent on occuring for completely valid casts, like this:
warning: cast from &apos;JSC::JSCell*&apos; to &apos;JSC::JSGlobalObject*&apos; increases required alignment of target type

JSGlobalObject is a subclass of JSCell.  It would be a compiler bug if the compiler allowed JSGlobalObject to have alignment  requirements that differed from jscell.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>447342</commentid>
    <comment_count>15</comment_count>
    <who name="Loïc Yhuel">loic.yhuel</who>
    <bug_when>2011-08-05 12:31:05 -0700</bug_when>
    <thetext>I applied the patch for my SH4 build, and there are errors on debug build due to the WriteBarrier.h change.

In Source/JavaScriptCore/runtime/ScopeChain.h :
Source/JavaScriptCore/wtf/StdLibExtras.h:68: error: invalid application of ‘__alignof__’ to incomplete type ‘JSC::JSGlobalObject’

Including JSGlobalObject.h produces more errors of the same type, on ObjectPrototype, FunctionPrototype, ...
But adding many includes just to remove warnings is perhaps too much.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>447351</commentid>
    <comment_count>16</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-08-05 12:40:14 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; I applied the patch for my SH4 build, and there are errors on debug build due to the WriteBarrier.h change.
&gt; 
&gt; In Source/JavaScriptCore/runtime/ScopeChain.h :
&gt; Source/JavaScriptCore/wtf/StdLibExtras.h:68: error: invalid application of ‘__alignof__’ to incomplete type ‘JSC::JSGlobalObject’
&gt; 
&gt; Including JSGlobalObject.h produces more errors of the same type, on ObjectPrototype, FunctionPrototype, ...
&gt; But adding many includes just to remove warnings is perhaps too much.

I would just disable that warning.  At least for JavaScriptCore, I have never seen it produce a warning that was actually valid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465833</commentid>
    <comment_count>17</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-12 15:24:00 -0700</bug_when>
    <thetext>Oliver: So should this be fixed or closed as Invalid?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472686</commentid>
    <comment_count>18</comment_count>
      <attachid>94390</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-09-23 19:03:31 -0700</bug_when>
    <thetext>Comment on attachment 94390
Patch

r- as this patch will probably not apply cleanly on tot anymore, and there was no response to my comments suggesting simply disabling the warning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472770</commentid>
    <comment_count>19</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-09-24 09:37:41 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; (In reply to comment #15)
&gt; &gt; I applied the patch for my SH4 build, and there are errors on debug build due to the WriteBarrier.h change.
&gt; &gt; 
&gt; &gt; In Source/JavaScriptCore/runtime/ScopeChain.h :
&gt; &gt; Source/JavaScriptCore/wtf/StdLibExtras.h:68: error: invalid application of ‘__alignof__’ to incomplete type ‘JSC::JSGlobalObject’
&gt; &gt; 
&gt; &gt; Including JSGlobalObject.h produces more errors of the same type, on ObjectPrototype, FunctionPrototype, ...
&gt; &gt; But adding many includes just to remove warnings is perhaps too much.
&gt; 
&gt; I would just disable that warning.  At least for JavaScriptCore, I have never seen it produce a warning that was actually valid.

Ok. If Ryuan Choi is not interested in this patch anymore I&apos;ll prepare a new one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484874</commentid>
    <comment_count>20</comment_count>
      <attachid>111196</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-10-16 19:01:34 -0700</bug_when>
    <thetext>Created attachment 111196
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484875</commentid>
    <comment_count>21</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-10-16 19:05:38 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; (From update of attachment 94390 [details])
&gt; r- as this patch will probably not apply cleanly on tot anymore, and there was no response to my comments suggesting simply disabling the warning.

Sorry about too late answer.

I upload patch which is just disabling warning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484892</commentid>
    <comment_count>22</comment_count>
      <attachid>111196</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-10-16 20:23:33 -0700</bug_when>
    <thetext>Comment on attachment 111196
Patch

It does not seem right to remove this warning for all platforms just because it&apos;s not working well for ARM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484911</commentid>
    <comment_count>23</comment_count>
      <attachid>111208</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-10-16 22:04:08 -0700</bug_when>
    <thetext>Created attachment 111208
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484959</commentid>
    <comment_count>24</comment_count>
      <attachid>111208</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-10-16 23:52:54 -0700</bug_when>
    <thetext>Comment on attachment 111208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111208&amp;action=review

&gt; Source/cmake/WebKitHelpers.cmake:24
&gt; +    SET(OLD_COMPILE_FLAGS &quot;-W -DANOTHER_BRICK_IN_THE -Wall -Wextra -Wchar-subscripts -Wformat -Wformat-security -Wmissing-format-attribute -Wno-format-y2k -Wno-parentheses -Wno-unused-parameter -Wpointer-arith  -Wreturn-type -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}&quot;)

It seems this removal is still adjusted into all platforms, isn&apos;t it ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484967</commentid>
    <comment_count>25</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-10-17 00:21:48 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; (From update of attachment 111208 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=111208&amp;action=review
&gt; 
&gt; &gt; Source/cmake/WebKitHelpers.cmake:24
&gt; &gt; +    SET(OLD_COMPILE_FLAGS &quot;-W -DANOTHER_BRICK_IN_THE -Wall -Wextra -Wchar-subscripts -Wformat -Wformat-security -Wmissing-format-attribute -Wno-format-y2k -Wno-parentheses -Wno-unused-parameter -Wpointer-arith  -Wreturn-type -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}&quot;)
&gt; 
&gt; It seems this removal is still adjusted into all platforms, isn&apos;t it ?

No, -Wcast-align will be added if WTF_CPU_ARM is not enabled, so other platforms still check it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484970</commentid>
    <comment_count>26</comment_count>
      <attachid>111208</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-10-17 00:28:03 -0700</bug_when>
    <thetext>Comment on attachment 111208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111208&amp;action=review

&gt;&gt;&gt; Source/cmake/WebKitHelpers.cmake:24
&gt;&gt;&gt; +    SET(OLD_COMPILE_FLAGS &quot;-W -DANOTHER_BRICK_IN_THE -Wall -Wextra -Wchar-subscripts -Wformat -Wformat-security -Wmissing-format-attribute -Wno-format-y2k -Wno-parentheses -Wno-unused-parameter -Wpointer-arith  -Wreturn-type -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}&quot;)
&gt;&gt; 
&gt;&gt; It seems this removal is still adjusted into all platforms, isn&apos;t it ?
&gt; 
&gt; No, -Wcast-align will be added if WTF_CPU_ARM is not enabled, so other platforms still check it.

Opps. I missed below code. I&apos;m Sorry. LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500444</commentid>
    <comment_count>27</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2011-11-10 17:51:20 -0800</bug_when>
    <thetext>Oliver, Darin,

Should I fix anything for this bug?

I simply disabled &quot;-Wcast-align&quot; for ARM build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536326</commentid>
    <comment_count>28</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2012-01-15 19:25:21 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 55368 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93246</attachid>
            <date>2011-05-11 22:29:59 -0700</date>
            <delta_ts>2011-05-12 21:46:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60690-20110512142954.patch</filename>
            <type>text/plain</type>
            <size>1602</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDg2MzA4
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUt
MTEgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gUmVtb3ZlIC1XY2FzdC1h
bGlnbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA2
OTAKKworICAgICAgICBSZW1vdmUgLVdjYXN0LWFsaWduIG9wdGlvbiB0byByZWR1Y2Ugd2Fybmlu
Z3Mgb24gYXJtIGJ1aWxkLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMu
Y21ha2U6CisKIDIwMTEtMDUtMTEgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFNvdXJjZS9jbWFrZS9X
ZWJLaXRIZWxwZXJzLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxw
ZXJzLmNtYWtlCShyZXZpc2lvbiA4NTcxNykKKysrIFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJz
LmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0yMSw3ICsyMSw3IEBAIE1BQ1JPKFdFQktJVF9TRVRf
RVhUUkFfQ09NUElMRVJfRkxBR1MgX3QKICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mbm8t
ZXhjZXB0aW9ucyAtZm5vLXN0cmljdC1hbGlhc2luZyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAK
ICAgICAjIEVuYWJsZSB3YXJuaW5ncyBieSBkZWZhdWx0Ci0gICAgU0VUKE9MRF9DT01QSUxFX0ZM
QUdTICItVyAtREFOT1RIRVJfQlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWdu
IC1XY2hhci1zdWJzY3JpcHRzIC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1m
b3JtYXQtYXR0cmlidXRlIC1Xbm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51
c2VkLXBhcmFtZXRlciAtV3BvaW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dy
aXRlLXN0cmluZ3MgJHtPTERfQ09NUElMRV9GTEFHU30iKQorICAgIFNFVChPTERfQ09NUElMRV9G
TEFHUyAiLVcgLURBTk9USEVSX0JSSUNLX0lOX1RIRSAtV2FsbCAtV2V4dHJhIC1XY2hhci1zdWJz
Y3JpcHRzIC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmli
dXRlIC1Xbm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFtZXRl
ciAtV3BvaW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3Mg
JHtPTERfQ09NUElMRV9GTEFHU30iKQogCiAgICAgIyBEaXNhYmxlIEMrKzB4IGNvbXBhdCB3YXJu
aW5ncyBmb3IgR0NDID49IDQuNi4wIHVudGlsIHdlIGJ1aWxkCiAgICAgIyBjbGVhbmx5IHdpdGgg
dGhhdC4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93400</attachid>
            <date>2011-05-12 21:47:07 -0700</date>
            <delta_ts>2011-05-23 02:40:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60690-20110513134705.patch</filename>
            <type>text/plain</type>
            <size>1779</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDEw
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUt
MTIgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gUmVtb3ZlIC1XY2FzdC1h
bGlnbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA2
OTAKKworICAgICAgICBSZW1vdmUgLVdjYXN0LWFsaWduIG9wdGlvbiB0byByZWR1Y2Ugd2Fybmlu
Z3Mgb24gYXJtIGJ1aWxkLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMu
Y21ha2U6CisKIDIwMTEtMDUtMTIgIEdyZWdnIFRhdmFyZXMgIDxnbWFuQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCkluZGV4OiBTb3VyY2UvY21h
a2UvV2ViS2l0SGVscGVycy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvV2ViS2l0
SGVscGVycy5jbWFrZQkocmV2aXNpb24gODU3MTcpCisrKyBTb3VyY2UvY21ha2UvV2ViS2l0SGVs
cGVycy5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMjEsNyArMjEsMTEgQEAgTUFDUk8oV0VCS0lU
X1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdAogICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAi
LWZuby1leGNlcHRpb25zIC1mbm8tc3RyaWN0LWFsaWFzaW5nICR7T0xEX0NPTVBJTEVfRkxBR1N9
IikKIAogICAgICMgRW5hYmxlIHdhcm5pbmdzIGJ5IGRlZmF1bHQKLSAgICBTRVQoT0xEX0NPTVBJ
TEVfRkxBR1MgIi1XIC1EQU5PVEhFUl9CUklDS19JTl9USEUgLVdhbGwgLVdleHRyYSAtV2Nhc3Qt
YWxpZ24gLVdjaGFyLXN1YnNjcmlwdHMgLVdmb3JtYXQgLVdmb3JtYXQtc2VjdXJpdHkgLVdtaXNz
aW5nLWZvcm1hdC1hdHRyaWJ1dGUgLVduby1mb3JtYXQteTJrIC1Xbm8tcGFyZW50aGVzZXMgLVdu
by11bnVzZWQtcGFyYW1ldGVyIC1XcG9pbnRlci1hcml0aCAgLVdyZXR1cm4tdHlwZSAtV3VuZGVm
IC1Xd3JpdGUtc3RyaW5ncyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCisgICAgU0VUKFdBUk5JTkdf
RkxBR1MgIi1XIC1EQU5PVEhFUl9CUklDS19JTl9USEUgLVdhbGwgLVdleHRyYSAtV2NoYXItc3Vi
c2NyaXB0cyAtV2Zvcm1hdCAtV2Zvcm1hdC1zZWN1cml0eSAtV21pc3NpbmctZm9ybWF0LWF0dHJp
YnV0ZSAtV25vLWZvcm1hdC15MmsgLVduby1wYXJlbnRoZXNlcyAtV25vLXVudXNlZC1wYXJhbWV0
ZXIgLVdwb2ludGVyLWFyaXRoICAtV3JldHVybi10eXBlIC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdz
IikKKyAgICBJRiAoTk9UICR7Q01BS0VfU1lTVEVNX1BST0NFU1NPUn0gU1RSRVFVQUwgImFybSIp
CisgICAgICAgIFNFVChXQVJOSU5HX0ZMQUdTICIke1dBUk5JTkdfRkxBR1N9IC1XY2FzdC1hbGln
biIpCisgICAgRU5ESUYgKCkKKyAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7V0FSTklOR19G
TEFHU30gJHtPTERfQ09NUElMRV9GTEFHU30iKQogCiAgICAgIyBEaXNhYmxlIEMrKzB4IGNvbXBh
dCB3YXJuaW5ncyBmb3IgR0NDID49IDQuNi4wIHVudGlsIHdlIGJ1aWxkCiAgICAgIyBjbGVhbmx5
IHdpdGggdGhhdC4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94390</attachid>
            <date>2011-05-23 02:40:32 -0700</date>
            <delta_ts>2011-10-16 19:01:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60690-20110523184033.patch</filename>
            <type>text/plain</type>
            <size>4012</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODcwNjUpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK
KzIwMTEtMDUtMjMgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIGluY3JlYXNp
bmcgcmVxdWlyZWQgYWxpZ25tZW50IG9mIHRhcmdldCB0eXBlIHdhcm5pbmcgb24gQVJNCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDY5MAorCisgICAg
ICAgICogaGVhcC9IYW5kbGVUeXBlcy5oOgorICAgICAgICAoSlNDOjpIYW5kbGVUeXBlczo6Z2V0
RnJvbVNsb3QpOgorICAgICAgICAqIGhlYXAvTWFya2VkQmxvY2suY3BwOgorICAgICAgICAoSlND
OjpNYXJrZWRCbG9jazo6ZGVzdHJveSk6CisgICAgICAgICogaGVhcC9NYXJrZWRCbG9jay5oOgor
ICAgICAgICAoSlNDOjpNYXJrZWRCbG9jazo6Zm9yRWFjaCk6CisgICAgICAgICogcnVudGltZS9K
U0NlbGwuaDoKKyAgICAgICAgKEpTQzo6SlNDZWxsOjpNYXJrZWRCbG9jazo6YWxsb2NhdGUpOgor
ICAgICAgICAqIHJ1bnRpbWUvV3JpdGVCYXJyaWVyLmg6CisgICAgICAgIChKU0M6OldyaXRlQmFy
cmllckJhc2U6OmdldCk6CisKIDIwMTEtMDUtMjMgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNh
bXN1bmcuY29tPgogCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IEVyaWMgU2VpZGVsLgpJbmRl
eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGFuZGxlVHlwZXMuaAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IYW5kbGVUeXBlcy5oCShyZXZpc2lvbiA4NzA2
NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hhbmRsZVR5cGVzLmgJKHdvcmtpbmcg
Y29weSkKQEAgLTM1LDcgKzM1LDcgQEAgdHlwZWRlZiBKU1ZhbHVlKiBIYW5kbGVTbG90OwogCiB0
ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdHJ1Y3QgSGFuZGxlVHlwZXMgewogICAgIHR5cGVkZWYgVCog
RXh0ZXJuYWxUeXBlOwotICAgIHN0YXRpYyBFeHRlcm5hbFR5cGUgZ2V0RnJvbVNsb3QoSGFuZGxl
U2xvdCBzbG90KSB7IHJldHVybiAoc2xvdCAmJiAqc2xvdCkgPyByZWludGVycHJldF9jYXN0PEV4
dGVybmFsVHlwZT4oc2xvdC0+YXNDZWxsKCkpIDogMDsgfQorICAgIHN0YXRpYyBFeHRlcm5hbFR5
cGUgZ2V0RnJvbVNsb3QoSGFuZGxlU2xvdCBzbG90KSB7IHJldHVybiAoc2xvdCAmJiAqc2xvdCkg
PyByZWludGVycHJldF9jYXN0X3B0cjxFeHRlcm5hbFR5cGU+KHNsb3QtPmFzQ2VsbCgpKSA6IDA7
IH0KICAgICBzdGF0aWMgSlNWYWx1ZSB0b0pTVmFsdWUoVCogY2VsbCkgeyByZXR1cm4gcmVpbnRl
cnByZXRfY2FzdDxKU0NlbGwqPihjZWxsKTsgfQogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IHN0
YXRpYyB2b2lkIHZhbGlkYXRlVXBjYXN0KCkgeyBUKiB0ZW1wOyB0ZW1wID0gKFUqKTA7IH0KIH07
CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suY3BwCShyZXZp
c2lvbiA4NzA2NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtNDQsNyArNDQsNyBAQCBNYXJrZWRCbG9jayogTWFya2VkQmxv
Y2s6OmNyZWF0ZShKU0dsb2JhCiB2b2lkIE1hcmtlZEJsb2NrOjpkZXN0cm95KE1hcmtlZEJsb2Nr
KiBibG9jaykKIHsKICAgICBmb3IgKHNpemVfdCBpID0gYmxvY2stPmZpcnN0QXRvbSgpOyBpIDwg
YmxvY2stPm1fZW5kQXRvbTsgaSArPSBibG9jay0+bV9hdG9tc1BlckNlbGwpCi0gICAgICAgIHJl
aW50ZXJwcmV0X2Nhc3Q8SlNDZWxsKj4oJmJsb2NrLT5hdG9tcygpW2ldKS0+fkpTQ2VsbCgpOwor
ICAgICAgICByZWludGVycHJldF9jYXN0X3B0cjxKU0NlbGwqPigmYmxvY2stPmF0b21zKClbaV0p
LT5+SlNDZWxsKCk7CiAgICAgYmxvY2stPm1fYWxsb2NhdGlvbi5kZWFsbG9jYXRlKCk7CiB9CiAK
SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suaAkocmV2aXNpb24g
ODcwNjUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5oCSh3b3Jr
aW5nIGNvcHkpCkBAIC0yMTYsNyArMjE2LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGZv
ciAoc2l6ZV90IGkgPSBmaXJzdEF0b20oKTsgaSA8IG1fZW5kQXRvbTsgaSArPSBtX2F0b21zUGVy
Q2VsbCkgewogICAgICAgICAgICAgaWYgKCFtX21hcmtzLmdldChpKSkKICAgICAgICAgICAgICAg
ICBjb250aW51ZTsKLSAgICAgICAgICAgIGZ1bmN0b3IocmVpbnRlcnByZXRfY2FzdDxKU0NlbGwq
PigmYXRvbXMoKVtpXSkpOworICAgICAgICAgICAgZnVuY3RvcihyZWludGVycHJldF9jYXN0X3B0
cjxKU0NlbGwqPigmYXRvbXMoKVtpXSkpOwogICAgICAgICB9CiAgICAgfQogCkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NlbGwuaAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NlbGwuaAkocmV2aXNpb24gODcwNjUpCisrKyBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NlbGwuaAkod29ya2luZyBjb3B5KQpAQCAtMzY3
LDcgKzM2Nyw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIHsKICAgICAgICAgd2hpbGUgKG1fbmV4
dEF0b20gPCBtX2VuZEF0b20pIHsKICAgICAgICAgICAgIGlmICghbV9tYXJrcy50ZXN0QW5kU2V0
KG1fbmV4dEF0b20pKSB7Ci0gICAgICAgICAgICAgICAgSlNDZWxsKiBjZWxsID0gcmVpbnRlcnBy
ZXRfY2FzdDxKU0NlbGwqPigmYXRvbXMoKVttX25leHRBdG9tXSk7CisgICAgICAgICAgICAgICAg
SlNDZWxsKiBjZWxsID0gcmVpbnRlcnByZXRfY2FzdF9wdHI8SlNDZWxsKj4oJmF0b21zKClbbV9u
ZXh0QXRvbV0pOwogICAgICAgICAgICAgICAgIG1fbmV4dEF0b20gKz0gbV9hdG9tc1BlckNlbGw7
CiAgICAgICAgICAgICAgICAgY2VsbC0+fkpTQ2VsbCgpOwogICAgICAgICAgICAgICAgIHJldHVy
biBjZWxsOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV3JpdGVCYXJyaWVy
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV3JpdGVCYXJy
aWVyLmgJKHJldmlzaW9uIDg3MDY1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv
V3JpdGVCYXJyaWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTk2LDcgKzk2LDcgQEAgcHVibGljOgog
ICAgIHsKICAgICAgICAgaWYgKG1fY2VsbCkKICAgICAgICAgICAgIHZhbGlkYXRlQ2VsbChtX2Nl
bGwpOwotICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxUKj4obV9jZWxsKTsKKyAgICAg
ICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3RfcHRyPFQqPihtX2NlbGwpOwogICAgIH0KIAogICAg
IFQqIG9wZXJhdG9yKigpIGNvbnN0Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111196</attachid>
            <date>2011-10-16 19:01:34 -0700</date>
            <delta_ts>2011-10-16 22:04:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60690-20111017110132.patch</filename>
            <type>text/plain</type>
            <size>1738</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJL
aXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKaW5kZXgg
ZWE0NzgyODEzNTNmMDI3ODllYjM5NzE4MDE3YWQ1ZDExOTE5NDJkZS4uNzRiZmZiYTgzZDhjZTQz
YmQ1M2MxYmUwNzA0MjVmYzkyYTFmZjI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktp
dEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKQEAg
LTIxLDcgKzIxLDcgQEAgTUFDUk8oV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFy
Z2V0KQogICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAiLWZuby1leGNlcHRpb25zIC1mbm8tc3Ry
aWN0LWFsaWFzaW5nICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKIAogICAgICMgRW5hYmxlIHdhcm5p
bmdzIGJ5IGRlZmF1bHQKLSAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1XIC1EQU5PVEhFUl9C
UklDS19JTl9USEUgLVdhbGwgLVdleHRyYSAtV2Nhc3QtYWxpZ24gLVdjaGFyLXN1YnNjcmlwdHMg
LVdmb3JtYXQgLVdmb3JtYXQtc2VjdXJpdHkgLVdtaXNzaW5nLWZvcm1hdC1hdHRyaWJ1dGUgLVdu
by1mb3JtYXQteTJrIC1Xbm8tcGFyZW50aGVzZXMgLVduby11bnVzZWQtcGFyYW1ldGVyIC1XcG9p
bnRlci1hcml0aCAgLVdyZXR1cm4tdHlwZSAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAke09MRF9D
T01QSUxFX0ZMQUdTfSIpCisgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItVyAtREFOT1RIRVJf
QlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjaGFyLXN1YnNjcmlwdHMgLVdmb3JtYXQgLVdm
b3JtYXQtc2VjdXJpdHkgLVdtaXNzaW5nLWZvcm1hdC1hdHRyaWJ1dGUgLVduby1mb3JtYXQteTJr
IC1Xbm8tcGFyZW50aGVzZXMgLVduby11bnVzZWQtcGFyYW1ldGVyIC1XcG9pbnRlci1hcml0aCAg
LVdyZXR1cm4tdHlwZSAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAke09MRF9DT01QSUxFX0ZMQUdT
fSIpCiAKICAgICAjIERpc2FibGUgQysrMHggY29tcGF0IHdhcm5pbmdzIGZvciBHQ0MgPj0gNC42
LjAgdW50aWwgd2UgYnVpbGQKICAgICAjIGNsZWFubHkgd2l0aCB0aGF0LgpkaWZmIC0tZ2l0IGEv
Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGY0M2NiZDNmN2Y0ZWMyNGUwZjVmMWJjNDA5YTkz
MDk0ODNjZDg5YzguLjUzYzQ4NGUwMjRiMTA0NzU4MjFhNGNiM2JkOTgwNmEwYTEzZDczOWEgMTAw
NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx
MS0xMC0xNiAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAg
QXZvaWQgaW5jcmVhc2luZyByZXF1aXJlZCBhbGlnbm1lbnQgb2YgdGFyZ2V0IHR5cGUgd2Fybmlu
ZyBvbiBBUk0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTYwNjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
UmVtb3ZlIC1XY2FzdC1hbGlnbiBvcHRpb24gdG8gcmVkdWNlIHdhcm5pbmdzIG9uIGFybSBidWls
ZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDEx
LTEwLTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWx3YXlz
IGVuYWJsZSBFTkFCTEUoRE9NX1NUT1JBR0UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111208</attachid>
            <date>2011-10-16 22:04:08 -0700</date>
            <delta_ts>2012-01-15 19:25:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60690-20111017140406.patch</filename>
            <type>text/plain</type>
            <size>1847</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJL
aXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKaW5kZXgg
ZWE0NzgyODEzNTNmMDI3ODllYjM5NzE4MDE3YWQ1ZDExOTE5NDJkZS4uNmMxMGIwMGQwOWJkN2Rk
ZjM2MzhiMzdjYTA1YTA2ZDQwNTFjZDNkZSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktp
dEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKQEAg
LTIxLDcgKzIxLDEwIEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh
cmdldCkKICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mbm8tZXhjZXB0aW9ucyAtZm5vLXN0
cmljdC1hbGlhc2luZyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAKICAgICAjIEVuYWJsZSB3YXJu
aW5ncyBieSBkZWZhdWx0Ci0gICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItVyAtREFOT1RIRVJf
QlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3JpcHRz
IC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1X
bm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV3Bv
aW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3MgJHtPTERf
Q09NUElMRV9GTEFHU30iKQorICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAiLVcgLURBTk9USEVS
X0JSSUNLX0lOX1RIRSAtV2FsbCAtV2V4dHJhIC1XY2hhci1zdWJzY3JpcHRzIC1XZm9ybWF0IC1X
Zm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1Xbm8tZm9ybWF0LXky
ayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV3BvaW50ZXItYXJpdGgg
IC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3MgJHtPTERfQ09NUElMRV9GTEFH
U30iKQorICAgIElGIChOT1QgV1RGX0NQVV9BUk0pCisgICAgICAgIFNFVChPTERfQ09NUElMRV9G
TEFHUyAiLVdjYXN0LWFsaWduICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKKyAgICBFTkRJRiAoKQog
CiAgICAgIyBEaXNhYmxlIEMrKzB4IGNvbXBhdCB3YXJuaW5ncyBmb3IgR0NDID49IDQuNi4wIHVu
dGlsIHdlIGJ1aWxkCiAgICAgIyBjbGVhbmx5IHdpdGggdGhhdC4KZGlmZiAtLWdpdCBhL0NoYW5n
ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmNDNjYmQzZjdmNGVjMjRlMGY1ZjFiYzQwOWE5MzA5NDgz
Y2Q4OWM4Li41M2M0ODRlMDI0YjEwNDc1ODIxYTRjYjNiZDk4MDZhMGExM2Q3MzlhIDEwMDY0NAot
LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAt
MTYgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIEF2b2lk
IGluY3JlYXNpbmcgcmVxdWlyZWQgYWxpZ25tZW50IG9mIHRhcmdldCB0eXBlIHdhcm5pbmcgb24g
QVJNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDY5
MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92
ZSAtV2Nhc3QtYWxpZ24gb3B0aW9uIHRvIHJlZHVjZSB3YXJuaW5ncyBvbiBhcm0gYnVpbGQuCisK
KyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxMS0xMC0x
NiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEFsd2F5cyBlbmFi
bGUgRU5BQkxFKERPTV9TVE9SQUdFKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>