6069 2005-12-13 15:40:38 -0800 Assertion failure in RenderBlock::addChildToFlow during replaceChild 2005-12-16 08:11:50 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED http://sms.linuxpowered.com/~puppiesonacid/scrash/ P2 Normal --- 1 jeffplang webkit-unassigned mitz oldest_to_newest 25923 0 jeffplang 2005-12-13 15:40:38 -0800 If you view the page, click the down arrow next to Home and then click its up arrow, Safari crashes. This may be because it's trying to call insertBefore(node, node) ? I'm not for sure. 25938 1 mitz 2005-12-14 01:03:56 -0800 On a debug build, this assert fails: WebCore/khtml/rendering/render_block.cpp:154: failed assertion `false' 25943 2 mitz 2005-12-14 02:34:39 -0800 The problem turns out to be that if Parent has children A and B (A being B's previous sibling), then Parent.replaceChild(A,B) messes up the DOM tree. 25947 3 5076 mitz 2005-12-14 03:57:59 -0800 Created attachment 5076 Don't bother with removing and re-inserting into the same place 25948 4 5076 mitz 2005-12-14 04:00:09 -0800 Comment on attachment 5076 Don't bother with removing and re-inserting into the same place Setting child to 0 instead of iffing the while loop to avoid having to indent everything. 25956 5 5076 darin 2005-12-14 09:41:15 -0800 Comment on attachment 5076 Don't bother with removing and re-inserting into the same place r=me 5076 2005-12-14 03:57:59 -0800 2005-12-14 09:41:15 -0800 Don't bother with removing and re-inserting into the same place 6069_r1.patch text/plain 4541 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE1MQpkaWZm IC1wIC11IC1yMS4xNTEgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCi0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJMTQgRGVjIDIwMDUgMDc6NDg6NDAgLTAwMDAJMS4xNTEKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkxNCBEZWMgMjAwNSAxMjowMjozNyAtMDAwMApAQCAtMSwzICsxLDEzIEBACisyMDA1 LTEyLSMjICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGVz dCBmb3I6IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA2 OQorICAgICAgICBBc3NlcnRpb24gZmFpbHVyZSBpbiBSZW5kZXJCbG9jazo6YWRkQ2hpbGRUb0Zs b3cgZHVyaW5nIHJlcGxhY2VDaGlsZAorCisgICAgICAgICogZmFzdC9qcy9yZXBsYWNlLWNoaWxk LXNpYmxpbmdzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9yZXBsYWNl LWNoaWxkLXNpYmxpbmdzLmh0bWw6IEFkZGVkLgorCiAyMDA1LTEyLTEzICBBZGVsZSBQZXRlcnNv biAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWouCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3JlcGxhY2UtY2hpbGQtc2libGluZ3MtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KZGlmZiAtTnB1IExheW91dFRlc3RzL2Zhc3QvanMvcmVwbGFjZS1jaGlsZC1z aWJsaW5ncy1leHBlY3RlZC50eHQKLS0tIExheW91dFRlc3RzL2Zhc3QvanMvcmVwbGFjZS1jaGls ZC1zaWJsaW5ncy1leHBlY3RlZC50eHQJMSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMAorKysgTGF5 b3V0VGVzdHMvZmFzdC9qcy9yZXBsYWNlLWNoaWxkLXNpYmxpbmdzLWV4cGVjdGVkLnR4dAkxNCBE ZWMgMjAwNSAxMToyMToyNyAtMDAwMApAQCAtMCwwICsxLDUgQEAKK1RoaXMgaXMgYSB0ZXN0IGZv ciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTYwNjkgQXNz ZXJ0aW9uIGZhaWx1cmUgaW4gUmVuZGVyQmxvY2s6OmFkZENoaWxkVG9GbG93IGR1cmluZyByZXBs YWNlQ2hpbGQuIEl0IHRlc3RzIHdoZXRoZXIgcmVwbGFjZUNoaWxkKCkgd29ya3MgY29ycmVjdGx5 IHdoZW4gdGhlIG5ldyBub2RlIGFuZCB0aGUgb2xkIG5vZGUgYXJlIHNpYmxpbmdzLgorCitUZXN0 IHJlc3VsdDogUEFTUworCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcmVwbGFjZS1jaGls ZC1zaWJsaW5ncy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KZGlmZiAtTnB1IExheW91dFRlc3RzL2Zhc3QvanMv cmVwbGFjZS1jaGlsZC1zaWJsaW5ncy5odG1sCi0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3JlcGxh Y2UtY2hpbGQtc2libGluZ3MuaHRtbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlv dXRUZXN0cy9mYXN0L2pzL3JlcGxhY2UtY2hpbGQtc2libGluZ3MuaHRtbAkxNCBEZWMgMjAwNSAx MToyMDo0MiAtMDAwMApAQCAtMCwwICsxLDMwIEBACis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0v L1czQy8vRFREIFhIVE1MIDEuMCBTdHJpY3QvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvVFIveGh0 bWwxL0RURC94aHRtbDEtc3RyaWN0LmR0ZCI+Cis8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5v cmcvMTk5OS94aHRtbCI+Cis8aGVhZD4KKzx0aXRsZT5yZXBsYWNlQ2hpbGQgc2libGluZ3MgYnVn PC90aXRsZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworZnVuY3Rpb24gdGVzdCgpIHsK KyAgICB2YXIgb2JqID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NoaWxkMScpOworICAgIHZh ciBwYXJlbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncGFyZW50Jyk7CisgICAgdmFyIG5l eHRvYmogPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY2hpbGQyJyk7CisgICAgdmFyIHJlcGxh Y2VkID0gcGFyZW50LnJlcGxhY2VDaGlsZChvYmosIG5leHRvYmopOworICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5lclRleHQgPSBwYXJlbnQuY2hpbGRyZW4ubGVuZ3Ro ID09IDEgPyAiUEFTUyIgOiAiRkFJTCI7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9u bG9hZD0idGVzdCgpIj4KKzxwPgorVGhpcyBpcyBhIHRlc3QgZm9yIDxpPmh0dHA6Ly9idWd6aWxs YS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA2OSBBc3NlcnRpb24gZmFpbHVyZSBp biBSZW5kZXJCbG9jazo6YWRkQ2hpbGRUb0Zsb3cgZHVyaW5nIHJlcGxhY2VDaGlsZDwvaT4uCitJ dCB0ZXN0cyB3aGV0aGVyIHJlcGxhY2VDaGlsZCgpIHdvcmtzIGNvcnJlY3RseSB3aGVuIHRoZSBu ZXcgbm9kZSBhbmQgdGhlCitvbGQgbm9kZSBhcmUgc2libGluZ3MuCis8L3A+Cis8aHI+Cis8cD5U ZXN0IHJlc3VsdDogPHNwYW4gaWQ9InJlc3VsdCI+PC9zcGFuPjwvcD4KKzxkaXYgaWQ9InBhcmVu dCI+Cis8ZGl2IGlkPSJjaGlsZDEiPjwvZGl2PjxkaXYgaWQ9ImNoaWxkMiI+PC9kaXY+Cis8L2Rp dj4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL0NoYW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS41MjcKZGlmZiAtcCAtdSAtcjEuNTI3IFdlYkNvcmUvQ2hhbmdlTG9nCi0tLSBXZWJDb3Jl L0NoYW5nZUxvZwkxNCBEZWMgMjAwNSAwNzo0ODozNSAtMDAwMAkxLjUyNworKysgV2ViQ29yZS9D aGFuZ2VMb2cJMTQgRGVjIDIwMDUgMTI6MDA6MTggLTAwMDAKQEAgLTEsMyArMSwxNiBAQAorMjAw NS0xMi0jIyAgTWl0eiBQZXR0ZWwgIDxvcGVuZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRl c3Q6IGZhc3QvanMvcmVwbGFjZS1jaGlsZC1zaWJsaW5ncy5odG1sCisKKyAgICAgICAgRml4IGZv cjogaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02MDY5Cisg ICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIFJlbmRlckJsb2NrOjphZGRDaGlsZFRvRmxvdyBk dXJpbmcgcmVwbGFjZUNoaWxkCisgICAgICAgIAorICAgICAgICAqIGtodG1sL3htbC9kb21fbm9k ZWltcGwuY3BwOgorICAgICAgICAoRE9NOjpDb250YWluZXJOb2RlSW1wbDo6cmVwbGFjZUNoaWxk KTogSWYgdGhlIG5ldyBjaGlsZCB3YXMgcmlnaHQKKyAgICAgICAgYmVmb3JlIG9yIHJpZ2h0IGFm dGVyIHRoZSBvbGQgY2hpbGQsIHRoZW4gaXQganVzdCBzdGF5cy4KKyAgICAgICAgCiAyMDA1LTEy LTEzICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNYWNpZWouCkluZGV4OiBXZWJDb3JlL2todG1sL3htbC9kb21fbm9kZWltcGwuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3htbC9kb21fbm9kZWlt cGwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIyMgpkaWZmIC1wIC11IC1yMS4yMjIgV2Vi Q29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcAotLS0gV2ViQ29yZS9raHRtbC94bWwvZG9t X25vZGVpbXBsLmNwcAk4IERlYyAyMDA1IDEwOjIwOjQxIC0wMDAwCTEuMjIyCisrKyBXZWJDb3Jl L2todG1sL3htbC9kb21fbm9kZWltcGwuY3BwCTE0IERlYyAyMDA1IDEyOjAwOjM3IC0wMDAwCkBA IC0yMjE1LDYgKzIyMTUsOSBAQCBOb2RlSW1wbCAqQ29udGFpbmVyTm9kZUltcGw6OnJlcGxhY2VD aGlsCiAgICAgaWYgKGV4Y2VwdGlvbmNvZGUpCiAgICAgICAgIHJldHVybiAwOwogCisgICAgLy8g SWYgdGhlIG5ldyBjaGlsZCB3YXMgcmlnaHQgYmVmb3JlIG9yIHJpZ2h0IGFmdGVyIHRoZSBvbGQg Y2hpbGQsIG5vdGhpbmcgZWxzZSBuZWVkcyB0byBjaGFuZ2UKKyAgICBpZiAocHJldiA9PSBjaGls ZCB8fCBuZXh0ID09IGNoaWxkKQorICAgICAgICBjaGlsZCA9IDA7CiAgICAgLy8gQWRkIHRoZSBu ZXcgY2hpbGQocmVuKQogICAgIHdoaWxlIChjaGlsZCkgewogICAgICAgICBuZXh0Q2hpbGQgPSBp c0ZyYWdtZW50ID8gY2hpbGQtPm5leHRTaWJsaW5nKCkgOiAwOwo=