60688 2011-05-11 21:39:50 -0700 [Qt] Arm debug build failing on ARMAssembler::debugOffset() 2011-05-13 12:00:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P3 Normal --- 0 kamaji webkit-unassigned abarth ademar barraclough commit-queue eric jturcotte laszlo.gombos ossy webkit.review.bot oldest_to_newest 402642 0 kamaji 2011-05-11 21:39:50 -0700 ARM debug builds that include ARMAssembler.h fail to find symbol m_formatter: ../../../webkit/Source/JavaScriptCore/assembler/ARMAssembler.h:686:41: error: 'm_formatter' was not declared in this scope m_formatter isn't declared anywhere visible to ARMAssembler.h I do see that this was originally declared in ARMv7Assembler.h, with a similar debugOffset() method using it.. This has been since replaced with a call to m_buffer.debugOffset(). I'm not too familiar with this code, so I'm not sure what exactly the right thing to do is. 402649 1 93243 kamaji 2011-05-11 22:00:38 -0700 Created attachment 93243 Patch 402651 2 kamaji 2011-05-11 22:02:16 -0700 Patch builds without error -- and looks like the right thing to do when comparing to what ARMv7Assembler.h. 402703 3 93243 ossy 2011-05-11 23:32:18 -0700 Comment on attachment 93243 Patch LGTM, r=me 402723 4 93243 commit-queue 2011-05-12 00:31:55 -0700 Comment on attachment 93243 Patch Clearing flags on attachment: 93243 Committed r86316: <http://trac.webkit.org/changeset/86316> 402724 5 commit-queue 2011-05-12 00:32:00 -0700 All reviewed patches have been landed. Closing bug. 402742 6 webkit.review.bot 2011-05-12 01:27:58 -0700 http://trac.webkit.org/changeset/86316 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/deleting/delete-ligature-001.html editing/deleting/delete-ligature-002.html editing/deleting/delete-ligature-003.html platform/mac/editing/input/devanagari-ligature.html 403721 7 ademar 2011-05-13 11:58:03 -0700 Revision r86316 cherry-picked into qtwebkit-2.2 with commit b718e0e <http://gitorious.org/webkit/qtwebkit/commit/b718e0e> 93243 2011-05-11 22:00:38 -0700 2011-05-12 00:31:54 -0700 Patch bug-60688-20110512010033.patch text/plain 1314 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODYzMDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVl ZTAzZTM1MzhmMjlkMzUzMzI0YzU5M2E2Y2Y3MzgyNGRmMTM1MWQuLmI2ODU5ZTlmZjE2MjQ1ZmM4 MzUxNmE4NzZhZDA5MTk2ZWEwOGIwMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDExLTA1LTExICBLZWl0aCBLeXppdmF0ICA8a2VpdGgua3l6aXZhdEBub2tp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W1F0XSBBcm0gZGVidWcgYnVpbGQgZmFpbGluZyBvbiBBUk1Bc3NlbWJsZXI6OmRlYnVnT2Zmc2V0 KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNjg4 CisKKyAgICAgICAgUmVsYXRlZCB0byBzdm4gcmV2IDg1NTIzCisKKyAgICAgICAgKiBhc3NlbWJs ZXIvQVJNQXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFSTUFzc2VtYmxlcjo6ZGVidWdPZmZz ZXQpOgorCiAyMDExLTA1LTExICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAppbmRleCBjM2YxOGI5NDM3ZGJmOGQwZTc2ZWRiNWIz NTcxYmYzNDE4NThhNDgwLi5iZTNhOWRhY2ZmMDI4ZjFiYzIzNzE2YWM2YjdmMzczZjEzZDdjMDFk IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxl ci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgK QEAgLTY4Myw3ICs2ODMsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdm9pZCogZXhlY3V0 YWJsZUNvcHkoRXhlY3V0YWJsZVBvb2wqIGFsbG9jYXRvcik7CiAKICNpZm5kZWYgTkRFQlVHCi0g ICAgICAgIHVuc2lnbmVkIGRlYnVnT2Zmc2V0KCkgeyByZXR1cm4gbV9mb3JtYXR0ZXIuZGVidWdP ZmZzZXQoKTsgfQorICAgICAgICB1bnNpZ25lZCBkZWJ1Z09mZnNldCgpIHsgcmV0dXJuIG1fYnVm ZmVyLmRlYnVnT2Zmc2V0KCk7IH0KICNlbmRpZgogCiAgICAgICAgIC8vIFBhdGNoaW5nIGhlbHBl cnMK