60680 2011-05-11 17:47:36 -0700 Disable gc validation in release builds 2011-05-18 11:28:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 402490 0 oliver 2011-05-11 17:47:36 -0700 task 402500 1 oliver 2011-05-11 17:59:00 -0700 We're just leaving this in the build for a few days to help diagnose some crashers. 405865 2 93944 oliver 2011-05-18 11:19:28 -0700 Created attachment 93944 Patch 405881 3 93944 aroben 2011-05-18 11:27:37 -0700 Comment on attachment 93944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93944&action=review > Source/JavaScriptCore/wtf/Platform.h:1218 > +#ifndef NDEBUG > +#if !defined(ENABLE_GC_VALIDATION) Could use && instead of two #ifs. Or if you are going to use two #ifs you could make them both #ifndef. 405884 4 oliver 2011-05-18 11:28:57 -0700 Committed r86779: <http://trac.webkit.org/changeset/86779> 93944 2011-05-18 11:19:28 -0700 2011-05-18 11:27:37 -0700 Patch bug-60680-20110518111927.patch text/plain 1240 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODY3NzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdl NjQ3NTIyNDk0ZGU2NDBiZTQ5YjgwNjExYzgxNTM0NjU5ZmU0MWIuLmJkMGQxM2JhN2RmZmVkMjMz NWMxMjQ0MDY1YjU0NWViMTNiMTAxMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDExLTA1LTE4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzYWJsZSBn YyB2YWxpZGF0aW9uIGluIHJlbGVhc2UgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDY4MAorCisgICAgICAgIEFkZCBiYWNrIHRoZSBOREVC VUcgY2hlY2sKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDExLTA1LTE3ICBHZW9m ZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbGVkIG91dCBhdHRl bXB0cyB0byBmaXggRUZMIGJ1aWxkIGJlY2F1c2UgdGhleSdyZSBub3QgZW5vdWdoIC0tIHRoZQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDU2NjhlYzllYTA0NjkwNjE3MDNk N2ZkNzE3YzU1MGQ1N2RlNGI5NTMuLmNjZWUwY2Q5YjVhMzc0MDkxNDlhOWZlMWViZDViZDI4YTVk MDM2ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTEyMTQsNyArMTIx NCwxMCBAQAogI2RlZmluZSBXVEZfVVNFX1VOSVhfRE9NQUlOX1NPQ0tFVFMgMQogI2VuZGlmCiAK LS8qIE1ha2UgdGhpcyBkZWJ1ZyBvbmx5IGFnYWluIC0tIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MDY4MCAqLworI2lmbmRlZiBOREVCVUcKKyNpZiAhZGVmaW5lZChF TkFCTEVfR0NfVkFMSURBVElPTikKICNkZWZpbmUgRU5BQkxFX0dDX1ZBTElEQVRJT04gMQorI2Vu ZGlmCisjZW5kaWYKIAogI2VuZGlmIC8qIFdURl9QbGF0Zm9ybV9oICovCg==