60677 2011-05-11 17:28:11 -0700 Layout unnecessarily interrupts smooth scrolling at msnbc.com 2011-05-11 17:46:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 402465 0 mitz 2011-05-11 17:28:11 -0700 Layout unnecessarily interrupts smooth scrolling at msnbc.com 402473 1 93220 mitz 2011-05-11 17:32:14 -0700 Created attachment 93220 Avoid an unnecessary immediate scroll in updateScrollbars() 402478 2 93220 darin 2011-05-11 17:37:23 -0700 Comment on attachment 93220 Avoid an unnecessary immediate scroll in updateScrollbars() View in context: https://bugs.webkit.org/attachment.cgi?id=93220&action=review > Source/WebCore/platform/ScrollView.cpp:586 > + IntPoint scrollPoint = adjustScrollPositionWithinRange(IntPoint(desiredOffset)) + IntSize(m_scrollOrigin.x(), m_scrollOrigin.y()); Wish there was a cleaner way to convert a point to a size. 402488 3 mitz 2011-05-11 17:46:23 -0700 Fixed in r86293. <http://trac.webkit.org/changeset/86293> 93220 2011-05-11 17:32:14 -0700 2011-05-11 17:37:23 -0700 Avoid an unnecessary immediate scroll in updateScrollbars() bug-60677-20110511173213.patch text/plain 1959 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjkwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTEgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBMYXlvdXQgdW5uZWNlc3NhcmlseSBpbnRlcnJ1cHRzIHNtb290aCBz Y3JvbGxpbmcgYXQgbXNuYmMuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MDY3NworCisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKTogT25seSBw ZXJmb3JtIGFuIGltbWVkaWF0ZSBzY3JvbGwsIGFib3J0aW5nIGFueSBydW5uaW5nCisgICAgICAg IGFuaW1hdGlvbiwgaWYgdGhlIG5ldyBzY3JvbGwgb2Zmc2V0IGNvbXB1dGVkIGhlcmUgaXMgZGlm ZmVyZW50IGZyb20gdGhlIGN1cnJlbnQgc2Nyb2xsIG9mZnNldC4KKwogMjAxMS0wNS0xMSAgQW50 b2luZSBMYWJvdXIgIDxwaW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2aWQgTGV2aW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAko cmV2aXNpb24gODYyNzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNTM2LDkgKzUzNiw2IEBAIHZvaWQgU2Nyb2xsVmlldzo6dXBk YXRlU2Nyb2xsYmFycyhjb25zdCAKIAogICAgIG1faW5VcGRhdGVTY3JvbGxiYXJzID0gdHJ1ZTsK IAotICAgIEludFBvaW50IHNjcm9sbFBvaW50ID0gYWRqdXN0U2Nyb2xsUG9zaXRpb25XaXRoaW5S YW5nZShJbnRQb2ludChkZXNpcmVkT2Zmc2V0KSk7Ci0gICAgSW50U2l6ZSBzY3JvbGwoc2Nyb2xs UG9pbnQueCgpLCBzY3JvbGxQb2ludC55KCkpOwotCiAgICAgaWYgKG1faG9yaXpvbnRhbFNjcm9s bGJhcikgewogICAgICAgICBpbnQgY2xpZW50V2lkdGggPSB2aXNpYmxlV2lkdGgoKTsKICAgICAg ICAgbV9ob3Jpem9udGFsU2Nyb2xsYmFyLT5zZXRFbmFibGVkKGNvbnRlbnRzV2lkdGgoKSA+IGNs aWVudFdpZHRoKTsKQEAgLTU4Niw3ICs1ODMsOSBAQCB2b2lkIFNjcm9sbFZpZXc6OnVwZGF0ZVNj cm9sbGJhcnMoY29uc3QgCiAgICAgICAgIHVwZGF0ZVNjcm9sbENvcm5lcigpOwogICAgIH0KIAot ICAgIFNjcm9sbGFibGVBcmVhOjpzY3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24oRmxvYXRQ b2ludChzY3JvbGwud2lkdGgoKSArIG1fc2Nyb2xsT3JpZ2luLngoKSwgc2Nyb2xsLmhlaWdodCgp ICsgbV9zY3JvbGxPcmlnaW4ueSgpKSk7CisgICAgSW50UG9pbnQgc2Nyb2xsUG9pbnQgPSBhZGp1 c3RTY3JvbGxQb3NpdGlvbldpdGhpblJhbmdlKEludFBvaW50KGRlc2lyZWRPZmZzZXQpKSArIElu dFNpemUobV9zY3JvbGxPcmlnaW4ueCgpLCBtX3Njcm9sbE9yaWdpbi55KCkpOworICAgIGlmIChz Y3JvbGxQb2ludCAhPSBzY3JvbGxQb3NpdGlvbigpKQorICAgICAgICBTY3JvbGxhYmxlQXJlYTo6 c2Nyb2xsVG9PZmZzZXRXaXRob3V0QW5pbWF0aW9uKHNjcm9sbFBvaW50KTsKIAogICAgIC8vIE1h a2Ugc3VyZSB0aGUgc2Nyb2xsYmFyIG9mZnNldHMgYXJlIHVwIHRvIGRhdGUuCiAgICAgaWYgKG1f aG9yaXpvbnRhbFNjcm9sbGJhcikK