60649 2011-05-11 13:00:28 -0700 [Qt] Extract code to set mouse event modifiers into common function 2011-05-11 14:36:00 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 1 dbates dbates benjamin kling ossy oldest_to_newest 402188 0 dbates 2011-05-11 13:00:28 -0700 Both PlatformMouseEvent(QInputEvent*, int clickCount) and PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount) contain identical code to set the state of the keyboard modifiers for a mouse event. Instead, we should extract this code into a common function, say mouseEventModifiersFromQtKeyboardModifiers() so as to remove duplicate code. 402194 1 93163 dbates 2011-05-11 13:11:07 -0700 Created attachment 93163 Patch 402294 2 93163 dbates 2011-05-11 14:35:54 -0700 Comment on attachment 93163 Patch Clearing flags on attachment: 93163 Committed r86273: <http://trac.webkit.org/changeset/86273> 402295 3 dbates 2011-05-11 14:36:00 -0700 All reviewed patches have been landed. Closing bug. 93163 2011-05-11 13:11:07 -0700 2011-05-11 14:35:54 -0700 Patch bug-60649-20110511130902.patch text/plain 2899 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjU1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDUtMTEgIERhbmllbCBC YXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gRXh0cmFjdCBjb2RlIHRvIHNldCBtb3VzZSBldmVudCBtb2Rp ZmllcnMgaW50byBjb21tb24gZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYwNjQ5CisKKyAgICAgICAgQ29uc29saWRhdGUgY29kZSB0byBz ZXQgdGhlIGtleWJvYXJkIG1vZGlmaWVycyBmb3IgYSBtb3VzZSBldmVudCBpbnRvIGEgY29tbW9u CisgICAgICAgIGZ1bmN0aW9uIHRoYXQgY2FuIGJlIHVzZWQgYnkgYm90aCBQbGF0Zm9ybU1vdXNl RXZlbnQoUUdyYXBoaWNzU2NlbmVNb3VzZUV2ZW50KiwgaW50IGNsaWNrQ291bnQpCisgICAgICAg IGFuZCBQbGF0Zm9ybU1vdXNlRXZlbnQoUUlucHV0RXZlbnQqLCBpbnQgY2xpY2tDb3VudCkgc28g YXMgdG8gcmVtb3ZlIGR1cGxpY2F0ZSBjb2RlLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWxpdHkg d2FzIGNoYW5nZWQuIFNvLCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Q bGF0Zm9ybU1vdXNlRXZlbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjptb3VzZUV2ZW50TW9k aWZpZXJzRnJvbVF0S2V5Ym9hcmRNb2RpZmllcnMpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6 OlBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KTogTW9kaWZpZWQgdG8gY2Fs bCBtb3VzZUV2ZW50TW9kaWZpZXJzRnJvbVF0S2V5Ym9hcmRNb2RpZmllcnMoKS4KKwogMjAxMS0w NS0xMSAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9x dC9QbGF0Zm9ybU1vdXNlRXZlbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vcXQvUGxhdGZvcm1Nb3VzZUV2ZW50UXQuY3BwCShyZXZpc2lvbiA4NjIzNykKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtTW91c2VFdmVudFF0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzQsNiArMzQsMTQgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitz dGF0aWMgdm9pZCBtb3VzZUV2ZW50TW9kaWZpZXJzRnJvbVF0S2V5Ym9hcmRNb2RpZmllcnMoUXQ6 OktleWJvYXJkTW9kaWZpZXJzIGtleWJvYXJkTW9kaWZpZXJzLCBib29sJiBhbHRLZXksIGJvb2wm IGN0cmxLZXksIGJvb2wmIG1ldGFLZXksIGJvb2wmIHNoaWZ0S2V5KQoreworICAgIGFsdEtleSA9 IGtleWJvYXJkTW9kaWZpZXJzICYgUXQ6OkFsdE1vZGlmaWVyOworICAgIGN0cmxLZXkgPSBrZXli b2FyZE1vZGlmaWVycyAmIFF0OjpDb250cm9sTW9kaWZpZXI7CisgICAgbWV0YUtleSA9IGtleWJv YXJkTW9kaWZpZXJzICYgUXQ6Ok1ldGFNb2RpZmllcjsKKyAgICBzaGlmdEtleSA9IGtleWJvYXJk TW9kaWZpZXJzICYgUXQ6OlNoaWZ0TW9kaWZpZXI7Cit9CisKICNpZiAhZGVmaW5lZChRVF9OT19H UkFQSElDU1ZJRVcpCiBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChRR3Jh cGhpY3NTY2VuZU1vdXNlRXZlbnQqIGV2ZW50LCBpbnQgY2xpY2tDb3VudCkKIHsKQEAgLTY1LDEw ICs3Myw3IEBAIFBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KFEKICAgICAg ICAgbV9idXR0b24gPSBOb0J1dHRvbjsKIAogICAgIG1fY2xpY2tDb3VudCA9IGNsaWNrQ291bnQ7 Ci0gICAgbV9zaGlmdEtleSA9ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OlNoaWZ0TW9kaWZp ZXIpOwotICAgIG1fY3RybEtleSA9IChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6Q29udHJvbE1v ZGlmaWVyKTsKLSAgICBtX2FsdEtleSA9ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkFsdE1v ZGlmaWVyKTsKLSAgICBtX21ldGFLZXkgPSAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6Ok1ldGFN b2RpZmllcik7CisgICAgbW91c2VFdmVudE1vZGlmaWVyc0Zyb21RdEtleWJvYXJkTW9kaWZpZXJz KGV2ZW50LT5tb2RpZmllcnMoKSwgbV9hbHRLZXksIG1fY3RybEtleSwgbV9tZXRhS2V5LCBtX3No aWZ0S2V5KTsKIH0KICNlbmRpZiAvLyBRVF9OT19HUkFQSElDU1ZJRVcKIApAQCAtMTIxLDEwICsx MjYsNyBAQCBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChRCiAgICAgfQog CiAgICAgbV9jbGlja0NvdW50ID0gY2xpY2tDb3VudDsKLSAgICBtX3NoaWZ0S2V5ID0gIChldmVu dC0+bW9kaWZpZXJzKCkgJiBRdDo6U2hpZnRNb2RpZmllcik7Ci0gICAgbV9jdHJsS2V5ID0gKGV2 ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpDb250cm9sTW9kaWZpZXIpOwotICAgIG1fYWx0S2V5ID0g IChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6QWx0TW9kaWZpZXIpOwotICAgIG1fbWV0YUtleSA9 IChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6TWV0YU1vZGlmaWVyKTsKKyAgICBtb3VzZUV2ZW50 TW9kaWZpZXJzRnJvbVF0S2V5Ym9hcmRNb2RpZmllcnMoZXZlbnQtPm1vZGlmaWVycygpLCBtX2Fs dEtleSwgbV9jdHJsS2V5LCBtX21ldGFLZXksIG1fc2hpZnRLZXkpOwogfQogCiB9Cg==