60635 2011-05-11 09:42:11 -0700 Video track sometimes fails to draw 2011-06-03 14:10:26 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 eric.carlson eric.carlson ademar oldest_to_newest 402050 0 eric.carlson 2011-05-11 09:42:11 -0700 If HTMLMediaElement replaces the MediaPlayer after its display state has been set to "video", the new media engine has no way to know that it is allowed to display video. If the display state is reset whenever MediaPlayer is replaced, the media engine will get the correct state when it is recalculated. <rdar://problem/9281951> 402068 1 93140 eric.carlson 2011-05-11 10:07:42 -0700 Created attachment 93140 Proposed patch. 402094 2 93140 darin 2011-05-11 10:33:19 -0700 Comment on attachment 93140 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=93140&action=review > Source/WebCore/html/HTMLMediaElement.cpp:713 > + // Reset display mode to force a recalculation of what to show becuase we are resetting the player. This misspells because. 402102 3 eric.carlson 2011-05-11 10:43:13 -0700 http://trac.webkit.org/changeset/86245 415186 4 ademar 2011-06-03 14:10:26 -0700 Revision r86245 cherry-picked into qtwebkit-2.2 with commit 3f5fab4 <http://gitorious.org/webkit/qtwebkit/commit/3f5fab4> 93140 2011-05-11 10:07:42 -0700 2011-05-11 10:33:18 -0700 Proposed patch. patch_display_mode.txt text/plain 1503 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMTEgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVmlkZW8gdHJhY2sgc29tZXRpbWVzIGZhaWxzIHRvIGRy YXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDYz NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTI4MTk1MT4KKworICAgICAgICBObyBuZXcgdGVz dHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgcGl4ZWwgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 bG9hZFJlc291cmNlKTogU2V0IGRpc3BsYXkgbW9kZSB0byAiVW5rbm93biIgdG8gZm9yY2UgYSAK KyAgICAgICAgICAgIHJlY2FsY3VsYXRpb24sIGFuZCBtZWRpYSBlbmdpbmUgbm90aWZpY2F0aW9u LCB0aGUgbmV4dCB0aW1lIHRoZSBzdGF0ZSBtYWNoaW5lIHJ1bnMuCisKIDIwMTEtMDUtMTEgIEFk YW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFR1cm4gb24gc3RyaWN0IFBh c3NPd25QdHIgb24gV2luZG93cwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwCShyZXZpc2lvbiA4NjIyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcxMCw2ICs3MTAsOSBAQCB2b2lkIEhU TUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZShjb25zCiAgICAgYm9vbCBwcml2YXRlTW9kZSA9 ICFzZXR0aW5ncyB8fCBzZXR0aW5ncy0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpOwogICAgIG1f cGxheWVyLT5zZXRQcml2YXRlQnJvd3NpbmdNb2RlKHByaXZhdGVNb2RlKTsKIAorICAgIC8vIFJl c2V0IGRpc3BsYXkgbW9kZSB0byBmb3JjZSBhIHJlY2FsY3VsYXRpb24gb2Ygd2hhdCB0byBzaG93 IGJlY3Vhc2Ugd2UgYXJlIHJlc2V0dGluZyB0aGUgcGxheWVyLgorICAgIHNldERpc3BsYXlNb2Rl KFVua25vd24pOworCiAgICAgaWYgKCFhdXRvcGxheSgpKQogICAgICAgICBtX3BsYXllci0+c2V0 UHJlbG9hZChtX3ByZWxvYWQpOwogICAgIG1fcGxheWVyLT5zZXRQcmVzZXJ2ZXNQaXRjaChtX3dl YmtpdFByZXNlcnZlc1BpdGNoKTsK