60631 2011-05-11 08:59:26 -0700 WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation 2011-05-11 09:46:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan webkit.review.bot oldest_to_newest 402004 0 sullivan 2011-05-11 08:59:26 -0700 WebKit2 clears the WebPageProxy's pendingAPIRequestURL when a provisional load starts, but does not clear it on an in-page anchor navigation. In-page anchor navigations never cause a provisional load to start, so the pendingAPIRequestURL is never cleared. This causes trouble for clients that test for a pendingAPIRequestURL later. In Radar as <rdar://problem/9420520>. 402033 1 93130 sullivan 2011-05-11 09:25:18 -0700 Created attachment 93130 Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations 402035 2 webkit.review.bot 2011-05-11 09:27:28 -0700 Attachment 93130 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 402039 3 93130 darin 2011-05-11 09:30:09 -0700 Comment on attachment 93130 Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations Need to include the bugs.webkit.org bug number too. 402041 4 93130 darin 2011-05-11 09:30:21 -0700 Comment on attachment 93130 Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations Bug URL, I mean. 402044 5 93133 sullivan 2011-05-11 09:31:43 -0700 Created attachment 93133 Added bugzilla bug number to ChangeLog 402052 6 sullivan 2011-05-11 09:46:12 -0700 Fixed in r86240. 93130 2011-05-11 09:25:18 -0700 2011-05-11 09:31:43 -0700 Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations 60631_patch.txt text/plain 1283 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjM1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTEgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk0MjA1MjA+IFdlYktpdDIgZG9l c24ndCBjbGVhciB0aGUgcGVuZGluZ0FQSVJlcXVlc3RVUkwgb24gaW4tcGFnZSBhbmNob3IgbmF2 aWdhdGlvbiBbNjA2MzFdCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRTYW1lRG9jdW1lbnROYXZpZ2F0aW9u Rm9yRnJhbWUpOgorICAgICAgICBDYWxsIGNsZWFyUGVuZGluZ0FQSVJlcXVlc3RVUkwoKS4KKwog MjAxMS0wNS0xMSAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDg2MjA3KQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MTgsNiArMTYxOCw3 IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRTYW1lRG9jdW1lbnROYXZpZ2EKICAgICBXZWJGcmFt ZVByb3h5KiBmcmFtZSA9IHByb2Nlc3MoKS0+d2ViRnJhbWUoZnJhbWVJRCk7CiAgICAgTUVTU0FH RV9DSEVDSyhmcmFtZSk7CiAKKyAgICBjbGVhclBlbmRpbmdBUElSZXF1ZXN0VVJMKCk7CiAgICAg ZnJhbWUtPmRpZFNhbWVEb2N1bWVudE5hdmlnYXRpb24odXJsKTsKIAogICAgIG1fbG9hZGVyQ2xp ZW50LmRpZFNhbWVEb2N1bWVudE5hdmlnYXRpb25Gb3JGcmFtZSh0aGlzLCBmcmFtZSwgc3RhdGlj X2Nhc3Q8U2FtZURvY3VtZW50TmF2aWdhdGlvblR5cGU+KG9wYXF1ZVNhbWVEb2N1bWVudE5hdmln YXRpb25UeXBlKSwgdXNlckRhdGEuZ2V0KCkpOwo= 93133 2011-05-11 09:31:43 -0700 2011-05-11 09:32:04 -0700 Added bugzilla bug number to ChangeLog 60631_patch.txt text/plain 1359 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjM1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMTEgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MDYzMT4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk0MjA1MjA+CisgICAgICAgIAor ICAgICAgICBXZWJLaXQyIGRvZXNuJ3QgY2xlYXIgdGhlIHBlbmRpbmdBUElSZXF1ZXN0VVJMIG9u IGluLXBhZ2UgYW5jaG9yIG5hdmlnYXRpb24gWzYwNjMxXQorCisgICAgICAgICogVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkU2Ft ZURvY3VtZW50TmF2aWdhdGlvbkZvckZyYW1lKToKKyAgICAgICAgQ2FsbCBjbGVhclBlbmRpbmdB UElSZXF1ZXN0VVJMKCkuCisKIDIwMTEtMDUtMTEgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiA4NjIwNykKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNjE4LDYgKzE2MTgsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkU2FtZURvY3VtZW50 TmF2aWdhCiAgICAgV2ViRnJhbWVQcm94eSogZnJhbWUgPSBwcm9jZXNzKCktPndlYkZyYW1lKGZy YW1lSUQpOwogICAgIE1FU1NBR0VfQ0hFQ0soZnJhbWUpOwogCisgICAgY2xlYXJQZW5kaW5nQVBJ UmVxdWVzdFVSTCgpOwogICAgIGZyYW1lLT5kaWRTYW1lRG9jdW1lbnROYXZpZ2F0aW9uKHVybCk7 CiAKICAgICBtX2xvYWRlckNsaWVudC5kaWRTYW1lRG9jdW1lbnROYXZpZ2F0aW9uRm9yRnJhbWUo dGhpcywgZnJhbWUsIHN0YXRpY19jYXN0PFNhbWVEb2N1bWVudE5hdmlnYXRpb25UeXBlPihvcGFx dWVTYW1lRG9jdW1lbnROYXZpZ2F0aW9uVHlwZSksIHVzZXJEYXRhLmdldCgpKTsK