60610 2011-05-10 22:27:51 -0700 Remove empty class CallbackGuard 2011-05-11 23:30:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki abarth eric psolanki webkit.review.bot oldest_to_newest 401772 0 psolanki 2011-05-10 22:27:51 -0700 CallbackGuard was only used on Tiger and it implementation was deleted in r85036 <http://trac.webkit.org/changeset/85036/trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm>. We can just delete the class and its usage now. 401775 1 93073 psolanki 2011-05-10 22:32:36 -0700 Created attachment 93073 Patch 401908 2 93073 kling 2011-05-11 04:53:08 -0700 Comment on attachment 93073 Patch r=me 402671 3 psolanki 2011-05-11 22:33:05 -0700 Committed r86309: <http://trac.webkit.org/changeset/86309> 402702 4 webkit.review.bot 2011-05-11 23:30:35 -0700 http://trac.webkit.org/changeset/86309 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/deleting/delete-ligature-001.html editing/deleting/delete-ligature-002.html editing/deleting/delete-ligature-003.html platform/mac/editing/input/devanagari-ligature.html 93073 2011-05-10 22:32:36 -0700 2011-05-11 04:53:08 -0700 Patch bug-60610-20110510223234.patch text/plain 6483 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogODYyMDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlYzlkMGY2MmQ0MzQ1ZDI4 Y2M1ZDIwY2JiZTk0NDlkMmQzY2FkZjEwLi5lNDEzNDM4NWUxZjE3MzVhNmViYWUyMzFhMmQ2ZWE2 MzcwZmI3ODYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMTAgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBlbXB0eSBjbGFzcyBDYWxsYmFja0d1YXJk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDYxMAor CisgICAgICAgIENhbGxiYWNrR3VhcmQgd2FzIG9ubHkgZXZlciB1c2VkIG9uIFRpZ2VyIGFuZCBp dCBpcyBub3cgYW4gZW1wdHkgY2xhc3MuIFJlbW92ZSBhbGwgdXNlcyBvZiBpdC4KKworICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tOgorICAgICAgICAo LVtXZWJDb3JlUmVzb3VyY2VIYW5kbGVBc0RlbGVnYXRlIGNvbm5lY3Rpb246d2lsbFNlbmRSZXF1 ZXN0OnJlZGlyZWN0UmVzcG9uc2U6XSk6CisgICAgICAgICgtW1dlYkNvcmVSZXNvdXJjZUhhbmRs ZUFzRGVsZWdhdGUgY29ubmVjdGlvblNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlOl0pOgorICAg ICAgICAoLVtXZWJDb3JlUmVzb3VyY2VIYW5kbGVBc0RlbGVnYXRlIGNvbm5lY3Rpb246ZGlkUmVj ZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOl0pOgorICAgICAgICAoLVtXZWJDb3JlUmVzb3Vy Y2VIYW5kbGVBc0RlbGVnYXRlIGNvbm5lY3Rpb246ZGlkQ2FuY2VsQXV0aGVudGljYXRpb25DaGFs bGVuZ2U6XSk6CisgICAgICAgICgtW1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzRGVsZWdhdGUgY29u bmVjdGlvbjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlOl0pOgorICAgICAg ICAoLVtXZWJDb3JlUmVzb3VyY2VIYW5kbGVBc0RlbGVnYXRlIGNvbm5lY3Rpb246ZGlkUmVjZWl2 ZVJlc3BvbnNlOl0pOgorICAgICAgICAoLVtXZWJDb3JlUmVzb3VyY2VIYW5kbGVBc0RlbGVnYXRl IGNvbm5lY3Rpb246ZGlkUmVjZWl2ZURhdGE6bGVuZ3RoUmVjZWl2ZWQ6XSk6CisgICAgICAgICgt W1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzRGVsZWdhdGUgY29ubmVjdGlvbjp3aWxsU3RvcEJ1ZmZl cmluZ0RhdGE6XSk6CisgICAgICAgICgtW1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzRGVsZWdhdGUg Y29ubmVjdGlvbjpkaWRTZW5kQm9keURhdGE6dG90YWxCeXRlc1dyaXR0ZW46dG90YWxCeXRlc0V4 cGVjdGVkVG9Xcml0ZTpdKToKKyAgICAgICAgKC1bV2ViQ29yZVJlc291cmNlSGFuZGxlQXNEZWxl Z2F0ZSBjb25uZWN0aW9uRGlkRmluaXNoTG9hZGluZzpdKToKKyAgICAgICAgKC1bV2ViQ29yZVJl c291cmNlSGFuZGxlQXNEZWxlZ2F0ZSBjb25uZWN0aW9uOmRpZEZhaWxXaXRoRXJyb3I6XSk6Cisg ICAgICAgICgtW1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzRGVsZWdhdGUgY29ubmVjdGlvbjp3aWxs Q2FjaGVSZXNwb25zZTpdKToKKwogMjAxMS0wNS0xMCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFu ZGxlTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VI YW5kbGVNYWMubW0KaW5kZXggYmVjNmYxYTZiMWY4ZjEwZGM2YmQyZjcwMGVlMGVlMmFhY2I1NjYx Yy4uYzhmMGZkYTk0NzljMGYyMTM0MTgxN2ZkMzIwMzI1MDllZmNjZWM2NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0K KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVN YWMubW0KQEAgLTEzNywxNiArMTM3LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogc3RhdGljIGJv b2wgaXNJbml0aWFsaXppbmdDb25uZWN0aW9uOwogI2VuZGlmCiAgICAgCi1jbGFzcyBDYWxsYmFj a0d1YXJkIHsKLXB1YmxpYzoKLSAgICBDYWxsYmFja0d1YXJkKCkKLSAgICB7Ci0gICAgfQotICAg IH5DYWxsYmFja0d1YXJkKCkKLSAgICB7Ci0gICAgfQotfTsKLQogc3RhdGljIFN0cmluZyBlbmNv ZGVCYXNpY0F1dGhvcml6YXRpb24oY29uc3QgU3RyaW5nJiB1c2VyLCBjb25zdCBTdHJpbmcmIHBh c3N3b3JkKQogewogICAgIHJldHVybiBiYXNlNjRFbmNvZGUoKHVzZXIgKyAiOiIgKyBwYXNzd29y ZCkudXRmOCgpKTsKQEAgLTcxNyw3ICs3MDcsNiBAQCBTdHJpbmcgUmVzb3VyY2VIYW5kbGU6OnBy aXZhdGVCcm93c2luZ1N0b3JhZ2VTZXNzaW9uSWRlbnRpZmllckRlZmF1bHRCYXNlKCkKICAgICAg ICAgfQogICAgIH0KIAotICAgIENhbGxiYWNrR3VhcmQgZ3VhcmQ7CiAgICAgUmVzb3VyY2VSZXF1 ZXN0IHJlcXVlc3QgPSBuZXdSZXF1ZXN0OwogCiAgICAgLy8gU2hvdWxkIG5vdCBzZXQgUmVmZXJl ciBhZnRlciBhIHJlZGlyZWN0IGZyb20gYSBzZWN1cmUgcmVzb3VyY2UgdG8gbm9uLXNlY3VyZSBv bmUuCkBAIC03NDksNyArNzM4LDYgQEAgU3RyaW5nIFJlc291cmNlSGFuZGxlOjpwcml2YXRlQnJv d3NpbmdTdG9yYWdlU2Vzc2lvbklkZW50aWZpZXJEZWZhdWx0QmFzZSgpCiAgICAgaWYgKCFtX2hh bmRsZSkKICAgICAgICAgcmV0dXJuIE5POwogCi0gICAgQ2FsbGJhY2tHdWFyZCBndWFyZDsKICAg ICByZXR1cm4gbV9oYW5kbGUtPnNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKCk7CiB9CiAKQEAg LTc2MSw3ICs3NDksNiBAQCBTdHJpbmcgUmVzb3VyY2VIYW5kbGU6OnByaXZhdGVCcm93c2luZ1N0 b3JhZ2VTZXNzaW9uSWRlbnRpZmllckRlZmF1bHRCYXNlKCkKIAogICAgIGlmICghbV9oYW5kbGUp CiAgICAgICAgIHJldHVybjsKLSAgICBDYWxsYmFja0d1YXJkIGd1YXJkOwogICAgIG1faGFuZGxl LT5kaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29yZShjaGFsbGVuZ2UpKTsKIH0K IApAQCAtNzczLDcgKzc2MCw2IEBAIFN0cmluZyBSZXNvdXJjZUhhbmRsZTo6cHJpdmF0ZUJyb3dz aW5nU3RvcmFnZVNlc3Npb25JZGVudGlmaWVyRGVmYXVsdEJhc2UoKQogCiAgICAgaWYgKCFtX2hh bmRsZSkKICAgICAgICAgcmV0dXJuOwotICAgIENhbGxiYWNrR3VhcmQgZ3VhcmQ7CiAgICAgbV9o YW5kbGUtPmRpZENhbmNlbEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvcmUoY2hhbGxlbmdlKSk7 CiB9CiAKQEAgLTc4NSw3ICs3NzEsNiBAQCBTdHJpbmcgUmVzb3VyY2VIYW5kbGU6OnByaXZhdGVC cm93c2luZ1N0b3JhZ2VTZXNzaW9uSWRlbnRpZmllckRlZmF1bHRCYXNlKCkKICAgICBpZiAoIW1f aGFuZGxlKQogICAgICAgICByZXR1cm4gTk87CiAgICAgICAgIAotICAgIENhbGxiYWNrR3VhcmQg Z3VhcmQ7CiAgICAgcmV0dXJuIG1faGFuZGxlLT5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVj dGlvblNwYWNlKGNvcmUocHJvdGVjdGlvblNwYWNlKSk7CiB9CiAjZW5kaWYKQEAgLTc5OCw3ICs3 ODMsNiBAQCBTdHJpbmcgUmVzb3VyY2VIYW5kbGU6OnByaXZhdGVCcm93c2luZ1N0b3JhZ2VTZXNz aW9uSWRlbnRpZmllckRlZmF1bHRCYXNlKCkKIAogICAgIGlmICghbV9oYW5kbGUgfHwgIW1faGFu ZGxlLT5jbGllbnQoKSkKICAgICAgICAgcmV0dXJuOwotICAgIENhbGxiYWNrR3VhcmQgZ3VhcmQ7 CiAKICAgICAvLyBBdm9pZCBNSU1FIHR5cGUgc25pZmZpbmcgaWYgdGhlIHJlc3BvbnNlIGNvbWVz IGJhY2sgYXMgMzA0IE5vdCBNb2RpZmllZC4KICAgICBpbnQgc3RhdHVzQ29kZSA9IFtyIHJlc3Bv bmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Ioc3RhdHVzQ29kZSldID8gWyhpZClyIHN0YXR1c0NvZGVd IDogMDsKQEAgLTg1MSw3ICs4MzUsNyBAQCBTdHJpbmcgUmVzb3VyY2VIYW5kbGU6OnByaXZhdGVC cm93c2luZ1N0b3JhZ2VTZXNzaW9uSWRlbnRpZmllckRlZmF1bHRCYXNlKCkKICAgICAvLyBGSVhN RTogSWYgd2UgZ2V0IG1vcmUgdGhhbiAyQiBieXRlcyBpbiBhIHNpbmdsZSBjaHVuaywgdGhpcyBj b2RlIHdvbid0IGRvIHRoZSByaWdodCB0aGluZy4KICAgICAvLyBIb3dldmVyLCB3aXRoIHRvZGF5 J3MgY29tcHV0ZXJzIGFuZCBuZXR3b3JraW5nIHNwZWVkcywgdGhpcyB3b24ndCBoYXBwZW4gaW4g cHJhY3RpY2UuCiAgICAgLy8gQ291bGQgYmUgYW4gaXNzdWUgd2l0aCBhIGdpYW50IGxvY2FsIGZp bGUuCi0gICAgQ2FsbGJhY2tHdWFyZCBndWFyZDsKKwogICAgIC8vIEZJWE1FOiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3OTMKICAgICAvLyAtMSBtZWFucyB3ZSBk byBub3QgcHJvdmlkZSBhbnkgZGF0YSBhYm91dCB0cmFuc2ZlciBzaXplIHRvIGluc3BlY3RvciBz byBpdCB3b3VsZCB1c2UKICAgICAvLyBDb250ZW50LUxlbmd0aCBoZWFkZXJzIG9yIGNvbnRlbnQg c2l6ZSB0byBzaG93IHRyYW5zZmVyIHNpemUuCkBAIC04NjksNyArODUzLDYgQEAgU3RyaW5nIFJl c291cmNlSGFuZGxlOjpwcml2YXRlQnJvd3NpbmdTdG9yYWdlU2Vzc2lvbklkZW50aWZpZXJEZWZh dWx0QmFzZSgpCiAgICAgLy8gRklYTUU6IElmIHdlIGdldCBhIHJlc291cmNlIHdpdGggbW9yZSB0 aGFuIDJCIGJ5dGVzLCB0aGlzIGNvZGUgd29uJ3QgZG8gdGhlIHJpZ2h0IHRoaW5nLgogICAgIC8v IEhvd2V2ZXIsIHdpdGggdG9kYXkncyBjb21wdXRlcnMgYW5kIG5ldHdvcmtpbmcgc3BlZWRzLCB0 aGlzIHdvbid0IGhhcHBlbiBpbiBwcmFjdGljZS4KICAgICAvLyBDb3VsZCBiZSBhbiBpc3N1ZSB3 aXRoIGEgZ2lhbnQgbG9jYWwgZmlsZS4KLSAgICBDYWxsYmFja0d1YXJkIGd1YXJkOwogICAgIG1f aGFuZGxlLT5jbGllbnQoKS0+d2lsbFN0b3BCdWZmZXJpbmdEYXRhKG1faGFuZGxlLCAoY29uc3Qg Y2hhciopW2RhdGEgYnl0ZXNdLCBzdGF0aWNfY2FzdDxpbnQ+KFtkYXRhIGxlbmd0aF0pKTsKIH0K IApAQCAtODgyLDcgKzg2NSw2IEBAIFN0cmluZyBSZXNvdXJjZUhhbmRsZTo6cHJpdmF0ZUJyb3dz aW5nU3RvcmFnZVNlc3Npb25JZGVudGlmaWVyRGVmYXVsdEJhc2UoKQogCiAgICAgaWYgKCFtX2hh bmRsZSB8fCAhbV9oYW5kbGUtPmNsaWVudCgpKQogICAgICAgICByZXR1cm47Ci0gICAgQ2FsbGJh Y2tHdWFyZCBndWFyZDsKICAgICBtX2hhbmRsZS0+Y2xpZW50KCktPmRpZFNlbmREYXRhKG1faGFu ZGxlLCB0b3RhbEJ5dGVzV3JpdHRlbiwgdG90YWxCeXRlc0V4cGVjdGVkVG9Xcml0ZSk7CiB9CiAK QEAgLTg5NCw3ICs4NzYsNiBAQCBTdHJpbmcgUmVzb3VyY2VIYW5kbGU6OnByaXZhdGVCcm93c2lu Z1N0b3JhZ2VTZXNzaW9uSWRlbnRpZmllckRlZmF1bHRCYXNlKCkKIAogICAgIGlmICghbV9oYW5k bGUgfHwgIW1faGFuZGxlLT5jbGllbnQoKSkKICAgICAgICAgcmV0dXJuOwotICAgIENhbGxiYWNr R3VhcmQgZ3VhcmQ7CiAKICAgICBpZiAoIVJlc291cmNlSGFuZGxlOjpkaWRTZW5kQm9keURhdGFE ZWxlZ2F0ZUV4aXN0cygpKQogICAgICAgICBkaXNhc3NvY2lhdGVTdHJlYW1XaXRoUmVzb3VyY2VI YW5kbGUoW21faGFuZGxlLT5maXJzdFJlcXVlc3QoKS5uc1VSTFJlcXVlc3QoKSBIVFRQQm9keVN0 cmVhbV0pOwpAQCAtOTEwLDcgKzg5MSw2IEBAIFN0cmluZyBSZXNvdXJjZUhhbmRsZTo6cHJpdmF0 ZUJyb3dzaW5nU3RvcmFnZVNlc3Npb25JZGVudGlmaWVyRGVmYXVsdEJhc2UoKQogCiAgICAgaWYg KCFtX2hhbmRsZSB8fCAhbV9oYW5kbGUtPmNsaWVudCgpKQogICAgICAgICByZXR1cm47Ci0gICAg Q2FsbGJhY2tHdWFyZCBndWFyZDsKIAogICAgIGlmICghUmVzb3VyY2VIYW5kbGU6OmRpZFNlbmRC b2R5RGF0YURlbGVnYXRlRXhpc3RzKCkpCiAgICAgICAgIGRpc2Fzc29jaWF0ZVN0cmVhbVdpdGhS ZXNvdXJjZUhhbmRsZShbbV9oYW5kbGUtPmZpcnN0UmVxdWVzdCgpLm5zVVJMUmVxdWVzdCgpIEhU VFBCb2R5U3RyZWFtXSk7CkBAIC05MzMsOCArOTEzLDYgQEAgU3RyaW5nIFJlc291cmNlSGFuZGxl Ojpwcml2YXRlQnJvd3NpbmdTdG9yYWdlU2Vzc2lvbklkZW50aWZpZXJEZWZhdWx0QmFzZSgpCiAg ICAgaWYgKCFtX2hhbmRsZSB8fCAhbV9oYW5kbGUtPmNsaWVudCgpKQogICAgICAgICByZXR1cm4g bmlsOwogCi0gICAgQ2FsbGJhY2tHdWFyZCBndWFyZDsKLSAgICAKICAgICBOU0NhY2hlZFVSTFJl c3BvbnNlICpuZXdSZXNwb25zZSA9IG1faGFuZGxlLT5jbGllbnQoKS0+d2lsbENhY2hlUmVzcG9u c2UobV9oYW5kbGUsIGNhY2hlZFJlc3BvbnNlKTsKICAgICBpZiAobmV3UmVzcG9uc2UgIT0gY2Fj aGVkUmVzcG9uc2UpCiAgICAgICAgIHJldHVybiBuZXdSZXNwb25zZTsK