60601 2011-05-10 18:19:29 -0700 Add some aggressive GC validation to debug builds. 2011-06-18 12:42:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 oliver oliver abarth ap eric webkit.review.bot oldest_to_newest 401680 0 oliver 2011-05-10 18:19:29 -0700 Add some aggressive GC validation to debug builds. 401685 1 93057 oliver 2011-05-10 18:28:04 -0700 Created attachment 93057 Patch 401694 2 93057 webkit-ews 2011-05-10 18:40:41 -0700 Comment on attachment 93057 Patch Attachment 93057 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8690090 401701 3 webkit.review.bot 2011-05-10 18:48:27 -0700 http://trac.webkit.org/changeset/86202 might have broken SnowLeopard Intel Release (Build) 401812 4 ap 2011-05-11 00:13:01 -0700 FWIW, ValueCheck.h (used by HashTable) calls similar a function checkConsistency(). Should these have identical or intentionally different names? 423182 5 93057 darin 2011-06-18 12:42:42 -0700 Comment on attachment 93057 Patch Need a version of this that doesn't break the build. Clearing the review flag for now. 93057 2011-05-10 18:28:04 -0700 2011-06-18 12:42:42 -0700 Patch bug-60601-20110510182803.patch text/plain 4783 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODYwODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZi NzNiODhmOTFmNjkzMTQwYTliNmU1MTYyYjYwMjg1MDdlNWQ2YzguLjA1NWMwYmE0ODM3ZTc2NzU2 ZGQ5NDQxZjI0Y2FkYzY5NGM0ZWQ5NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI0IEBACisyMDExLTA1LTEwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNvbWUg YWdncmVzc2l2ZSBHQyB2YWxpZGF0aW9uIHRvIGRlYnVnIGJ1aWxkcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNjAxCisKKyAgICAgICAgV2hlbiBh c3NlcnRpb25zIGFyZSBlbmFibGVkIHdlIG5vdyBkbyBzb21lIHZhbGlkaXR5IGNoZWNraW5nCisg ICAgICAgIG9mIG9iamVjdHMgYmVpbmcgYWRkZWQgdG8gdGhlIG1hcmsgc3RhY2suCisKKyAgICAg ICAgKiBieXRlY29kZS9JbnN0cnVjdGlvbi5oOgorICAgICAgICAoSlNDOjpQb2x5bW9ycGhpY0Fj Y2Vzc1N0cnVjdHVyZUxpc3Q6OlBvbHltb3JwaGljU3R1YkluZm86OlBvbHltb3JwaGljU3R1Yklu Zm8pOgorICAgICAgICAoSlNDOjpQb2x5bW9ycGhpY0FjY2Vzc1N0cnVjdHVyZUxpc3Q6OnZpc2l0 QWdncmVnYXRlKToKKyAgICAgICAgKiBoZWFwL01hcmtTdGFjay5jcHA6CisgICAgICAgIChKU0M6 Ok1hcmtTdGFjazo6dmFsaWRhdGVTZXQpOgorICAgICAgICAoSlNDOjpNYXJrU3RhY2s6OnZhbGlk YXRlVmFsdWUpOgorICAgICAgICAqIGhlYXAvTWFya1N0YWNrLmg6CisgICAgICAgIChKU0M6Ok1h cmtTdGFjazo6YXBwZW5kVmFsdWVzKToKKyAgICAgICAgKEpTQzo6TWFya1N0YWNrOjphcHBlbmQp OgorICAgICAgICAoSlNDOjpNYXJrU3RhY2s6OmludGVybmFsQXBwZW5kKToKKwogMjAxMS0wNS0w OSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQXV0b21hdGljYWxs eSB0b3VjaCBXZWJLaXQuaWRsIHdoZW5ldmVyIGFueSBvdGhlciBXZWJLaXQxIElETCBmaWxlIGNo YW5nZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbnN0cnVj dGlvbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0luc3RydWN0aW9uLmgKaW5k ZXggODY2ODQ2Y2FhY2JiNzBlNzA5MTI5ZTA1MmQ1MzhmMWEwODhlMTM0YS4uYjNiYjViNzExZmU2 YThhNTFlZTlhNGJiZmYyYzQ2Mzg1OTY0YzE3MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0luc3RydWN0aW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0luc3RydWN0aW9uLmgKQEAgLTY3LDYgKzY3LDExIEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgICAgICAgICAgICAgIFdyaXRlQmFycmllckJhc2U8U3RydWN0dXJlQ2hhaW4+IGNoYWlu OwogICAgICAgICAgICAgfSB1OwogCisgICAgICAgICAgICBQb2x5bW9ycGhpY1N0dWJJbmZvKCkK KyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB1LnByb3RvLmNsZWFyKCk7CisgICAgICAg ICAgICB9CisKICAgICAgICAgICAgIHZvaWQgc2V0KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwg SlNDZWxsKiBvd25lciwgUG9seW1vcnBoaWNBY2Nlc3NTdHJ1Y3R1cmVMaXN0U3R1YlJvdXRpbmVU eXBlIF9zdHViUm91dGluZSwgU3RydWN0dXJlKiBfYmFzZSkKICAgICAgICAgICAgIHsKICAgICAg ICAgICAgICAgICBzdHViUm91dGluZSA9IF9zdHViUm91dGluZTsKQEAgLTExMSw3ICsxMTYsMTEg QEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHsKICAgICAgICAgICAgIGZvciAoaW50IGkgPSAw OyBpIDwgY291bnQ7ICsraSkgewogICAgICAgICAgICAgICAgIFBvbHltb3JwaGljU3R1YkluZm8m IGluZm8gPSBsaXN0W2ldOwotICAgICAgICAgICAgICAgIEFTU0VSVChpbmZvLmJhc2UpOworICAg ICAgICAgICAgICAgIGlmICghaW5mby5iYXNlKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIFdl J3JlIGJlaW5nIG1hcmtlZCBkdXJpbmcgaW5pdGlhbGlzYXRpb24gb2YgYW4gZW50cnkKKyAgICAg ICAgICAgICAgICAgICAgQVNTRVJUKCFpbmZvLnUucHJvdG8pOworICAgICAgICAgICAgICAgICAg ICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICAgICAgdmlzaXRvci5hcHBlbmQoJmluZm8uYmFzZSk7CiAgICAgICAgICAgICAgICAgaWYg KGluZm8udS5wcm90byAmJiAhaW5mby5pc0NoYWluKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvTWFya1N0YWNrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L01hcmtTdGFjay5jcHAKaW5kZXggMzRmNmQxNGNiZGY2YjdjM2YxZTFhZGI0M2NhZWU4YTAzODMw YmI1Yy4uZGRhYTM3ZDhkYTUyZDM2NTNlYWI5OTU0MmRjNTA5ZjlhZDkwY2Q2YyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya1N0YWNrLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2suY3BwCkBAIC0xMzIsNCArMTMyLDI2IEBAIHZv aWQgTWFya1N0YWNrOjpkcmFpbigpCiAjZW5kaWYKIH0KIAordm9pZCBNYXJrU3RhY2s6OnZhbGlk YXRlU2V0KEpTVmFsdWUqIHZhbHVlcywgc2l6ZV90IGNvdW50KQoreworICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgY291bnQ7IGkrKykgeworICAgICAgICBpZiAodmFsdWVzW2ldKQorICAgICAg ICAgICAgdmFsaWRhdGVWYWx1ZSh2YWx1ZXNbaV0pOworICAgIH0KK30KKwordm9pZCBNYXJrU3Rh Y2s6OnZhbGlkYXRlVmFsdWUoSlNWYWx1ZSB2YWx1ZSkKK3sKKyAgICBBU1NFUlQodmFsdWUpOwor ICAgIGlmICghdmFsdWUuaXNDZWxsKCkpCisgICAgICAgIHJldHVybjsKKyAgICBKU0NlbGwqIGNl bGwgPSB2YWx1ZS5hc0NlbGwoKTsKKyAgICBBU1NFUlQoY2VsbCk7CisgICAgQVNTRVJUKGNlbGwt PnN0cnVjdHVyZSgpKTsKKyAgICAvLyBCb3RoIHRoZSBjZWxsJ3Mgc3RydWN0dXJlLCBhbmQgdGhl IGNlbGwncyBzdHJ1Y3R1cmUncyBzdHJ1Y3R1cmUgc2hvdWxkIGJlIHRoZSBTdHJ1Y3R1cmUgU3Ry dWN0dXJlLgorICAgIC8vIEkgaGF0ZSB0aGlzIHNlbnRlbmNlLgorICAgIEFTU0VSVChjZWxsLT5z dHJ1Y3R1cmUoKS0+c3RydWN0dXJlKCktPkpTQ2VsbDo6Y2xhc3NJbmZvKCkgPT0gY2VsbC0+c3Ry dWN0dXJlKCktPkpTQ2VsbDo6Y2xhc3NJbmZvKCkpOworfQorCisKIH0gLy8gbmFtZXNwYWNlIEpT QwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya1N0YWNrLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2suaAppbmRleCBlNzc5NjAzNmUwZDdk ZWY0MWQ2YjQxOGZhNWZlMGQwY2M3ZWJmMDU4Li4xY2I1OWUzMWUxYzgxY2QwYzQ4YjdlOTM2NDZl NDY3NTJkMGM3YzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJr U3RhY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2suaApAQCAt NjIsOSArNjIsMTUgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAgICAgdGVtcGxhdGUgPHR5cGVu YW1lIFQ+IHZvaWQgYXBwZW5kKFdyaXRlQmFycmllckJhc2U8VD4qKTsKIAorICAgICAgICBzdGF0 aWMgdm9pZCB2YWxpZGF0ZVNldChKU1ZhbHVlKiwgc2l6ZV90KTsKKyAgICAgICAgc3RhdGljIHZv aWQgdmFsaWRhdGVWYWx1ZShKU1ZhbHVlKTsKKwogICAgICAgICB2b2lkIGFwcGVuZFZhbHVlcyhX cml0ZUJhcnJpZXJCYXNlPFVua25vd24+KiBiYXJyaWVycywgc2l6ZV90IGNvdW50LCBNYXJrU2V0 UHJvcGVydGllcyBwcm9wZXJ0aWVzID0gTm9OdWxsVmFsdWVzKQogICAgICAgICB7CiAgICAgICAg ICAgICBKU1ZhbHVlKiB2YWx1ZXMgPSBiYXJyaWVycy0+c2xvdCgpOworI2lmICFBU1NFUlRfRElT QUJMRUQKKyAgICAgICAgICAgIHZhbGlkYXRlU2V0KHZhbHVlcywgY291bnQpOworI2VuZGlmCiAg ICAgICAgICAgICBpZiAoY291bnQpCiAgICAgICAgICAgICAgICAgbV9tYXJrU2V0cy5hcHBlbmQo TWFya1NldCh2YWx1ZXMsIHZhbHVlcyArIGNvdW50LCBwcm9wZXJ0aWVzKSk7CiAgICAgICAgIH0K QEAgLTIwNyw2ICsyMTMsOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICB7CiAgICAgICAgIGlmICgh Y291bnQpCiAgICAgICAgICAgICByZXR1cm47CisjaWYgIUFTU0VSVF9ESVNBQkxFRAorICAgICAg ICB2YWxpZGF0ZVNldChzbG90LCBjb3VudCk7CisjZW5kaWYKICAgICAgICAgbV9tYXJrU2V0cy5h cHBlbmQoTWFya1NldChzbG90LCBzbG90ICsgY291bnQsIE5vTnVsbFZhbHVlcykpOwogICAgIH0K ICAgICAKQEAgLTIzMCw2ICsyMzksOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICBBTFdBWVNfSU5M SU5FIHZvaWQgTWFya1N0YWNrOjppbnRlcm5hbEFwcGVuZChKU1ZhbHVlIHZhbHVlKQogICAgIHsK ICAgICAgICAgQVNTRVJUKHZhbHVlKTsKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisgICAgICAgIHZh bGlkYXRlVmFsdWUodmFsdWUpOworI2VuZGlmCiAgICAgICAgIGlmICh2YWx1ZS5pc0NlbGwoKSkK ICAgICAgICAgICAgIGludGVybmFsQXBwZW5kKHZhbHVlLmFzQ2VsbCgpKTsKICAgICB9Cg==