60559 2011-05-10 10:33:28 -0700 Frequent crashes beneath WebCore::ScriptElement::prepareScript 2023-05-28 09:16:56 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 sam tonyg abarth ademar aestes annevk ap eric joepeck simonjam tonyg oldest_to_newest 401305 0 92975 sam 2011-05-10 10:33:28 -0700 Created attachment 92975 Crash Log We are seeing a high volume of crashes under WebCore::ScriptElement::prepareScript, unfortunately, I have not found any repro steps yet. It looks to me like there is a null ScriptElement in HTMLScriptRunner::runScript, though I have not worked out yet how that could happen. Attaching sample crash log. 401306 1 sam 2011-05-10 10:34:52 -0700 <rdar://problem/9277712> 401313 2 tonyg 2011-05-10 10:40:42 -0700 Sam, do you have a rough idea of when this started to appear? 401330 3 sam 2011-05-10 10:52:58 -0700 We first started getting reports mid-april. 401344 4 sam 2011-05-10 10:58:28 -0700 In all the crashlogs it is always beneath doccument.write. 401346 5 eric 2011-05-10 11:02:37 -0700 I could see how this could happen. We need a bunch more ASSERTs around things like takeScriptToProcess to make sure its' never being called when m_scriptToProcess is 0. I don't know the exact series of steps which could cause this, but it's definitely possible to call takeScriptToProcess at the wrong time. I suspect that some part of code is seeing the tree builder paused and assuming its for scripts and we're getitng in here. not sure. 401564 6 abarth 2011-05-10 15:24:21 -0700 HTMLDocumentParser::runScriptsForPausedTreeBuilder assumes m_treeBuilder->isPaused() implies m_treeBuilder->takeScriptToProcess(scriptStartPosition) is non-null, but HTMLScriptRunner::execute returning false can make m_treeBuilder->isPaused() stay true even though the element has been taken. In HTMLScriptRunner::execute this code looks related to the nesting: if (haveParsingBlockingScript()) { if (m_scriptNestingLevel) return false; // Block the parser. Unwind to the outermost HTMLScriptRunner::execute before continuing parsing. So... Maybe if you document.write an inline script followed by something else that gets us running down these code paths. Not sure. 402179 7 93161 sam 2011-05-11 12:46:33 -0700 Created attachment 93161 Patch to paper over the issue. I would like to land this patch to fix the crash at the source, but leave in the ASSERT and this bug open, to try and solve it in a more robust way (and hopefully find a test case). 402203 8 93161 eric 2011-05-11 13:21:52 -0700 Comment on attachment 93161 Patch to paper over the issue. I think we want an earlier assert. I mean, this patch isn't bad, but it just papers over the crash. 402215 9 sam 2011-05-11 13:29:26 -0700 (In reply to comment #8) > (From update of attachment 93161 [details]) > I think we want an earlier assert. I mean, this patch isn't bad, but it just papers over the crash. I can certainly add an earlier assert, perhaps in HTMLDocumentParser::runScriptsForPausedTreeBuilder, but the intent of this patch is to paper over the issue to avoid the crash in the meantime. 402222 10 93161 abarth 2011-05-11 13:31:35 -0700 Comment on attachment 93161 Patch to paper over the issue. I think this is fine for now, but I'll let Eric do the official review. Please leave the bug open so we can write the proper fix later. 402275 11 sam 2011-05-11 14:18:24 -0700 Landed work around in r86270. 404442 12 tonyg 2011-05-16 06:25:23 -0700 In notifyFinished() and executeScriptsWaitingForStylesheets() we un-pause immediately before script execution, but in runScriptsForPausedTreeBuilder() we leave it paused during execution. It looks like we should always unpause before execution. I'll put together a repo and patch. 410939 13 ademar 2011-05-26 15:44:38 -0700 Revision r86270 cherry-picked into qtwebkit-2.2 with commit 3374ed3 <http://gitorious.org/webkit/qtwebkit/commit/3374ed3> 1259527 14 joepeck 2016-12-13 13:56:29 -0800 This ASSERT has been in for years. Maybe we found some cases and they have been addressed over time? 1958522 15 annevk 2023-05-28 09:16:56 -0700 As per comment 14. 92975 2011-05-10 10:33:28 -0700 2011-05-10 10:33:28 -0700 Crash Log Log.txt text/plain 6355 sam Q3Jhc2hlZCBUaHJlYWQ6ICAwICBEaXNwYXRjaCBxdWV1ZTogY29tLmFwcGxlLm1haW4tdGhyZWFk CgpFeGNlcHRpb24gVHlwZTogIEVYQ19CQURfQUNDRVNTIChTSUdTRUdWKQpFeGNlcHRpb24gQ29k ZXM6IEtFUk5fSU5WQUxJRF9BRERSRVNTIGF0IDB4MDAwMDAwMDAwMDAwMDAxOAoKVGhyZWFkIDAg Q3Jhc2hlZDo6IERpc3BhdGNoIHF1ZXVlOiBjb20uYXBwbGUubWFpbi10aHJlYWQKMCAgIGNvbS5h cHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODNmNTc3YWUgV2ViQ29yZTo6U2Ny aXB0RWxlbWVudDo6cHJlcGFyZVNjcmlwdChXVEY6OlRleHRQb3NpdGlvbjxXVEY6Ok9uZUJhc2Vk TnVtYmVyPiBjb25zdCYsIFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OkxlZ2FjeVR5cGVTdXBwb3J0 KSArIDE4CjEgICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2ZmZjgzYjMy OTM4IFdlYkNvcmU6OkhUTUxTY3JpcHRSdW5uZXI6OnJ1blNjcmlwdChXZWJDb3JlOjpFbGVtZW50 KiwgV1RGOjpUZXh0UG9zaXRpb248V1RGOjpPbmVCYXNlZE51bWJlcj4gY29uc3QmKSArIDgwCjIg ICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2ZmZjgzYjMzNGFkIFdlYkNv cmU6OkhUTUxTY3JpcHRSdW5uZXI6OmV4ZWN1dGUoV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OkVs ZW1lbnQ+LCBXVEY6OlRleHRQb3NpdGlvbjxXVEY6Ok9uZUJhc2VkTnVtYmVyPiBjb25zdCYpICsg MjEKMyAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODNiMDZjN2Yg V2ViQ29yZTo6SFRNTERvY3VtZW50UGFyc2VyOjpydW5TY3JpcHRzRm9yUGF1c2VkVHJlZUJ1aWxk ZXIoKSArIDg3CjQgICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2ZmZjgz YjA2ZDdjIFdlYkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6Y2FuVGFrZU5leHRUb2tlbihXZWJD b3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OlN5bmNocm9ub3VzTW9kZSwgV2ViQ29yZTo6UHVtcFNl c3Npb24mKSArIDg4CjUgICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2Zm ZjgzYjA2ZmEyIFdlYkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6cHVtcFRva2VuaXplcihXZWJD b3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OlN5bmNocm9ub3VzTW9kZSkgKyAzOTgKNiAgIGNvbS5h cHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODNiMDc1MzEgV2ViQ29yZTo6SFRN TERvY3VtZW50UGFyc2VyOjppbnNlcnQoV2ViQ29yZTo6U2VnbWVudGVkU3RyaW5nIGNvbnN0Jikg KyAxMzMKNyAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODM2MTcy YzUgV2ViQ29yZTo6RG9jdW1lbnQ6OndyaXRlKFdlYkNvcmU6OlNlZ21lbnRlZFN0cmluZyBjb25z dCYsIFdlYkNvcmU6OkRvY3VtZW50KikgKyAxNTUKOCAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAg ICAgICAgIAkweDAwMDA3ZmZmODNjY2UwYTEgX1pON1dlYkNvcmVMMTNkb2N1bWVudFdyaXRlRVBO M0pTQzlFeGVjU3RhdGVFUE5TXzEySFRNTERvY3VtZW50RU5TXzE4TmV3bGluZVJlcXVpcmVtZW50 RSArIDExNTMKOSAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODNj Y2UyNTEgV2ViQ29yZTo6SlNIVE1MRG9jdW1lbnQ6OndyaXRlKEpTQzo6RXhlY1N0YXRlKikgKyAy MQoxMCAgPz8/ICAgICAgICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDI3ZGM2NmEwMDFlOCAw ICsgNDM4Mjc1NjgwNTA2NjQKMTEgIGNvbS5hcHBsZS5KYXZhU2NyaXB0Q29yZSAgICAgIAkweDAw MDA3ZmZmODgxMWViYjcgSlNDOjpJbnRlcnByZXRlcjo6ZXhlY3V0ZShKU0M6OlByb2dyYW1FeGVj dXRhYmxlKiwgSlNDOjpFeGVjU3RhdGUqLCBKU0M6OlNjb3BlQ2hhaW5Ob2RlKiwgSlNDOjpKU09i amVjdCopICsgNTE3CjEyICBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUgICAgICAJMHgwMDAwN2Zm Zjg4MGZlMjg3IEpTQzo6ZXZhbHVhdGUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OlNjb3BlQ2hhaW5O b2RlKiwgSlNDOjpTb3VyY2VDb2RlIGNvbnN0JiwgSlNDOjpKU1ZhbHVlKSArIDM1OQoxMyAgY29t LmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDdmZmY4MzU5MWY4YiBXZWJDb3JlOjpT Y3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZUluV29ybGQoV2ViQ29yZTo6U2NyaXB0U291cmNlQ29k ZSBjb25zdCYsIFdlYkNvcmU6OkRPTVdyYXBwZXJXb3JsZCopICsgNDI3CjE0ICBjb20uYXBwbGUu V2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2ZmZjgzNTkxZDdjIFdlYkNvcmU6OlNjcmlwdENv bnRyb2xsZXI6OmV2YWx1YXRlKFdlYkNvcmU6OlNjcmlwdFNvdXJjZUNvZGUgY29uc3QmKSArIDQ0 CjE1ICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2ZmZjgzZjU2OTFlIFdl YkNvcmU6OlNjcmlwdEVsZW1lbnQ6OmV4ZWN1dGVTY3JpcHQoV2ViQ29yZTo6U2NyaXB0U291cmNl Q29kZSBjb25zdCYpICsgMTA4CjE2ICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgw MDAwN2ZmZjgzYjMzMDlhIFdlYkNvcmU6OkhUTUxTY3JpcHRSdW5uZXI6OmV4ZWN1dGVQZW5kaW5n U2NyaXB0QW5kRGlzcGF0Y2hFdmVudChXZWJDb3JlOjpQZW5kaW5nU2NyaXB0JikgKyA0NzYKMTcg IGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODNiMzMzOGEgV2ViQ29y ZTo6SFRNTFNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVBhcnNpbmdCbG9ja2luZ1NjcmlwdCgpICsgNDYK MTggIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZmODNiMzM0ZmEgV2Vi Q29yZTo6SFRNTFNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZShXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6 RWxlbWVudD4sIFdURjo6VGV4dFBvc2l0aW9uPFdURjo6T25lQmFzZWROdW1iZXI+IGNvbnN0Jikg KyA5OAoxOSAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDdmZmY4M2IwNmM3 ZiBXZWJDb3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OnJ1blNjcmlwdHNGb3JQYXVzZWRUcmVlQnVp bGRlcigpICsgODcKMjAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3ZmZm ODNiMDZkN2MgV2ViQ29yZTo6SFRNTERvY3VtZW50UGFyc2VyOjpjYW5UYWtlTmV4dFRva2VuKFdl YkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6U3luY2hyb25vdXNNb2RlLCBXZWJDb3JlOjpQdW1w U2Vzc2lvbiYpICsgODgKMjEgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDA3 ZmZmODNiMDZmYTIgV2ViQ29yZTo6SFRNTERvY3VtZW50UGFyc2VyOjpwdW1wVG9rZW5pemVyKFdl YkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6U3luY2hyb25vdXNNb2RlKSArIDM5OAoyMiAgY29t LmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDdmZmY4M2IwNzFkMCBXZWJDb3JlOjpI VE1MRG9jdW1lbnRQYXJzZXI6OnJlc3VtZVBhcnNpbmdBZnRlclNjcmlwdEV4ZWN1dGlvbigpICsg MTE2CjIzICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwN2ZmZjgzYjA3MzJk IFdlYkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6bm90aWZ5RmluaXNoZWQoV2ViQ29yZTo6Q2Fj aGVkUmVzb3VyY2UqKSArIDExMQoyNCAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4 MDAwMDdmZmY4MzVlZThjYyBXZWJDb3JlOjpDYWNoZWRTY3JpcHQ6OmNoZWNrTm90aWZ5KCkgKyA3 MAoyNSAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDdmZmY4MzkyMzM0NiBX ZWJDb3JlOjpDYWNoZWRSZXNvdXJjZVJlcXVlc3Q6OmRpZEZpbmlzaExvYWRpbmcoV2ViQ29yZTo6 U3VicmVzb3VyY2VMb2FkZXIqLCBkb3VibGUpICsgMTY2CjI2ICBjb20uYXBwbGUuV2ViQ29yZSAg ICAgICAgICAgICAJMHgwMDAwN2ZmZjgzZjk0YWZjIFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVy OjpkaWRGaW5pc2hMb2FkaW5nKGRvdWJsZSkgKyA2NAoyNyAgY29tLmFwcGxlLkZvdW5kYXRpb24g ICAgICAgICAgCTB4MDAwMDdmZmY4MjZlZDM5NSBfX19OU1VSTENvbm5lY3Rpb25EaWRGaW5pc2hM b2FkaW5nX2Jsb2NrX2ludm9rZV8xICsgMTIyCjI4ICBjb20uYXBwbGUuRm91bmRhdGlvbiAgICAg ICAgICAJMHgwMDAwN2ZmZjgyNjBlMWQ1IF9OU1VSTENvbm5lY3Rpb25EaWRGaW5pc2hMb2FkaW5n ICsgODEKMjkgIGNvbS5hcHBsZS5DRk5ldHdvcmsgICAgICAgICAgIAkweDAwMDA3ZmZmODVhZjhi NDcgVVJMQ29ubmVjdGlvbkNsaWVudDo6X2NsaWVudERpZEZpbmlzaExvYWRpbmcoVVJMQ29ubmVj dGlvbkNsaWVudDo6Q2xpZW50Q29ubmVjdGlvbkV2ZW50UXVldWUqKSArIDM5MwozMCAgY29tLmFw cGxlLkNGTmV0d29yayAgICAgICAgICAgCTB4MDAwMDdmZmY4NWJhZjFjYSBVUkxDb25uZWN0aW9u Q2xpZW50OjpDbGllbnRDb25uZWN0aW9uRXZlbnRRdWV1ZTo6cHJvY2Vzc0FsbEV2ZW50c0FuZENv bnN1bWVQYXlsb2FkKFhDb25uZWN0aW9uRXZlbnRJbmZvPFhDbGllbnRFdmVudCwgWENsaWVudEV2 ZW50UGFyYW1zPiosIGxvbmcpICsgODYyCjMxICBjb20uYXBwbGUuQ0ZOZXR3b3JrICAgICAgICAg ICAJMHgwMDAwN2ZmZjg1YWU5ODIzIFVSTENvbm5lY3Rpb25DbGllbnQ6OnByb2Nlc3NFdmVudHMo KSArIDE4NQozMiAgY29tLmFwcGxlLkNGTmV0d29yayAgICAgICAgICAgCTB4MDAwMDdmZmY4NWFl OTZkNiBNdWx0aXBsZXhlclNvdXJjZTo6cGVyZm9ybSgpICsgMjEyCjMzICBjb20uYXBwbGUuQ29y ZUZvdW5kYXRpb24gICAgICAJMHgwMDAwN2ZmZjg3NGNmYmZkIF9fQ0ZSdW5Mb29wRG9Tb3VyY2Vz MCArIDI1MwozNCAgY29tLmFwcGxlLkNvcmVGb3VuZGF0aW9uICAgICAgCTB4MDAwMDdmZmY4NzRj ZjVjOSBfX0NGUnVuTG9vcFJ1biArIDkwNQozNSAgY29tLmFwcGxlLkNvcmVGb3VuZGF0aW9uICAg ICAgCTB4MDAwMDdmZmY4NzRjZjAwNiBDRlJ1bkxvb3BSdW5TcGVjaWZpYyArIDIzMAozNiAgY29t LmFwcGxlLkhJVG9vbGJveCAgICAgICAgICAgCTB4MDAwMDdmZmY4NjAxM2VjZiBSdW5DdXJyZW50 RXZlbnRMb29wSW5Nb2RlICsgMjc3CjM3ICBjb20uYXBwbGUuSElUb29sYm94ICAgICAgICAgICAJ MHgwMDAwN2ZmZjg2MDEzY2M5IFJlY2VpdmVOZXh0RXZlbnRDb21tb24gKyAzNTUKMzggIGNvbS5h cHBsZS5ISVRvb2xib3ggICAgICAgICAgIAkweDAwMDA3ZmZmODYwMTNiNTYgQmxvY2tVbnRpbE5l eHRFdmVudE1hdGNoaW5nTGlzdEluTW9kZSArIDYyCjM5ICBjb20uYXBwbGUuQXBwS2l0ICAgICAg ICAgICAgICAJMHgwMDAwN2ZmZjhhNTA0MzU1IF9EUFNOZXh0RXZlbnQgKyA2NTkKNDAgIGNvbS5h cHBsZS5BcHBLaXQgICAgICAgICAgICAgIAkweDAwMDA3ZmZmOGE1MDNjNWMgLVtOU0FwcGxpY2F0 aW9uIG5leHRFdmVudE1hdGNoaW5nTWFzazp1bnRpbERhdGU6aW5Nb2RlOmRlcXVldWU6XSArIDEz NQo0MSAgY29tLmFwcGxlLkFwcEtpdCAgICAgICAgICAgICAgCTB4MDAwMDdmZmY4YTRjODY4NCAt W05TQXBwbGljYXRpb24gcnVuXSArIDQ1Ngo0MiAgY29tLmFwcGxlLldlYktpdDIgICAgICAgICAg ICAgCTB4MDAwMDdmZmY4ODJkYmY1YSBXZWJLaXQ6OldlYlByb2Nlc3NNYWluKFdlYktpdDo6Q29t bWFuZExpbmUgY29uc3QmKSArIDU3NAo0MyAgY29tLmFwcGxlLldlYktpdDIgICAgICAgICAgICAg CTB4MDAwMDdmZmY4ODJhZGRlNiBXZWJLaXRNYWluICsgMjk0CjQ0ICBjb20uYXBwbGUuV2ViUHJv Y2VzcyAgICAgICAgICAJMHgwMDAwMDAwMTA3NjI0ZGE0IDB4MTA3NjI0MDAwICsgMzQ5MgoKVGhy ZWFkIDAgY3Jhc2hlZCB3aXRoIFg4NiBUaHJlYWQgU3RhdGUgKDY0LWJpdCk6CiAgcmF4OiAweDAw MDAwMDAwMDAwMDAwMDAgIHJieDogMHgwMDAwN2ZmZjY3MjIxNDkwICByY3g6IDB4MDAwMDAwMDEw NzZiYjMyMCAgcmR4OiAweDAwMDAwMDAwMDAwMDAwMDAKICByZGk6IDB4MDAwMDAwMDAwMDAwMDAw MCAgcnNpOiAweDAwMDA3ZmZmNjcyMjE0OTAgIHJicDogMHgwMDAwN2ZmZjY3MjIxMzIwICByc3A6 IDB4MDAwMDdmZmY2NzIyMTI3MAogICByODogMHgwMDAwMDAwMDAwMDAwMDAwICAgcjk6IDB4MDAw MDAwMDAwMDAwMDAwMCAgcjEwOiAweDAwMDAwMDAwMDAwMDAwMDAgIHIxMTogMHgwMDAwMDAwMDAw MDAwMDAwCiAgcjEyOiAweDAwMDAwMDAwMDAwMDAwMDAgIHIxMzogMHgwMDAwMDAwMTBhZDU0NGE4 ICByMTQ6IDB4MDAwMDAwMDEwZDIxNzAwMCAgcjE1OiAweDAwMDAwMDAxMGZjOThjNjAKICByaXA6 IDB4MDAwMDdmZmY4M2Y1NzdhZSAgcmZsOiAweDAwMDAwMDAwMDAwMTAyMDIgIGNyMjogMHgwMDAw MDAwMDAwMDAwMDE4CkxvZ2ljYWwgQ1BVOiAwCg== 93161 2011-05-11 12:46:33 -0700 2011-05-11 14:18:33 -0700 Patch to paper over the issue. paperOverFix.diff text/plain 1691 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MjU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMTEgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGcmVxdWVudCBjcmFzaGVzIGJlbmVhdGggV2ViQ29yZTo6U2NyaXB0RWxl bWVudDo6cHJlcGFyZVNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjA1NTkKKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxTY3JpcHRSdW5u ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNjcmlwdFJ1bm5lcjo6cnVuU2NyaXB0KToK KyAgICAgICAgQWRkIG51bGwgY2hlY2sgYW5kIGV4cGxhbmF0aW9uIHRoYXQgd2UgYXJlIGtlZXBp bmcgdGhlIEFTU0VSVCB0byBoZWxwCisgICAgICAgIHRyYWNrIGRvd24gdGhlIGNhdXNlIGFuZCBw cm9kdWNlIGEgdGVzdC4KKwogMjAxMS0wNS0xMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u QGlnYWxpYS5jb20+CiAKICAgICAgICAgVHJ5IG9uY2UgbW9yZSB0byBmaXggdGhlIFdpbkNhaXJv IGJ1aWxkLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFNjcmlwdFJ1bm5l ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFNjcmlw dFJ1bm5lci5jcHAJKHJldmlzaW9uIDg2MjQ5KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTFNjcmlwdFJ1bm5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4NCw3ICsyODQsMTQg QEAgdm9pZCBIVE1MU2NyaXB0UnVubmVyOjpydW5TY3JpcHQoRWxlbWVudAogICAgICAgICBOZXN0 aW5nTGV2ZWxJbmNyZW1lbnRlciBuZXN0aW5nTGV2ZWxJbmNyZW1lbnRlcihtX3NjcmlwdE5lc3Rp bmdMZXZlbCk7CiAKICAgICAgICAgU2NyaXB0RWxlbWVudCogc2NyaXB0RWxlbWVudCA9IHRvU2Ny aXB0RWxlbWVudChzY3JpcHQpOworCisgICAgICAgIC8vIFRoaXMgY29udGFpbnMgYm90aCBhbmQg QVNTRVJUSU9OIGFuZCBhIG51bGwgY2hlY2sgc2luY2Ugd2Ugc2hvdWxkIG5vdAorICAgICAgICAv LyBiZSBnZXR0aW5nIGludG8gdGhlIGNhc2Ugb2YgYSBudWxsIHNjcmlwdCBlbGVtZW50LCBidXQg c2VlbSB0byBiZSBmcm9tCisgICAgICAgIC8vIHRpbWUgdG8gdGltZS4gVGhlIGFzc2VydGlvbiBp cyBsZWZ0IGluIHRvIGhlbHAgZmluZCB0aG9zZSBjYXNlcyBhbmQKKyAgICAgICAgLy8gaXMgYmVp bmcgdHJhY2tlZCBieSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw NTU5Pi4KICAgICAgICAgQVNTRVJUKHNjcmlwdEVsZW1lbnQpOworICAgICAgICBpZiAoIXNjcmlw dEVsZW1lbnQpCisgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgc2NyaXB0RWxlbWVudC0+ cHJlcGFyZVNjcmlwdChzY3JpcHRTdGFydFBvc2l0aW9uKTsKIAo=