60542 2011-05-10 03:18:35 -0700 Fix build with --disable-video --enable-fullscreen-api 2011-11-30 09:04:19 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 ojab webkit-unassigned commit-queue eric.carlson eric jer.noble pnormand oldest_to_newest 401116 0 ojab 2011-05-10 03:18:35 -0700 Patch in the following comment. 401118 1 92936 ojab 2011-05-10 03:24:27 -0700 Created attachment 92936 add needed ifdef 401553 2 92936 menard 2011-05-10 15:14:12 -0700 Comment on attachment 92936 add needed ifdef LGTM. 402644 3 jer.noble 2011-05-11 21:47:48 -0700 Whoops, I didn't consider that combination. Looks good to me. 402652 4 eric 2011-05-11 22:03:00 -0700 Thanks Jer. 402730 5 commit-queue 2011-05-12 00:40:43 -0700 The commit-queue encountered the following flaky tests while processing attachment 92936: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 402731 6 92936 commit-queue 2011-05-12 00:42:23 -0700 Comment on attachment 92936 add needed ifdef Clearing flags on attachment: 92936 Committed r86319: <http://trac.webkit.org/changeset/86319> 511791 7 pnormand 2011-11-30 09:04:19 -0800 Patch landed. 92936 2011-05-10 03:24:27 -0700 2011-05-12 00:42:23 -0700 add needed ifdef 60542.patch text/plain 1468 ojab SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MTM5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTAgIG9qYWIgIDxv amFiQG9qYWIucnU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IGJ1aWxkIHdpdGggLS1kaXNhYmxlLXZpZGVvIC0tZW5hYmxlLWZ1bGxzY3JlZW4t YXBpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDU0 MgorCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6U2VsZWN0b3JDaGVja2VyOjpjaGVja09uZVNlbGVjdG9yKToK KwogMjAxMS0wNS0xMCAgVG9ueSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIEJ1aWxkIGZpeDogaW5jbHVkZSBFeGNlcHRpb25Db2RlCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZpc2lvbiA4NjEzOSkKKysrIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjkwOSw4 ICsyOTA5LDEwIEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6U2VsZWN0b3JDaGVja2VyOjoKICAg ICAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0Z1bGxTY3JlZW5NZWRpYURvY3VtZW50 OgogICAgICAgICAgICAgICAgIGlmICghZS0+ZG9jdW1lbnQoKS0+d2Via2l0SXNGdWxsU2NyZWVu KCkpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyNpZiBFTkFCTEUoVklERU8p CiAgICAgICAgICAgICAgICAgaWYgKCFlLT5kb2N1bWVudCgpLT53ZWJraXRDdXJyZW50RnVsbFNj cmVlbkVsZW1lbnQoKSB8fCAhZS0+ZG9jdW1lbnQoKS0+d2Via2l0Q3VycmVudEZ1bGxTY3JlZW5F bGVtZW50KCktPmlzTWVkaWFFbGVtZW50KCkpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKyNlbmRpZgogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAg Y2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvRnVsbFNjcmVlbkRvY3VtZW50OgogICAgICAgICAgICAg ICAgIC8vIFdoaWxlIGEgRG9jdW1lbnQgaXMgaW4gdGhlIGZ1bGxzY3JlZW4gc3RhdGUsIHRoZSAn ZnVsbC1zY3JlZW4tZG9jdW1lbnQnIHBzZXVkb2NsYXNzIGFwcGxpZXMgCg==