60531 2011-05-09 21:45:24 -0700 WebKit2: Cancelling full screen before animation completes leads to full screen window staying up. 2011-05-10 15:43:37 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 401043 0 jer.noble 2011-05-09 21:45:24 -0700 WebKit2: Cancelling full screen before animation completes leads to full screen window staying up 401044 1 jer.noble 2011-05-09 21:46:34 -0700 If the user cancels full screen mode before the enter full screen animation completes, Safari leaves the full screen window up containing the (non-full screen) page content. 401045 2 jer.noble 2011-05-09 21:51:30 -0700 <rdar://problem/9411473> 401046 3 92915 jer.noble 2011-05-09 21:52:32 -0700 Created attachment 92915 Patch 401229 4 92915 darin 2011-05-10 08:51:15 -0700 Comment on attachment 92915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92915&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322 > > - _isAnimating = NO; Should remove this excess blank line too. 401578 5 jer.noble 2011-05-10 15:41:08 -0700 (In reply to comment #4) > (From update of attachment 92915 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92915&action=review > > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322 > > > > - _isAnimating = NO; > > Should remove this excess blank line too. Will do. Thanks! 401585 6 jer.noble 2011-05-10 15:43:37 -0700 Committed r86186: <http://trac.webkit.org/changeset/86186> 92915 2011-05-09 21:52:32 -0700 2011-05-10 08:51:15 -0700 Patch bug-60531-20110509215231.patch text/plain 5070 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODYwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhNTc3ZjQ5OWUyN2ZhZDNj ZTFiNGM1Yzk0ZjRkNGU0M2M5ZDNjZDdjLi43MjhkYjBmYjdlYzc2MDg3MmU2MTQ1MDlmN2UwYWM1 MzBhNWYwYTllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMDkgIEplcmVt eSBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MjogQ2FuY2VsbGluZyBmdWxsIHNjcmVlbiBi ZWZvcmUgYW5pbWF0aW9uIGNvbXBsZXRlcyBsZWFkcyB0byBmdWxsIHNjcmVlbiB3aW5kb3cgc3Rh eWluZyB1cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYwNTMxCisKKyAgICAgICAgUmVtb3ZlIHRoZSAodW51c2VkKSBfaXNBbmltYXRpbmcgaXZhciBh bmQgcmVwbGFjZSBpdCB3aXRoIHR3byBpdmFyczogX2lzRW50ZXJpbmdGdWxsU2NyZWVuIGFuZCAK KyAgICAgICAgX2lzRXhpdGluZ0Z1bGxTY3JlZW4uICBUaGVzZSB3aWxsIGVuc3VyZSBlYWNoIGlz IG9ubHkgY2FsbGVkIG9uY2UgcGVyIGZ1bGwgc2NyZWVuIHJlcXVlc3QsIGFuZAorICAgICAgICB0 aGF0IGlmIG9uZSBleGl0L2VudGVyIHJlcXVlc3QgaW50ZXJydXB0cyBhbm90aGVyLCB0aGF0IHRo ZSByZXF1aXJlZCBmdW5jdGlvbnMgYXJlIGNhbGxlZCBpbiAKKyAgICAgICAgb3JkZXIuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW06Cisg ICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZW50ZXJGdWxsU2NyZWVuOl0p OiBSZW1vdmVkIF9pc0FuaW1hdGluZy4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29u dHJvbGxlciBleGl0RnVsbFNjcmVlbl0pOiBEaXR0by4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlciBiZWdhbkVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbl0pOiBHYXRlIG9u IF9pc0VudGVyaW5nRnVsbFNjcmVlbi4gQ2hlY2sgX2lzRXhpdGluZ0Z1bGxTY3JlZW4KKyAgICAg ICAgICAgIGFuZCBjYWxsIFtzZWxmIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246XSBp ZiBuZWNlc3NhcnkuCisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZmlu aXNoZWRFbnRlckZ1bGxTY3JlZW5BbmltYXRpb246XSk6IEdhdGUgb24gX2lzRW50ZXJpbmdGdWxs U2NyZWVuLgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGJlZ2FuRXhp dEZ1bGxTY3JlZW5BbmltYXRpb25dKTogR2F0ZSBvbiBfaXNFeGl0aW5nRnVsbFNjcmVlbi4gQ2hl Y2sgX2lzRW50ZXJpbmdGdWxsU2NyZWVuCisgICAgICAgICAgICBhbmQgY2FsbCBbc2VsZiBmaW5p c2hlZEVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbjpdIGlmIG5lY2Vzc2FyeS4KKyAgICAgICAgKC1b V0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5pc2hlZEV4aXRGdWxsU2NyZWVuQW5pbWF0 aW9uOl0pOiBHYXRlIG9uIF9pc0V4aXRpbmdGdWxsU2NyZWVuLgorCiAyMDExLTA1LTA5ICBBZGFt IFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBbHdheXMgc2V0IHRoZSBmb250 IHJlbmRlcmluZyBtb2RlIGJhc2VkIG9uIHByZWZlcmVuY2UgdmFsdWVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIu aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJv bGxlci5oCmluZGV4IDU3MzExZTdkNmU4MTRjOWY3NDQzNDEyMjU2N2RlZmY5NzBkYjhkMGQuLmE4 NjUzMDJkNzE4NTAzYTZiY2RhMDAxYjFjNTkyZDQ1OTlhMTQ2ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJv bGxlci5oCkBAIC00NSw3ICs0NSw4IEBAIGNsYXNzIEludFJlY3Q7CiAgICAgUmV0YWluUHRyPE5T Vmlldz4gX2xheWVyVmlld1BsYWNlaG9sZGVyOwogICAgIFJldGFpblB0cjxOU1ZpZXc+IF9sYXll ckhvc3RpbmdWaWV3OwogICAgIAotICAgIEJPT0wgX2lzQW5pbWF0aW5nOworICAgIEJPT0wgX2lz RW50ZXJpbmdGdWxsU2NyZWVuOworICAgIEJPT0wgX2lzRXhpdGluZ0Z1bGxTY3JlZW47CiAgICAg Qk9PTCBfaXNGdWxsU2NyZWVuOwogICAgIEJPT0wgX2lzV2luZG93TG9hZGVkOwogICAgIEJPT0wg X2ZvcmNlRGlzYWJsZUFuaW1hdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCBmNzI1 OWFhZjFlNWNmZjllNWQyMzBmMzdiMWJhNzNkODcxMDhlMGE3Li4yODUyZmM1NGIyNTc5ODMwNDY3 ZmY0ZmY0NzhjMTg2MGJiNDg2MGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC0xNzYs NyArMTc2LDYgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAgICAgICAgIHJldHVybjsKICAg ICAKICAgICBfaXNGdWxsU2NyZWVuID0gWUVTOwotICAgIF9pc0FuaW1hdGluZyA9IFlFUzsKICAg ICAKICAgICBOU0Rpc2FibGVTY3JlZW5VcGRhdGVzKCk7CiAgICAgCkBAIC0yMDgsNyArMjA3LDE0 IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogfQogCiAtICh2b2lkKWJlZ2FuRW50ZXJGdWxs U2NyZWVuQW5pbWF0aW9uCi17ICAgIAoreworICAgIGlmIChfaXNFbnRlcmluZ0Z1bGxTY3JlZW4p CisgICAgICAgIHJldHVybjsKKyAgICBfaXNFbnRlcmluZ0Z1bGxTY3JlZW4gPSBZRVM7CisKKyAg ICBpZiAoX2lzRXhpdGluZ0Z1bGxTY3JlZW4pCisgICAgICAgIFtzZWxmIGZpbmlzaGVkRXhpdEZ1 bGxTY3JlZW5BbmltYXRpb246Tk9dOworCiAgICAgW3NlbGYgX3VwZGF0ZU1lbnVBbmREb2NrRm9y RnVsbFNjcmVlbl07ICAgCiAgICAgW3NlbGYgX3VwZGF0ZVBvd2VyQXNzZXJ0aW9uc107CiAgICAg CkBAIC0yMjgsMTEgKzIzNCwxNCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICBbQ0FU cmFuc2FjdGlvbiBjb21taXRdOwogCiAgICAgTlNFbmFibGVTY3JlZW5VcGRhdGVzKCk7Ci0gICAg X2lzQW5pbWF0aW5nID0gWUVTOwogfQogCiAtICh2b2lkKWZpbmlzaGVkRW50ZXJGdWxsU2NyZWVu QW5pbWF0aW9uOihib29sKWNvbXBsZXRlZAogeworICAgIGlmICghX2lzRW50ZXJpbmdGdWxsU2Ny ZWVuKQorICAgICAgICByZXR1cm47CisgICAgX2lzRW50ZXJpbmdGdWxsU2NyZWVuID0gTk87CisK ICAgICBOU0Rpc2FibGVTY3JlZW5VcGRhdGVzKCk7CiAgICAgCiAgICAgaWYgKGNvbXBsZXRlZCkg eyAgICAgICAgICAgICAgICAKQEAgLTI1OSw4ICsyNjgsNiBAQCB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKICAgICAKICAgICBbc2VsZiBfbWFuYWdlcl0tPmRpZEVudGVyRnVsbFNjcmVlbigpOwog ICAgIE5TRW5hYmxlU2NyZWVuVXBkYXRlcygpOwotICAgIAotICAgIF9pc0FuaW1hdGluZyA9IE5P OwogfQogCiAtICh2b2lkKWV4aXRGdWxsU2NyZWVuCkBAIC0yNjksNyArMjc2LDYgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CiAgICAgICAgIHJldHVybjsKICAgICAKICAgICBfaXNGdWxsU2Ny ZWVuID0gTk87Ci0gICAgX2lzQW5pbWF0aW5nID0gWUVTOwogICAgIAogICAgIE5TRGlzYWJsZVNj cmVlblVwZGF0ZXMoKTsKICAgICAKQEAgLTI3OCw3ICsyODQsMTQgQEAgdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmU7CiB9CiAKIC0gKHZvaWQpYmVnYW5FeGl0RnVsbFNjcmVlbkFuaW1hdGlvbgoteyAg IAoreworICAgIGlmIChfaXNFeGl0aW5nRnVsbFNjcmVlbikKKyAgICAgICAgcmV0dXJuOworICAg IF9pc0V4aXRpbmdGdWxsU2NyZWVuID0gWUVTOworCisgICAgaWYgKF9pc0VudGVyaW5nRnVsbFNj cmVlbikKKyAgICAgICAgW3NlbGYgZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpOT107 CisKICAgICBbc2VsZiBfdXBkYXRlTWVudUFuZERvY2tGb3JGdWxsU2NyZWVuXTsgICAKICAgICBb c2VsZiBfdXBkYXRlUG93ZXJBc3NlcnRpb25zXTsKICAgICAKQEAgLTMwMCwxMSArMzEzLDE0IEBA IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgIFtDQVRyYW5zYWN0aW9uIGNvbW1pdF07CiAg ICAgCiAgICAgTlNFbmFibGVTY3JlZW5VcGRhdGVzKCk7Ci0gICAgX2lzQW5pbWF0aW5nID0gWUVT OwogfQogCiAtICh2b2lkKWZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246KGJvb2wpY29t cGxldGVkCiB7CisgICAgaWYgKCFfaXNFeGl0aW5nRnVsbFNjcmVlbikKKyAgICAgICAgcmV0dXJu OworICAgIF9pc0V4aXRpbmdGdWxsU2NyZWVuID0gTk87CisKICAgICBOU0Rpc2FibGVTY3JlZW5V cGRhdGVzKCk7CiAgICAgCiAgICAgaWYgKGNvbXBsZXRlZCkgewpAQCAtMzE5LDcgKzMzNSw2IEBA IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgIFtzZWxmIF9tYW5hZ2VyXS0+ZGlkRXhpdEZ1 bGxTY3JlZW4oKTsKICAgICBOU0VuYWJsZVNjcmVlblVwZGF0ZXMoKTsKICAgICAKLSAgICBfaXNB bmltYXRpbmcgPSBOTzsKIH0KIAogLSAodm9pZCllbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdN b2RlOihjb25zdCBXZWJLaXQ6OkxheWVyVHJlZUNvbnRleHQmKWxheWVyVHJlZUNvbnRleHQK