<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60528</bug_id>
          
          <creation_ts>2011-05-09 19:11:35 -0700</creation_ts>
          <short_desc>new-run-webkit-tests don&apos;t run platform specific tests when running subsets of tests</short_desc>
          <delta_ts>2012-06-08 16:07:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>37956</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>64491</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>ojan</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>400994</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-05-09 19:11:35 -0700</bug_when>
    <thetext>Passing a directory name X to old-run-webkit-tests would run all tests in LayoutTests/X and LayoutTests/platform/Y/X where Y is the given platform but new-run-webkit-tests don&apos;t run the latter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401009</commentid>
    <comment_count>1</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-05-09 19:48:37 -0700</bug_when>
    <thetext>For chromium, this might be expected since we run all the tests on all platforms (unless skipped in test_expectations.txt).  I guess for chromium we should run LayoutTests/platform/*/X and for other platforms, match ORWT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401284</commentid>
    <comment_count>2</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-05-10 10:13:32 -0700</bug_when>
    <thetext>Actually, in a thread a couple weeks back I suggested that we change NRWT to match ORWT across the board (and stop running platform/* for Chromium), and nobody disagreed.

I have no problem matching ORWT here, although I was never aware of this particular behavior and it&apos;s a little surprising to me (I would think you would have to specify both directories if you wanted both directories). I don&apos;t feel particularly strongly about it one way or another.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401287</commentid>
    <comment_count>3</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-05-10 10:18:30 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Actually, in a thread a couple weeks back I suggested that we change NRWT to match ORWT across the board (and stop running platform/* for Chromium), and nobody disagreed.

I think that&apos;s better.  I don&apos;t like Chromium port doing different thing from other ports.  It just complicates things, confuse contributors from other ports, and adds maintenance cost.

&gt; I have no problem matching ORWT here, although I was never aware of this particular behavior and it&apos;s a little surprising to me (I would think you would have to specify both directories if you wanted both directories). I don&apos;t feel particularly strongly about it one way or another.

It&apos;s really useful when you&apos;re writing some patch and want to sanity-test your patch against some subsets of tests (e.g. editing) since there&apos;s no easy way to tell which directory has platform-specific tests other than manually looking at the directories.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>430055</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-06-29 18:08:25 -0700</bug_when>
    <thetext>This doesn&apos;t need to block Bug 34984.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645107</commentid>
    <comment_count>5</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-08 16:07:11 -0700</bug_when>
    <thetext>this is a duplicate of bug 37956, looks like.

*** This bug has been marked as a duplicate of bug 37956 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>