60499 2011-05-09 12:54:37 -0700 [Qt] DumpRenderTreeQt needs an implementation of unmarkText 2011-05-10 01:39:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cshu cshu commit-queue ossy oldest_to_newest 400689 0 cshu 2011-05-09 12:54:37 -0700 Should help to fix editing/inserting/insert-composition-whitespace.html 400700 1 92837 cshu 2011-05-09 13:19:46 -0700 Created attachment 92837 fix patch 400804 2 92837 kenneth 2011-05-09 15:21:21 -0700 Comment on attachment 92837 fix patch Looks good. Are you going to use that confirmComposition for other tests? Because it is doing a lot more than unmarking text :-) 400967 3 cshu 2011-05-09 18:26:41 -0700 Maybe, I haven't realized it yet. :) Thanks for the review. (In reply to comment #2) > (From update of attachment 92837 [details]) > Looks good. Are you going to use that confirmComposition for other tests? Because it is doing a lot more than unmarking text :-) 400993 4 92837 commit-queue 2011-05-09 19:11:33 -0700 Comment on attachment 92837 fix patch Clearing flags on attachment: 92837 Committed r86124: <http://trac.webkit.org/changeset/86124> 400995 5 commit-queue 2011-05-09 19:11:38 -0700 All reviewed patches have been landed. Closing bug. 401098 6 ossy 2011-05-10 01:39:38 -0700 Guys, you should have to run layout tests before commiting and/or watch the buildbots after commiting. Please respect the rules: http://www.webkit.org/coding/contributing.html "Once you have made your changes, you need to run the regression tests, which is done via the run-webkit-tests script. All tests must pass. Patches will not be landed in the tree if they break existing layout tests." I landed a fix: http://trac.webkit.org/changeset/86137 instead of you ... :S 92837 2011-05-09 13:19:46 -0700 2011-05-09 19:11:33 -0700 fix patch 60499_1.patch text/plain 5669 cshu SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4NjA4MykKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDkgIENo YW5nIFNodSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIER1bXBSZW5kZXJUcmVlUXQgbmVlZHMgYW4gaW1wbGVt ZW50YXRpb24gb2YgdW5tYXJrVGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjA0OTkKKworICAgICAgICBUaGUgaW1wbGVtZW50YXRpb24gaXMgc2lt aWxhciB0byBndGsuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1 cHBvcnRRdC5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y29uZmlybUNv bXBvc2l0aW9uKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRRdC5oOgorCiAyMDExLTA1LTA3ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNw cAkocmV2aXNpb24gODU4NTIpCisrKyBTb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1 bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEwOSw2ICsxMTA5 LDI1IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnJlbW92ZVNoYWQKICAgICB3ZWJF bGVtZW50LT5yZW1vdmVTaGFkb3dSb290KCk7CiB9CiAKK3ZvaWQgRHVtcFJlbmRlclRyZWVTdXBw b3J0UXQ6OmNvbmZpcm1Db21wb3NpdGlvbihRV2ViUGFnZSogcGFnZSwgY29uc3QgY2hhciogdGV4 dCkKK3sKKyAgICBGcmFtZSogZnJhbWUgPSBwYWdlLT5oYW5kbGUoKS0+cGFnZS0+Zm9jdXNDb250 cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIGlmICghZnJhbWUpCisgICAgICAg IHJldHVybjsKKworICAgIEVkaXRvciogZWRpdG9yID0gZnJhbWUtPmVkaXRvcigpOworICAgIGlm ICghZWRpdG9yIHx8ICghZWRpdG9yLT5oYXNDb21wb3NpdGlvbigpICYmICF0ZXh0KSkKKyAgICAg ICAgcmV0dXJuOworCisgICAgaWYgKGVkaXRvci0+aGFzQ29tcG9zaXRpb24oKSkgeworICAgICAg ICBpZiAodGV4dCkKKyAgICAgICAgICAgIGVkaXRvci0+Y29uZmlybUNvbXBvc2l0aW9uKFN0cmlu Zzo6ZnJvbVVURjgodGV4dCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBlZGl0b3ItPmNv bmZpcm1Db21wb3NpdGlvbigpOworICAgIH0gZWxzZQorICAgICAgICBlZGl0b3ItPmluc2VydFRl eHQoU3RyaW5nOjpmcm9tVVRGOCh0ZXh0KSwgMCk7Cit9CisKIC8vIFByb3ZpZGUgYSBiYWNrd2Fy ZCBjb21wYXRpYmlsaXR5IHdpdGggcHJldmlvdXNseSBleHBvcnRlZCBwcml2YXRlIHN5bWJvbHMg YXMgb2YgUXRXZWJLaXQgNC42IHJlbGVhc2UKIAogdm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9yZXN1 bWVBY3RpdmVET01PYmplY3RzKFFXZWJGcmFtZSogZnJhbWUpCkluZGV4OiBTb3VyY2UvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR dC5oCShyZXZpc2lvbiA4NTg1MikKKysrIFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaAkod29ya2luZyBjb3B5KQpAQCAtOTQsNiArOTQsNyBA QCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2V0U2VsZWN0VHJhaWxpbmdXaGl0ZXNwYWNlRW5h YmxlZChRV2ViUGFnZSogcGFnZSwgYm9vbCBlbmFibGVkKTsKICAgICBzdGF0aWMgUVZhcmlhbnRM aXN0IHNlbGVjdGVkUmFuZ2UoUVdlYlBhZ2UqIHBhZ2UpOwogICAgIHN0YXRpYyBRVmFyaWFudExp c3QgZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UoUVdlYlBhZ2UqIHBhZ2UsIGludCBsb2NhdGlv biwgaW50IGxlbmd0aCk7CisgICAgc3RhdGljIHZvaWQgY29uZmlybUNvbXBvc2l0aW9uKFFXZWJQ YWdlKiwgY29uc3QgY2hhciogdGV4dCk7CiAKICAgICBzdGF0aWMgYm9vbCBwYXVzZUFuaW1hdGlv bihRV2ViRnJhbWUqLCBjb25zdCBRU3RyaW5nJiBuYW1lLCBkb3VibGUgdGltZSwgY29uc3QgUVN0 cmluZyYgZWxlbWVudElkKTsKICAgICBzdGF0aWMgYm9vbCBwYXVzZVRyYW5zaXRpb25PZlByb3Bl cnR5KFFXZWJGcmFtZSosIGNvbnN0IFFTdHJpbmcmIG5hbWUsIGRvdWJsZSB0aW1lLCBjb25zdCBR U3RyaW5nJiBlbGVtZW50SWQpOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gODYwODMpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wNS0wOSAgQ2hhbmcgU2h1ICA8Y3No dUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRHVtcFJlbmRlclRyZWVRdCBuZWVkcyBhbiBpbXBsZW1lbnRhdGlvbiBvZiB1 bm1hcmtUZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MDQ5OQorCisgICAgICAgIFRoZSBpbXBsZW1lbnRhdGlvbiBpcyBzaW1pbGFyIHRvIGd0ay4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L1RleHRJbnB1dENvbnRyb2xsZXJRdC5jcHA6 CisgICAgICAgIChUZXh0SW5wdXRDb250cm9sbGVyOjp1bm1hcmtUZXh0KToKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9xdC9UZXh0SW5wdXRDb250cm9sbGVyUXQuaDoKKwogMjAxMS0wNS0wOSAg QWxpY2UgQm94aGFsbCAgPGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPamFuIFZhZmFpLgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGV4dElucHV0 Q29udHJvbGxlclF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9U ZXh0SW5wdXRDb250cm9sbGVyUXQuY3BwCShyZXZpc2lvbiA4NTg1MikKKysrIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL3F0L1RleHRJbnB1dENvbnRyb2xsZXJRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE1NiwzICsxNTYsOCBAQCBRVmFyaWFudExpc3QgVGV4dElucHV0Q29udHJvbGxlcjo6Zmlyc3RS CiB7CiAgICAgcmV0dXJuIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpmaXJzdFJlY3RGb3JDaGFy YWN0ZXJSYW5nZShxb2JqZWN0X2Nhc3Q8UVdlYlBhZ2UqPihwYXJlbnQoKSksIGxvY2F0aW9uLCBs ZW5ndGgpOwogfQorCit2b2lkIFRleHRJbnB1dENvbnRyb2xsZXI6OnVubWFya1RleHQoKQorewor ICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Ojpjb25maXJtQ29tcG9zaXRpb24ocW9iamVjdF9j YXN0PFFXZWJQYWdlKj4ocGFyZW50KCkpLCAwKTsKK30KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L1RleHRJbnB1dENvbnRyb2xsZXJRdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL3F0L1RleHRJbnB1dENvbnRyb2xsZXJRdC5oCShyZXZpc2lvbiA4NTg1MikKKysr IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1RleHRJbnB1dENvbnRyb2xsZXJRdC5oCSh3b3JraW5n IGNvcHkpCkBAIC00NCw3ICs0NCw3IEBAIHB1YmxpYyBzbG90czoKICAgICB2b2lkIGRvQ29tbWFu ZChjb25zdCBRU3RyaW5nJiBjb21tYW5kKTsKICAgICB2b2lkIHNldE1hcmtlZFRleHQoY29uc3Qg UVN0cmluZyYgc3RyaW5nLCBpbnQgc3RhcnQsIGludCBlbmQpOwogLy8gICAgIGJvb2wgaGFzTWFy a2VkVGV4dCgpOwotLy8gICAgIHZvaWQgdW5tYXJrVGV4dCgpOworICAgICB2b2lkIHVubWFya1Rl eHQoKTsKIC8vICAgICBRTGlzdDxpbnQ+IG1hcmtlZFJhbmdlKCk7CiAgICAgUVZhcmlhbnRMaXN0 IHNlbGVjdGVkUmFuZ2UoKTsKIC8vICAgICB2b2lkIHZhbGlkQXR0cmlidXRlc0Zvck1hcmtlZFRl eHQoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MDgzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMDkgIENoYW5nIFNodSAg PGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIER1bXBSZW5kZXJUcmVlUXQgbmVlZHMgYW4gaW1wbGVtZW50YXRpb24g b2YgdW5tYXJrVGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjA0OTkKKworICAgICAgICBVbnNraXBwZWQgcGFzc2VkIHRlc3QuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTA1LTA5ICBDaGFuZyBTaHUgIDxjc2h1QHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp cHBlZAkocmV2aXNpb24gODYwODIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CSh3b3JraW5nIGNvcHkpCkBAIC0zMzYsNyArMzM2LDYgQEAgZWRpdGluZy9pbnNlcnRpbmcvbXVs dGlwbGUtbGluZXMtc2VsZWN0ZQogZWRpdGluZy9pbnNlcnRpbmcvdHlwaW5nLXRhYi1kZXNpZ25t b2RlLWZvcm1zLmh0bWwKIGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy10YWItZGVzaWdubW9kZS5o dG1sCiBlZGl0aW5nL2luc2VydGluZy81OTk0NDgwLTIuaHRtbAotZWRpdGluZy9pbnNlcnRpbmcv aW5zZXJ0LWNvbXBvc2l0aW9uLXdoaXRlc3BhY2UuaHRtbAogCiAjIGh0dHA6Ly9idWdyZXBvcnRz LnF0Lm5va2lhLmNvbS9icm93c2UvUVRCVUctMTU1NjYKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QvYmFzaWMtYXV0aC1ub3VzZXIuaHRtbAo=