60487 2011-05-09 11:40:46 -0700 [Qt] DRT eventSender.addTouchPoint method is not setting the start position 2011-05-16 14:04:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 32484 0 igor.oliveira webkit-unassigned ademar commit-queue oldest_to_newest 400610 0 igor.oliveira 2011-05-09 11:40:46 -0700 when adding a new touch point(eventSender.addTouchPoint(x,y)). The startPos is not being set. it is necessary to create tests for bug: https://bugs.webkit.org/show_bug.cgi?id=32484 400612 1 92814 igor.oliveira 2011-05-09 11:44:23 -0700 Created attachment 92814 patch Proposed Patch 400665 2 92814 kling 2011-05-09 12:36:31 -0700 Comment on attachment 92814 patch View in context: https://bugs.webkit.org/attachment.cgi?id=92814&action=review Nice catch. r- because the code is ugly. Not your fault, but let's fix it. :) > Tools/DumpRenderTree/qt/EventSenderQt.cpp:406 > QTouchEvent::TouchPoint point(id); > m_touchPoints.append(point); > updateTouchPoint(index, x, y); > + m_touchPoints[index].setStartPos(QPointF(x, y)); > m_touchPoints[index].setState(Qt::TouchPointPressed); This code is unnecessarily confusing, we should fix it while we're visiting. Something like: QTouchEvent::TouchPoint point(id); point.setPos(QPointF(x, y)); point.setStartPos(QPointF(x, y)); point.setState(Qt::TouchPointPressed); m_touchPoints.append(point); And of course the 'index' variable won't be needed after this cleanup. 400694 3 92835 igor.oliveira 2011-05-09 12:57:44 -0700 Created attachment 92835 patch proposed patch. 400705 4 92835 kling 2011-05-09 13:23:25 -0700 Comment on attachment 92835 patch r=me 400775 5 92835 commit-queue 2011-05-09 14:56:24 -0700 Comment on attachment 92835 patch Clearing flags on attachment: 92835 Committed r86090: <http://trac.webkit.org/changeset/86090> 400776 6 commit-queue 2011-05-09 14:56:27 -0700 All reviewed patches have been landed. Closing bug. 404698 7 ademar 2011-05-16 14:04:30 -0700 Revision r86090 cherry-picked into qtwebkit-2.2 with commit 1064adb <http://gitorious.org/webkit/qtwebkit/commit/1064adb> 92814 2011-05-09 11:44:23 -0700 2011-05-09 12:57:44 -0700 patch 0001-Qt-DRT-eventSender.addTouchPoint-method-is-not-setti.patch text/plain 1609 igor.oliveira RnJvbSBkZjcyYWE1YTU2NDE2MDU1N2U0OTRiMDRiYTIyY2UwYTQ4MWE0ZTAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IE1vbiwgOSBNYXkgMjAxMSAxNDo0MDozNCAtMDQwMApTdWJqZWN0OiBbUEFU Q0hdIFtRdF0gRFJUIGV2ZW50U2VuZGVyLmFkZFRvdWNoUG9pbnQgbWV0aG9kIGlzIG5vdCBzZXR0 aW5nIHRoZSBzdGFydCBwb3NpdGlvbgoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBUb29scy9EdW1wUmVuZGVyVHJlZS9x dC9FdmVudFNlbmRlclF0LmNwcCB8ICAgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCBjNzFkYzQ1Li43ZDRlNDk2IDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUt MDkgIElnb3IgT2xpdmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEUlQgZXZlbnRT ZW5kZXIuYWRkVG91Y2hQb2ludCBtZXRob2QgaXMgbm90IHNldHRpbmcgdGhlIHN0YXJ0IHBvc2l0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDQ4 NworCisgICAgICAgIFdoZW4gYWRkaW5nIGEgbmV3IHRvdWNoIHBvaW50LCB0aGUgc3RhcnQgcG9z aXRpb24gb2YgdGhpcyBwb2ludCBuZWVkcyB0byBiZSBzZXQuCisKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjphZGRU b3VjaFBvaW50KToKKwogMjAxMS0wNS0wOSAgTWFoZXNoIEt1bGthcm5pICA8bWFoZXNoLmt1bGth cm5pQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZm IC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcAppbmRleCBlZjg5ZTAyLi5lMzI2 OTA0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcApAQCAtNDAy LDYgKzQwMiw3IEBAIHZvaWQgRXZlbnRTZW5kZXI6OmFkZFRvdWNoUG9pbnQoaW50IHgsIGludCB5 KQogICAgIFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50IHBvaW50KGlkKTsKICAgICBtX3RvdWNoUG9p bnRzLmFwcGVuZChwb2ludCk7CiAgICAgdXBkYXRlVG91Y2hQb2ludChpbmRleCwgeCwgeSk7Cisg ICAgbV90b3VjaFBvaW50c1tpbmRleF0uc2V0U3RhcnRQb3MoUVBvaW50Rih4LCB5KSk7CiAgICAg bV90b3VjaFBvaW50c1tpbmRleF0uc2V0U3RhdGUoUXQ6OlRvdWNoUG9pbnRQcmVzc2VkKTsKIH0K IAotLSAKMS43LjEKCg== 92835 2011-05-09 12:57:44 -0700 2011-05-09 14:56:24 -0700 patch 0001-Qt-DRT-eventSender.addTouchPoint-method-is-not-setti.patch text/plain 2179 igor.oliveira RnJvbSBmY2Q3ZWFmODVlNDhkOGVlMTBkZmIwYTFkOThkMjMwOTIzMmM5NTE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IE1vbiwgOSBNYXkgMjAxMSAxNDo0MDozNCAtMDQwMApTdWJqZWN0OiBbUEFU Q0hdIFtRdF0gRFJUIGV2ZW50U2VuZGVyLmFkZFRvdWNoUG9pbnQgbWV0aG9kIGlzIG5vdCBzZXR0 aW5nIHRoZSBzdGFydCBwb3NpdGlvbgoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBUb29scy9EdW1wUmVuZGVyVHJlZS9x dC9FdmVudFNlbmRlclF0LmNwcCB8ICAgMTIgKysrKystLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQs IDE3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM3MWRjNDUuLjdkNGU0OTYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxMS0wNS0wOSAgSWdvciBPbGl2ZWlyYSAgPGlnb3Iub2xpdmVpcmFAb3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd IERSVCBldmVudFNlbmRlci5hZGRUb3VjaFBvaW50IG1ldGhvZCBpcyBub3Qgc2V0dGluZyB0aGUg c3RhcnQgcG9zaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYwNDg3CisKKyAgICAgICAgV2hlbiBhZGRpbmcgYSBuZXcgdG91Y2ggcG9pbnQsIHRo ZSBzdGFydCBwb3NpdGlvbiBvZiB0aGlzIHBvaW50IG5lZWRzIHRvIGJlIHNldC4KKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwOgorICAgICAgICAoRXZlbnRT ZW5kZXI6OmFkZFRvdWNoUG9pbnQpOgorCiAyMDExLTA1LTA5ICBNYWhlc2ggS3Vsa2FybmkgIDxt YWhlc2gua3Vsa2FybmlAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMg S2xpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0 LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwCmluZGV4IGVm ODllMDIuLjA4ZTAyMzIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0V2ZW50 U2VuZGVyUXQuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQu Y3BwCkBAIC0zOTQsMTUgKzM5NCwxMyBAQCB2b2lkIEV2ZW50U2VuZGVyOjpzY2hlZHVsZUFzeW5j aHJvbm91c0NsaWNrKCkKIAogdm9pZCBFdmVudFNlbmRlcjo6YWRkVG91Y2hQb2ludChpbnQgeCwg aW50IHkpCiB7Ci0gICAgLy8gVXNlIGluZGV4IHRvIHJlZmVyIHRvIHRoZSBwb3NpdGlvbiBpbiB0 aGUgdmVjdG9yIHRoYXQgdGhpcyB0b3VjaAotICAgIC8vIGlzIHN0b3JlZC4gV2UgdGhlbiBjcmVh dGUgYSB1bmlxdWUgaWQgZm9yIHRoZSB0b3VjaCB0aGF0IHdpbGwgYmUKLSAgICAvLyBwYXNzZWQg aW50byBXZWJDb3JlLgotICAgIGludCBpbmRleCA9IG1fdG91Y2hQb2ludHMuY291bnQoKTsKLSAg ICBpbnQgaWQgPSBtX3RvdWNoUG9pbnRzLmlzRW1wdHkoKSA/IDAgOiBtX3RvdWNoUG9pbnRzLmxh c3QoKS5pZCgpICsgMTsKKyAgICBjb25zdCBpbnQgaWQgPSBtX3RvdWNoUG9pbnRzLmlzRW1wdHko KSA/IDAgOiBtX3RvdWNoUG9pbnRzLmxhc3QoKS5pZCgpICsgMTsKKyAgICBjb25zdCBRUG9pbnRG IHBvcyh4LCB5KTsKICAgICBRVG91Y2hFdmVudDo6VG91Y2hQb2ludCBwb2ludChpZCk7CisgICAg cG9pbnQuc2V0UG9zKHBvcyk7CisgICAgcG9pbnQuc2V0U3RhcnRQb3MocG9zKTsKKyAgICBwb2lu dC5zZXRTdGF0ZShRdDo6VG91Y2hQb2ludFByZXNzZWQpOwogICAgIG1fdG91Y2hQb2ludHMuYXBw ZW5kKHBvaW50KTsKLSAgICB1cGRhdGVUb3VjaFBvaW50KGluZGV4LCB4LCB5KTsKLSAgICBtX3Rv dWNoUG9pbnRzW2luZGV4XS5zZXRTdGF0ZShRdDo6VG91Y2hQb2ludFByZXNzZWQpOwogfQogCiB2 b2lkIEV2ZW50U2VuZGVyOjp1cGRhdGVUb3VjaFBvaW50KGludCBpbmRleCwgaW50IHgsIGludCB5 KQotLSAKMS43LjEKCg==