60485 2011-05-09 11:35:09 -0700 [Qt] Remove unused FontPlatformData functions. 2011-05-09 12:56:24 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling abarth eric webkit.review.bot oldest_to_newest 400604 0 kling 2011-05-09 11:35:09 -0700 SSIA 400607 1 92813 kling 2011-05-09 11:36:22 -0700 Created attachment 92813 Proposed patch 400620 2 kling 2011-05-09 11:54:50 -0700 D'oh. There are more unused functions in this class. Let's toss 'em all. 400621 3 92817 kling 2011-05-09 11:55:12 -0700 Created attachment 92817 Proposed patch v2 400650 4 92817 kling 2011-05-09 12:22:57 -0700 Comment on attachment 92817 Proposed patch v2 Clearing flags on attachment: 92817 Committed r86078: <http://trac.webkit.org/changeset/86078> 400651 5 kling 2011-05-09 12:23:04 -0700 All reviewed patches have been landed. Closing bug. 400691 6 webkit.review.bot 2011-05-09 12:56:24 -0700 http://trac.webkit.org/changeset/86078 might have broken Windows Debug (Build) 92813 2011-05-09 11:36:22 -0700 2011-05-09 11:55:12 -0700 Proposed patch bug-60485.diff text/plain 1333 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZGM2YWZlLi4xMWIxZWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDUtMDkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHVu dXNlZCBmdW5jdGlvbiBGb250UGxhdGZvcm1EYXRhOjpzbWFsbENhcHMoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0ODUKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9ybURhdGEuaDoKKyAgICAgICAgKFdlYkNvcmU6 OkZvbnRQbGF0Zm9ybURhdGE6OnNtYWxsQ2Fwcyk6IFJlbW92ZWQuCisKIDIwMTEtMDUtMDkgIEFk YW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdpbmRvd3MgcHJvamVjdCBm aWxlIGZpeCBhZnRlciByODYwNDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9ybURhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9ybURhdGEuaAppbmRleCA4OGZkNjI3Li45ZTQ2MjA4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UGxhdGZv cm1EYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFBs YXRmb3JtRGF0YS5oCkBAIC0xNTYsMTMgKzE1Niw2IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICAgICAgcmV0dXJuIG1fZGF0YS0+Zm9udC5pdGFsaWMoKTsKICAgICB9 Ci0gICAgYm9vbCBzbWFsbENhcHMoKSBjb25zdAotICAgIHsKLSAgICAgICAgUV9BU1NFUlQoIWlz SGFzaFRhYmxlRGVsZXRlZFZhbHVlKCkpOwotICAgICAgICBpZiAoIW1fZGF0YSkKLSAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgcmV0dXJuIG1fZGF0YS0+Zm9udC5jYXBpdGFsaXph dGlvbigpID09IFFGb250OjpTbWFsbENhcHM7Ci0gICAgfQogICAgIAogICAgIEZvbnRPcmllbnRh dGlvbiBvcmllbnRhdGlvbigpIGNvbnN0IHsgcmV0dXJuIEhvcml6b250YWw7IH0gLy8gRklYTUU6 IEltcGxlbWVudC4KICAgICB2b2lkIHNldE9yaWVudGF0aW9uKEZvbnRPcmllbnRhdGlvbikgeyB9 IC8vIEZJWE1FOiBJbXBsZW1lbnQuCg== 92817 2011-05-09 11:55:12 -0700 2011-05-09 12:22:57 -0700 Proposed patch v2 bug-60485.diff text/plain 1994 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZGM2YWZlLi4xYmU0NjM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDUtMDkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHVu dXNlZCBGb250UGxhdGZvcm1EYXRhIGZ1bmN0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNDg1CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9xdC9Gb250UGxhdGZvcm1EYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZv cm1EYXRhOjpib2xkKTogUmVtb3ZlZC4KKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURh dGE6OmZhbWlseSk6IFJlbW92ZWQuCisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRh OjppdGFsaWMpOiBSZW1vdmVkLgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6 c21hbGxDYXBzKTogUmVtb3ZlZC4KKwogMjAxMS0wNS0wOSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBh cHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBwcm9qZWN0IGZpbGUgZml4IGFmdGVyIHI4NjA0 NwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFBs YXRmb3JtRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFBs YXRmb3JtRGF0YS5oCmluZGV4IDg4ZmQ2MjcuLjc2NjJhYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9ybURhdGEuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UGxhdGZvcm1EYXRhLmgKQEAgLTEz NSwzNSArMTM1LDcgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIHJl dHVybiBtX2RhdGEtPnNpemU7CiAgICAgfQotICAgIFFTdHJpbmcgZmFtaWx5KCkgY29uc3QKLSAg ICB7Ci0gICAgICAgIFFfQVNTRVJUKCFpc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSgpKTsKLSAgICAg ICAgaWYgKCFtX2RhdGEpCi0gICAgICAgICAgICByZXR1cm4gUVN0cmluZygpOwotICAgICAgICBy ZXR1cm4gbV9kYXRhLT5mb250LmZhbWlseSgpOwotICAgIH0KLSAgICBib29sIGJvbGQoKSBjb25z dAotICAgIHsKLSAgICAgICAgUV9BU1NFUlQoIWlzSGFzaFRhYmxlRGVsZXRlZFZhbHVlKCkpOwot ICAgICAgICBpZiAoIW1fZGF0YSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAg cmV0dXJuIG1fZGF0YS0+Ym9sZDsKLSAgICB9Ci0gICAgYm9vbCBpdGFsaWMoKSBjb25zdAotICAg IHsKLSAgICAgICAgUV9BU1NFUlQoIWlzSGFzaFRhYmxlRGVsZXRlZFZhbHVlKCkpOwotICAgICAg ICBpZiAoIW1fZGF0YSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgcmV0dXJu IG1fZGF0YS0+Zm9udC5pdGFsaWMoKTsKLSAgICB9Ci0gICAgYm9vbCBzbWFsbENhcHMoKSBjb25z dAotICAgIHsKLSAgICAgICAgUV9BU1NFUlQoIWlzSGFzaFRhYmxlRGVsZXRlZFZhbHVlKCkpOwot ICAgICAgICBpZiAoIW1fZGF0YSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAg cmV0dXJuIG1fZGF0YS0+Zm9udC5jYXBpdGFsaXphdGlvbigpID09IFFGb250OjpTbWFsbENhcHM7 Ci0gICAgfQotICAgIAorCiAgICAgRm9udE9yaWVudGF0aW9uIG9yaWVudGF0aW9uKCkgY29uc3Qg eyByZXR1cm4gSG9yaXpvbnRhbDsgfSAvLyBGSVhNRTogSW1wbGVtZW50LgogICAgIHZvaWQgc2V0 T3JpZW50YXRpb24oRm9udE9yaWVudGF0aW9uKSB7IH0gLy8gRklYTUU6IEltcGxlbWVudC4KIAo=