60477 2011-05-09 08:53:34 -0700 [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html 2011-05-16 14:04:13 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 60554 1 cshu cshu abarth ademar commit-queue eric rniwa tonikitoo webkit.review.bot oldest_to_newest 400535 0 cshu 2011-05-09 08:53:34 -0700 In the above test, type 'tab' should insert tab-space in the form. But it didn't happen. 400537 1 cshu 2011-05-09 08:54:57 -0700 editing/inserting/typing-tab-designmode.html seems to have the same problem. 401337 2 92982 cshu 2011-05-10 10:54:40 -0700 Created attachment 92982 fix patch 401989 3 92982 rniwa 2011-05-11 08:34:34 -0700 Comment on attachment 92982 fix patch Looks sane to me but I guess someone from Qt port should review it. 402019 4 92982 cshu 2011-05-11 09:12:18 -0700 Comment on attachment 92982 fix patch thanks, guys. 402058 5 commit-queue 2011-05-11 09:54:20 -0700 The commit-queue encountered the following flaky tests while processing attachment 92982: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 402060 6 92982 commit-queue 2011-05-11 09:59:25 -0700 Comment on attachment 92982 fix patch Clearing flags on attachment: 92982 Committed r86243: <http://trac.webkit.org/changeset/86243> 402061 7 commit-queue 2011-05-11 09:59:29 -0700 All reviewed patches have been landed. Closing bug. 402135 8 webkit.review.bot 2011-05-11 11:52:09 -0700 http://trac.webkit.org/changeset/86243 might have broken Windows XP Debug (Tests) The following tests are not passing: inspector/debugger/source-frame.html inspector/extensions/extensions.html media/controls-without-preload.html 402154 9 cshu 2011-05-11 12:14:48 -0700 (In reply to comment #8) > http://trac.webkit.org/changeset/86243 might have broken Windows XP Debug (Tests) > The following tests are not passing: > inspector/debugger/source-frame.html > inspector/extensions/extensions.html > media/controls-without-preload.html The patch only touched Qt code. 404697 10 ademar 2011-05-16 14:04:04 -0700 Revision r86243 cherry-picked into qtwebkit-2.2 with commit 614ea61 <http://gitorious.org/webkit/qtwebkit/commit/614ea61> 92982 2011-05-10 10:54:40 -0700 2011-05-11 09:59:25 -0700 fix patch 60477_1.patch text/plain 3212 cshu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MTY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDUtMTAgIENoYW5nIFNo dSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbUXRdIFRhYiBub3Qgd29ya2luZyBpbiBlZGl0aW5nL2luc2VydGluZy90 eXBpbmctdGFiLWRlc2lnbm1vZGUtZm9ybXMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0NzcKKworICAgICAgICBQbGF0Zm9ybUtleWJvYXJk RXZlbnQubV90ZXh0IHNob3VsZCBiZSBzZXQgdG8gIlx0IiBpbnN0ZWFkIG9mIGxlYXZpbmcgYXMg bnVsbC4KKyAgICAgICAgVGhlIHZhbHVlIGlzIGNoZWNrZWQgYXQgRXZlbnRIYW5kbGVyLmNwcDoy NTI3IChyODYxNjYpLgorCisgICAgICAgIEZ1bmN0aW9uIGtleVRleHRGb3JLZXlFdmVudCBpcyBw YXJ0aWFsbHkgaW1wbGVtZW50ZWQgYW5kIGNhbiBiZSBlbmhhbmNlZCBpbgorICAgICAgICBhIG5l ZWQtYmFzZS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmtleVRleHRGb3JLZXlFdmVudCk6CisgICAgICAgIChX ZWJDb3JlOjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudCk6CisK IDIwMTEtMDUtMDYgIEJyZXR0IFdpbHNvbiAgPGJyZXR0d0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAJKHJldmlzaW9uIDg2 MTY2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50 UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzgsMTIgKzU3OCwyMyBAQCBzdGF0aWMgYm9vbCBp c1ZpcnR1YWxLZXlDb2RlUmVwcmVzZW50aW5nCiAgICAgfQogfQogCitzdGF0aWMgU3RyaW5nIGtl eVRleHRGb3JLZXlFdmVudChjb25zdCBRS2V5RXZlbnQqIGV2ZW50KQoreworICAgIHN3aXRjaCAo ZXZlbnQtPmtleSgpKSB7CisgICAgY2FzZSBRdDo6S2V5X1RhYjoKKyAgICBjYXNlIFF0OjpLZXlf QmFja3RhYjoKKyAgICAgICAgaWYgKGV2ZW50LT50ZXh0KCkuaXNOdWxsKCkpCisgICAgICAgICAg ICByZXR1cm4gIlx0IjsKKyAgICB9CisgICAgcmV0dXJuIGV2ZW50LT50ZXh0KCk7Cit9CisKIFBs YXRmb3JtS2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KFFLZXlFdmVudCogZXZl bnQpCiB7CiAgICAgY29uc3QgaW50IHN0YXRlID0gZXZlbnQtPm1vZGlmaWVycygpOwogICAgIG1f dHlwZSA9IChldmVudC0+dHlwZSgpID09IFFFdmVudDo6S2V5UmVsZWFzZSkgPyBLZXlVcCA6IEtl eURvd247Ci0gICAgbV90ZXh0ID0gZXZlbnQtPnRleHQoKTsKLSAgICBtX3VubW9kaWZpZWRUZXh0 ID0gZXZlbnQtPnRleHQoKTsgLy8gRklYTUU6IG5vdCBjb3JyZWN0CisgICAgbV90ZXh0ID0ga2V5 VGV4dEZvcktleUV2ZW50KGV2ZW50KTsKKyAgICBtX3VubW9kaWZpZWRUZXh0ID0gbV90ZXh0OyAv LyBGSVhNRTogbm90IGNvcnJlY3QKICAgICBtX2tleUlkZW50aWZpZXIgPSBrZXlJZGVudGlmaWVy Rm9yUXRLZXlDb2RlKGV2ZW50LT5rZXkoKSk7CiAgICAgbV9hdXRvUmVwZWF0ID0gZXZlbnQtPmlz QXV0b1JlcGVhdCgpOwogICAgIG1fY3RybEtleSA9IChzdGF0ZSAmIFF0OjpDb250cm9sTW9kaWZp ZXIpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODYxNjcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wNS0xMCAgQ2hhbmcgU2h1ICA8 Y3NodUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gVGFiIG5vdCB3b3JraW5nIGluIGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGlu Zy10YWItZGVzaWdubW9kZS1mb3Jtcy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MDQ3NworCisgICAgICAgIFVuc2tpcCBwYXNzZWQgdGVzdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTA1LTEwICBDaGFuZyBT aHUgIDxjc2h1QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlzaW9uIDg2MTY2KQorKysgTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMzMzLDggKzMzMyw2 IEBAIGVkaXRpbmcvaW5zZXJ0aW5nL2VkaXRhYmxlLWh0bWwtZWxlbWVudC4KIGVkaXRpbmcvaW5z ZXJ0aW5nL2VkaXRpbmctZW1wdHktZGl2cy5odG1sCiBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQt ZGl2LTAyMy5odG1sCiBlZGl0aW5nL2luc2VydGluZy9tdWx0aXBsZS1saW5lcy1zZWxlY3RlZC5o dG1sCi1lZGl0aW5nL2luc2VydGluZy90eXBpbmctdGFiLWRlc2lnbm1vZGUtZm9ybXMuaHRtbAot ZWRpdGluZy9pbnNlcnRpbmcvdHlwaW5nLXRhYi1kZXNpZ25tb2RlLmh0bWwKIGVkaXRpbmcvaW5z ZXJ0aW5nLzU5OTQ0ODAtMi5odG1sCiAKICMgaHR0cDovL2J1Z3JlcG9ydHMucXQubm9raWEuY29t L2Jyb3dzZS9RVEJVRy0xNTU2Ngo=