60475 2011-05-09 08:49:30 -0700 Style fix: Function names must begin with lowercase letter. 2011-05-09 12:39:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 54181 1 tonyg tonyg commit-queue mitz shishir oldest_to_newest 400533 0 tonyg 2011-05-09 08:49:30 -0700 Style fix: Funciton names must begin with lowercase letter. 400536 1 92796 tonyg 2011-05-09 08:53:35 -0700 Created attachment 92796 Patch 400540 2 92796 darin 2011-05-09 09:09:16 -0700 Comment on attachment 92796 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92796&action=review > Source/WebCore/page/PageVisibilityState.h:47 > #if ENABLE(PAGE_VISIBILITY_API) > -String GetPageVisibilityStateString(PageVisibilityState); > +String getPageVisibilityStateString(PageVisibilityState); > #endif If your intent is to fix to match WebKit project style, then the name should be: pageVisibilityStateString We only use “get” in functions with out arguments; functions that simply return a value use noun or adjective phrases. 400541 3 92797 tonyg 2011-05-09 09:18:07 -0700 Created attachment 92797 Patch 400592 4 92797 commit-queue 2011-05-09 11:19:09 -0700 Comment on attachment 92797 Patch Clearing flags on attachment: 92797 Committed r86069: <http://trac.webkit.org/changeset/86069> 400593 5 commit-queue 2011-05-09 11:19:14 -0700 All reviewed patches have been landed. Closing bug. 400673 6 commit-queue 2011-05-09 12:39:12 -0700 The commit-queue encountered the following flaky tests while processing attachment 92797: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 92796 2011-05-09 08:53:35 -0700 2011-05-09 09:18:00 -0700 Patch bug-60475-20110509165333.patch text/plain 2458 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogODYwNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NTAzNjgwNmJmY2U3N2Fh NDA1YjQ0M2QxYjQ0Y2FhMjgxNzY2NGE2Li5iNDhkOTgwMWM4YjdkNDdiOTlhM2E2ZmVmNTQ3Njgx MjZjZDZiN2VmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDkgIFRvbnkg R2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdHlsZSBmaXg6IEZ1bmN0aW9uIG5hbWVzIG11c3Qg YmVnaW4gd2l0aCBsb3dlcmNhc2UgbGV0dGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0NzUKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6d2Via2l0VmlzaWJpbGl0eVN0YXRlKToKKyAg ICAgICAgKiBwYWdlL1BhZ2VWaXNpYmlsaXR5U3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Z2V0UGFnZVZpc2liaWxpdHlTdGF0ZVN0cmluZyk6CisgICAgICAgICogcGFnZS9QYWdlVmlzaWJp bGl0eVN0YXRlLmg6CisKIDIwMTEtMDUtMDYgIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCmluZGV4IGFmNWZkNzA2YjgzZWMxMzkyZmZmMDZiOGJjOGY4OGI5MGM5YzQw ZTguLjI3Y2UwYzMzNmE3YjFlNjA4ZjFjYTU3OGY4OGE5ZWU5MWQxZGFhMzYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcApAQCAtMTM2OSw3ICsxMzY5LDcgQEAgUGFnZVZpc2liaWxpdHlTdGF0ZSBE b2N1bWVudDo6dmlzaWJpbGl0eVN0YXRlKCkgY29uc3QKIAogU3RyaW5nIERvY3VtZW50Ojp3ZWJr aXRWaXNpYmlsaXR5U3RhdGUoKSBjb25zdAogewotICAgIHJldHVybiBHZXRQYWdlVmlzaWJpbGl0 eVN0YXRlU3RyaW5nKHZpc2liaWxpdHlTdGF0ZSgpKTsKKyAgICByZXR1cm4gZ2V0UGFnZVZpc2li aWxpdHlTdGF0ZVN0cmluZyh2aXNpYmlsaXR5U3RhdGUoKSk7CiB9CiAKIGJvb2wgRG9jdW1lbnQ6 OndlYmtpdElzVmlzaWJsZSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L1BhZ2VWaXNpYmlsaXR5U3RhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVmlzaWJp bGl0eVN0YXRlLmNwcAppbmRleCBmZTE4ZGZhZGUxNTI1YzdiNzI5MjUxNjZiNmUyMDY2MmUzMWRi YzAwLi5iNGFmZmU4ZDI4M2ZhNDA3NDEzM2ZlMzAwNDQ2MDg1YTYwZjIzOGM1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VWaXNpYmlsaXR5U3RhdGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZVZpc2liaWxpdHlTdGF0ZS5jcHAKQEAgLTM1LDcgKzM1LDcgQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1TdHJpbmcgR2V0UGFnZVZpc2liaWxpdHlTdGF0ZVN0 cmluZyhQYWdlVmlzaWJpbGl0eVN0YXRlIHN0YXRlKQorU3RyaW5nIGdldFBhZ2VWaXNpYmlsaXR5 U3RhdGVTdHJpbmcoUGFnZVZpc2liaWxpdHlTdGF0ZSBzdGF0ZSkKIHsKICAgICBERUZJTkVfU1RB VElDX0xPQ0FMKGNvbnN0IFN0cmluZywgdmlzaWJsZSwgKCJ2aXNpYmxlIikpOwogICAgIERFRklO RV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBoaWRkZW4sICgiaGlkZGVuIikpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVmlzaWJpbGl0eVN0YXRlLmggYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2VWaXNpYmlsaXR5U3RhdGUuaAppbmRleCBhN2Q3MDIxMTc0ZTBmMjIx MzFjNzkzNDdmYjcxNTI3NDMxNjVjN2EwLi4wNmRiNjg2OGIxZDhmYTdkZGFlMjJiNWFjODZiMWU0 ZmMyM2NjMmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VWaXNpYmlsaXR5 U3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VWaXNpYmlsaXR5U3RhdGUuaApA QCAtNDMsNyArNDMsNyBAQCBlbnVtIFBhZ2VWaXNpYmlsaXR5U3RhdGUgewogfTsKIAogI2lmIEVO QUJMRShQQUdFX1ZJU0lCSUxJVFlfQVBJKQotU3RyaW5nIEdldFBhZ2VWaXNpYmlsaXR5U3RhdGVT dHJpbmcoUGFnZVZpc2liaWxpdHlTdGF0ZSk7CitTdHJpbmcgZ2V0UGFnZVZpc2liaWxpdHlTdGF0 ZVN0cmluZyhQYWdlVmlzaWJpbGl0eVN0YXRlKTsKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCg== 92797 2011-05-09 09:18:07 -0700 2011-05-09 11:19:09 -0700 Patch bug-60475-20110509171805.patch text/plain 2480 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogODYwNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NTAzNjgwNmJmY2U3N2Fh NDA1YjQ0M2QxYjQ0Y2FhMjgxNzY2NGE2Li4xZTgzOGVkNmE4ZjNiZDFkNjA3MTAzNWMwZWVlMzYy NTRiMGY2NTcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDkgIFRvbnkg R2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdHlsZSBmaXg6IEZ1bmN0aW9uIG5hbWVzIG11c3Qg YmVnaW4gd2l0aCBsb3dlcmNhc2UgbGV0dGVyIGFuZCBzaG91bGQgbm90IHVzZSAiZ2V0Ii4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNDc1CisKKyAg ICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Ondl YmtpdFZpc2liaWxpdHlTdGF0ZSk6CisgICAgICAgICogcGFnZS9QYWdlVmlzaWJpbGl0eVN0YXRl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhZ2VWaXNpYmlsaXR5U3RhdGVTdHJpbmcpOiBSZW5h bWVkLgorICAgICAgICAqIHBhZ2UvUGFnZVZpc2liaWxpdHlTdGF0ZS5oOgorCiAyMDExLTA1LTA2 ICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCBhZjVmZDcw NmI4M2VjMTM5MmZmZjA2YjhiYzhmODhiOTBjOWM0MGU4Li43MmI3NGZhNzllYmY4ZWU0NDNhMjRl MDIzMWI1MzgxZjcyZjk4OTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTEzNjksNyAr MTM2OSw3IEBAIFBhZ2VWaXNpYmlsaXR5U3RhdGUgRG9jdW1lbnQ6OnZpc2liaWxpdHlTdGF0ZSgp IGNvbnN0CiAKIFN0cmluZyBEb2N1bWVudDo6d2Via2l0VmlzaWJpbGl0eVN0YXRlKCkgY29uc3QK IHsKLSAgICByZXR1cm4gR2V0UGFnZVZpc2liaWxpdHlTdGF0ZVN0cmluZyh2aXNpYmlsaXR5U3Rh dGUoKSk7CisgICAgcmV0dXJuIHBhZ2VWaXNpYmlsaXR5U3RhdGVTdHJpbmcodmlzaWJpbGl0eVN0 YXRlKCkpOwogfQogCiBib29sIERvY3VtZW50Ojp3ZWJraXRJc1Zpc2libGUoKSBjb25zdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVmlzaWJpbGl0eVN0YXRlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUGFnZVZpc2liaWxpdHlTdGF0ZS5jcHAKaW5kZXggZmUxOGRmYWRl MTUyNWM3YjcyOTI1MTY2YjZlMjA2NjJlMzFkYmMwMC4uYjA0OTNhOWZiOTk0Yjk1YzVhNGNkNmYx MTg5YTg4NzZjZTJhYWRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVmlz aWJpbGl0eVN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VWaXNpYmlsaXR5 U3RhdGUuY3BwCkBAIC0zNSw3ICszNSw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotU3Ry aW5nIEdldFBhZ2VWaXNpYmlsaXR5U3RhdGVTdHJpbmcoUGFnZVZpc2liaWxpdHlTdGF0ZSBzdGF0 ZSkKK1N0cmluZyBwYWdlVmlzaWJpbGl0eVN0YXRlU3RyaW5nKFBhZ2VWaXNpYmlsaXR5U3RhdGUg c3RhdGUpCiB7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHZpc2libGUs ICgidmlzaWJsZSIpKTsKICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywgaGlk ZGVuLCAoImhpZGRlbiIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZVZp c2liaWxpdHlTdGF0ZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlVmlzaWJpbGl0eVN0YXRl LmgKaW5kZXggYTdkNzAyMTE3NGUwZjIyMTMxYzc5MzQ3ZmI3MTUyNzQzMTY1YzdhMC4uODlmNzli OGNmZGUzZThjMTY4MjA1NTIxODgzYWQ5MTYzMjhlMDg1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9QYWdlVmlzaWJpbGl0eVN0YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9QYWdlVmlzaWJpbGl0eVN0YXRlLmgKQEAgLTQzLDcgKzQzLDcgQEAgZW51bSBQYWdlVmlzaWJp bGl0eVN0YXRlIHsKIH07CiAKICNpZiBFTkFCTEUoUEFHRV9WSVNJQklMSVRZX0FQSSkKLVN0cmlu ZyBHZXRQYWdlVmlzaWJpbGl0eVN0YXRlU3RyaW5nKFBhZ2VWaXNpYmlsaXR5U3RhdGUpOworU3Ry aW5nIHBhZ2VWaXNpYmlsaXR5U3RhdGVTdHJpbmcoUGFnZVZpc2liaWxpdHlTdGF0ZSk7CiAjZW5k aWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=