<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60469</bug_id>
          
          <creation_ts>2011-05-09 08:26:01 -0700</creation_ts>
          <short_desc>[Qt] Some skipped editing tests actually work and just need rebaseline.</short_desc>
          <delta_ts>2011-08-11 13:12:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>LATER</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>60479</dependson>
    
    <dependson>60498</dependson>
    
    <dependson>60702</dependson>
    
    <dependson>60707</dependson>
    
    <dependson>60717</dependson>
    
    <dependson>61075</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chang Shu">cshu</reporter>
          <assigned_to name="Chang Shu">cshu</assigned_to>
          <cc>ademar</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>400506</commentid>
    <comment_count>0</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-09 08:26:01 -0700</bug_when>
    <thetext>I am in the process of investigating editing tests on Qt. I noticed some tests are actually working but need a rebaseline.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>400512</commentid>
    <comment_count>1</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-09 08:27:52 -0700</bug_when>
    <thetext>editing/inserting/4278698.html
The above test works. Ossy, can you help to rebaseline it? Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>400517</commentid>
    <comment_count>2</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-09 08:36:14 -0700</bug_when>
    <thetext>editing/inserting/editable-html-element.html
this one works, too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>400520</commentid>
    <comment_count>3</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-09 08:39:52 -0700</bug_when>
    <thetext>and this:
editing/inserting/editing-empty-divs.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>400521</commentid>
    <comment_count>4</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-09 08:42:24 -0700</bug_when>
    <thetext>and this:
editing/inserting/insert-div-023.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>400523</commentid>
    <comment_count>5</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-09 08:44:14 -0700</bug_when>
    <thetext>and this:
editing/inserting/multiple-lines-selected.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401403</commentid>
    <comment_count>6</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 11:58:01 -0700</bug_when>
    <thetext>editing/pasteboard/smart-paste-008.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401409</commentid>
    <comment_count>7</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 12:07:20 -0700</bug_when>
    <thetext>editing/pasteboard/nested-blocks-with-text-area.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401410</commentid>
    <comment_count>8</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 12:08:53 -0700</bug_when>
    <thetext>editing/pasteboard/nested-blocks-with-text-field.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401412</commentid>
    <comment_count>9</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 12:11:15 -0700</bug_when>
    <thetext>editing/pasteboard/input-field-1.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401414</commentid>
    <comment_count>10</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 12:12:44 -0700</bug_when>
    <thetext>editing/pasteboard/4806874.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401452</commentid>
    <comment_count>11</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:36:19 -0700</bug_when>
    <thetext>editing/pasteboard/5387578.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401455</commentid>
    <comment_count>12</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:37:40 -0700</bug_when>
    <thetext>editing/pasteboard/bad-placeholder.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401458</commentid>
    <comment_count>13</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:39:38 -0700</bug_when>
    <thetext>editing/pasteboard/4076267.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401459</commentid>
    <comment_count>14</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:40:15 -0700</bug_when>
    <thetext>editing/pasteboard/4076267-2.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401464</commentid>
    <comment_count>15</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:53:05 -0700</bug_when>
    <thetext>editing/pasteboard/block-wrappers-necessary.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401465</commentid>
    <comment_count>16</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:56:11 -0700</bug_when>
    <thetext>editing/pasteboard/paste-text-001.html
editing/pasteboard/4242293-1.html

these two work out-of-box. just upskip them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401466</commentid>
    <comment_count>17</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:56:24 -0700</bug_when>
    <thetext>editing/pasteboard/paste-text-008.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401469</commentid>
    <comment_count>18</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 13:59:54 -0700</bug_when>
    <thetext>editing/pasteboard/paste-text-at-tabspan-001.html
editing/pasteboard/onpaste-text-html-types.html

These two also work fine. Unskip.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401513</commentid>
    <comment_count>19</comment_count>
      <attachid>93009</attachid>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-10 14:43:13 -0700</bug_when>
    <thetext>Created attachment 93009
fix patch: part 1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>401950</commentid>
    <comment_count>20</comment_count>
      <attachid>93009</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-05-11 07:22:03 -0700</bug_when>
    <thetext>Comment on attachment 93009
fix patch: part 1

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402009</commentid>
    <comment_count>21</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-11 09:04:30 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 93009:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (authors: ap@webkit.org and eric@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402010</commentid>
    <comment_count>22</comment_count>
      <attachid>93009</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-11 09:05:37 -0700</bug_when>
    <thetext>Comment on attachment 93009
fix patch: part 1

Clearing flags on attachment: 93009

Committed r86235: &lt;http://trac.webkit.org/changeset/86235&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402011</commentid>
    <comment_count>23</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-11 09:05:43 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402014</commentid>
    <comment_count>24</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-11 09:08:05 -0700</bug_when>
    <thetext>more patches coming...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402074</commentid>
    <comment_count>25</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-05-11 10:18:01 -0700</bug_when>
    <thetext>Generally we do one-patch per-bug and use meta bugs.  Then again, you&apos;re welcome to use bugzilla however you wish.  :)  Our tools are obviously optimized for hte one-patch-per-bug workflow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402086</commentid>
    <comment_count>26</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-05-11 10:27:08 -0700</bug_when>
    <thetext>(In reply to comment #25)
&gt; Generally we do one-patch per-bug and use meta bugs.  Then again, you&apos;re welcome to use bugzilla however you wish.  :)  Our tools are obviously optimized for hte one-patch-per-bug workflow.

Thanks, Eric. I understand. This bug is slightly special. You can consider it a meta bug. But since it&apos;s just rebaseline, I didn&apos;t plan to create separate bugs for each patch. It also takes time to investigate each test case, so I can&apos;t do everything in one patch. But if this confuses people, I will create separate bugs in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403666</commentid>
    <comment_count>27</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-05-13 10:53:36 -0700</bug_when>
    <thetext>We had some changes in our DRT on trunk and it&apos;s not &quot;safe&quot; to cherry-pick layout tests to qtwebkit-2.2 anymore (not without auditing the changes). 

I&apos;m removing them from the meta-bug (they were not critical anyway, just a nice-to-have).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449971</commentid>
    <comment_count>28</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-08-11 13:12:02 -0700</bug_when>
    <thetext>This task can be resumed later.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93009</attachid>
            <date>2011-05-10 14:43:13 -0700</date>
            <delta_ts>2011-05-11 09:05:37 -0700</delta_ts>
            <desc>fix patch: part 1</desc>
            <filename>60469_1.patch</filename>
            <type>text/plain</type>
            <size>2148</size>
            <attacher name="Chang Shu">cshu</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDg2MTgwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTAgIENoYW5nIFNodSAgPGNzaHVA
d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBbUXRdIFNvbWUgc2tpcHBlZCBlZGl0aW5nIHRlc3RzIGFjdHVhbGx5IHdvcmsgYW5kIGp1
c3QgbmVlZCByZWJhc2VsaW5lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NjA0NjkKKworICAgICAgICBVbnNraXAgc29tZSBlZGl0aW5nIHRlc3RzIHRo
YXQgYWN0dWFsbHkgd29yay4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIw
MTEtMDUtMTAgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hyb21pdW0ub3JnPgogCiAgICAg
ICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9x
dC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJ
KHJldmlzaW9uIDg2MTc5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29y
a2luZyBjb3B5KQpAQCAtMzQ1LDcgKzM0NSw2IEBAIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv
YmFzaWMtYXV0aC1ub3UKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKICMtLS0tLS0gTm90IHNlbGVj
dGluZyBhbGwgb2YgdGV4dC4KICMtLS0tLS0gc2VsLm1vZGlmeSgibW92ZSIsICJmb3J3YXJkIiwg
IndvcmQiKTsgZG9lcyBub3Qgc2VsZWN0IHRoZSBsYXN0IGNoYXJhY3RlciBpbiB0aGUgd29yZAot
ZWRpdGluZy9wYXN0ZWJvYXJkLzQyNDIyOTMtMS5odG1sCiBlZGl0aW5nL3Bhc3RlYm9hcmQvc21h
cnQtcGFzdGUtMDA4Lmh0bWwKICMtLS0tLS0gc2FmZSB0byBza2lwLiBRdCByZXN1bHRzIHNhbWUg
YXMgY2hyb21pdW0ncy4gTWFjIGRyb3BzIHRoZSAnYicgaW4gdGhlIGZpbmFsIGJhciwKICMtLS0t
LS0gdGhhdCBsb29rcyBsaWtlIGEgYnVnLgpAQCAtMzYzLDE1ICszNjIsMTAgQEAgZWRpdGluZy9w
YXN0ZWJvYXJkL2JhZC1wbGFjZWhvbGRlci5odG1sCiBlZGl0aW5nL3Bhc3RlYm9hcmQvNDA3NjI2
Ny0yLmh0bWwKIGVkaXRpbmcvcGFzdGVib2FyZC80MDc2MjY3Lmh0bWwKIGVkaXRpbmcvcGFzdGVi
b2FyZC9ibG9jay13cmFwcGVycy1uZWNlc3NhcnkuaHRtbAotZWRpdGluZy9wYXN0ZWJvYXJkL3Bh
c3RlLXRleHQtMDAxLmh0bWwKIGVkaXRpbmcvcGFzdGVib2FyZC9wYXN0ZS10ZXh0LTAwOC5odG1s
CiAjIC0tLS0tIFJlbmRlcnRyZWUgcmVzdWx0cyBPSyBidXQgZGlmZmVyZW5jZXMgaW4gZWRpdGlu
ZyBkZWxlZ2F0ZSBtZXNzYWdlIGR1ZSB0byByZW5kZXJpbmcuCiAjIC0tLS0tIFRoaXMgbG9va3Mg
c2FmZSB0byB1bnNraXAuCiBlZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUteG1sLnhodG1sCi0jIC0t
LS0tIFJlbmRlcnRyZWUgcmVzdWx0cyBtYXRjaCBidXQgd2lkdGggb2YgdGFicyBmaWVsZCBpcyBz
dXNwaWNpb3VzLgotZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXRleHQtYXQtdGFic3Bhbi0wMDEu
aHRtbAotIyAtLS0tLSBRdCBkb2Vzbid0IGFkZCBhc2xpc2VzIGZvciAidGV4dC9wbGFpbiIgdG8g
dHlwZXM6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTkyMgotZWRp
dGluZy9wYXN0ZWJvYXJkL29ucGFzdGUtdGV4dC1odG1sLXR5cGVzLmh0bWwKICAKICMgPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09ICMKICMgICAgICAgRmFpbGluZyBwbHVnaW5zIHRlc3RzLiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMK
</data>

          </attachment>
      

    </bug>

</bugzilla>