60457 2011-05-09 00:25:45 -0700 [EFL] Added initialization/shutdown for ecore_file library 2011-05-12 10:38:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned abarth commit-queue eric kenneth lucas.de.marchi rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 400370 0 t.morawski 2011-05-09 00:25:45 -0700 Added initialization and shuthown fo ecore_file library and replaced realpath function to ecore_file_realpath. 400371 1 92765 t.morawski 2011-05-09 00:26:58 -0700 Created attachment 92765 Patch 400450 2 92765 lucas.de.marchi 2011-05-09 04:47:52 -0700 Comment on attachment 92765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92765&action=review > Tools/ChangeLog:8 > + Added initialization and shuthown fo ecore_file library and replaced s/fo/for/ > Tools/EWebLauncher/main.c:802 > - rpath = realpath(theme, NULL); > + rpath = ecore_file_realpath(theme); > if (!rpath) > return NULL; ecore_file_realpath always allocate a string, even when realpath would return an error (exception: when there's an out of memory condition). In this case you need to check whether the returned string is empty. > Tools/EWebLauncher/main.c:888 > + return quit(EINA_FALSE, "ERROR: could not created tmp directory.\n"); s/created/create/ 400466 3 92784 t.morawski 2011-05-09 05:53:16 -0700 Created attachment 92784 Fixed patch 400882 4 92784 lucas.de.marchi 2011-05-09 16:30:01 -0700 Comment on attachment 92784 Fixed patch View in context: https://bugs.webkit.org/attachment.cgi?id=92784&action=review > Tools/EWebLauncher/main.c:800 > - rpath = realpath(theme, NULL); > - if (!rpath) > - return NULL; > - > - if (stat(rpath, &st)) { > + rpath = ecore_file_realpath("/etc"); /etc ???? Why? Maybe you used as a test and let it here? 401066 5 92923 t.morawski 2011-05-09 22:55:28 -0700 Created attachment 92923 Patch 3 401479 6 rakuco 2011-05-10 14:06:46 -0700 It looks OK to me, informal r+ from my side. 401750 7 ryuan.choi 2011-05-10 21:50:17 -0700 rpath is not a parameter of ecore_file_realpath, right? rpath = ecore_file_realpath(theme); 401829 8 93084 t.morawski 2011-05-11 01:05:11 -0700 Created attachment 93084 Patch 4 401919 9 lucas.de.marchi 2011-05-11 05:25:21 -0700 (In reply to comment #7) > rpath is not a parameter of ecore_file_realpath, right? Right. Tomasz, we can't apply every patch and test when reviewing. Please, test your changes to see if it really fixes the issue before uploading a new patch. Now it looks good. 402874 10 93084 commit-queue 2011-05-12 09:03:29 -0700 Comment on attachment 93084 Patch 4 Clearing flags on attachment: 93084 Committed r86349: <http://trac.webkit.org/changeset/86349> 402875 11 commit-queue 2011-05-12 09:03:35 -0700 All reviewed patches have been landed. Closing bug. 402947 12 webkit.review.bot 2011-05-12 10:38:53 -0700 http://trac.webkit.org/changeset/86349 might have broken GTK Linux 32-bit Release 92765 2011-05-09 00:26:58 -0700 2011-05-09 07:34:24 -0700 Patch file.patch text/plain 1986 t.morawski ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMDA1 YmQyLi4yYTEyMTY3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDggIFRvbWFzeiBNb3Jhd3NraSAgPHQu bW9yYXdza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0VGTF0gQWRkZWQgaW5pdGlhbGl6YXRpb24vc2h1dGRvd24gZm9yIGVj b3JlX2ZpbGUgbGlicmFyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjA0NTcKKworICAgICAgICBBZGRlZCBpbml0aWFsaXphdGlvbiBhbmQgc2h1dGhv d24gZm8gZWNvcmVfZmlsZSBsaWJyYXJ5IGFuZCByZXBsYWNlZAorICAgICAgICByZWFscGF0aCBm dW5jdGlvbiB0byBlY29yZV9maWxlX3JlYWxwYXRoLgorCisgICAgICAgICogRVdlYkxhdW5jaGVy L21haW4uYzoKKyAgICAgICAgKHF1aXQpOgorICAgICAgICAoZmluZFRoZW1lUGF0aCk6CisgICAg ICAgIChtYWluKToKKwogMjAxMS0wNS0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvVG9vbHMv RVdlYkxhdW5jaGVyL21haW4uYyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKaW5kZXggM2Ji MjdhMi4uNTc4MDUyMCAxMDA2NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYworKysg Yi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCkBAIC02MzYsNiArNjM2LDcgQEAgcXVpdChFaW5h X0Jvb2wgc3VjY2VzcywgY29uc3QgY2hhciAqbXNnKQogewogICAgIGVkamVfc2h1dGRvd24oKTsK ICAgICBlY29yZV9ldmFzX3NodXRkb3duKCk7CisgICAgZWNvcmVfZmlsZV9zaHV0ZG93bigpOwog CiAgICAgaWYgKG1zZykKICAgICAgICAgZnB1dHMobXNnLCAoc3VjY2VzcykgPyBzdGRvdXQgOiBz dGRlcnIpOwpAQCAtNzk2LDcgKzc5Nyw3IEBAIGZpbmRUaGVtZVBhdGgoY29uc3QgY2hhciAqdGhl bWUpCiAgICAgaWYgKCF0aGVtZSkKICAgICAgICAgdGhlbWUgPSBkZWZhdWx0VGhlbWU7CiAKLSAg ICBycGF0aCA9IHJlYWxwYXRoKHRoZW1lLCBOVUxMKTsKKyAgICBycGF0aCA9IGVjb3JlX2ZpbGVf cmVhbHBhdGgodGhlbWUpOwogICAgIGlmICghcnBhdGgpCiAgICAgICAgIHJldHVybiBOVUxMOwog CkBAIC04NTQsNiArODU1LDEyIEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKICAgICAg ICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKICAgICB9CiAKKyAgICBpZiAoIWVjb3JlX2ZpbGVfaW5p dCgpKSB7CisgICAgICAgIGVkamVfc2h1dGRvd24oKTsKKyAgICAgICAgZWNvcmVfZXZhc19zaHV0 ZG93bigpOworICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOworICAgIH0KKwogICAgIGVjb3Jl X2FwcF9hcmdzX3NldChhcmdjLCAoY29uc3QgY2hhcioqKSBhcmd2KTsKICAgICBhcmdzID0gZWNv cmVfZ2V0b3B0X3BhcnNlKCZvcHRpb25zLCB2YWx1ZXMsIGFyZ2MsIGFyZ3YpOwogCkBAIC04Nzcs NyArODg0LDkgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgIGlmICghdG1wKQog ICAgICAgICB0bXAgPSAiL3RtcCI7CiAgICAgc25wcmludGYocGF0aCwgc2l6ZW9mKHBhdGgpLCAi JXMvLmV3ZWJraXQtJXUiLCB0bXAsIGdldHVpZCgpKTsKLSAgICBlY29yZV9maWxlX21rcGF0aChw YXRoKTsKKyAgICBpZiAoIWVjb3JlX2ZpbGVfbWtwYXRoKHBhdGgpKQorICAgICAgICByZXR1cm4g cXVpdChFSU5BX0ZBTFNFLCAiRVJST1I6IGNvdWxkIG5vdCBjcmVhdGVkIHRtcCBkaXJlY3Rvcnku XG4iKTsKKwogICAgIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KHBhdGgpOwog ICAgIGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9zZXQocGF0aCk7CiAK 92784 2011-05-09 05:53:16 -0700 2011-05-09 22:55:28 -0700 Fixed patch file.patch text/plain 2130 t.morawski ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNzFk YzQ1Li43NWU5ZWZmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDkgIFRvbWFzeiBNb3Jhd3NraSAgPHQu bW9yYXdza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0VGTF0gQWRkZWQgaW5pdGlhbGl6YXRpb24vc2h1dGRvd24gZm9yIGVj b3JlX2ZpbGUgbGlicmFyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjA0NTcKKworICAgICAgICBBZGRlZCBpbml0aWFsaXphdGlvbiBhbmQgc2h1dGhv d24gZm9yIGVjb3JlX2ZpbGUgbGlicmFyeSBhbmQgcmVwbGFjZWQKKyAgICAgICAgcmVhbHBhdGgg ZnVuY3Rpb24gdG8gZWNvcmVfZmlsZV9yZWFscGF0aC4KKworICAgICAgICAqIEVXZWJMYXVuY2hl ci9tYWluLmM6CisgICAgICAgIChxdWl0KToKKyAgICAgICAgKGZpbmRUaGVtZVBhdGgpOgorICAg ICAgICAobWFpbik6CisKIDIwMTEtMDUtMDkgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxr YXJuaUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlm ZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIv bWFpbi5jCmluZGV4IDNiYjI3YTIuLjNiNGJkYTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVu Y2hlci9tYWluLmMKKysrIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNjM2LDYgKzYz Niw3IEBAIHF1aXQoRWluYV9Cb29sIHN1Y2Nlc3MsIGNvbnN0IGNoYXIgKm1zZykKIHsKICAgICBl ZGplX3NodXRkb3duKCk7CiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOworICAgIGVjb3JlX2Zp bGVfc2h1dGRvd24oKTsKIAogICAgIGlmIChtc2cpCiAgICAgICAgIGZwdXRzKG1zZywgKHN1Y2Nl c3MpID8gc3Rkb3V0IDogc3RkZXJyKTsKQEAgLTc5NiwxMSArNzk3LDggQEAgZmluZFRoZW1lUGF0 aChjb25zdCBjaGFyICp0aGVtZSkKICAgICBpZiAoIXRoZW1lKQogICAgICAgICB0aGVtZSA9IGRl ZmF1bHRUaGVtZTsKIAotICAgIHJwYXRoID0gcmVhbHBhdGgodGhlbWUsIE5VTEwpOwotICAgIGlm ICghcnBhdGgpCi0gICAgICAgIHJldHVybiBOVUxMOwotCi0gICAgaWYgKHN0YXQocnBhdGgsICZz dCkpIHsKKyAgICBycGF0aCA9IGVjb3JlX2ZpbGVfcmVhbHBhdGgoIi9ldGMiKTsKKyAgICBpZiAo IXN0cmxlbihycGF0aCkgfHwgc3RhdChycGF0aCwgJnN0KSkgewogICAgICAgICBmcmVlKHJwYXRo KTsKICAgICAgICAgcmV0dXJuIE5VTEw7CiAgICAgfQpAQCAtODU0LDYgKzg1MiwxMiBAQCBtYWlu KGludCBhcmdjLCBjaGFyICphcmd2W10pCiAgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CiAg ICAgfQogCisgICAgaWYgKCFlY29yZV9maWxlX2luaXQoKSkgeworICAgICAgICBlZGplX3NodXRk b3duKCk7CisgICAgICAgIGVjb3JlX2V2YXNfc2h1dGRvd24oKTsKKyAgICAgICAgcmV0dXJuIEVY SVRfRkFJTFVSRTsKKyAgICB9CisKICAgICBlY29yZV9hcHBfYXJnc19zZXQoYXJnYywgKGNvbnN0 IGNoYXIqKikgYXJndik7CiAgICAgYXJncyA9IGVjb3JlX2dldG9wdF9wYXJzZSgmb3B0aW9ucywg dmFsdWVzLCBhcmdjLCBhcmd2KTsKIApAQCAtODc3LDcgKzg4MSw5IEBAIG1haW4oaW50IGFyZ2Ms IGNoYXIgKmFyZ3ZbXSkKICAgICBpZiAoIXRtcCkKICAgICAgICAgdG1wID0gIi90bXAiOwogICAg IHNucHJpbnRmKHBhdGgsIHNpemVvZihwYXRoKSwgIiVzLy5ld2Via2l0LSV1IiwgdG1wLCBnZXR1 aWQoKSk7Ci0gICAgZWNvcmVfZmlsZV9ta3BhdGgocGF0aCk7CisgICAgaWYgKCFlY29yZV9maWxl X21rcGF0aChwYXRoKSkKKyAgICAgICAgcmV0dXJuIHF1aXQoRUlOQV9GQUxTRSwgIkVSUk9SOiBj b3VsZCBub3QgY3JlYXRlIHRtcCBkaXJlY3RvcnkuXG4iKTsKKwogICAgIGV3a19zZXR0aW5nc19p Y29uX2RhdGFiYXNlX3BhdGhfc2V0KHBhdGgpOwogICAgIGV3a19zZXR0aW5nc193ZWJfZGF0YWJh c2VfcGF0aF9zZXQocGF0aCk7CiAK 92923 2011-05-09 22:55:28 -0700 2011-05-11 01:05:11 -0700 Patch 3 file.patch text/plain 2134 t.morawski ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MWE1 ZDgyLi5hMGNmOTRiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDkgIFRvbWFzeiBNb3Jhd3NraSAgPHQu bW9yYXdza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0VGTF0gQWRkZWQgaW5pdGlhbGl6YXRpb24vc2h1dGRvd24gZm9yIGVj b3JlX2ZpbGUgbGlicmFyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjA0NTcKKworICAgICAgICBBZGRlZCBpbml0aWFsaXphdGlvbiBhbmQgc2h1dGhv d24gZm9yIGVjb3JlX2ZpbGUgbGlicmFyeSBhbmQgcmVwbGFjZWQKKyAgICAgICAgcmVhbHBhdGgg ZnVuY3Rpb24gdG8gZWNvcmVfZmlsZV9yZWFscGF0aC4KKworICAgICAgICAqIEVXZWJMYXVuY2hl ci9tYWluLmM6CisgICAgICAgIChxdWl0KToKKyAgICAgICAgKGZpbmRUaGVtZVBhdGgpOgorICAg ICAgICAobWFpbik6CisKIDIwMTEtMDUtMDkgIEFsaWNlIEJveGhhbGwgIDxhYm94aGFsbEBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4KZGlmZiAtLWdpdCBh L1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmlu ZGV4IDNiYjI3YTIuLjA1OWZhZjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWlu LmMKKysrIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNjM2LDYgKzYzNiw3IEBAIHF1 aXQoRWluYV9Cb29sIHN1Y2Nlc3MsIGNvbnN0IGNoYXIgKm1zZykKIHsKICAgICBlZGplX3NodXRk b3duKCk7CiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOworICAgIGVjb3JlX2ZpbGVfc2h1dGRv d24oKTsKIAogICAgIGlmIChtc2cpCiAgICAgICAgIGZwdXRzKG1zZywgKHN1Y2Nlc3MpID8gc3Rk b3V0IDogc3RkZXJyKTsKQEAgLTc5NiwxMSArNzk3LDggQEAgZmluZFRoZW1lUGF0aChjb25zdCBj aGFyICp0aGVtZSkKICAgICBpZiAoIXRoZW1lKQogICAgICAgICB0aGVtZSA9IGRlZmF1bHRUaGVt ZTsKIAotICAgIHJwYXRoID0gcmVhbHBhdGgodGhlbWUsIE5VTEwpOwotICAgIGlmICghcnBhdGgp Ci0gICAgICAgIHJldHVybiBOVUxMOwotCi0gICAgaWYgKHN0YXQocnBhdGgsICZzdCkpIHsKKyAg ICBycGF0aCA9IGVjb3JlX2ZpbGVfcmVhbHBhdGgocnBhdGgpOworICAgIGlmICghc3RybGVuKHJw YXRoKSB8fCBzdGF0KHJwYXRoLCAmc3QpKSB7CiAgICAgICAgIGZyZWUocnBhdGgpOwogICAgICAg ICByZXR1cm4gTlVMTDsKICAgICB9CkBAIC04NTQsNiArODUyLDEyIEBAIG1haW4oaW50IGFyZ2Ms IGNoYXIgKmFyZ3ZbXSkKICAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKICAgICB9CiAKKyAg ICBpZiAoIWVjb3JlX2ZpbGVfaW5pdCgpKSB7CisgICAgICAgIGVkamVfc2h1dGRvd24oKTsKKyAg ICAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOworICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJF OworICAgIH0KKwogICAgIGVjb3JlX2FwcF9hcmdzX3NldChhcmdjLCAoY29uc3QgY2hhcioqKSBh cmd2KTsKICAgICBhcmdzID0gZWNvcmVfZ2V0b3B0X3BhcnNlKCZvcHRpb25zLCB2YWx1ZXMsIGFy Z2MsIGFyZ3YpOwogCkBAIC04NzcsNyArODgxLDkgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqYXJn dltdKQogICAgIGlmICghdG1wKQogICAgICAgICB0bXAgPSAiL3RtcCI7CiAgICAgc25wcmludGYo cGF0aCwgc2l6ZW9mKHBhdGgpLCAiJXMvLmV3ZWJraXQtJXUiLCB0bXAsIGdldHVpZCgpKTsKLSAg ICBlY29yZV9maWxlX21rcGF0aChwYXRoKTsKKyAgICBpZiAoIWVjb3JlX2ZpbGVfbWtwYXRoKHBh dGgpKQorICAgICAgICByZXR1cm4gcXVpdChFSU5BX0ZBTFNFLCAiRVJST1I6IGNvdWxkIG5vdCBj cmVhdGUgc2V0dGluZ3MgZGF0YWJhc2UgZGlyZWN0b3J5LlxuIik7CisKICAgICBld2tfc2V0dGlu Z3NfaWNvbl9kYXRhYmFzZV9wYXRoX3NldChwYXRoKTsKICAgICBld2tfc2V0dGluZ3Nfd2ViX2Rh dGFiYXNlX3BhdGhfc2V0KHBhdGgpOwogCg== 93084 2011-05-11 01:05:11 -0700 2011-05-12 09:03:29 -0700 Patch 4 file.patch text/plain 0 t.morawski