60452 2011-05-08 13:29:19 -0700 Make JSRetainPtr work with JSGlobalContextRefs 2011-05-08 14:06:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jberlin jberlin barraclough ggaren jberlin sam oldest_to_newest 400285 0 jberlin 2011-05-08 13:29:19 -0700 It would be nice to have JSRetainPtr work with JSGlobalContextRefs so that anyone holding a reference to a JSGlobalContextRef could benefit from the ease of use of smart pointers. 400289 1 92745 jberlin 2011-05-08 13:47:43 -0700 Created attachment 92745 Patch 400296 2 92745 jberlin 2011-05-08 14:03:25 -0700 Comment on attachment 92745 Patch Thanks Dan! Committed in http://trac.webkit.org/changeset/86036 92745 2011-05-08 13:47:43 -0700 2011-05-08 14:03:25 -0700 Patch makeJSRetainPtrWorkWithJSGlobalContextRefs.patch text/plain 1449 jberlin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODYwMzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDUtMDggIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIEpTUmV0YWluUHRy IHdvcmsgd2l0aCBKU0dsb2JhbENvbnRleHRSZWZzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0NTIKKworICAgICAgICBBZGQgc3BlY2lhbGl6ZWQg ZnVuY3Rpb25zIGZvciBKU1JldGFpbiBhbmQgSlNSZWxlYXNlIHdoZW4gZGVhbGluZyB3aXRoIEpT R2xvYmFsQ29udGV4dFJlZnMuCisKKyAgICAgICAgKiBBUEkvSlNSZXRhaW5QdHIuaDoKKyAgICAg ICAgKEpTUmV0YWluKToKKyAgICAgICAgKEpTUmVsZWFzZSk6CisKIDIwMTEtMDUtMDcgIERhd2l0 IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbmll bCBCYXRlcy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZXRhaW5QdHIuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmV0YWluUHRyLmgJKHJl dmlzaW9uIDg2MDMyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JldGFpblB0ci5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMSArMjksMTQgQEAKICNpZm5kZWYgSlNSZXRhaW5QdHJf aAogI2RlZmluZSBKU1JldGFpblB0cl9oCiAKKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0Nv bnRleHRSZWYuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU1N0cmluZ1JlZi5oPgogI2lu Y2x1ZGUgPGFsZ29yaXRobT4KIAogaW5saW5lIHZvaWQgSlNSZXRhaW4oSlNTdHJpbmdSZWYgc3Ry aW5nKSB7IEpTU3RyaW5nUmV0YWluKHN0cmluZyk7IH0KIGlubGluZSB2b2lkIEpTUmVsZWFzZShK U1N0cmluZ1JlZiBzdHJpbmcpIHsgSlNTdHJpbmdSZWxlYXNlKHN0cmluZyk7IH0KK2lubGluZSB2 b2lkIEpTUmV0YWluKEpTR2xvYmFsQ29udGV4dFJlZiBjb250ZXh0KSB7IEpTR2xvYmFsQ29udGV4 dFJldGFpbihjb250ZXh0KTsgfQoraW5saW5lIHZvaWQgSlNSZWxlYXNlKEpTR2xvYmFsQ29udGV4 dFJlZiBjb250ZXh0KSB7IEpTR2xvYmFsQ29udGV4dFJlbGVhc2UoY29udGV4dCk7IH0KIAogZW51 bSBBZG9wdFRhZyB7IEFkb3B0IH07CiAK