60449 2011-05-08 01:04:45 -0700 Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com 2013-03-28 16:18:20 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.jerryseinfeld.com/ InRadar P2 Normal --- 1 jer.noble jer.noble ademar darin eric esprehn hyatt jchaffraix mitz webkit.review.bot oldest_to_newest 400219 0 jer.noble 2011-05-08 01:04:45 -0700 1. Navigate to <http://jerryseinfeld.com/> 2. Click one of the video titles 3. When the video is playing, click the full screen button in the bottom right The full-screen video is obscured by a black screen with what looks like a scrollbar track on the right. Moving the mouse sometimes hides the black screen, exposing strange-looking video control HUD, but other times leads to a Web Process crash. 400220 1 jer.noble 2011-05-08 01:05:15 -0700 <rdar://problem/9403197> 400221 2 92733 jer.noble 2011-05-08 01:30:44 -0700 Created attachment 92733 Patch 400239 3 92733 darin 2011-05-08 08:13:43 -0700 Comment on attachment 92733 Patch Normally every non-anonymous renderer has a 1-to-1 relationship with the DOM element that is returned by node(). I’m not sure it’s OK to mark something non-anonymous if it does not have that 1-to-1 relationship with a DOM element. It may fix the behavior of this one code path, but cause problems on other code paths. Someone more expert than me in the rendering subsystem could weigh in, or we could do a bit more research about the other call sites that check the anonymous flag. Another possibility is to add code at the call site that coalesces anonymous children. 400245 4 jer.noble 2011-05-08 09:23:55 -0700 (In reply to comment #3) > (From update of attachment 92733 [details]) > Normally every non-anonymous renderer has a 1-to-1 relationship with the DOM element that is returned by node(). I’m not sure it’s OK to mark something non-anonymous if it does not have that 1-to-1 relationship with a DOM element. It may fix the behavior of this one code path, but cause problems on other code paths. > > Someone more expert than me in the rendering subsystem could weigh in, or we could do a bit more research about the other call sites that check the anonymous flag. > > Another possibility is to add code at the call site that coalesces anonymous children. The other option I was considering was changing the definition of "isAnonymousBlock()". List marker renders are already excluded there (for good reason: you wouldn't want your list markers getting coalesced with the nearest non-marker anonymous block). I don't really understand the "1-to-1" comment. I though anonymous renderers were ones whose node() function returned the document? (From the RenderObject constructor initialization of m_isAnonymous.) 400248 5 darin 2011-05-08 09:37:13 -0700 (In reply to comment #4) > I thought anonymous renderers were ones whose node() function returned the document? (From the RenderObject constructor initialization of m_isAnonymous.) That’s right. Generally speaking each element has exactly one non-anonymous renderer. 400254 6 92737 jer.noble 2011-05-08 10:06:46 -0700 Created attachment 92737 Patch This is the other option: excluding RenderFullScreen objects from isAnonymousBlock() 400255 7 webkit.review.bot 2011-05-08 10:09:29 -0700 Attachment 92737 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/full..." exit_code: 1 Source/WebCore/rendering/RenderObject.h:406: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 400256 8 jer.noble 2011-05-08 10:23:18 -0700 (In reply to comment #5) > (In reply to comment #4) > > I thought anonymous renderers were ones whose node() function returned the document? (From the RenderObject constructor initialization of m_isAnonymous.) > > That’s right. Generally speaking each element has exactly one non-anonymous renderer. Oh right. "Normally every non-anonymous renderer has a 1-to-1 relationship..." I somehow converted "non-anonymous" to "anonymous" somewhere between my eyes and brain. :) Okay, so it appears the requirements for being an anonymous block are much more strict, and already set up to exclude certain renderers that would otherwise be counted as anonymous blocks. And the number of call sites is much more limited. 400271 9 92737 eric 2011-05-08 12:49:06 -0700 Comment on attachment 92737 Patch The rules about what is anonymous vs. not seem very confusing. We recently had a MathML crasher for similar reasons (that blocks which should have been anonymous were not). Perhaps someone can explain the anonymous renderer rules in a public place? 400927 10 jer.noble 2011-05-09 17:26:04 -0700 Committed r86109: <http://trac.webkit.org/changeset/86109> 401438 11 ademar 2011-05-10 13:21:53 -0700 Revision r86109 cherry-picked into qtwebkit-2.2 with commit 9b3c5d2 <http://gitorious.org/webkit/qtwebkit/commit/9b3c5d2> 865762 12 eric 2013-03-28 13:37:26 -0700 Adding jchaffraix and esprehn, who may be able to explain the rules of anonymous renderers (here or in a Wiki). 92733 2011-05-08 01:30:44 -0700 2011-05-08 10:06:43 -0700 Patch bug-60449-20110508013043.patch text/plain 3923 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODYwMjUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZDU2MWEzOThlODhjODU4MzE0YzBh Y2I0NmU3ODI1ZThhN2Q1NzVhLi42NjY3ZDBlMzJlNmFjMzk2YmRkNzY3NTg1ODgxZDJkMjUwYTRl NWRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDggIEplcmVteSBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRnVsbC1zY3JlZW4gdmlkZW8gZGlzYXBwZWFycyBiZWhpbmQgYmxhY2sgc2Ny ZWVuIHdpdGggc2Nyb2xsYmFyLCBmb2xsb3dlZCBieSBjcmFzaCBhdCBqZXJyeXNlaW5mZWxkLmNv bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0NDkK KworICAgICAgICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcmVtb3ZlLXNpYmxpbmctZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbW92ZS1z aWJsaW5nLmh0bWw6IEFkZGVkLgorCiAyMDExLTA1LTA1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbW92ZS1z aWJsaW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NDU2MmFjYTk5YzlmNmIzYjNmMWUzZjlm NjI4MjdhMTU0ODYxMDI3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVl bi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBA CitFVkVOVCh3ZWJraXRmdWxsc2NyZWVuY2hhbmdlKQorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy5odG1s IGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmFlMWJhZmM1ZGVlNDM1Mzg0MjkwOWJiOGM5YmFkNmM0OGJjNWUxZDkKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbW92 ZS1zaWJsaW5nLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGJvZHk+Cis8c2NyaXB0IHNyYz0iZnVs bC1zY3JlZW4tdGVzdC5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJvbmUiPgorICAgIDxkaXYgaWQ9 ImZ1bGxzY3JlZW4iPjwvZGl2PgorICAgIDxkaXYgaWQ9InR3byI+PHNwYW4+PC9zcGFuPjwvZGl2 PgorPC9kaXY+CisKKzxzY3JpcHQ+CisvLyBCYWlsIG91dCBlYXJseSBpZiB0aGUgZnVsbCBzY3Jl ZW4gQVBJIGlzIG5vdCBlbmFibGVkIG9yIGlzIG1pc3Npbmc6CitpZiAoRWxlbWVudC5wcm90b3R5 cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkKSB7CisgICAgbG9nUmVzdWx0 KGZhbHNlLCAiRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5k ZWZpbmVkIik7CisgICAgZW5kVGVzdCgpOworfSBlbHNlIHsKKyAgICB2YXIgY2FsbGJhY2s7Cisg ICAgd2FpdEZvckV2ZW50KGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsIGZ1bmN0 aW9uKCkgeworICAgICAgICB2YXIgb25lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ29uZScp OworICAgICAgICB2YXIgdHdvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3R3bycpOworICAg ICAgICBvbmUucmVtb3ZlQ2hpbGQodHdvKTsKKyAgICAgICAgZW5kVGVzdCgpOworICAgIH0pOwor CisgICAgZnVuY3Rpb24gZ29GdWxsU2NyZWVuKCkgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnZnVsbHNjcmVlbicpLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKCk7CisgICAgfQor ICAgIHJ1bldpdGhLZXlEb3duKGdvRnVsbFNjcmVlbik7Cit9Cis8L3NjcmlwdD4KXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNlMGM5ZGZlYTNkMDYyZjM1ZGQwMzk0 MWU0OGJhNjllOGJhNTVhZS4uMDg0OTg2MTBkNzQ3MGRmNzdlMDI4MzA0ZjUyM2FhODM2YzUxNjVk ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTA1LTA4ICBKZXJlbXkgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZ1bGwtc2NyZWVuIHZpZGVvIGRpc2FwcGVhcnMgYmVoaW5kIGJsYWNr IHNjcmVlbiB3aXRoIHNjcm9sbGJhciwgZm9sbG93ZWQgYnkgY3Jhc2ggYXQgamVycnlzZWluZmVs ZC5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw NDQ5CisKKyAgICAgICAgTWFrZSBSZW5kZXJGdWxsU2NyZWVuIG5vbi1hbm9ueW1vdXMsIHNvIHRo YXQgaXQgZG9lcyBub3QgZ2V0IGRlbGV0ZWQgd2hlbiBhIHBhcmVudCBhdHRlbXB0cyB0byBjb2Fs ZXNjZSAKKyAgICAgICAgYW5vbnltb3VzIGNoaWxkcmVuLgorCisgICAgICAgIFRlc3Q6IGZ1bGxz Y3JlZW4vZnVsbC1zY3JlZW4tcmVtb3ZlLXNpYmxpbmcuaHRtbAorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckZ1bGxTY3JlZW4uaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZ1bGxTY3Jl ZW46OlJlbmRlckZ1bGxTY3JlZW4pOgorCiAyMDExLTA1LTA1ICBKZXIgTm9ibGUgIDxqZXIubm9i bGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVuLmgKaW5kZXggMzBmOTVjMWEz OGYzYTg5ZWJmZmQ4NjU0NzYxOWI3MTU0MjI2NGE4YS4uNTJkNGVlMmE3YmQ0ZWRiNzZhNzlmMGE3 YTk5OTA0MzQ0YmYzMjAxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZ1bGxTY3JlZW4uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnVs bFNjcmVlbi5oCkBAIC0zMyw3ICszMyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3Mg UmVuZGVyRnVsbFNjcmVlbiA6IHB1YmxpYyBSZW5kZXJGbGV4aWJsZUJveCB7CiBwdWJsaWM6Ci0g ICAgUmVuZGVyRnVsbFNjcmVlbihOb2RlKiBub2RlKSA6IFJlbmRlckZsZXhpYmxlQm94KG5vZGUp IHsgc2V0UmVwbGFjZWQoZmFsc2UpOyB9CisgICAgUmVuZGVyRnVsbFNjcmVlbihOb2RlKiBub2Rl KSA6IFJlbmRlckZsZXhpYmxlQm94KG5vZGUpIHsgc2V0UmVwbGFjZWQoZmFsc2UpOyBzZXRJc0Fu b255bW91cyhmYWxzZSk7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJGdWxsU2NyZWVuKCkg Y29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgY29uc3QgY2hhciogcmVuZGVyTmFt ZSgpIGNvbnN0IHsgcmV0dXJuICJSZW5kZXJGdWxsU2NyZWVuIjsgfQogICAgIAo= 92737 2011-05-08 10:06:46 -0700 2011-05-09 16:58:12 -0700 Patch bug-60449-20110508100645.patch text/plain 4423 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODYwMjUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZDU2MWEzOThlODhjODU4MzE0YzBh Y2I0NmU3ODI1ZThhN2Q1NzVhLi42NjY3ZDBlMzJlNmFjMzk2YmRkNzY3NTg1ODgxZDJkMjUwYTRl NWRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDggIEplcmVteSBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRnVsbC1zY3JlZW4gdmlkZW8gZGlzYXBwZWFycyBiZWhpbmQgYmxhY2sgc2Ny ZWVuIHdpdGggc2Nyb2xsYmFyLCBmb2xsb3dlZCBieSBjcmFzaCBhdCBqZXJyeXNlaW5mZWxkLmNv bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0NDkK KworICAgICAgICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcmVtb3ZlLXNpYmxpbmctZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbW92ZS1z aWJsaW5nLmh0bWw6IEFkZGVkLgorCiAyMDExLTA1LTA1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbW92ZS1z aWJsaW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NDU2MmFjYTk5YzlmNmIzYjNmMWUzZjlm NjI4MjdhMTU0ODYxMDI3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVl bi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBA CitFVkVOVCh3ZWJraXRmdWxsc2NyZWVuY2hhbmdlKQorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy5odG1s IGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmFlMWJhZmM1ZGVlNDM1Mzg0MjkwOWJiOGM5YmFkNmM0OGJjNWUxZDkKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbW92 ZS1zaWJsaW5nLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGJvZHk+Cis8c2NyaXB0IHNyYz0iZnVs bC1zY3JlZW4tdGVzdC5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJvbmUiPgorICAgIDxkaXYgaWQ9 ImZ1bGxzY3JlZW4iPjwvZGl2PgorICAgIDxkaXYgaWQ9InR3byI+PHNwYW4+PC9zcGFuPjwvZGl2 PgorPC9kaXY+CisKKzxzY3JpcHQ+CisvLyBCYWlsIG91dCBlYXJseSBpZiB0aGUgZnVsbCBzY3Jl ZW4gQVBJIGlzIG5vdCBlbmFibGVkIG9yIGlzIG1pc3Npbmc6CitpZiAoRWxlbWVudC5wcm90b3R5 cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkKSB7CisgICAgbG9nUmVzdWx0 KGZhbHNlLCAiRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5k ZWZpbmVkIik7CisgICAgZW5kVGVzdCgpOworfSBlbHNlIHsKKyAgICB2YXIgY2FsbGJhY2s7Cisg ICAgd2FpdEZvckV2ZW50KGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsIGZ1bmN0 aW9uKCkgeworICAgICAgICB2YXIgb25lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ29uZScp OworICAgICAgICB2YXIgdHdvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3R3bycpOworICAg ICAgICBvbmUucmVtb3ZlQ2hpbGQodHdvKTsKKyAgICAgICAgZW5kVGVzdCgpOworICAgIH0pOwor CisgICAgZnVuY3Rpb24gZ29GdWxsU2NyZWVuKCkgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnZnVsbHNjcmVlbicpLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKCk7CisgICAgfQor ICAgIHJ1bldpdGhLZXlEb3duKGdvRnVsbFNjcmVlbik7Cit9Cis8L3NjcmlwdD4KXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNlMGM5ZGZlYTNkMDYyZjM1ZGQwMzk0 MWU0OGJhNjllOGJhNTVhZS4uZGJlMjBjNzNhZmJiZjRjZmQyZjU1ZTUzNjA1NDRmYmQ3MWM0ODY2 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTA1LTA4ICBKZXJlbXkgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZ1bGwtc2NyZWVuIHZpZGVvIGRpc2FwcGVhcnMgYmVoaW5kIGJsYWNr IHNjcmVlbiB3aXRoIHNjcm9sbGJhciwgZm9sbG93ZWQgYnkgY3Jhc2ggYXQgamVycnlzZWluZmVs ZC5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYw NDQ5CisKKyAgICAgICAgTWFrZSBSZW5kZXJGdWxsU2NyZWVuIGEgbm9uLWFub255bW91cyBibG9j aywgc28gdGhhdCBpdCBkb2VzIG5vdCBnZXQgZGVsZXRlZCB3aGVuIGEgcGFyZW50IGF0dGVtcHRz IHRvIAorICAgICAgICBjb2FsZXNjZSBhbm9ueW1vdXMgY2hpbGRyZW4uCisKKyAgICAgICAgVGVz dDogZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtc2libGluZy5odG1sCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmpl Y3Q6OmlzQW5vbnltb3VzQmxvY2spOgorCiAyMDExLTA1LTA1ICBKZXIgTm9ibGUgIDxqZXIubm9i bGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4IGIyZjFiZGRlYzYzNzdhOGYw OWEwOTAwMjA5NjRkN2MwMjg3N2IzNTguLjUzN2YwOGEyYjNkYjI1Y2VlMDdmZTA1ZmZjNzZmZjk4 ZTNhOWEyMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKQEAgLTM5 OSw3ICszOTksMTEgQEAgcHVibGljOgogICAgICAgICAvLyBSZW5kZXJCbG9jazo6Y3JlYXRlQW5v bnltb3VzQmxvY2soKS4gVGhpcyBpbmNsdWRlcyBjcmVhdGluZyBhbiBhbm9ueW1vdXMKICAgICAg ICAgLy8gUmVuZGVyQmxvY2sgaGF2aW5nIGEgQkxPQ0sgb3IgQk9YIGRpc3BsYXkuIE90aGVyIGNs YXNzZXMgc3VjaCBhcyBSZW5kZXJUZXh0RnJhZ21lbnQKICAgICAgICAgLy8gYXJlIG5vdCBSZW5k ZXJCbG9ja3MgYW5kIHdpbGwgcmV0dXJuIGZhbHNlLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU2NzA5LiAKLSAgICAgICAgcmV0dXJuIG1faXNBbm9ueW1vdXMg JiYgKHN0eWxlKCktPmRpc3BsYXkoKSA9PSBCTE9DSyB8fCBzdHlsZSgpLT5kaXNwbGF5KCkgPT0g Qk9YKSAmJiBzdHlsZSgpLT5zdHlsZVR5cGUoKSA9PSBOT1BTRVVETyAmJiBpc1JlbmRlckJsb2Nr KCkgJiYgIWlzTGlzdE1hcmtlcigpOworICAgICAgICByZXR1cm4gbV9pc0Fub255bW91cyAmJiAo c3R5bGUoKS0+ZGlzcGxheSgpID09IEJMT0NLIHx8IHN0eWxlKCktPmRpc3BsYXkoKSA9PSBCT1gp ICYmIHN0eWxlKCktPnN0eWxlVHlwZSgpID09IE5PUFNFVURPICYmIGlzUmVuZGVyQmxvY2soKSAm JiAhaXNMaXN0TWFya2VyKCkKKyNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCisgICAgICAgICAg ICAmJiAhaXNSZW5kZXJGdWxsU2NyZWVuKCkKKyNlbmRpZgorICAgICAgICAgICAgOwogICAgIH0K ICAgICBib29sIGlzQW5vbnltb3VzQ29sdW1uc0Jsb2NrKCkgY29uc3QgeyByZXR1cm4gc3R5bGUo KS0+c3BlY2lmaWVzQ29sdW1ucygpICYmIGlzQW5vbnltb3VzQmxvY2soKTsgfQogICAgIGJvb2wg aXNBbm9ueW1vdXNDb2x1bW5TcGFuQmxvY2soKSBjb25zdCB7IHJldHVybiBzdHlsZSgpLT5jb2x1 bW5TcGFuKCkgJiYgaXNBbm9ueW1vdXNCbG9jaygpOyB9Cg==