60437 2011-05-07 09:34:30 -0700 Added missing DATABASE macro 2011-05-11 05:30:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 400076 0 t.morawski 2011-05-07 09:34:30 -0700 Added missing DATABASE macro in ewk_settings.cpp file. 400077 1 92691 t.morawski 2011-05-07 09:39:32 -0700 Created attachment 92691 Patch 400078 2 92692 t.morawski 2011-05-07 09:44:57 -0700 Created attachment 92692 Patch 2 400102 3 92692 dbates 2011-05-07 14:31:40 -0700 Comment on attachment 92692 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=92692&action=review rs=me > Source/WebKit/efl/ewk/ewk_settings.cpp:96 > + return _ewk_default_web_database_quota; The spacing seems to be off here by one space character. 400206 4 92727 t.morawski 2011-05-07 22:39:53 -0700 Created attachment 92727 Patch 3 400455 5 92727 lucas.de.marchi 2011-05-09 05:15:04 -0700 Comment on attachment 92727 Patch 3 LGTM 400484 6 92727 commit-queue 2011-05-09 07:09:55 -0700 Comment on attachment 92727 Patch 3 Rejecting attachment 92727 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1 Last 500 characters of output: ebCore/platform/graphics/ca/GraphicsLayerCA.cpp r86051 = 06f401359be7b4b6ee7c0f35b6c47ab3b3f5badf (refs/remotes/trunk) M Source/WebCore/ChangeLog M Source/WebCore/WebCore.vcproj/WebCore.vcproj r86052 = 9fe0a47c5421a8afbd9f3f92525ebc9a5783a97f (refs/remotes/trunk) M LayoutTests/platform/qt/Skipped M LayoutTests/ChangeLog r86053 = d8690d6cfb3d4e89edcf4a272c5e20a02f2072e0 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8655538 400511 7 commit-queue 2011-05-09 08:26:40 -0700 The commit-queue encountered the following flaky tests while processing attachment 92727: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) java/lc3/ConvertUndefined/undefined-003.html bug 60470 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 401156 8 92727 t.morawski 2011-05-10 06:12:39 -0700 Comment on attachment 92727 Patch 3 I don't know what was happened... so, I one time more set commit-queue 401186 9 lucas.de.marchi 2011-05-10 07:29:28 -0700 (In reply to comment #8) > (From update of attachment 92727 [details]) > I don't know what was happened... so, I one time more set commit-queue Your changelog is wrong... See the error: ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 401187 10 t.morawski 2011-05-10 07:38:38 -0700 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 92727 [details] [details]) > > I don't know what was happened... so, I one time more set commit-queue > > Your changelog is wrong... See the error: > > > ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Why style script doesn't show it? 401824 11 93082 t.morawski 2011-05-11 00:43:48 -0700 Created attachment 93082 Patch 4 401825 12 t.morawski 2011-05-11 00:44:53 -0700 (In reply to comment #9) Thank you, could you review my the last one patch? 401826 13 gyuyoung.kim 2011-05-11 00:57:36 -0700 LGTM. Demarchi, how do you think ? 401921 14 93082 lucas.de.marchi 2011-05-11 05:30:09 -0700 Comment on attachment 93082 Patch 4 LGTM. I manually applied this patch. http://trac.webkit.org/changeset/86227 Clearing flags. 92691 2011-05-07 09:39:32 -0700 2011-05-07 09:44:57 -0700 Patch macro.patch text/plain 1394 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhYzZiN2YzLi41ZTBlMmI4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgbWlzc2luZyBEQVRBQkFTRSBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0MzcKKworICAgICAgICAqIGV3ay9ld2tfc2V0 dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1 b3RhX2dldCk6CisKIDIwMTEtMDUtMDUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfc2V0dGluZ3MuY3BwCmluZGV4IDE2YWJkYzcuLjU3MWQ5MzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC01Niw3ICs1Niw5IEBAIHN0YXRpYyBjb25zdCBjaGFy KiBfZXdrX2NhY2hlX2RpcmVjdG9yeV9wYXRoID0gMDsKIAogc3RhdGljIGNvbnN0IGNoYXIqIF9l d2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcGF0aCA9IDA7CiBzdGF0aWMgY29uc3QgY2hhciogX2V3 a19pY29uX2RhdGFiYXNlX3BhdGggPSAwOworI2lmIEVOQUJMRShEQVRBQkFTRSkKIHN0YXRpYyB1 aW50NjRfdCBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhID0gMSAqIDEwMjQgKiAxMDI0 OworI2VuZGlmCiAKIHN0YXRpYyBXVEY6OlN0cmluZyBfZXdrX3NldHRpbmdzX3dlYmtpdF9wbGF0 Zm9ybV9nZXQoKQogewpAQCAtOTAsNyArOTIsMTEgQEAgc3RhdGljIFdURjo6U3RyaW5nIF9ld2tf c2V0dGluZ3Nfd2Via2l0X29zX3ZlcnNpb25fZ2V0KCkKICAqLwogdWludDY0X3QgZXdrX3NldHRp bmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1b3RhX2dldCh2b2lkKQogewotICAgIHJldHVybiBf ZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhOworI2lmIEVOQUJMRShEQVRBQkFTRSkKKyAg ICAgcmV0dXJuIF9ld2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcXVvdGE7CisjZWxzZQorICAgIHJl dHVybiAwOworI2VuZGlmCiB9CiAKIC8qKgo= 92692 2011-05-07 09:44:57 -0700 2011-05-07 22:39:53 -0700 Patch 2 macro.patch text/plain 1460 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhYzZiN2YzLi41ZTBlMmI4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgbWlzc2luZyBEQVRBQkFTRSBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0MzcKKworICAgICAgICAqIGV3ay9ld2tfc2V0 dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1 b3RhX2dldCk6CisKIDIwMTEtMDUtMDUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfc2V0dGluZ3MuY3BwCmluZGV4IDE2YWJkYzcuLjU2YWJiMDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC01NCw5ICs1NCwxMSBAQAogc3RhdGljIGNvbnN0IGNo YXIqIF9ld2tfY2FjaGVfZGlyZWN0b3J5X3BhdGggPSAwOwogI2VuZGlmCiAKLXN0YXRpYyBjb25z dCBjaGFyKiBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3BhdGggPSAwOwogc3RhdGljIGNvbnN0 IGNoYXIqIF9ld2tfaWNvbl9kYXRhYmFzZV9wYXRoID0gMDsKKyNpZiBFTkFCTEUoREFUQUJBU0Up CitzdGF0aWMgY29uc3QgY2hhciogX2V3a19kZWZhdWx0X3dlYl9kYXRhYmFzZV9wYXRoID0gMDsK IHN0YXRpYyB1aW50NjRfdCBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhID0gMSAqIDEw MjQgKiAxMDI0OworI2VuZGlmCiAKIHN0YXRpYyBXVEY6OlN0cmluZyBfZXdrX3NldHRpbmdzX3dl YmtpdF9wbGF0Zm9ybV9nZXQoKQogewpAQCAtOTAsNyArOTIsMTEgQEAgc3RhdGljIFdURjo6U3Ry aW5nIF9ld2tfc2V0dGluZ3Nfd2Via2l0X29zX3ZlcnNpb25fZ2V0KCkKICAqLwogdWludDY0X3Qg ZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1b3RhX2dldCh2b2lkKQogewotICAg IHJldHVybiBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhOworI2lmIEVOQUJMRShEQVRB QkFTRSkKKyAgICAgcmV0dXJuIF9ld2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcXVvdGE7CisjZWxz ZQorICAgIHJldHVybiAwOworI2VuZGlmCiB9CiAKIC8qKgo= 92727 2011-05-07 22:39:53 -0700 2011-05-11 00:43:48 -0700 Patch 3 macro.patch text/plain 1461 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA2ZDkwMjI4Li41NmQzYTA2IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTMgQEAKIDIwMTEtMDUtMDcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CiAKKyAgICAgICAgQWRkZWQgbWlzc2luZyBEQVRBQkFTRSBtYWNybworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0MzcKKworICAg ICAgICAqIGV3ay9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dlYl9k YXRhYmFzZV9kZWZhdWx0X3F1b3RhX2dldCk6CisKKzIwMTEtMDUtMDcgIFRvbWFzeiBNb3Jhd3Nr aSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVs IEJhdGVzLgogCiAgICAgICAgIFtFRkxdIFJlbW92ZSBld2tfdGlsZV91bnVzZWRfY2FjaGVfZnJl ZSBmdW5jdGlvbiBmcm9tIHB1YmxpYyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5n cy5jcHAKaW5kZXggMTZhYmRjNy4uZWNlYjY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19z ZXR0aW5ncy5jcHAKQEAgLTU0LDkgKzU0LDExIEBACiBzdGF0aWMgY29uc3QgY2hhciogX2V3a19j YWNoZV9kaXJlY3RvcnlfcGF0aCA9IDA7CiAjZW5kaWYKIAotc3RhdGljIGNvbnN0IGNoYXIqIF9l d2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcGF0aCA9IDA7CiBzdGF0aWMgY29uc3QgY2hhciogX2V3 a19pY29uX2RhdGFiYXNlX3BhdGggPSAwOworI2lmIEVOQUJMRShEQVRBQkFTRSkKK3N0YXRpYyBj b25zdCBjaGFyKiBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3BhdGggPSAwOwogc3RhdGljIHVp bnQ2NF90IF9ld2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcXVvdGEgPSAxICogMTAyNCAqIDEwMjQ7 CisjZW5kaWYKIAogc3RhdGljIFdURjo6U3RyaW5nIF9ld2tfc2V0dGluZ3Nfd2Via2l0X3BsYXRm b3JtX2dldCgpCiB7CkBAIC05MCw3ICs5MiwxMSBAQCBzdGF0aWMgV1RGOjpTdHJpbmcgX2V3a19z ZXR0aW5nc193ZWJraXRfb3NfdmVyc2lvbl9nZXQoKQogICovCiB1aW50NjRfdCBld2tfc2V0dGlu Z3Nfd2ViX2RhdGFiYXNlX2RlZmF1bHRfcXVvdGFfZ2V0KHZvaWQpCiB7CisjaWYgRU5BQkxFKERB VEFCQVNFKQogICAgIHJldHVybiBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhOworI2Vs c2UKKyAgICByZXR1cm4gMDsKKyNlbmRpZgogfQogCiAvKioK 93082 2011-05-11 00:43:48 -0700 2011-05-11 05:30:09 -0700 Patch 4 macro.patch text/plain 1418 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA5NDhjNThlLi43MmUzMjU2IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTEgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgbWlzc2luZyBEQVRBQkFTRSBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA0MzcKKworICAgICAgICAqIGV3ay9ld2tfc2V0 dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1 b3RhX2dldCk6CisKIDIwMTEtMDUtMDggIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5nLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3NldHRpbmdzLmNwcAppbmRleCAxNmFiZGM3Li5lY2ViNjdmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtNTQsOSArNTQsMTEgQEAKIHN0YXRpYyBjb25z dCBjaGFyKiBfZXdrX2NhY2hlX2RpcmVjdG9yeV9wYXRoID0gMDsKICNlbmRpZgogCi1zdGF0aWMg Y29uc3QgY2hhciogX2V3a19kZWZhdWx0X3dlYl9kYXRhYmFzZV9wYXRoID0gMDsKIHN0YXRpYyBj b25zdCBjaGFyKiBfZXdrX2ljb25fZGF0YWJhc2VfcGF0aCA9IDA7CisjaWYgRU5BQkxFKERBVEFC QVNFKQorc3RhdGljIGNvbnN0IGNoYXIqIF9ld2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcGF0aCA9 IDA7CiBzdGF0aWMgdWludDY0X3QgX2V3a19kZWZhdWx0X3dlYl9kYXRhYmFzZV9xdW90YSA9IDEg KiAxMDI0ICogMTAyNDsKKyNlbmRpZgogCiBzdGF0aWMgV1RGOjpTdHJpbmcgX2V3a19zZXR0aW5n c193ZWJraXRfcGxhdGZvcm1fZ2V0KCkKIHsKQEAgLTkwLDcgKzkyLDExIEBAIHN0YXRpYyBXVEY6 OlN0cmluZyBfZXdrX3NldHRpbmdzX3dlYmtpdF9vc192ZXJzaW9uX2dldCgpCiAgKi8KIHVpbnQ2 NF90IGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfZGVmYXVsdF9xdW90YV9nZXQodm9pZCkKIHsK KyNpZiBFTkFCTEUoREFUQUJBU0UpCiAgICAgcmV0dXJuIF9ld2tfZGVmYXVsdF93ZWJfZGF0YWJh c2VfcXVvdGE7CisjZWxzZQorICAgIHJldHVybiAwOworI2VuZGlmCiB9CiAKIC8qKgo=