60420 2011-05-06 17:10:08 -0700 [Qt] Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration broken by r85961 2011-05-07 07:36:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 kamaji webkit-unassigned aroben commit-queue kling laszlo.gombos ossy oldest_to_newest 399926 0 kamaji 2011-05-06 17:10:08 -0700 svn commit r85961 from bug 60285 broke the Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration. platformVisibilityDidChange() was left without an implementation: g++ -Wl,--gc-sections -Wl,--no-undefined -Wl,-O1 -shared -Wl,-soname,libQtWebKit.so.4 -o libQtWebKit.so.4.9.0 obj/release/MathMLNames.o obj/release/MathMLElementFactory.o obj/release/SVGNames.o ... obj/release/moc_InspectorServerQt.o obj/release/moc_QtFallbackWebPopup.o obj/release/moc_qwkhistory.o obj/release/qrc_WebCore.o obj/release/qrc_WebKit.o obj/release/qrc_InspectorBackendStub.o -L../../WebKit2/release -L../../WebCore/release -L../../JavaScriptCore/release -L/usr/lib -lwebkit2 -lwebcore -ljscore -lsqlite3 -lphonon -lQtXmlPatterns -lQtGui -lQtNetwork -lQtCore -lpthread ../../WebKit2/release/libwebkit2.a(NetscapePlugin.o): In function `WebKit::NetscapePlugin::visibilityDidChange()': NetscapePlugin.cpp:(.text._ZN6WebKit14NetscapePlugin19visibilityDidChangeEv+0x0): undefined reference to `WebKit::NetscapePlugin::platformVisibilityDidChange()' collect2: ld returned 1 exit status make[1]: *** [../../lib/libQtWebKit.so.4.9.0] Error 1 399931 1 92661 kamaji 2011-05-06 17:14:25 -0700 Created attachment 92661 Patch 400067 2 commit-queue 2011-05-07 07:33:48 -0700 The commit-queue encountered the following flaky tests while processing attachment 92661: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 400069 3 92661 commit-queue 2011-05-07 07:36:42 -0700 Comment on attachment 92661 Patch Clearing flags on attachment: 92661 Committed r86006: <http://trac.webkit.org/changeset/86006> 400070 4 commit-queue 2011-05-07 07:36:46 -0700 All reviewed patches have been landed. Closing bug. 92661 2011-05-06 17:14:25 -0700 2011-05-07 07:36:42 -0700 Patch bug-60420-20110506201517.patch text/plain 1332 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODU5NzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4Y2VlODZkMzcyMWRkODJm NWUxNzMxMzUxMzRiMjA5YTdmNjhjNDM4Li5lOWNiODIwZjNiYjU0NmFhYmZkODBjMjJlYzEzNDZi MThkZTUwZGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDYgIEtlaXRo IEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFdlYmtpdDIgUExVR0lOX0FSQ0hJVEVD VFVSRShVTlNVUFBPUlRFRCkgY29uZmlndXJhdGlvbiBicm9rZW4gYnkgcjg1OTYxCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDQyMAorCisgICAgICAg ICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTm9uZS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVZpc2liaWxpdHlEaWRDaGFu Z2UpOgorCiAyMDExLTA0LTI4ICBLZWl0aCBLeXppdmF0ICA8a2VpdGgua3l6aXZhdEBub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5O b25lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRz Y2FwZVBsdWdpbk5vbmUuY3BwCmluZGV4IGQ0YjIwNDNmOThlYWJmM2RkZDBmM2ZmYTBkM2FjMDU1 OWQ3MDRlOWUuLmFhZDQ0YjI3NmM3ODJmNGY4MGYyNTQ1YWZjZWYwMWY0MWM4YThkY2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw ZVBsdWdpbk5vbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9OZXRzY2FwZVBsdWdpbk5vbmUuY3BwCkBAIC01MSw2ICs1MSwxMCBAQCB2b2lkIE5l dHNjYXBlUGx1Z2luOjpwbGF0Zm9ybUdlb21ldHJ5RGlkQ2hhbmdlKCkKIHsKIH0KIAordm9pZCBO ZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1WaXNpYmlsaXR5RGlkQ2hhbmdlKCkKK3sKK30KKwogdm9p ZCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1QYWludChHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJ bnRSZWN0JiwgYm9vbCkKIHsKIH0K