<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60413</bug_id>
          
          <creation_ts>2011-05-06 15:29:25 -0700</creation_ts>
          <short_desc>[Soup] ResourceHandles are leaked on 304 responses</short_desc>
          <delta_ts>2011-05-06 16:06:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>alex</cc>
    
    <cc>svillar</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>399855</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-05-06 15:29:25 -0700</bug_when>
    <thetext>When handling 304 responses, the libsoup backend never cleans up ResourceHandles.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399862</commentid>
    <comment_count>1</comment_count>
      <attachid>92652</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-05-06 15:36:20 -0700</bug_when>
    <thetext>Created attachment 92652
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399866</commentid>
    <comment_count>2</comment_count>
      <attachid>92652</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2011-05-06 15:40:11 -0700</bug_when>
    <thetext>Comment on attachment 92652
Patch

Looks good to me!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399879</commentid>
    <comment_count>3</comment_count>
      <attachid>92652</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-05-06 16:06:10 -0700</bug_when>
    <thetext>Comment on attachment 92652
Patch

Clearing flags on attachment: 92652

Committed r85984: &lt;http://trac.webkit.org/changeset/85984&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399880</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-05-06 16:06:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>92652</attachid>
            <date>2011-05-06 15:36:20 -0700</date>
            <delta_ts>2011-05-06 16:06:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60413-20110506153619.patch</filename>
            <type>text/plain</type>
            <size>2082</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODU3OTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYWQzYWM3NWY2OWI3ZDVh
YTM4NmUzZTZmN2Q5YjY1MWYxOWRiNDEwLi42MTNkYTljMDA5ZjcwNzY3ZDJjMzExZWY5MGVmYTdl
N2JlMzhhYzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMDYgIE1hcnRp
biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtTb3VwXSBSZXNvdXJjZUhhbmRsZXMgYXJlIGxl
YWtlZCBvbiAzMDQgcmVzcG9uc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD02MDQxMworCisgICAgICAgIEFsd2F5cyBjYWxsIGNsZWFudXBTb3VwUmVx
dWVzdE9wZXJhdGlvbiwgZXZlbiB3aGVuIHRoZSByZXF1ZXN0IHdhcyBub3QKKyAgICAgICAgY2Fu
Y2VsZWQuIEJlZm9yZSB0aGUgY29kZSB3b3VsZCBjYWxsIGRpZEZpbmlzaExvYWRpbmcgYW5kIHRo
ZW4gbmV2ZXIgY2xlYW4gdXAKKyAgICAgICAgdGhlIHJlcXVlc3QuCisKKyAgICAgICAgTm8gbmV3
IHRlc3RzLiBUaGlzIHNpbXBseSBmaXhlcyBhIG1lbW9yeSBsZWFrLgorCisgICAgICAgICogcGxh
dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpzZW5kUmVxdWVzdENhbGxiYWNrKToKKwogMjAxMS0wNS0wNCAgQWxleGlzIE1lbmFyZCAg
PGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHdhcm5p
bmcgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw
L1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr
L3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBjN2RkYzc1ODhiYTk3NTZkOWIxNTk5
MzAzNDQ2MThlMmNkZDQxYmEzLi5hMzUwOGUxMmQ5OTM2ZGYyZWFmZjFhNDc4MmI2ZDczOTIzZDdj
ZmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz
b3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr
L3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNDY4LDEzICs0NjgsMTEgQEAgc3RhdGlj
IHZvaWQgc2VuZFJlcXVlc3RDYWxsYmFjayhHT2JqZWN0KiBzb3VyY2UsIEdBc3luY1Jlc3VsdCog
cmVzLCBncG9pbnRlciB1c2UKICAgICAgICAgICAgICAgICBjbGllbnQtPmRpZFJlY2VpdmVEYXRh
KGhhbmRsZS5nZXQoKSwgc291cE1zZy0+cmVzcG9uc2VfYm9keS0+ZGF0YSwgc291cE1zZy0+cmVz
cG9uc2VfYm9keS0+bGVuZ3RoLCBzb3VwTXNnLT5yZXNwb25zZV9ib2R5LT5sZW5ndGgpOwogICAg
ICAgICB9CiAKLSAgICAgICAgLy8gZGlkUmVjZWl2ZURhdGEgYWJvdmUgbWlnaHQgaGF2ZSBjYW5j
ZWxsZWQgaXQKLSAgICAgICAgaWYgKGQtPm1fY2FuY2VsbGVkIHx8ICFjbGllbnQpIHsKLSAgICAg
ICAgICAgIGNsZWFudXBTb3VwUmVxdWVzdE9wZXJhdGlvbihoYW5kbGUuZ2V0KCkpOwotICAgICAg
ICAgICAgcmV0dXJuOwotICAgICAgICB9CisgICAgICAgIC8vIGRpZFJlY2VpdmVEYXRhIGFib3Zl
IG1pZ2h0IGhhdmUgY2FuY2VsZWQgdGhpcyBvcGVyYXRpb24uIElmIG5vdCwgaW5mb3JtIHRoZSBj
bGllbnQgd2UndmUgZmluaXNoZWQgbG9hZGluZy4KKyAgICAgICAgaWYgKCFkLT5tX2NhbmNlbGxl
ZCAmJiBjbGllbnQpCisgICAgICAgICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRpbmcoaGFuZGxl
LmdldCgpLCAwKTsKIAotICAgICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRpbmcoaGFuZGxlLmdl
dCgpLCAwKTsKKyAgICAgICAgY2xlYW51cFNvdXBSZXF1ZXN0T3BlcmF0aW9uKGhhbmRsZS5nZXQo
KSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>