60391 2011-05-06 11:44:51 -0700 Media Stream no-interface-object test should not have ReferenceError message in expected results 2011-06-18 13:18:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 60394 0 adam.bergkvist adam.bergkvist abarth darin dglazkov eric leandrogracia tommyw webkit.review.bot oldest_to_newest 399679 0 adam.bergkvist 2011-05-06 11:44:51 -0700 The message for ReferenceError differs between JSC and V8 and having it in the expected results file requires unnecessary platform specific expected results. 399682 1 92615 adam.bergkvist 2011-05-06 11:48:20 -0700 Created attachment 92615 Proposed patch 401258 2 darin 2011-05-10 09:27:18 -0700 (In reply to comment #0) > The message for ReferenceError differs between JSC and V8 and having it in the expected results file requires unnecessary platform specific expected results. Does it have to differ? Can we make the messages the same? 401871 3 adam.bergkvist 2011-05-11 02:36:54 -0700 (In reply to comment #2) > (In reply to comment #0) > > The message for ReferenceError differs between JSC and V8 and having it in the expected results file requires unnecessary platform specific expected results. > > Does it have to differ? Can we make the messages the same? I think it would be good to have the same message. The question is which message it should be? The V8 message seems to match the one you get in Firefox (aoeu is not defined), but perhaps the JSC message (Can't find variable: aoeu) is better since "is not defined" can be confused with undefined (an undefined value of a declared variable). 402565 4 eric 2011-05-11 19:43:28 -0700 (In reply to comment #2) > (In reply to comment #0) > > The message for ReferenceError differs between JSC and V8 and having it in the expected results file requires unnecessary platform specific expected results. > > Does it have to differ? Can we make the messages the same? :( 402625 5 abarth 2011-05-11 20:56:19 -0700 > Does it have to differ? Can we make the messages the same? I would very much like to make the messages the same. Historically when I've discussed this issue with the V8 team, they haven't been very receptive. (I can dig up the bug numbers if you're interested.) Some of the messages are generated by the bindings layer, which are easier to synchronize. Unfortunately, I believe the ReferenceError is generated by the JS engine itself. 410510 6 leandrogracia 2011-05-26 09:20:00 -0700 This should be fixed by now. Can you please confirm it? All the tests passed in mac using JSC last time I tried. Thanks. 412226 7 adam.bergkvist 2011-05-30 07:50:08 -0700 (In reply to comment #6) > This should be fixed by now. Can you please confirm it? All the tests passed in mac using JSC last time I tried. > > Thanks. Still got the same problem with a build from this morning (r87680). Here's the diff: --- /tmp/layout-test-results/fast/dom/MediaStream/no-interface-object-expected.txt 2011-05-30 13:28:59.468002394 +0200 +++ /tmp/layout-test-results/fast/dom/MediaStream/no-interface-object-actual.txt 2011-05-30 13:28:59.468002394 +0200 @@ -4,13 +4,13 @@ PASS typeof NavigatorUserMedia is "undefined" -PASS NavigatorUserMedia.prototype threw exception ReferenceError: NavigatorUserMedia is not defined. +PASS NavigatorUserMedia.prototype threw exception ReferenceError: Can't find variable: NavigatorUserMedia. PASS typeof NavigatorUserMediaError is "undefined" -PASS NavigatorUserMediaError.prototype threw exception ReferenceError: NavigatorUserMediaError is not defined. +PASS NavigatorUserMediaError.prototype threw exception ReferenceError: Can't find variable: NavigatorUserMediaError. PASS typeof NavigatorUserMediaSuccessCallback is "undefined" -PASS NavigatorUserMediaSuccessCallback.prototype threw exception ReferenceError: NavigatorUserMediaSuccessCallback is not defined. +PASS NavigatorUserMediaSuccessCallback.prototype threw exception ReferenceError: Can't find variable: NavigatorUserMediaSuccessCallback. PASS typeof NavigatorUserMediaErrorCallback is "undefined" -PASS NavigatorUserMediaErrorCallback.prototype threw exception ReferenceError: NavigatorUserMediaErrorCallback is not defined. +PASS NavigatorUserMediaErrorCallback.prototype threw exception ReferenceError: Can't find variable: NavigatorUserMediaErrorCallback. PASS successfullyParsed is true TEST COMPLETE 412562 8 leandrogracia 2011-05-31 05:30:09 -0700 Sorry, I assigned the bug to Tommyw accidentally. I'm resetting it. 412594 9 tommyw 2011-05-31 06:59:13 -0700 The patch looks just fine, but just for clarification have you verified it in V8? 412615 10 adam.bergkvist 2011-05-31 07:40:10 -0700 (In reply to comment #9) > The patch looks just fine, but just for clarification have you verified it in V8? No, but the chromium ews seems happy. 412640 11 leandrogracia 2011-05-31 08:30:15 -0700 (In reply to comment #10) > (In reply to comment #9) > > The patch looks just fine, but just for clarification have you verified it in V8? > > No, but the chromium ews seems happy. Yes, it looks like. The Chromium ews bot doesn't seem to turn red when some tests fail (which was the case), but fortunately these were completely unrelated to this. So it seems it's working fine in V8 too. 419513 12 92615 adam.bergkvist 2011-06-13 05:48:22 -0700 Comment on attachment 92615 Proposed patch Filed a new bug for the continued discussion about aligning the error messages between JSC and V8: http://webkit.org/b/62540 423211 13 92615 webkit.review.bot 2011-06-18 13:18:16 -0700 Comment on attachment 92615 Proposed patch Clearing flags on attachment: 92615 Committed r89203: <http://trac.webkit.org/changeset/89203> 423212 14 webkit.review.bot 2011-06-18 13:18:21 -0700 All reviewed patches have been landed. Closing bug. 92615 2011-05-06 11:48:20 -0700 2011-06-18 13:18:16 -0700 Proposed patch getUserMedia-no-interface-object.patch text/plain 3244 adam.bergkvist ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMmFhZjZmLi45M2Q3YjU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUt MDYgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lZGlhIFN0cmVhbSBu by1pbnRlcmZhY2Utb2JqZWN0IHRlc3Qgc2hvdWxkIG5vdCBoYXZlIFJlZmVyZW5jZUVycm9yIG1l c3NhZ2UgaW4gZXhwZWN0ZWQgcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjAzOTEKKworICAgICAgICBGaXhlZCBuby1pbnRlcmZhY2Utb2Jq ZWN0IHRlc3QgdG8gbm90IGluY2x1ZGUgUmVmZXJlbmNlRXJyb3IgbWVzc2FnZSBpbiBleHBlY3Rl ZCByZXN1bHRzCisKKyAgICAgICAgKiBmYXN0L2RvbS9NZWRpYVN0cmVhbS9uby1pbnRlcmZhY2Ut b2JqZWN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9NZWRpYVN0cmVhbS9zY3Jp cHQtdGVzdHMvbm8taW50ZXJmYWNlLW9iamVjdC5qczoKKyAgICAgICAgKHNob3VsZFRocm93UmVm ZXJlbmNlRXJyb3IpOgorICAgICAgICAodGVzdCk6CisKIDIwMTEtMDUtMDUgIE9qYW4gVmFmYWkg IDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNaWhhaSBQYXJwYXJp dGEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9NZWRpYVN0cmVhbS9uby1pbnRl cmZhY2Utb2JqZWN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL01lZGlhU3Ry ZWFtL25vLWludGVyZmFjZS1vYmplY3QtZXhwZWN0ZWQudHh0CmluZGV4IGIwMDQyNzUuLmQzYzQ1 Y2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL01lZGlhU3RyZWFtL25vLWludGVy ZmFjZS1vYmplY3QtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL01lZGlh U3RyZWFtL25vLWludGVyZmFjZS1vYmplY3QtZXhwZWN0ZWQudHh0CkBAIC00LDEzICs0LDEzIEBA IE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFCiAKIAogUEFTUyB0eXBlb2YgTmF2aWdhdG9yVXNlck1l ZGlhIGlzICJ1bmRlZmluZWQiCi1QQVNTIE5hdmlnYXRvclVzZXJNZWRpYS5wcm90b3R5cGUgdGhy ZXcgZXhjZXB0aW9uIFJlZmVyZW5jZUVycm9yOiBOYXZpZ2F0b3JVc2VyTWVkaWEgaXMgbm90IGRl ZmluZWQuCitQQVNTIE5hdmlnYXRvclVzZXJNZWRpYS5wcm90b3R5cGUgdGhyZXcgZXhjZXB0aW9u IFJlZmVyZW5jZUVycm9yCiBQQVNTIHR5cGVvZiBOYXZpZ2F0b3JVc2VyTWVkaWFFcnJvciBpcyAi dW5kZWZpbmVkIgotUEFTUyBOYXZpZ2F0b3JVc2VyTWVkaWFFcnJvci5wcm90b3R5cGUgdGhyZXcg ZXhjZXB0aW9uIFJlZmVyZW5jZUVycm9yOiBOYXZpZ2F0b3JVc2VyTWVkaWFFcnJvciBpcyBub3Qg ZGVmaW5lZC4KK1BBU1MgTmF2aWdhdG9yVXNlck1lZGlhRXJyb3IucHJvdG90eXBlIHRocmV3IGV4 Y2VwdGlvbiBSZWZlcmVuY2VFcnJvcgogUEFTUyB0eXBlb2YgTmF2aWdhdG9yVXNlck1lZGlhU3Vj Y2Vzc0NhbGxiYWNrIGlzICJ1bmRlZmluZWQiCi1QQVNTIE5hdmlnYXRvclVzZXJNZWRpYVN1Y2Nl c3NDYWxsYmFjay5wcm90b3R5cGUgdGhyZXcgZXhjZXB0aW9uIFJlZmVyZW5jZUVycm9yOiBOYXZp Z2F0b3JVc2VyTWVkaWFTdWNjZXNzQ2FsbGJhY2sgaXMgbm90IGRlZmluZWQuCitQQVNTIE5hdmln YXRvclVzZXJNZWRpYVN1Y2Nlc3NDYWxsYmFjay5wcm90b3R5cGUgdGhyZXcgZXhjZXB0aW9uIFJl ZmVyZW5jZUVycm9yCiBQQVNTIHR5cGVvZiBOYXZpZ2F0b3JVc2VyTWVkaWFFcnJvckNhbGxiYWNr IGlzICJ1bmRlZmluZWQiCi1QQVNTIE5hdmlnYXRvclVzZXJNZWRpYUVycm9yQ2FsbGJhY2sucHJv dG90eXBlIHRocmV3IGV4Y2VwdGlvbiBSZWZlcmVuY2VFcnJvcjogTmF2aWdhdG9yVXNlck1lZGlh RXJyb3JDYWxsYmFjayBpcyBub3QgZGVmaW5lZC4KK1BBU1MgTmF2aWdhdG9yVXNlck1lZGlhRXJy b3JDYWxsYmFjay5wcm90b3R5cGUgdGhyZXcgZXhjZXB0aW9uIFJlZmVyZW5jZUVycm9yCiBQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZG9tL01lZGlhU3RyZWFtL3NjcmlwdC10ZXN0cy9uby1pbnRlcmZh Y2Utb2JqZWN0LmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vTWVkaWFTdHJlYW0vc2NyaXB0LXRl c3RzL25vLWludGVyZmFjZS1vYmplY3QuanMKaW5kZXggNjgxN2YwZi4uMzk2ZTU2ZiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vTWVkaWFTdHJlYW0vc2NyaXB0LXRlc3RzL25vLWlu dGVyZmFjZS1vYmplY3QuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vTWVkaWFTdHJlYW0v c2NyaXB0LXRlc3RzL25vLWludGVyZmFjZS1vYmplY3QuanMKQEAgLTEsOSArMSwyNSBAQAogZGVz Y3JpcHRpb24oIlRlc3RzIHRoYXQgdGhlIGZvbGxvd2luZyBjbGFzc2VzIGFyZSBub3QgbWFuaXB1 bGFibGUgYnkgSmF2YVNjcmlwdCAoTm9JbnRlcmZhY2VPYmplY3QpLiIpOwogCitmdW5jdGlvbiBz aG91bGRUaHJvd1JlZmVyZW5jZUVycm9yKGV4cHIpCit7CisgICAgdmFyIGU7CisgICAgdHJ5IHsK KyAgICAgICAgZXZhbChleHByKTsKKyAgICB9IGNhdGNoIChfZSkgeworICAgICAgICBlID0gX2U7 CisgICAgfQorCisgICAgdmFyIG1zZyA9IGV4cHIgKyAoZSA/ICIgdGhyZXcgZXhjZXB0aW9uICIg KyBlLm5hbWUgOiAiIGRpZCBub3QgdGhyb3ciKTsKKyAgICBpZiAoZSAmJiBlLm5hbWUgPT0gIlJl ZmVyZW5jZUVycm9yIikKKyAgICAgICAgdGVzdFBhc3NlZChtc2cpOworICAgIGVsc2UKKyAgICAg ICAgdGVzdEZhaWxlZChtc2cpOworfQorCiBmdW5jdGlvbiB0ZXN0KG5hbWUpCiB7CiAgICAgc2hv dWxkQmUoJ3R5cGVvZiAnICsgbmFtZSwgJyJ1bmRlZmluZWQiJyk7Ci0gICAgc2hvdWxkVGhyb3co bmFtZSArICcucHJvdG90eXBlJyk7CisgICAgc2hvdWxkVGhyb3dSZWZlcmVuY2VFcnJvcihuYW1l ICsgJy5wcm90b3R5cGUnKTsKIH0KIAogdGVzdCgnTmF2aWdhdG9yVXNlck1lZGlhJyk7Cg==