60373 2011-05-06 09:17:03 -0700 check-webkit-style / TestExpectationChecker doesn't catch all parse errors in test_expectations.txt 2011-05-09 13:23:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 60466 P2 Normal --- 1 enne webkit-unassigned abarth dpranke enne levin oldest_to_newest 399545 0 enne 2011-05-06 09:17:03 -0700 It's unfortunate that it's so easy to check in a test_expectations.txt file that doesn't work either due to a typo or due to two rules that conflict with each other in specificity. It'd be nice if folks were warned that they were about to do such a thing. 399562 1 abarth 2011-05-06 09:37:36 -0700 Another approach is to simply test_expectations to the point where it cannot have parse errors. 399563 2 enne 2011-05-06 09:39:20 -0700 (In reply to comment #1) > Another approach is to simply test_expectations to the point where it cannot have parse errors. This bug was prompted by http://trac.webkit.org/changeset/85950, which fixed what was called a parse error, but it was really a cuplicate expectation where one was more specific than the other. On further inspection, it looks like check-webkit-style will complain about "duplicate or ambiguous expectation" but only if both offending lines are in the patch. Maybe it needs to consider the whole file? 399564 3 abarth 2011-05-06 09:41:53 -0700 I don't believe it is possible to have parse errors in the Skipped files, which are another approach to the same problem. Yes, I know Skipped files do not have all the features of test_expectations. 399589 4 levin 2011-05-06 10:07:07 -0700 (In reply to comment #2) > (In reply to comment #1) > > Another approach is to simply test_expectations to the point where it cannot have parse errors. > > This bug was prompted by http://trac.webkit.org/changeset/85950, which fixed what was called a parse error, but it was really a cuplicate expectation where one was more specific than the other. > > On further inspection, it looks like check-webkit-style will complain about "duplicate or ambiguous expectation" but only if both offending lines are in the patch. Maybe it needs to consider the whole file? In general, check-webkit-style only complains about the line that you changed. However, I'm sure one could change this for a particular checker. Patches welcome :). 399619 5 dpranke 2011-05-06 10:39:34 -0700 I think this should probably be merged into bug 51548, and I agree that the checker needs to consider the whole file, not just the lines that are modified. 400707 6 levin 2011-05-09 13:23:50 -0700 This particular issue (of filtering errors) came up for another checker as well, so I'm fixing both in one bug. *** This bug has been marked as a duplicate of bug 60466 ***