60371 2011-05-06 07:15:31 -0700 Warning fix on PluginPackage.cpp. 2011-05-10 13:16:55 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 menard menard abarth ademar apavlov commit-queue darin eric webkit.review.bot oldest_to_newest 399492 0 menard 2011-05-06 07:15:31 -0700 Warning fix on PluginPackage.cpp. 399496 1 92581 menard 2011-05-06 07:16:41 -0700 Created attachment 92581 Patch 399497 2 menard 2011-05-06 07:17:21 -0700 Is there a better way to fix this? 399498 3 92581 tonikitoo 2011-05-06 07:18:14 -0700 Comment on attachment 92581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92581&action=review > Source/WebCore/ChangeLog:8 > + Warning fix on conversion from time_t to unsigned. you could say on what platform and compiler it warns :) 399515 4 92583 menard 2011-05-06 07:51:49 -0700 Created attachment 92583 Patch 399577 5 92583 darin 2011-05-06 09:51:07 -0700 Comment on attachment 92583 Patch This is probably not a good fix. If time_t is not an unsigned then we probably aren’t hashing the whole thing. I think we need a better fix here rather than just quieting the warning. 400848 6 menard 2011-05-09 15:51:58 -0700 (In reply to comment #5) > (From update of attachment 92583 [details]) > This is probably not a good fix. If time_t is not an unsigned then we probably aren’t hashing the whole thing. I think we need a better fix here rather than just quieting the warning. Hi Darin, time_t can be a integer (because time() can return -1 when the time can't be read) or a real floating type in some OS. Apparently some embedded systems also have a unsigned 32 bit version of it (so dates prior to 1970 are not represented). unsigned on my 64 bits machine is 4 bytes. The StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes); always takes care of the size of the data going in. So I believe we can just modify hasCodes to store a time_t array or a uint64_t? 400900 7 darin 2011-05-09 16:48:34 -0700 (In reply to comment #6) > The StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes); always takes care of the size of the data going in. So I believe we can just modify hasCodes to store a time_t array or a uint64_t? Yes, I think we can change this to be a struct with two members of the appropriate types rather than an array. 401020 8 92583 eric 2011-05-09 20:40:03 -0700 Comment on attachment 92583 Patch OK. 401021 9 92583 eric 2011-05-09 20:40:50 -0700 Comment on attachment 92583 Patch Hmm.. Sounds liek Darin would like a differnt fix. 401152 10 92942 menard 2011-05-10 06:00:58 -0700 Created attachment 92942 Patch 401153 11 92943 menard 2011-05-10 06:03:03 -0700 Created attachment 92943 Patch 401214 12 92943 commit-queue 2011-05-10 08:25:19 -0700 Comment on attachment 92943 Patch Clearing flags on attachment: 92943 Committed r86153: <http://trac.webkit.org/changeset/86153> 401215 13 commit-queue 2011-05-10 08:25:23 -0700 All reviewed patches have been landed. Closing bug. 401246 14 commit-queue 2011-05-10 09:11:18 -0700 The commit-queue encountered the following flaky tests while processing attachment 92943: http/tests/xmlhttprequest/encode-request-url-2.html bug 51765 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 401292 15 webkit.review.bot 2011-05-10 10:20:13 -0700 http://trac.webkit.org/changeset/86153 might have broken Leopard Intel Debug (Tests) The following tests are not passing: fast/lists/003-vertical.html fonts/cursive.html 401415 16 menard 2011-05-10 12:13:07 -0700 Anyone with a Leopard Debug build around to help please? I don't have a Mac machine. 401435 17 ademar 2011-05-10 13:16:55 -0700 Revision r86153 cherry-picked into qtwebkit-2.2 with commit 2317327 <http://gitorious.org/webkit/qtwebkit/commit/2317327> 92581 2011-05-06 07:16:41 -0700 2011-05-06 07:51:42 -0700 Patch bug-60371-20110506111652.patch text/plain 1153 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1OTQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDYgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZyBmaXggb24gUGx1Z2luUGFja2Fn ZS5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDM3MQorCisgICAgICAgIFdhcm5pbmcgZml4IG9uIGNvbnZlcnNpb24gZnJvbSB0aW1lX3QgdG8g dW5zaWduZWQuCisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6aGFzaCk6CisKIDIwMTEtMDUtMDYgIEFsZXhhbmRl ciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZ dXJ5IFNlbWlraGF0c2t5LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNr YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2th Z2UuY3BwCShyZXZpc2lvbiA4NTk0MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu UGFja2FnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0NSw3ICszNDUsNyBAQCB1bnNpZ25lZCBQ bHVnaW5QYWNrYWdlOjpoYXNoKCkgY29uc3QKIHsKICAgICB1bnNpZ25lZCBoYXNoQ29kZXNbXSA9 IHsKICAgICAgICAgbV9wYXRoLmltcGwoKS0+aGFzaCgpLAotICAgICAgICBtX2xhc3RNb2RpZmll ZAorICAgICAgICBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obV9sYXN0TW9kaWZpZWQpCiAgICAgfTsK IAogICAgIHJldHVybiBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnk8c2l6ZW9mKGhhc2hDb2Rlcyk+ KGhhc2hDb2Rlcyk7Cg== 92583 2011-05-06 07:51:49 -0700 2011-05-10 06:00:51 -0700 Patch bug-60371-20110506115200.patch text/plain 1176 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1OTQ1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDYgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZyBmaXggb24gUGx1Z2luUGFja2Fn ZS5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDM3MQorCisgICAgICAgIFdhcm5pbmcgZml4IG9uIGNvbnZlcnNpb24gZnJvbSB0aW1lX3QgdG8g dW5zaWduZWQgb24gTGludXggd2l0aCBnY2MgNC42LjAuCisKKyAgICAgICAgKiBwbHVnaW5zL1Bs dWdpblBhY2thZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6aGFzaCk6 CisKIDIwMTEtMDUtMDYgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkIFF0IDQuOCBidWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAJKHJldmlzaW9uIDg1OTQ1KQorKysgU291cmNl L1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ1 LDcgKzM0NSw3IEBAIHVuc2lnbmVkIFBsdWdpblBhY2thZ2U6Omhhc2goKSBjb25zdAogewogICAg IHVuc2lnbmVkIGhhc2hDb2Rlc1tdID0gewogICAgICAgICBtX3BhdGguaW1wbCgpLT5oYXNoKCks Ci0gICAgICAgIG1fbGFzdE1vZGlmaWVkCisgICAgICAgIHN0YXRpY19jYXN0PHVuc2lnbmVkPiht X2xhc3RNb2RpZmllZCkKICAgICB9OwogCiAgICAgcmV0dXJuIFN0cmluZ0hhc2hlcjo6aGFzaE1l bW9yeTxzaXplb2YoaGFzaENvZGVzKT4oaGFzaENvZGVzKTsK 92942 2011-05-10 06:00:58 -0700 2011-05-10 06:02:56 -0700 Patch bug-60371-20110510100056.patch text/plain 1629 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MTQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMTAgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZyBmaXggb24gUGx1Z2luUGFja2Fn ZS5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDM3MQorCisgICAgICAgIFdhcm5pbmcgZml4IG9uIGNvbnZlcnNpb24gZnJvbSB0aW1lX3QgdG8g dW5zaWduZWQgb24gTGludXggd2l0aCBnY2MgNC42LjAuCisgICAgICAgIExldCdzIHVzZSBhIHN0 cnVjdCByYXRoZXIgdGhhbiBhbiBhcnJheSBzbyB3ZSBjYW4gcGFzcyBldmVyeXRoaW5nIHRvIFN0 cmluZ0hhc2hlci4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpoYXNoKToKKwogMjAxMS0wNS0xMCAgQmVuIE11 cmRvY2ggIDxiZW5tQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxv Y2suCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAJKHJldmlz aW9uIDg2MDgyKQorKysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzQzLDEyICszNDMsMTUgQEAgdm9pZCBQbHVnaW5QYWNrYWdlOjpp bml0aWFsaXplQnJvd3NlckZ1bgogI2lmIEVOQUJMRShQTFVHSU5fUEFDS0FHRV9TSU1QTEVfSEFT SCkKIHVuc2lnbmVkIFBsdWdpblBhY2thZ2U6Omhhc2goKSBjb25zdAogewotICAgIHVuc2lnbmVk IGhhc2hDb2Rlc1tdID0gewotICAgICAgICBtX3BhdGguaW1wbCgpLT5oYXNoKCksCi0gICAgICAg IG1fbGFzdE1vZGlmaWVkCi0gICAgfTsKKyAgICBzdHJ1Y3QgSGFzaENvZGVzIHsKKyAgICAgICAg dW5zaWduZWQgaGFzaDsKKyAgICAgICAgdGltZV90IG1vZGlmaWVkRGF0ZTsKKyAgICB9IGhhc2hD b2RlczsKIAotICAgIHJldHVybiBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnk8c2l6ZW9mKGhhc2hD b2Rlcyk+KGhhc2hDb2Rlcyk7CisgICAgaGFzaENvZGVzLmhhc2ggPSBtX3BhdGguaW1wbCgpLT5o YXNoKCk7CisgICAgaGFzaENvZGVzLm1vZGlmaWVkRGF0ZSA9IG1fbGFzdE1vZGlmaWVkOworCisg ICAgcmV0dXJuIFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9yeTxzaXplb2YoaGFzaENvZGVzKT4oJmhh c2hDb2Rlcyk7CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6ZXF1YWwoY29uc3QgUGx1Z2luUGFj a2FnZSYgYSwgY29uc3QgUGx1Z2luUGFja2FnZSYgYikK 92943 2011-05-10 06:03:03 -0700 2011-05-10 08:25:19 -0700 Patch bug-60371-20110510100301.patch text/plain 1629 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MTQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMTAgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZyBmaXggb24gUGx1Z2luUGFja2Fn ZS5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDM3MQorCisgICAgICAgIFdhcm5pbmcgZml4IG9uIGNvbnZlcnNpb24gZnJvbSB0aW1lX3QgdG8g dW5zaWduZWQgb24gTGludXggd2l0aCBHQ0MgNC42LjAuCisgICAgICAgIExldCdzIHVzZSBhIHN0 cnVjdCByYXRoZXIgdGhhbiBhbiBhcnJheSBzbyB3ZSBjYW4gcGFzcyBldmVyeXRoaW5nIHRvIFN0 cmluZ0hhc2hlci4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpoYXNoKToKKwogMjAxMS0wNS0xMCAgQmVuIE11 cmRvY2ggIDxiZW5tQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxv Y2suCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAJKHJldmlz aW9uIDg2MDgyKQorKysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzQzLDEyICszNDMsMTUgQEAgdm9pZCBQbHVnaW5QYWNrYWdlOjpp bml0aWFsaXplQnJvd3NlckZ1bgogI2lmIEVOQUJMRShQTFVHSU5fUEFDS0FHRV9TSU1QTEVfSEFT SCkKIHVuc2lnbmVkIFBsdWdpblBhY2thZ2U6Omhhc2goKSBjb25zdAogewotICAgIHVuc2lnbmVk IGhhc2hDb2Rlc1tdID0gewotICAgICAgICBtX3BhdGguaW1wbCgpLT5oYXNoKCksCi0gICAgICAg IG1fbGFzdE1vZGlmaWVkCi0gICAgfTsKKyAgICBzdHJ1Y3QgSGFzaENvZGVzIHsKKyAgICAgICAg dW5zaWduZWQgaGFzaDsKKyAgICAgICAgdGltZV90IG1vZGlmaWVkRGF0ZTsKKyAgICB9IGhhc2hD b2RlczsKIAotICAgIHJldHVybiBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnk8c2l6ZW9mKGhhc2hD b2Rlcyk+KGhhc2hDb2Rlcyk7CisgICAgaGFzaENvZGVzLmhhc2ggPSBtX3BhdGguaW1wbCgpLT5o YXNoKCk7CisgICAgaGFzaENvZGVzLm1vZGlmaWVkRGF0ZSA9IG1fbGFzdE1vZGlmaWVkOworCisg ICAgcmV0dXJuIFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9yeTxzaXplb2YoaGFzaENvZGVzKT4oJmhh c2hDb2Rlcyk7CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6ZXF1YWwoY29uc3QgUGx1Z2luUGFj a2FnZSYgYSwgY29uc3QgUGx1Z2luUGFja2FnZSYgYikK