60367 2011-05-06 06:14:53 -0700 [Qt] Implement layoutTestController.layerTreeAsText() 2011-05-12 04:15:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy webkit-unassigned abecsi commit-queue joybro201 laszlo.gombos luiz ossy tonikitoo oldest_to_newest 399470 0 ossy 2011-05-06 06:14:53 -0700 compositing tests need layoutTestController.layerTreeAsText() 400212 1 92730 joybro201 2011-05-07 23:38:24 -0700 Created attachment 92730 Patch 400225 2 92730 kling 2011-05-08 03:38:32 -0700 Comment on attachment 92730 Patch Assuming that this change makes new tests pass, those tests should be unskipped in LayoutTests/platform/qt/Skipped 400247 3 joybro201 2011-05-08 09:31:42 -0700 (In reply to comment #2) > (From update of attachment 92730 [details]) > Assuming that this change makes new tests pass, those tests should be unskipped in LayoutTests/platform/qt/Skipped This patch is for a compositing test, and currently all compositing tests are skipped in the qt port. It might be because 3D_RENDERING and ACCELERATED_COMPOSITING are not supported in default. In this case, the tests should be remained in the skipped list. right? 400429 4 ossy 2011-05-09 03:46:59 -0700 Young, I tested your patch, but I always got empty string in actual result reported by layoutTestController.layerTreeAsText() 400453 5 joybro201 2011-05-09 05:01:22 -0700 (In reply to comment #4) > Young, I tested your patch, but I always got empty string in > actual result reported by layoutTestController.layerTreeAsText() You probably tested it with a binary not built with the texmap option. Qt port built with default settings does not create GraphicsLayer, so layoutTestController.layerTreeAsText() always returns empty string. You could see the right result if you try it again after enabling the texmap feature. :) 400471 6 ossy 2011-05-09 06:14:40 -0700 (In reply to comment #5) > You probably tested it with a binary not built with the texmap option. > Qt port built with default settings does not create GraphicsLayer, so layoutTestController.layerTreeAsText() always returns empty string. > > You could see the right result if you try it again after enabling the texmap feature. :) You're right, I didn't know that I have to enable texmap in WebCore.pri too. I did it and now 52 tests pass. But we can't remove compositing tests from the Skipped list if texmap isn't default build option. Additionally I got the following results: failing tests: --------------- compositing/geometry/ancestor-overflow-change.html compositing/geometry/layer-due-to-layer-children-deep-switch.html compositing/geometry/layer-due-to-layer-children-switch.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/geometry/limit-layer-bounds-fixed-positioned.html compositing/geometry/limit-layer-bounds-opacity-transition.html compositing/geometry/limit-layer-bounds-overflow-root.html compositing/geometry/limit-layer-bounds-transformed-overflow.html compositing/geometry/preserve-3d-switching.html compositing/geometry/tall-page-composited.html compositing/iframes/become-overlapped-iframe.html compositing/iframes/composited-iframe-scroll.html compositing/iframes/composited-parent-iframe.html compositing/iframes/connect-compositing-iframe2.html compositing/iframes/connect-compositing-iframe3.html compositing/iframes/connect-compositing-iframe-delayed.html compositing/iframes/connect-compositing-iframe.html compositing/iframes/enter-compositing-iframe.html compositing/iframes/iframe-content-flipping.html compositing/iframes/iframe-resize.html compositing/iframes/overlapped-iframe.html compositing/iframes/scrolling-iframe.html compositing/layer-creation/overflow-scroll-overlap.html compositing/overflow/clip-descendents.html compositing/overflow/content-gains-scrollbars.html compositing/overflow/overflow-scrollbar-layers.html compositing/plugins/small-to-large-composited-plugin.html compositing/tiling/crash-reparent-tiled-layer.html compositing/tiling/huge-layer-add-remove-child.html compositing/tiling/huge-layer-img.html compositing/tiling/huge-layer-resize.html compositing/tiling/huge-layer-with-layer-children-resize.html compositing/tiling/huge-layer-with-layer-children.html compositing/tiling/huge-layer.html new tests without expected results: ------------------------------------ compositing/compositing-visible-descendant.html compositing/direct-image-compositing.html compositing/generated-content.html compositing/layers-inside-overflow-scroll.html compositing/self-painting-layers.html compositing/sibling-positioning.html compositing/text-on-large-layer.html compositing/animation/state-at-end-event-transform-layer.html compositing/color-matching/image-color-matching.html compositing/color-matching/pdf-image-match.html compositing/geometry/abs-position-inside-opacity.html compositing/geometry/clipped-video-controller.html compositing/geometry/clipping-foreground.html compositing/geometry/composited-html-size.html compositing/geometry/fixed-in-composited.html compositing/geometry/fixed-position.html compositing/geometry/horizontal-scroll-composited.html compositing/geometry/layer-due-to-layer-children-deep.html compositing/geometry/layer-due-to-layer-children.html compositing/geometry/limit-layer-bounds-overflow-repaint.html compositing/geometry/outline-change.html compositing/geometry/partial-layout-update.html compositing/geometry/root-layer-update.html compositing/geometry/transfrom-origin-on-zero-size-layer.html compositing/geometry/vertical-scroll-composited.html compositing/geometry/video-fixed-scrolling.html compositing/geometry/video-opacity-overlay.html compositing/iframes/composited-iframe-alignment.html compositing/iframes/iframe-copy-on-scroll.html compositing/iframes/iframe-in-composited-layer.html compositing/images/direct-image-background-color.html compositing/masks/direct-image-mask.html compositing/masks/masked-ancestor.html compositing/masks/multiple-masks.html compositing/masks/simple-composited-mask.html compositing/overflow/ancestor-overflow.html compositing/overflow/fixed-position-ancestor-clip.html compositing/overflow/overflow-compositing-descendant.html compositing/overflow/overflow-positioning.html compositing/overflow/overflow-scroll.html compositing/overflow/parent-overflow.html compositing/overflow/scroll-ancestor-update.html compositing/overflow/scrollbar-painting.html compositing/plugins/composited-plugin.html compositing/reflections/animation-inside-reflection.html compositing/reflections/compositing-change-inside-reflection.html compositing/reflections/deeply-nested-reflections.html compositing/reflections/load-video-in-reflection.html compositing/reflections/masked-reflection-on-composited.html compositing/reflections/nested-reflection-anchor-point.html compositing/reflections/nested-reflection-animated.html compositing/reflections/nested-reflection-mask-change.html compositing/reflections/nested-reflection-on-overflow.html compositing/reflections/nested-reflection-opacity.html compositing/reflections/nested-reflection-size-change.html compositing/reflections/nested-reflection-transformed2.html compositing/reflections/nested-reflection-transformed.html compositing/reflections/nested-reflection-transition.html compositing/reflections/nested-reflection.html compositing/reflections/reflection-in-composited.html compositing/reflections/reflection-on-composited.html compositing/reflections/reflection-opacity.html compositing/reflections/reflection-ordering.html compositing/reflections/reflection-positioning2.html compositing/reflections/reflection-positioning.html compositing/reflections/simple-composited-reflections.html compositing/reflections/transform-inside-reflection.html compositing/repaint/become-overlay-composited-layer.html compositing/repaint/composited-document-element.html compositing/repaint/content-into-overflow.html compositing/repaint/layer-repaint-rects.html compositing/repaint/layer-repaint.html compositing/repaint/opacity-between-absolute2.html compositing/repaint/opacity-between-absolute.html compositing/repaint/overflow-into-content.html compositing/shadows/shadow-drawing.html compositing/transitions/scale-transition-no-start.html compositing/transitions/singular-scale-transition.html compositing/video/video-background-color.html It make the next test timeout ------------------------------ compositing/scroll-painted-composited-content.html crashing tests --------------- compositing/iframes/become-composited-nested-iframes.html compositing/iframes/iframe-size-from-zero.html compositing/iframes/invisible-nested-iframe-show.html compositing/iframes/layout-on-compositing-change.html compositing/iframes/overlapped-nested-iframes.html 402748 7 92730 kenneth 2011-05-12 01:42:43 -0700 Comment on attachment 92730 Patch shouldn't you unskip some tests? I assume this is tested with all tests that were failing 402752 8 joybro201 2011-05-12 02:04:24 -0700 (In reply to comment #7) > (From update of attachment 92730 [details]) > shouldn't you unskip some tests? I assume this is tested with all tests that were failing As ossy said in the above comment, we can't unskip compositing tests before texmap becomes default build option. Thanks for reviewing :) 402753 9 92730 ossy 2011-05-12 02:08:12 -0700 Comment on attachment 92730 Patch Let's go ahead, cq+. 402782 10 92730 commit-queue 2011-05-12 04:15:52 -0700 Comment on attachment 92730 Patch Clearing flags on attachment: 92730 Committed r86329: <http://trac.webkit.org/changeset/86329> 402784 11 commit-queue 2011-05-12 04:15:57 -0700 All reviewed patches have been landed. Closing bug. 92730 2011-05-07 23:38:24 -0700 2011-05-12 04:15:52 -0700 Patch bug-60367-20110508153820.patch text/plain 4126 joybro201 U3VidmVyc2lvbiBSZXZpc2lvbjogODYwMTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggOTE1ZjJmN2Q3ZDAz YjNmZTg4OGI1ZDVlOTIyMzAzMTcwMzYxMzc0MS4uMTA0ODY5OThiNmJhMDQ2NjgxYTg1MzUxMTMy NDQwYmJiNjJhYjM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wNS0w NyAgWW91bmcgSGFuIExlZSAgPGpveWJyb0Bjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEltcGxlbWVudCBsYXlvdXRU ZXN0Q29udHJvbGxlci5sYXllclRyZWVBc1RleHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAzNjcKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3Vw cG9ydFF0OjpsYXllclRyZWVBc1RleHQpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBS ZW5kZXJUcmVlU3VwcG9ydFF0Lmg6CisKIDIwMTEtMDUtMDcgIEpvZSBNYXNvbiAgPGptYXNvbkBy aW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQu Y3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRRdC5jcHAKaW5kZXggNjgyYjg3ODljOTIzZDQ4ZTM3OWU0YjAyN2YyMjM0M2Y4Nzk3NTMyOS4u N2NlZWI0ZjdhNTkzZjcxYjQ2ZWYxNjc1MmUwNDQ0ODVmYTBjNmQyNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRRdC5jcHAKQEAgLTExMTcsNiArMTExNywxMiBAQCBRU3RyaW5nIER1bXBSZW5kZXJUcmVlU3Vw cG9ydFF0OjpzaGFkb3dQc2V1ZG9JZChjb25zdCBRV2ViRWxlbWVudCYgZWxlbWVudCkKICAgICBy ZXR1cm4gcHNldWRvSWQ7CiB9CiAKK1FTdHJpbmcgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6Omxh eWVyVHJlZUFzVGV4dChRV2ViRnJhbWUqIGZyYW1lKQoreworICAgIFdlYkNvcmU6OkZyYW1lKiBj b3JlRnJhbWUgPSBRV2ViRnJhbWVQcml2YXRlOjpjb3JlKGZyYW1lKTsKKyAgICByZXR1cm4gY29y ZUZyYW1lLT5sYXllclRyZWVBc1RleHQoKTsKK30KKwogLy8gUHJvdmlkZSBhIGJhY2t3YXJkIGNv bXBhdGliaWxpdHkgd2l0aCBwcmV2aW91c2x5IGV4cG9ydGVkIHByaXZhdGUgc3ltYm9scyBhcyBv ZiBRdFdlYktpdCA0LjYgcmVsZWFzZQogCiB2b2lkIFFXRUJLSVRfRVhQT1JUIHF0X3Jlc3VtZUFj dGl2ZURPTU9iamVjdHMoUVdlYkZyYW1lKiBmcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaCBiL1NvdXJjZS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaAppbmRleCBj MDI3ZDJhYTMzZjUxZjUwYjIzMmU3OWM3YmYxNDk4MmMwYTU3NWI3Li4xOWJmZDAxMWE4MGZmNDRj NjgwYWQ3MmE3N2NiNWEzZmIxZWQ2MjFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmgKKysrIGIvU291cmNlL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCkBAIC0yMDYsNiAr MjA2LDggQEAgcHVibGljOgogICAgIHN0YXRpYyBRVmFyaWFudCBlbnN1cmVTaGFkb3dSb290KGNv bnN0IFFXZWJFbGVtZW50Jik7CiAgICAgc3RhdGljIHZvaWQgcmVtb3ZlU2hhZG93Um9vdChjb25z dCBRV2ViRWxlbWVudCYpOwogICAgIHN0YXRpYyBRU3RyaW5nIHNoYWRvd1BzZXVkb0lkKGNvbnN0 IFFXZWJFbGVtZW50Jik7CisKKyAgICBzdGF0aWMgUVN0cmluZyBsYXllclRyZWVBc1RleHQoUVdl YkZyYW1lKik7CiB9OwogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCA1YzExNjU3ZDc1ZjViZDhiZWY2YjdlOGY1MGE5NmJhN2M2N2U3 MDI0Li41NmE1MDRkMWE0NmQxM2RiYTM1ZjNjNzI3MWZkODdkNTQ4YmE3ZjZlIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDUtMDcgIFlvdW5nIEhhbiBMZWUgIDxqb3licm9AY29tcGFueTEwMC5uZXQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBJbXBsZW1l bnQgbGF5b3V0VGVzdENvbnRyb2xsZXIubGF5ZXJUcmVlQXNUZXh0KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMzY3CisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcDoKKyAgICAgICAgKExheW91 dFRlc3RDb250cm9sbGVyOjpsYXllclRyZWVBc1RleHQpOgorICAgICAgICAqIER1bXBSZW5kZXJU cmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuaDoKKwogMjAxMS0wNS0wNyAgSm9lIE1hc29u ICA8am1hc29uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJR dC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNw cAppbmRleCA5YzliM2JkNzgwZTQ5N2Q0YzE3NTAzODQwZjkzMjI5MmY5NDQ0YTQ2Li4wZTVjNmQw YWM0N2I1ZTFhMmQxNjg4NzRlYjY3OTBkNWI1Y2RmNTAxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcApAQCAtOTE1LDUgKzkxNSwx MCBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzeW5jTG9jYWxTdG9yYWdlKCkKICAgICAv LyBGSVhNRTogSW1wbGVtZW50LgogfQogCitRU3RyaW5nIExheW91dFRlc3RDb250cm9sbGVyOjps YXllclRyZWVBc1RleHQoKQoreworICAgIHJldHVybiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6 bGF5ZXJUcmVlQXNUZXh0KG1fZHJ0LT53ZWJQYWdlKCktPm1haW5GcmFtZSgpKTsKK30KKwogY29u c3QgdW5zaWduZWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdXaWR0aCA9IDgwMDsKIGNv bnN0IHVuc2lnbmVkIExheW91dFRlc3RDb250cm9sbGVyOjptYXhWaWV3SGVpZ2h0ID0gNjAwOwpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJR dC5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCmlu ZGV4IGM2NjY1MGJmYjg3ZDY4ZmVlYThjNjBmNDcxMGM3ZWRmMGE2MmMwY2EuLmU2MWU3MWZhZGEw NzU4NjI4ZjdiYTJmMzQxNzEyNDdhY2UzZmIwYTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuaAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKQEAgLTI2OCw2ICsyNjgsNyBAQCBwdWJs aWMgc2xvdHM6CiAgICAgdm9pZCBkZWxldGVMb2NhbFN0b3JhZ2VGb3JPcmlnaW4oY29uc3QgUVN0 cmluZyYgb3JpZ2luSWRlbnRpZmllcik7CiAgICAgdm9pZCBvYnNlcnZlU3RvcmFnZVRyYWNrZXJO b3RpZmljYXRpb25zKHVuc2lnbmVkIG51bWJlcik7CiAgICAgdm9pZCBzeW5jTG9jYWxTdG9yYWdl KCk7CisgICAgUVN0cmluZyBsYXllclRyZWVBc1RleHQoKTsKIAogcHJpdmF0ZSBzbG90czoKICAg ICB2b2lkIHByb2Nlc3NXb3JrKCk7Cg==