60347 2011-05-06 00:17:23 -0700 [Qt] [qtwebkit-2.2] Fails to build with Qt for Embedded Linux 2011-05-09 13:46:28 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P1 Normal --- 0 bero menard ademar benjamin menard oldest_to_newest 399375 0 bero 2011-05-06 00:17:23 -0700 Attempting to build qtwebkit-2.2 with Qt for Embedded Linux results in a build failure because PluginContainerQt.cpp (which uses QX11EmbedContainer, which obviously doesn't exist on embedded, unconditionally) is being built. 399625 1 92603 menard 2011-05-06 10:42:25 -0700 Created attachment 92603 Proposed patch. Fix the build. 399639 2 92603 kling 2011-05-06 10:55:59 -0700 Comment on attachment 92603 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=92603&action=review rs=me > ChangeLog:6 > + Fix the build on embedded linux. qpa is the name for lighthouse but the old > + name for Qt for Embedded Linux should still be used in order to build properly. I'm missing a [Qt] here somewhere. embedded linux -> Embedded Linux > Source/WebCore/ChangeLog:6 > + Fix the build on embedded linux. qpa is the name for lighthouse but the old > + name for Qt for Embedded Linux should still be used in order to build properly. Ditto. 400695 3 menard 2011-05-09 12:58:10 -0700 Committed r86083: <http://trac.webkit.org/changeset/86083> 400722 4 ademar 2011-05-09 13:46:15 -0700 Revision r86083 cherry-picked into qtwebkit-2.2 with commit b105226 <http://gitorious.org/webkit/qtwebkit/commit/b105226> 92603 2011-05-06 10:42:25 -0700 2011-05-06 10:55:59 -0700 Proposed patch. patch.diff text/plain 2084 menard ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0ZDQ4YTQyLi44NjQzZDJi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDUtMDYgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRo ZSBidWlsZCBvbiBlbWJlZGRlZCBsaW51eC4gcXBhIGlzIHRoZSBuYW1lIGZvciBsaWdodGhvdXNl IGJ1dCB0aGUgb2xkCisgICAgICAgIG5hbWUgZm9yIFF0IGZvciBFbWJlZGRlZCBMaW51eCBzaG91 bGQgc3RpbGwgYmUgdXNlZCBpbiBvcmRlciB0byBidWlsZCBwcm9wZXJseS4KKworICAgICAgICAq IFNvdXJjZS9XZWJLaXQucHJpOgorCiAyMDExLTA1LTA1ICBBbGV4aXMgTWVuYXJkICA8YWxleGlz Lm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJlbmphbWluIFBv dWxhaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggN2I1MDg1OS4uMGU2YTJmYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA1LTA2ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVu Ym9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCB0aGUgYnVpbGQgb24gZW1iZWRkZWQgbGludXguIHFwYSBpcyB0aGUgbmFtZSBmb3Ig bGlnaHRob3VzZSBidXQgdGhlIG9sZAorICAgICAgICBuYW1lIGZvciBRdCBmb3IgRW1iZWRkZWQg TGludXggc2hvdWxkIHN0aWxsIGJlIHVzZWQgaW4gb3JkZXIgdG8gYnVpbGQgcHJvcGVybHkuCisK KyAgICAgICAgKiBXZWJDb3JlLnByaToKKwogMjAxMS0wNS0wNSAgQW5kcmVhcyBLbGluZyAgPGFu ZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNt YW5uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkgYi9Tb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLnByaQppbmRleCA2M2UzNzJjLi41MTUwMjU3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLnByaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQpA QCAtMTAsNyArMTAsNyBAQCBRVCAqPSBuZXR3b3JrCiAKIFNPVVJDRV9ESVIgPSAkJHJlcGxhY2Uo UFdELCAvV2ViQ29yZSwgIiIpCiAKLWNvbnRhaW5zKFFUX0NPTkZJRywgcXBhKTpDT05GSUcgKz0g ZW1iZWRkZWQKK2NvbnRhaW5zKFFUX0NPTkZJRywgcXBhKXxjb250YWlucyhRVF9DT05GSUcsIGVt YmVkZGVkKTogQ09ORklHICs9IGVtYmVkZGVkCiAKICMgVXNlIGEgY29uZmlnLXNwZWNpZmljIHRh cmdldCB0byBwcmV2ZW50IHBhcmFsbGVsIGJ1aWxkcyBmaWxlIGNsYXNoZXMgb24gTWFjCiBtYWM6 IENPTkZJRyhkZWJ1ZywgZGVidWd8cmVsZWFzZSk6IFdFQkNPUkVfVEFSR0VUID0gd2ViY29yZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQucHJpIGIvU291cmNlL1dlYktpdC5wcmkKaW5kZXgg NDJiOGRmZi4uMDA3ZmI0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC5wcmkKKysrIGIvU291 cmNlL1dlYktpdC5wcmkKQEAgLTEsNiArMSw2IEBACiAjIEluY2x1ZGUgZmlsZSB0byBtYWtlIGl0 IGVhc3kgdG8gaW5jbHVkZSBXZWJLaXQgaW50byBRdCBwcm9qZWN0cwogCi1jb250YWlucyhRVF9D T05GSUcsIHFwYSk6Q09ORklHICs9IGVtYmVkZGVkCitjb250YWlucyhRVF9DT05GSUcsIHFwYSl8 Y29udGFpbnMoUVRfQ09ORklHLCBlbWJlZGRlZCk6IENPTkZJRyArPSBlbWJlZGRlZAogCiAjIERl dGVjdCB0aGF0IHdlIGFyZSBidWlsZGluZyBhcyBhIHN0YW5kYWxvbmUgcGFja2FnZSBieSB0aGUg cHJlc2VuY2Ugb2YKICMgZWl0aGVyIHRoZSBnZW5lcmF0ZWQgZmlsZXMgZGlyZWN0b3J5IG9yIGFz IHBhcnQgb2YgdGhlIFF0IHBhY2thZ2UgdGhyb3VnaAo=