<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60345</bug_id>
          
          <creation_ts>2011-05-06 00:00:09 -0700</creation_ts>
          <short_desc>EWS can&apos;t reject patches</short_desc>
          <delta_ts>2011-05-06 08:40:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>399367</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-05-06 00:00:09 -0700</bug_when>
    <thetext>Traceback (most recent call last):
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/bot/queueengine.py&quot;, line 108, in run
    if not self._delegate.process_work_item(work_item):
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/commands/queues.py&quot;, line 378, in process_work_item
    if not self.review_patch(patch):
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py&quot;, line 149, in review_patch
    self._post_reject_message_on_bug(self._tool, patch, task.failure_status_id, self._failing_tests_message(task, patch))
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py&quot;, line 109, in _post_reject_message_on_bug
    tool.bugs.set_flag_on_attachment(patch.bug_id(), &quot;commit-queue&quot;, &quot;-&quot;, message, extra_message_text)
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py&quot;, line 631, in set_flag_on_attachment
    self.browser.set_value(comment_text, name=&apos;comment&apos;, nr=0)
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py&quot;, line 2823, in set_value
    c = self.find_control(name, type, kind, id, label=label, nr=nr)
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py&quot;, line 3101, in find_control
    return self._find_control(name, type, kind, id, label, predicate, nr)
  File &quot;/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py&quot;, line 3185, in _find_control
    raise ControlNotFoundError(&quot;no control matching &quot;+description)
ControlNotFoundError: no control matching name &apos;comment&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399368</commentid>
    <comment_count>1</comment_count>
      <attachid>92551</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-05-06 00:06:29 -0700</bug_when>
    <thetext>Created attachment 92551
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399369</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-05-06 00:07:02 -0700</bug_when>
    <thetext>Committed r85922: &lt;http://trac.webkit.org/changeset/85922&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399372</commentid>
    <comment_count>3</comment_count>
      <attachid>92551</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-05-06 00:12:53 -0700</bug_when>
    <thetext>Comment on attachment 92551
Patch

I landed this without review because I&apos;m a problem child.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399529</commentid>
    <comment_count>4</comment_count>
      <attachid>92551</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-05-06 08:40:24 -0700</bug_when>
    <thetext>Comment on attachment 92551
Patch

Lgtm</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>92551</attachid>
            <date>2011-05-06 00:06:29 -0700</date>
            <delta_ts>2011-05-06 08:40:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60345-20110506000628.patch</filename>
            <type>text/plain</type>
            <size>2999</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg1OTIxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDUtMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor
ICAgICAgICBFV1MgY2FuJ3QgcmVqZWN0IHBhdGNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMzQ1CisKKyAgICAgICAgV2UncmUgc3VwcG9zZWQg
dG8gdXNlIHBhdGNoLmlkKCkgZm9yIHRoZSBhdHRhY2htZW50IElELCBzaWxseS4KKworICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHk6
CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5
c3RlbV91bml0dGVzdC5weToKKwogMjAxMS0wNS0wNSAgU3RldmUgTGFjZXkgIDxzamxAY2hyb21p
dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCkluZGV4OiBUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5Cj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5p
bmdzeXN0ZW0ucHkJKHJldmlzaW9uIDg1OTE2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90
b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQkod29ya2luZyBjb3B5KQpAQCAtMTA2
LDcgKzEwNiw3IEBAIGNsYXNzIEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKEFic3RyYWMKICAg
ICAgICAgIyB0aGUgY2FzZSB3aGVyZSBwYXRjaC5jb21taXRfcXVldWUoKSBpc24ndCBhbHJlYWR5
IHNldCB0byAnLScuCiAgICAgICAgIGlmIGNscy53YXRjaGVyczoKICAgICAgICAgICAgIHRvb2wu
YnVncy5hZGRfY2NfdG9fYnVnKHBhdGNoLmJ1Z19pZCgpLCBjbHMud2F0Y2hlcnMpCi0gICAgICAg
IHRvb2wuYnVncy5zZXRfZmxhZ19vbl9hdHRhY2htZW50KHBhdGNoLmJ1Z19pZCgpLCAiY29tbWl0
LXF1ZXVlIiwgIi0iLCBtZXNzYWdlLCBleHRyYV9tZXNzYWdlX3RleHQpCisgICAgICAgIHRvb2wu
YnVncy5zZXRfZmxhZ19vbl9hdHRhY2htZW50KHBhdGNoLmlkKCksICJjb21taXQtcXVldWUiLCAi
LSIsIG1lc3NhZ2UsIGV4dHJhX21lc3NhZ2VfdGV4dCkKIAogICAgIEBjbGFzc21ldGhvZAogICAg
IGRlZiBoYW5kbGVfc2NyaXB0X2Vycm9yKGNscywgdG9vbCwgc3RhdGUsIHNjcmlwdF9lcnJvcik6
CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5n
c3lzdGVtX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDg1
OTE2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2Fybmlu
Z3N5c3RlbV91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNzIsNyArNzIsNyBAQCBjbGFz
cyBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbVRlc3QoUXVlCiAgICAgZGVmIHRlc3RfcG9zdF9y
ZWplY3RfbWVzc2FnZV9vbl9idWcoc2VsZik6CiAgICAgICAgIHRvb2wgPSBNb2NrVG9vbCgpCiAg
ICAgICAgIHBhdGNoID0gdG9vbC5idWdzLmZldGNoX2F0dGFjaG1lbnQoMTk3KQotICAgICAgICBl
eHBlY3RlZF9zdGRlcnIgPSAiIiJNT0NLIHNldHRpbmcgZmxhZyAnY29tbWl0LXF1ZXVlJyB0byAn
LScgb24gYXR0YWNobWVudCAnNDInIHdpdGggY29tbWVudCAnQXR0YWNobWVudCAxOTcgZGlkIG5v
dCBwYXNzIG1vY2stZXdzICh3aW4pOgorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiIiJNT0NL
IHNldHRpbmcgZmxhZyAnY29tbWl0LXF1ZXVlJyB0byAnLScgb24gYXR0YWNobWVudCAnMTk3JyB3
aXRoIGNvbW1lbnQgJ0F0dGFjaG1lbnQgMTk3IGRpZCBub3QgcGFzcyBtb2NrLWV3cyAod2luKToK
IE91dHB1dDogaHR0cDovL2R1bW15X3VybCcgYW5kIGFkZGl0aW9uYWwgY29tbWVudCAnRVhUUkEn
CiAiIiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsCkBAIC0x
MTgsNyArMTE4LDcgQEAgY2xhc3MgRWFybHlXYXJuaW5nU3l0ZW1UZXN0KFF1ZXVlc1Rlc3QpOgog
ICAgICAgICAgICAgIm5leHRfd29ya19pdGVtIjogIiIsCiAgICAgICAgICAgICAicHJvY2Vzc193
b3JrX2l0ZW0iOiAiTU9DSzogdXBkYXRlX3N0YXR1czogJShuYW1lKXMgUGFzc1xuTU9DSzogcmVs
ZWFzZV93b3JrX2l0ZW06ICUobmFtZSlzIDE5N1xuIiAlIHN0cmluZ19yZXBsYWNlbW50cywKICAg
ICAgICAgICAgICJoYW5kbGVfc2NyaXB0X2Vycm9yIjogIiIiTU9DSzogdXBkYXRlX3N0YXR1czog
JShuYW1lKXMgU2NyaXB0RXJyb3IgZXJyb3IgbWVzc2FnZQotTU9DSyBzZXR0aW5nIGZsYWcgJ2Nv
bW1pdC1xdWV1ZScgdG8gJy0nIG9uIGF0dGFjaG1lbnQgJzQyJyB3aXRoIGNvbW1lbnQgJ0F0dGFj
aG1lbnQgMTk3IGRpZCBub3QgcGFzcyAlKG5hbWUpcyAoJShwb3J0KXMpOgorTU9DSyBzZXR0aW5n
IGZsYWcgJ2NvbW1pdC1xdWV1ZScgdG8gJy0nIG9uIGF0dGFjaG1lbnQgJzE5Nycgd2l0aCBjb21t
ZW50ICdBdHRhY2htZW50IDE5NyBkaWQgbm90IHBhc3MgJShuYW1lKXMgKCUocG9ydClzKToKIE91
dHB1dDogaHR0cDovL2R1bW15X3VybCcgYW5kIGFkZGl0aW9uYWwgY29tbWVudCAnTm9uZScKICIi
IiAlIHN0cmluZ19yZXBsYWNlbW50cywKICAgICAgICAgfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>