<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60342</bug_id>
          
          <creation_ts>2011-05-05 23:04:33 -0700</creation_ts>
          <short_desc>[chromium] Skia: Visible corner seam artifacts painting CSS outline property</short_desc>
          <delta_ts>2011-07-27 21:52:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>61369</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>61369</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ben Wells">benwells</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benwells</cc>
    
    <cc>jamesr</cc>
    
    <cc>noel.gordon</cc>
    
    <cc>reed</cc>
    
    <cc>senorblanco</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>399345</commentid>
    <comment_count>0</comment_count>
      <attachid>92545</attachid>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-05-05 23:04:33 -0700</bug_when>
    <thetext>Created attachment 92545
Test case

Test case attached.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399346</commentid>
    <comment_count>1</comment_count>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-05-05 23:08:53 -0700</bug_when>
    <thetext>http://crbug.com/81777</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399357</commentid>
    <comment_count>2</comment_count>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-05-05 23:23:51 -0700</bug_when>
    <thetext>Outline sides are drawn by GraphicsContext::drawConvexPolygon, with the shouldAntialias flag set false. This works on CG. If I change skia&apos;s implementation by adding one line

    paint.setAntiAlias(shouldAntialias);

the artifacts in the corner seams / joins go away. Would this cause any problems with the work you&apos;re doing on borders?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>399378</commentid>
    <comment_count>3</comment_count>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-05-06 00:28:14 -0700</bug_when>
    <thetext>The GraphicsContext::drawConvexPolygon is also used when drawing borders and changing it also changes how borders are drawn. In particular seams in borders between two colors no longer use anti-aliasing. 

The old border code in RenderBoxModelObject (defined out by PATH_BASED_BORDER_RADIUS_DRAWING) always calls drawConvexPolygon with shouldAntialias off. 

This is why there is a difference in test css2.1/t0805-c5516-brdr-c-00-a.html noted in bug 41311.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>400311</commentid>
    <comment_count>4</comment_count>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-05-08 18:55:15 -0700</bug_when>
    <thetext>http://crbug.com/10354</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>402656</commentid>
    <comment_count>5</comment_count>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-05-11 22:11:32 -0700</bug_when>
    <thetext>When this bug is fixed, the #if !USE(SKIA) blocks in outline drawing in RenderObject.cpp and RenderInline.cpp should be removed to fix bug 58999 for skia.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443327</commentid>
    <comment_count>6</comment_count>
    <who name="Ben Wells">benwells</who>
    <bug_when>2011-07-27 21:52:44 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 61369 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>92545</attachid>
            <date>2011-05-05 23:04:33 -0700</date>
            <delta_ts>2011-05-05 23:04:33 -0700</delta_ts>
            <desc>Test case</desc>
            <filename>testcase-solid-color.html</filename>
            <type>text/html</type>
            <size>170</size>
            <attacher name="Ben Wells">benwells</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4gCiAgZGl2IHsKICAgIG1hcmdpbjogNjBweDsKICAgIHdp
ZHRoOiA0MHB4OwogICAgaGVpZ2h0OiA0MHB4OwogICAgb3V0bGluZTogNDBweCBzb2xpZCByZ2Io
MCwgMCwgMCk7CiAgfQo8L3N0eWxlPiAKPGJvZHk+IAogIDxkaXY+PC9kaXY+IAo8L2JvZHk+IAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>