60340 2011-05-05 22:28:12 -0700 [chromium] Make IndexedDB code use WebPermissionClient API 2011-05-06 10:01:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60378 1 jam jam fishd jamesr oldest_to_newest 399330 0 jam 2011-05-05 22:28:12 -0700 [chromium] Make IndexedDB code use WebPermissionClient API 399334 1 92542 jam 2011-05-05 22:33:56 -0700 Created attachment 92542 Patch 399348 2 92542 jamesr 2011-05-05 23:14:10 -0700 Comment on attachment 92542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review R= me. Do we have any way to test this stuff? > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71 > + if (webView->permissionClient()&& !webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) { Missing space before && 399358 3 jam 2011-05-05 23:25:24 -0700 (In reply to comment #2) > (From update of attachment 92542 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review > > R= me. Do we have any way to test this stuff? there aren't automated end-to-end tests afaik > > > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71 > > + if (webView->permissionClient()&& !webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) { > > Missing space before && fixed 399360 4 jam 2011-05-05 23:26:37 -0700 Committed r85919: <http://trac.webkit.org/changeset/85919> 92542 2011-05-05 22:33:56 -0700 2011-05-05 23:14:10 -0700 Patch bug-60340-20110505223141.patch text/plain 3012 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4NTkxNSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDUtMDUgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d IE1ha2UgSW5kZXhlZERCIGNvZGUgdXNlIFdlYlBlcm1pc3Npb25DbGllbnQgQVBJCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDM0MAorCisgICAgICAg ICogcHVibGljL1dlYlBlcm1pc3Npb25DbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGVy bWlzc2lvbkNsaWVudDo6YWxsb3dJbmRleGVkREIpOgorICAgICAgICAqIHNyYy9JREJGYWN0b3J5 QmFja2VuZFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SURCRmFjdG9yeUJhY2tlbmRQcm94 eTo6b3Blbik6CisKIDIwMTEtMDUtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSb2xsIENocm9taXVtIERFUFMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJQZXJtaXNzaW9uQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGVybWlzc2lvbkNsaWVudC5oCShyZXZpc2lvbiA4NTkx MykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBlcm1pc3Npb25DbGllbnQu aAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsNyBAQAogbmFtZXNwYWNlIFdlYktpdCB7CiAK IGNsYXNzIFdlYkZyYW1lOworY2xhc3MgV2ViU2VjdXJpdHlPcmlnaW47CiBjbGFzcyBXZWJTdHJp bmc7CiAKIGNsYXNzIFdlYlBlcm1pc3Npb25DbGllbnQgewpAQCAtNDQsNiArNDUsOSBAQCBwdWJs aWM6CiAgICAgLy8gQ29udHJvbHMgd2hldGhlciBpbWFnZXMgYXJlIGFsbG93ZWQgZm9yIHRoaXMg ZnJhbWUuCiAgICAgdmlydHVhbCBib29sIGFsbG93SW1hZ2VzKFdlYkZyYW1lKiwgYm9vbCBlbmFi bGVkUGVyU2V0dGluZ3MpIHsgcmV0dXJuIGVuYWJsZWRQZXJTZXR0aW5nczsgfQogCisgICAgLy8g Q29udHJvbHMgd2hldGhlciBhY2Nlc3MgdG8gSW5kZXhlZCBEQiBhcmUgYWxsb3dlZCBmb3IgdGhp cyBmcmFtZS4KKyAgICB2aXJ0dWFsIGJvb2wgYWxsb3dJbmRleGVkREIoV2ViRnJhbWUqLCBjb25z dCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2luJikgeyByZXR1cm4gdHJ1 ZTsgfQorCiAgICAgLy8gQ29udHJvbHMgd2hldGhlciBwbHVnaW5zIGFyZSBhbGxvd2VkIGZvciB0 aGlzIGZyYW1lLgogICAgIHZpcnR1YWwgYm9vbCBhbGxvd1BsdWdpbnMoV2ViRnJhbWUqLCBib29s IGVuYWJsZWRQZXJTZXR0aW5ncykgeyByZXR1cm4gZW5hYmxlZFBlclNldHRpbmdzOyB9CiAKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkZhY3RvcnlCYWNrZW5kUHJveHkuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkZhY3RvcnlCYWNr ZW5kUHJveHkuY3BwCShyZXZpc2lvbiA4NTkxMykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL0lEQkZhY3RvcnlCYWNrZW5kUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0 Miw5IEBACiAjaW5jbHVkZSAiV2ViSURCRmFjdG9yeS5oIgogI2luY2x1ZGUgIldlYktpdC5oIgog I2luY2x1ZGUgIldlYktpdENsaWVudC5oIgorI2luY2x1ZGUgIldlYlBlcm1pc3Npb25DbGllbnQu aCIKICNpbmNsdWRlICJXZWJWZWN0b3IuaCIKKyNpbmNsdWRlICJXZWJWaWV3SW1wbC5oIgogCiB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApAQCAtNjQsNyArNjYsMTMgQEAgSURCRmFjdG9yeUJh Y2tlbmRQcm94eTo6fklEQkZhY3RvcnlCYWNrZQogCiB2b2lkIElEQkZhY3RvcnlCYWNrZW5kUHJv eHk6Om9wZW4oY29uc3QgU3RyaW5nJiBuYW1lLCBQYXNzUmVmUHRyPElEQkNhbGxiYWNrcz4gY2Fs bGJhY2tzLCBQYXNzUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiBvcmlnaW4sIEZyYW1lKiBmcmFtZSwg Y29uc3QgU3RyaW5nJiBkYXRhRGlyLCBpbnQ2NF90IG1heGltdW1TaXplLCBCYWNraW5nU3RvcmVU eXBlIGJhY2tpbmdTdG9yZVR5cGUpCiB7Ci0gICAgV2ViRnJhbWUqIHdlYkZyYW1lID0gV2ViRnJh bWVJbXBsOjpmcm9tRnJhbWUoZnJhbWUpOworICAgIFdlYkZyYW1lSW1wbCogd2ViRnJhbWUgPSBX ZWJGcmFtZUltcGw6OmZyb21GcmFtZShmcmFtZSk7CisgICAgV2ViVmlld0ltcGwqIHdlYlZpZXcg PSB3ZWJGcmFtZS0+dmlld0ltcGwoKTsKKyAgICBpZiAod2ViVmlldy0+cGVybWlzc2lvbkNsaWVu dCgpJiYgIXdlYlZpZXctPnBlcm1pc3Npb25DbGllbnQoKS0+YWxsb3dJbmRleGVkREIod2ViRnJh bWUsIG5hbWUsIG9yaWdpbikpIHsKKyAgICAgICAgY2FsbGJhY2tzLT5vbkVycm9yKFdlYklEQkRh dGFiYXNlRXJyb3IoMCwgIlRoZSB1c2VyIGRlbmllZCBwZXJtaXNzaW9uIHRvIGFjY2VzcyB0aGUg ZGF0YWJhc2UuIikpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgbV93ZWJJREJGYWN0 b3J5LT5vcGVuKG5hbWUsIG5ldyBXZWJJREJDYWxsYmFja3NJbXBsKGNhbGxiYWNrcyksIG9yaWdp biwgd2ViRnJhbWUsIGRhdGFEaXIsIG1heGltdW1TaXplLCBzdGF0aWNfY2FzdDxXZWJJREJGYWN0 b3J5OjpCYWNraW5nU3RvcmVUeXBlPihiYWNraW5nU3RvcmVUeXBlKSk7CiB9CiAK