60339 2011-05-05 22:21:21 -0700 Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro. 2011-05-06 01:42:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 macpherson webkit-unassigned commit-queue oldest_to_newest 399325 0 macpherson 2011-05-05 22:21:21 -0700 Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro. 399327 1 92541 macpherson 2011-05-05 22:23:01 -0700 Created attachment 92541 Patch 399335 2 92541 eric 2011-05-05 22:34:12 -0700 Comment on attachment 92541 Patch As you can see, so much of this code is old... and crappy. Hopefully your newer code will make it easy for people to add new properties *correctly* and not end up with so many differnet bits of code doing the same thing differently like the old code was. :) 399430 3 92541 commit-queue 2011-05-06 01:42:21 -0700 Comment on attachment 92541 Patch Clearing flags on attachment: 92541 Committed r85938: <http://trac.webkit.org/changeset/85938> 399431 4 commit-queue 2011-05-06 01:42:26 -0700 All reviewed patches have been landed. Closing bug. 92541 2011-05-05 22:23:01 -0700 2011-05-06 01:42:21 -0700 Patch bug-60339-20110506152259.patch text/plain 2533 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1OTE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMDUgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5 UHJvcGVydHkoKSBDU1NQcm9wZXJ0eVdlYmtpdENvbG9yQ29ycmVjdGlvbiBjYXNlIHVzZSBhcHBy b3ByaWF0ZSBtYWNyby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYwMzM5CisKKyAgICAgICAgTm8gdGVzdHMgYWRkZWQgYXMgbm8gZnVuY3Rpb25hbGl0 eSBjaGFuZ2VkLgorCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6CisgICAgICAgIFVz ZSBjb3JyZWN0IG1hY3JvIGZvciBDU1NQcm9wZXJ0eVNwZWFrLgorICAgICAgICAqIHJlbmRlcmlu Zy9zdHlsZS9SZW5kZXJTdHlsZS5oOgorICAgICAgICAoV2ViQ29yZTo6SW5oZXJpdGVkRmxhZ3M6 OmluaXRpYWxDb2xvclNwYWNlKToKKyAgICAgICAgQWRkIGluaXRpYWxDb2xvclNwYWNlKCkgc3Rh dGljIG1ldGhvZC4KKwogMjAxMS0wNS0wNSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDg1OTE1KQorKysgU291 cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01 NDMzLDE1ICs1NDMzLDcgQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KGlu dAogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRDb2xv ckNvcnJlY3Rpb246Ci0gICAgICAgIGlmIChpc0luaGVyaXQpIAotICAgICAgICAgICAgbV9zdHls ZS0+c2V0Q29sb3JTcGFjZShtX3BhcmVudFN0eWxlLT5jb2xvclNwYWNlKCkpOwotICAgICAgICBl bHNlIGlmIChpc0luaXRpYWwpCi0gICAgICAgICAgICBtX3N0eWxlLT5zZXRDb2xvclNwYWNlKENv bG9yU3BhY2VEZXZpY2VSR0IpOwotICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgIGlmICghcHJp bWl0aXZlVmFsdWUpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgbV9zdHls ZS0+c2V0Q29sb3JTcGFjZSgqcHJpbWl0aXZlVmFsdWUpOwotICAgICAgICB9CisgICAgICAgIEhB TkRMRV9JTkhFUklUX0FORF9JTklUSUFMX0FORF9QUklNSVRJVkUoY29sb3JTcGFjZSwgQ29sb3JT cGFjZSk7CiAgICAgICAgIHJldHVybjsKICAgICBjYXNlIENTU1Byb3BlcnR5U2l6ZToKICAgICAg ICAgYXBwbHlQYWdlU2l6ZVByb3BlcnR5KHZhbHVlKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCShyZXZpc2lvbiA4NTkxNSkKKysrIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMjE1LDYgKzEyMTUsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIExlbmd0aFNpemUgaW5pdGlh bEJvcmRlclJhZGl1cygpIHsgcmV0dXJuIExlbmd0aFNpemUoTGVuZ3RoKDAsIEZpeGVkKSwgTGVu Z3RoKDAsIEZpeGVkKSk7IH0KICAgICBzdGF0aWMgRUNhcHRpb25TaWRlIGluaXRpYWxDYXB0aW9u U2lkZSgpIHsgcmV0dXJuIENBUFRPUDsgfQogICAgIHN0YXRpYyBFQ2xlYXIgaW5pdGlhbENsZWFy KCkgeyByZXR1cm4gQ05PTkU7IH0KKyAgICBzdGF0aWMgQ29sb3JTcGFjZSBpbml0aWFsQ29sb3JT cGFjZSgpIHsgcmV0dXJuIENvbG9yU3BhY2VEZXZpY2VSR0I7IH0KICAgICBzdGF0aWMgVGV4dERp cmVjdGlvbiBpbml0aWFsRGlyZWN0aW9uKCkgeyByZXR1cm4gTFRSOyB9CiAgICAgc3RhdGljIFdy aXRpbmdNb2RlIGluaXRpYWxXcml0aW5nTW9kZSgpIHsgcmV0dXJuIFRvcFRvQm90dG9tV3JpdGlu Z01vZGU7IH0KICAgICBzdGF0aWMgVGV4dENvbWJpbmUgaW5pdGlhbFRleHRDb21iaW5lKCkgeyBy ZXR1cm4gVGV4dENvbWJpbmVOb25lOyB9Cg==