60330 2011-05-05 18:59:26 -0700 [results.html] zoomed pixel results should not be antialiased 2011-05-06 10:23:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric mihaip tony oldest_to_newest 399283 0 ojan 2011-05-05 18:59:26 -0700 [results.html] zoomed pixel results should not be antialiased 399284 1 92528 ojan 2011-05-05 19:01:04 -0700 Created attachment 92528 Patch 399299 2 92528 mihaip 2011-05-05 20:20:03 -0700 Comment on attachment 92528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92528&action=review > LayoutTests/ChangeLog:8 > + -Use canvas instead of CSS zoom. Clever (especially how you avoided readback). 399301 3 ojan 2011-05-05 20:25:56 -0700 (In reply to comment #2) > (From update of attachment 92528 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92528&action=review > > > LayoutTests/ChangeLog:8 > > + -Use canvas instead of CSS zoom. > > Clever (especially how you avoided readback). Thanks, readback wasn't an option due to Chrome's disallowing file access from file URLs. 399603 4 ojan 2011-05-06 10:23:05 -0700 Committed r85957: <http://trac.webkit.org/changeset/85957> 92528 2011-05-05 19:01:04 -0700 2011-05-05 20:20:03 -0700 Patch bug-60330-20110505190103.patch text/plain 7505 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODU4NjAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5ODVmODEzYTMzMTgxY2ZhYzI5MTRm MzJiNGY1ZWRjZGNmYzE3ZjM0Li4zMmI5MDY2NmQ0NTdmMTg3MWQwMzExMWEwZGMwYmI2MzU5Y2Iy OGZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDUgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbcmVzdWx0cy5odG1sXSB6b29tZWQgcGl4ZWwgcmVzdWx0cyBzaG91bGQgbm90IGJl IGFudGlhbGlhc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MDMzMAorCisgICAgICAgIC1Vc2UgY2FudmFzIGluc3RlYWQgb2YgQ1NTIHpvb20uCisg ICAgICAgIC1Pbmx5IHpvb20gdGhlIHBhcnQgb2YgdGhlIGltYWdlIHdlIG5lZWQgdG8gc2hvdy4K KyAgICAgICAgLU1ha2UgcGl4ZWwgem9vbWluZyBtb3N0bHkgd29yayBpbiBGaXJlZm94LgorICAg ICAgICAtSW5jcmVhc2UgdGhlIHpvb20gZnJvbSAzeCB0byA2eC4KKworICAgICAgICAqIGZhc3Qv aGFybmVzcy9yZXN1bHRzLmh0bWw6CisKIDIwMTEtMDUtMDUgIEFuZHJleSBLb3N5YWtvdiAgPGNh c2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBTa2lwIGluc3BlY3Rvci9j b25zb2xlL2NvbnNvbGUtc2hhZG93LWRvbS1hY2Nlc3MuaHRtbCAoY3Jhc2hlcyBpbiBkZWJ1ZykK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sCmluZGV4IDIzZjg4NTIzNzIwZDlhNzhk MDU3NjUyNzIzMjE4Yjk5ZDcyYzg4YzQuLjVkYTI2MzY3MWRmMmQ1YTBhMDFlYTIxZDA5NTk3NzMy YmI5OTFlNGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRzLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbApAQCAtMTI0LDE3 ICsxMjQsMTcgQEAgdGggewogICAgIGxlZnQ6IDA7CiAgICAgd2lkdGg6IDEwMCU7CiAgICAgZGlz cGxheTogLXdlYmtpdC1ib3g7CisgICAgZGlzcGxheTogLW1vei1ib3g7CiAgICAgcG9pbnRlci1l dmVudHM6IG5vbmU7CiB9CiAKIC5waXhlbC16b29tLWNvbnRhaW5lciA+ICogewotICAgIGRpc3Bs YXk6IC13ZWJraXQtYm94OwogICAgIC13ZWJraXQtYm94LWZsZXg6IDE7Ci0gICAgYm9yZGVyOiAx cHggaW5zZXQgbGlnaHRncmF5OwotICAgIGhlaWdodDogMTAwcHg7CisgICAgLW1vei1ib3gtZmxl eDogMTsKKyAgICBib3JkZXI6IDJweCBpbnNldCBsaWdodGdyYXk7CiAgICAgb3ZlcmZsb3c6IGhp ZGRlbjsKLSAgICB6b29tOiAzMDAlOwotICAgIGJhY2tncm91bmQtY29sb3I6IHdoaXRlOworICAg IGxpbmUtaGVpZ2h0OiAwOworICAgIHdpZHRoOiAwOwogfQogCiAucGl4ZWwtem9vbS1jb250YWlu ZXIgaW1nIHsKQEAgLTE4MywxNSArMTgzLDI2IEBAIGZ1bmN0aW9uIHN0cmlwRXh0ZW5zaW9uKHRl c3QpCiAgICAgcmV0dXJuIHRlc3Quc3Vic3RyaW5nKDAsIGluZGV4KTsKIH0KIAorZnVuY3Rpb24g bWF0Y2hlc1NlbGVjdG9yKG5vZGUsIHNlbGVjdG9yKQoreworICAgIGlmIChub2RlLndlYmtpdE1h dGNoZXNTZWxlY3RvcikKKyAgICAgICAgcmV0dXJuIG5vZGUud2Via2l0TWF0Y2hlc1NlbGVjdG9y KHNlbGVjdG9yKTsKKworICAgIGlmIChub2RlLm1vek1hdGNoZXNTZWxlY3RvcikKKyAgICAgICAg cmV0dXJuIG5vZGUubW96TWF0Y2hlc1NlbGVjdG9yKHNlbGVjdG9yKTsKK30KKwogZnVuY3Rpb24g cGFyZW50T2ZUeXBlKG5vZGUsIHNlbGVjdG9yKQogewotICAgIHdoaWxlIChub2RlID0gbm9kZS5w YXJlbnRFbGVtZW50KSB7Ci0gICAgICAgIGlmIChub2RlLndlYmtpdE1hdGNoZXNTZWxlY3Rvcihz ZWxlY3RvcikpCisgICAgd2hpbGUgKG5vZGUgPSBub2RlLnBhcmVudE5vZGUpIHsKKyAgICAgICAg aWYgKG1hdGNoZXNTZWxlY3Rvcihub2RlLCBzZWxlY3RvcikpCiAgICAgICAgICAgICByZXR1cm4g bm9kZTsKICAgICB9CiAgICAgcmV0dXJuIG51bGw7CiB9CiAKKworCiBmdW5jdGlvbiByZW1vdmUo bm9kZSkKIHsKICAgICBub2RlLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQobm9kZSk7CkBAIC0yNTcs NiArMjY4LDE0IEBAIGZ1bmN0aW9uIHVwZGF0ZUV4cGFuZGVkU3RhdGUocm93LCBpc0V4cGFuZGVk KQogICAgIHVwZGF0ZUltYWdlVG9nZ2xpbmdUaW1lcigpOwogfQogCitmdW5jdGlvbiBhcHBlbmRI VE1MKG5vZGUsIGh0bWwpCit7CisgICAgaWYgKG5vZGUuaW5zZXJ0QWRqYWNlbnRIVE1MKQorICAg ICAgICBub2RlLmluc2VydEFkamFjZW50SFRNTCgnYmVmb3JlRW5kJywgaHRtbCk7CisgICAgZWxz ZQorICAgICAgICBub2RlLmlubmVySFRNTCArPSBodG1sOworfQorCiBmdW5jdGlvbiBleHBhbmRF eHBlY3RhdGlvbnMoZXhwYW5kTGluaykKIHsKICAgICB2YXIgcm93ID0gcGFyZW50T2ZUeXBlKGV4 cGFuZExpbmssICd0cicpOwpAQCAtMjg2LDcgKzMwNSw3IEBAIGZ1bmN0aW9uIGV4cGFuZEV4cGVj dGF0aW9ucyhleHBhbmRMaW5rKQogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIHJlc3VsdCA9 IHJlc3VsdElmcmFtZShsaW5rLmhyZWYpOwogCi0gICAgICAgIG5ld0NlbGwuaW5zZXJ0QWRqYWNl bnRIVE1MKCdiZWZvcmVFbmQnLCByZXN1bHQpOyAgICAKKyAgICAgICAgYXBwZW5kSFRNTChuZXdD ZWxsLCByZXN1bHQpOyAgICAKICAgICB9CiAKICAgICBuZXdSb3cuYXBwZW5kQ2hpbGQobmV3Q2Vs bCk7CkBAIC02ODQsOSArNzAzLDIyIEBAIHZhciBQaXhlbFpvb21lciA9IHt9OwogCiBQaXhlbFpv b21lci5zaG93T25EZWxheSA9IHRydWU7CiAKK1BpeGVsWm9vbWVyLl96b29tRmFjdG9yID0gNjsK KwogUGl4ZWxab29tZXIuX3pvb21JbWFnZUNvbnRhaW5lciA9IGZ1bmN0aW9uKHVybCkKIHsKLSAg ICByZXR1cm4gJzxkaXYgY2xhc3M9em9vbS1pbWFnZS1jb250YWluZXI+PGltZyBzcmM9IicgKyB1 cmwgKyAnIj48L2Rpdj4nOworICAgIHZhciBjb250YWluZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdkaXYnKTsKKyAgICBjb250YWluZXIuY2xhc3NOYW1lID0gJ3pvb20taW1hZ2UtY29udGFp bmVyJzsKKyAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnY2FudmFzJyk7 CisgICAgY29udGFpbmVyLmFwcGVuZENoaWxkKGNhbnZhcyk7CisgICAgCisgICAgY2FudmFzLmJh Y2tpbmdJbWFnZSA9IG5ldyBJbWFnZSgpOworICAgIGNhbnZhcy5iYWNraW5nSW1hZ2Uub25sb2Fk ID0gZnVuY3Rpb24oKSB7CisgICAgICAgIGNhbnZhcy5iYWNraW5nSW1hZ2VJc0xvYWRlZCA9IHRy dWU7CisgICAgICAgIFBpeGVsWm9vbWVyLl9kcmF3QWxsKCk7CisgICAgfQorICAgIGNhbnZhcy5i YWNraW5nSW1hZ2Uuc3JjID0gdXJsOworICAgIHJldHVybiBjb250YWluZXI7CiB9CiAKIFBpeGVs Wm9vbWVyLl9jcmVhdGVDb250YWluZXIgPSBmdW5jdGlvbihlKQpAQCAtNzAzLDM1ICs3MzUsNTgg QEAgUGl4ZWxab29tZXIuX2NyZWF0ZUNvbnRhaW5lciA9IGZ1bmN0aW9uKGUpCiAgICAgdmFyIHRv Z2dsaW5nSW1hZ2VMaW5rID0gcm93LnF1ZXJ5U2VsZWN0b3IoJ2FbaHJlZiQ9Ii1kaWZmcy5odG1s Il0nKTsKICAgICBpZiAodG9nZ2xpbmdJbWFnZUxpbmspIHsKICAgICAgICAgdmFyIHByZWZpeCA9 IHRvZ2dsaW5nSW1hZ2VMaW5rLmdldEF0dHJpYnV0ZSgnZGF0YS1wcmVmaXgnKTsKLSAgICAgICAg aHRtbCArPSBQaXhlbFpvb21lci5fem9vbUltYWdlQ29udGFpbmVyKHByZWZpeCArICctZXhwZWN0 ZWQucG5nJykgKwotICAgICAgICAgICAgUGl4ZWxab29tZXIuX3pvb21JbWFnZUNvbnRhaW5lcihw cmVmaXggKyAnLWFjdHVhbC5wbmcnKTsKKyAgICAgICAgY29udGFpbmVyLmFwcGVuZENoaWxkKFBp eGVsWm9vbWVyLl96b29tSW1hZ2VDb250YWluZXIocHJlZml4ICsgJy1leHBlY3RlZC5wbmcnKSk7 CisgICAgICAgIGNvbnRhaW5lci5hcHBlbmRDaGlsZChQaXhlbFpvb21lci5fem9vbUltYWdlQ29u dGFpbmVyKHByZWZpeCArICctYWN0dWFsLnBuZycpKTsKICAgICB9CiAgICAgCiAgICAgZm9yICh2 YXIgaSA9IDA7IGkgPCBpbWFnZURpZmZMaW5rcy5sZW5ndGg7IGkrKykKLSAgICAgICAgaHRtbCAr PSBQaXhlbFpvb21lci5fem9vbUltYWdlQ29udGFpbmVyKGltYWdlRGlmZkxpbmtzW2ldLmhyZWYp OworICAgICAgICBjb250YWluZXIuYXBwZW5kQ2hpbGQoUGl4ZWxab29tZXIuX3pvb21JbWFnZUNv bnRhaW5lcihpbWFnZURpZmZMaW5rc1tpXS5ocmVmKSk7CiAKLSAgICBjb250YWluZXIuaW5uZXJI VE1MID0gaHRtbDsKICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGNvbnRhaW5lcik7Ci0K LSAgICBQaXhlbFpvb21lci5fcG9zaXRpb24oZSk7CisgICAgUGl4ZWxab29tZXIuX2RyYXdBbGwo KTsKIH0KIAotUGl4ZWxab29tZXIuX3Bvc2l0aW9uID0gZnVuY3Rpb24oZSkKK1BpeGVsWm9vbWVy Ll9kcmF3ID0gZnVuY3Rpb24oY2FudmFzKQogewotICAgIHZhciBwYWdlWCA9IGUuY2xpZW50WDsK LSAgICB2YXIgcGFnZVkgPSBlLmNsaWVudFk7Ci0gICAgdmFyIHRhcmdldExvY2F0aW9uID0gZS50 YXJnZXQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7Ci0gICAgdmFyIHggPSBwYWdlWCAtIHRhcmdl dExvY2F0aW9uLmxlZnQ7Ci0gICAgdmFyIHkgPSBwYWdlWSAtIHRhcmdldExvY2F0aW9uLnRvcDsK KyAgICBpZiAoIWNhbnZhcy5iYWNraW5nSW1hZ2VJc0xvYWRlZCkKKyAgICAgICAgcmV0dXJuOwog Ci0gICAgdmFyIHpvb21Db250YWluZXJzID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnLnBp eGVsLXpvb20tY29udGFpbmVyID4gLnpvb20taW1hZ2UtY29udGFpbmVyJyk7Ci0gICAgZm9yICh2 YXIgaSA9IDA7IGkgPCB6b29tQ29udGFpbmVycy5sZW5ndGg7IGkrKykgewotICAgICAgICB2YXIg Y29udGFpbmVyID0gem9vbUNvbnRhaW5lcnNbaV07Ci0gICAgICAgIGNvbnRhaW5lci5zY3JvbGxM ZWZ0ID0geCAtIGNvbnRhaW5lci5vZmZzZXRXaWR0aCAvIDI7Ci0gICAgICAgIGNvbnRhaW5lci5z Y3JvbGxUb3AgPSB5IC0gY29udGFpbmVyLm9mZnNldEhlaWdodCAvIDI7CisgICAgdmFyIGRlc3Rp bmF0aW9uV2lkdGggPSBNYXRoLmZsb29yKGRvY3VtZW50LmJvZHkub2Zmc2V0V2lkdGggLyAzKSAr IDEwMDsKKyAgICB2YXIgZGVzdGluYXRpb25IZWlnaHQgPSAzMDA7CisgICAgCisgICAgdmFyIHNv dXJjZVdpZHRoID0gTWF0aC5jZWlsKGRlc3RpbmF0aW9uV2lkdGggLyBQaXhlbFpvb21lci5fem9v bUZhY3Rvcik7CisgICAgdmFyIHNvdXJjZUhlaWdodCA9IE1hdGguY2VpbChkZXN0aW5hdGlvbkhl aWdodCAvIFBpeGVsWm9vbWVyLl96b29tRmFjdG9yKTsKKworICAgIGNhbnZhcy53aWR0aCA9IGRl c3RpbmF0aW9uV2lkdGg7CisgICAgY2FudmFzLmhlaWdodCA9IGRlc3RpbmF0aW9uSGVpZ2h0Owor ICAgIAorICAgIHZhciBzdGFydFggPSBNYXRoLmZsb29yKFBpeGVsWm9vbWVyLl9jdXJyZW50WCAt IHNvdXJjZVdpZHRoIC8gMik7CisgICAgdmFyIHN0YXJ0WSA9IE1hdGguZmxvb3IoUGl4ZWxab29t ZXIuX2N1cnJlbnRZIC0gc291cmNlSGVpZ2h0IC8gMik7CisgICAgICAgIAorICAgIHN0YXJ0WCA9 IE1hdGgubWF4KHN0YXJ0WCwgMCk7CisgICAgc3RhcnRYID0gTWF0aC5taW4oc3RhcnRYLCA4MDAg LSBzb3VyY2VXaWR0aCk7CisgICAgCisgICAgc3RhcnRZID0gTWF0aC5tYXgoc3RhcnRZLCAwKTsK KyAgICBzdGFydFkgPSBNYXRoLm1pbihzdGFydFksIDYwMCAtIHNvdXJjZUhlaWdodCk7CisKKyAg ICB2YXIgc291cmNlTnVtUGl4ZWxzID0gMTsKKyAgICB2YXIgZGVzdGluYXRpb25OdW1QaXhlbHMg PSBQaXhlbFpvb21lci5fem9vbUZhY3RvcjsKKyAgICB2YXIgY29udGV4dCA9IGNhbnZhcy5nZXRD b250ZXh0KCcyZCcpOworICAgIGZvciAodmFyIHNvdXJjZVggPSBzdGFydFg7IHNvdXJjZVggPCBz dGFydFggKyBzb3VyY2VXaWR0aDsgc291cmNlWCsrKSB7CisgICAgICAgIGZvciAodmFyIHNvdXJj ZVkgPSBzdGFydFk7IHNvdXJjZVkgPCBzdGFydFkgKyBzb3VyY2VIZWlnaHQ7IHNvdXJjZVkrKykg eworICAgICAgICAgICAgdmFyIGRlc3RpbmF0aW9uWCA9IFBpeGVsWm9vbWVyLl96b29tRmFjdG9y ICogKHNvdXJjZVggLSBzdGFydFgpOworICAgICAgICAgICAgdmFyIGRlc3RpbmF0aW9uWSA9IFBp eGVsWm9vbWVyLl96b29tRmFjdG9yICogKHNvdXJjZVkgLSBzdGFydFkpOyAgICAgICAgICAgIAor ICAgICAgICAgICAgY29udGV4dC5kcmF3SW1hZ2UoY2FudmFzLmJhY2tpbmdJbWFnZSwgc291cmNl WCwgc291cmNlWSwgc291cmNlTnVtUGl4ZWxzLCBzb3VyY2VOdW1QaXhlbHMsCisgICAgICAgICAg ICAgICAgZGVzdGluYXRpb25YLCBkZXN0aW5hdGlvblksIGRlc3RpbmF0aW9uTnVtUGl4ZWxzLCBk ZXN0aW5hdGlvbk51bVBpeGVscyk7ICAgICAgICAgICAgCisgICAgICAgIH0KICAgICB9CiB9CiAK K1BpeGVsWm9vbWVyLl9kcmF3QWxsID0gZnVuY3Rpb24oKQoreworICAgIGZvckVhY2goZG9jdW1l bnQucXVlcnlTZWxlY3RvckFsbCgnLnBpeGVsLXpvb20tY29udGFpbmVyIGNhbnZhcycpLCBQaXhl bFpvb21lci5fZHJhdyk7Cit9CisKIFBpeGVsWm9vbWVyLmhhbmRsZU1vdXNlT3V0ID0gZnVuY3Rp b24oZSkKIHsKICAgICBpZiAoZS5yZWxhdGVkVGFyZ2V0ICYmIGUucmVsYXRlZFRhcmdldC50YWdO YW1lICE9ICdJRlJBTUUnKQpAQCAtNzYwLDYgKzgxNSwxMCBAQCBQaXhlbFpvb21lci5oYW5kbGVN b3VzZU1vdmUgPSBmdW5jdGlvbihlKSB7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgCisg ICAgdmFyIHRhcmdldExvY2F0aW9uID0gZS50YXJnZXQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7 CisgICAgUGl4ZWxab29tZXIuX2N1cnJlbnRYID0gZS5jbGllbnRYIC0gdGFyZ2V0TG9jYXRpb24u bGVmdDsKKyAgICBQaXhlbFpvb21lci5fY3VycmVudFkgPSBlLmNsaWVudFkgLSB0YXJnZXRMb2Nh dGlvbi50b3A7CisKICAgICBpZiAoIWNvbnRhaW5lcikgewogICAgICAgICBpZiAoUGl4ZWxab29t ZXIuc2hvd09uRGVsYXkpIHsKICAgICAgICAgICAgIFBpeGVsWm9vbWVyLl9tb3VzZU1vdmVUaW1l b3V0ID0gc2V0VGltZW91dChmdW5jdGlvbigpIHsKQEAgLTc3Miw3ICs4MzEsNyBAQCBQaXhlbFpv b21lci5oYW5kbGVNb3VzZU1vdmUgPSBmdW5jdGlvbihlKSB7CiAgICAgICAgIHJldHVybjsKICAg ICB9CiAgICAgCi0gICAgUGl4ZWxab29tZXIuX3Bvc2l0aW9uKGUpOworICAgIFBpeGVsWm9vbWVy Ll9kcmF3QWxsKCk7CiB9CiAKIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoJ21vdXNlbW92ZScs IFBpeGVsWm9vbWVyLmhhbmRsZU1vdXNlTW92ZSwgZmFsc2UpOwo=