60327 2011-05-05 17:48:51 -0700 Lazily allocate ScrollAnimator in ScrollableArea 2011-05-06 10:13:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin dglazkov gustavo.noronha gustavo sam simon.fraser webkit.review.bot xan.lopez oldest_to_newest 399243 0 simon.fraser 2011-05-05 17:48:51 -0700 ScrollableArea should lazily allocate ScrollAnimator to save memory. 399245 1 simon.fraser 2011-05-05 17:50:36 -0700 <rdar://problem/9365401> 399251 2 92516 simon.fraser 2011-05-05 17:57:13 -0700 Created attachment 92516 Patch 399387 3 92516 webkit.review.bot 2011-05-06 00:34:53 -0700 Comment on attachment 92516 Patch Attachment 92516 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8587230 399596 4 simon.fraser 2011-05-06 10:13:12 -0700 Checked in with fixes: http://trac.webkit.org/changeset/85955 92516 2011-05-05 17:57:13 -0700 2011-05-06 00:34:53 -0700 Patch bug-60327-20110505175712.patch text/plain 5265 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogODU4OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MjAzMjg0ZjVlN2RlMGQ1 N2EwYmYxNDM4Njk3M2NhYWI5OWZmMGEwLi44ODJiNTMwMDYxMzUwNDk4NDliMmExYjA1OTJlZTdi ODljZDNlYmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjggQEAKIDIwMTEtMDUtMDUgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF6aWx5IGFsbG9jYXRlIFNjcm9sbEFuaW1hdG9y IGluIFNjcm9sbGFibGVBcmVhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02MDMyNworCisgICAgICAgIEF2b2lkIGFsbG9jYXRpbmcgdGhlIFNjcm9sbEFu aW1hdG9yIHVwLWZyb250LCBiZWNhdXNlIHdlCisgICAgICAgIGNyZWF0ZSBsb3RzIG9mIFNjcm9s bGFibGVBcmVhcyB2aWEgUmVuZGVyTGF5ZXIsIGFuZCB3ZSBzaG91bGQKKyAgICAgICAgb25seSBu ZWVkIHRoZSBhbmltYXRvciB3aGVuIHNjcm9sbGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL1Nj cm9sbGFibGVBcmVhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGFibGVBcmVhOjpTY3Jv bGxhYmxlQXJlYSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxhYmxlQXJlYTo6ZW5zdXJlU2Ny b2xsQW5pbWF0b3IpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYWJsZUFyZWE6OnNjcm9sbCk6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxhYmxlQXJlYTo6c2Nyb2xsVG9PZmZzZXRXaXRob3V0 QW5pbWF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGFibGVBcmVhOjpzY3JvbGxUb1hP ZmZzZXRXaXRob3V0QW5pbWF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGFibGVBcmVh OjpzY3JvbGxUb1lPZmZzZXRXaXRob3V0QW5pbWF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbGFibGVBcmVhOjpoYW5kbGVXaGVlbEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bGFibGVBcmVhOjpoYW5kbGVHZXN0dXJlRXZlbnQpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9s bGFibGVBcmVhLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxhYmxlQXJlYTo6c2Nyb2xsQW5p bWF0b3IpOgorCisyMDExLTA1LTA1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCiAKICAgICAgICAgRXZlcnkg UmVuZGVyTGF5ZXIgcmVnaXN0ZXJzIGl0c2VsZiBhcyBhIFNjcm9sbGFibGVBcmVhCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAKaW5kZXggMTAzMzgwNjdmM2MzNjY3 MDViNzk5NzU0OTAzYTUwOGQ2ZWZmNjg5Ny4uMDE1YWM0ODcyODFmODFlNTlkYWQ4MWI4MDVjZTcy MGI0ZjJiOTViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJs ZUFyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmNw cApAQCAtNDMsOCArNDMsNyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBTY3JvbGxhYmxlQXJl YTo6U2Nyb2xsYWJsZUFyZWEoKQotICAgIDogbV9zY3JvbGxBbmltYXRvcihTY3JvbGxBbmltYXRv cjo6Y3JlYXRlKHRoaXMpKQotICAgICwgbV9jb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250ZW50RWRn ZSh0cnVlKQorICAgIDogbV9jb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250ZW50RWRnZSh0cnVlKQog ICAgICwgbV9pbkxpdmVSZXNpemUoZmFsc2UpCiAgICAgLCBtX3ZlcnRpY2FsU2Nyb2xsRWxhc3Rp Y2l0eShTY3JvbGxFbGFzdGljaXR5Tm9uZSkKICAgICAsIG1faG9yaXpvbnRhbFNjcm9sbEVsYXN0 aWNpdHkoU2Nyb2xsRWxhc3RpY2l0eU5vbmUpCkBAIC01NSw2ICs1NCwxMiBAQCBTY3JvbGxhYmxl QXJlYTo6flNjcm9sbGFibGVBcmVhKCkKIHsKIH0KIAordm9pZCBTY3JvbGxhYmxlQXJlYTo6ZW5z dXJlU2Nyb2xsQW5pbWF0b3IoKSBjb25zdAoreworICAgIGlmICghbV9zY3JvbGxBbmltYXRvcikK KyAgICAgICAgbV9zY3JvbGxBbmltYXRvciA9IFNjcm9sbEFuaW1hdG9yOjpjcmVhdGUodGhpcyk7 Cit9CisKIGJvb2wgU2Nyb2xsYWJsZUFyZWE6OnNjcm9sbChTY3JvbGxEaXJlY3Rpb24gZGlyZWN0 aW9uLCBTY3JvbGxHcmFudWxhcml0eSBncmFudWxhcml0eSwgZmxvYXQgbXVsdGlwbGllcikKIHsK ICAgICBTY3JvbGxiYXJPcmllbnRhdGlvbiBvcmllbnRhdGlvbjsKQEAgLTg5LDEyICs5NCwxMiBA QCBib29sIFNjcm9sbGFibGVBcmVhOjpzY3JvbGwoU2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiwg U2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVsYQogICAgIGlmIChkaXJlY3Rpb24gPT0gU2Nyb2xsVXAg fHwgZGlyZWN0aW9uID09IFNjcm9sbExlZnQpCiAgICAgICAgIG11bHRpcGxpZXIgPSAtbXVsdGlw bGllcjsKIAotICAgIHJldHVybiBtX3Njcm9sbEFuaW1hdG9yLT5zY3JvbGwob3JpZW50YXRpb24s IGdyYW51bGFyaXR5LCBzdGVwLCBtdWx0aXBsaWVyKTsKKyAgICByZXR1cm4gc2Nyb2xsQW5pbWF0 b3IoKS0+c2Nyb2xsKG9yaWVudGF0aW9uLCBncmFudWxhcml0eSwgc3RlcCwgbXVsdGlwbGllcik7 CiB9CiAKIHZvaWQgU2Nyb2xsYWJsZUFyZWE6OnNjcm9sbFRvT2Zmc2V0V2l0aG91dEFuaW1hdGlv bihjb25zdCBGbG9hdFBvaW50JiBvZmZzZXQpCiB7Ci0gICAgbV9zY3JvbGxBbmltYXRvci0+c2Ny b2xsVG9PZmZzZXRXaXRob3V0QW5pbWF0aW9uKG9mZnNldCk7CisgICAgc2Nyb2xsQW5pbWF0b3Io KS0+c2Nyb2xsVG9PZmZzZXRXaXRob3V0QW5pbWF0aW9uKG9mZnNldCk7CiB9CiAKIHZvaWQgU2Ny b2xsYWJsZUFyZWE6OnNjcm9sbFRvT2Zmc2V0V2l0aG91dEFuaW1hdGlvbihTY3JvbGxiYXJPcmll bnRhdGlvbiBvcmllbnRhdGlvbiwgZmxvYXQgb2Zmc2V0KQpAQCAtMTA3LDIzICsxMTIsMjMgQEAg dm9pZCBTY3JvbGxhYmxlQXJlYTo6c2Nyb2xsVG9PZmZzZXRXaXRob3V0QW5pbWF0aW9uKFNjcm9s bGJhck9yaWVudGF0aW9uIG9yaWVudGEKIAogdm9pZCBTY3JvbGxhYmxlQXJlYTo6c2Nyb2xsVG9Y T2Zmc2V0V2l0aG91dEFuaW1hdGlvbihmbG9hdCB4KQogewotICAgIHNjcm9sbFRvT2Zmc2V0V2l0 aG91dEFuaW1hdGlvbihGbG9hdFBvaW50KHgsIG1fc2Nyb2xsQW5pbWF0b3ItPmN1cnJlbnRQb3Np dGlvbigpLnkoKSkpOworICAgIHNjcm9sbFRvT2Zmc2V0V2l0aG91dEFuaW1hdGlvbihGbG9hdFBv aW50KHgsIHNjcm9sbEFuaW1hdG9yKCktPmN1cnJlbnRQb3NpdGlvbigpLnkoKSkpOwogfQogCiB2 b2lkIFNjcm9sbGFibGVBcmVhOjpzY3JvbGxUb1lPZmZzZXRXaXRob3V0QW5pbWF0aW9uKGZsb2F0 IHkpCiB7Ci0gICAgc2Nyb2xsVG9PZmZzZXRXaXRob3V0QW5pbWF0aW9uKEZsb2F0UG9pbnQobV9z Y3JvbGxBbmltYXRvci0+Y3VycmVudFBvc2l0aW9uKCkueCgpLCB5KSk7CisgICAgc2Nyb2xsVG9P ZmZzZXRXaXRob3V0QW5pbWF0aW9uKEZsb2F0UG9pbnQoc2Nyb2xsQW5pbWF0b3IoKS0+Y3VycmVu dFBvc2l0aW9uKCkueCgpLCB5KSk7CiB9CiAKIHZvaWQgU2Nyb2xsYWJsZUFyZWE6OmhhbmRsZVdo ZWVsRXZlbnQoUGxhdGZvcm1XaGVlbEV2ZW50JiB3aGVlbEV2ZW50KQogewotICAgIG1fc2Nyb2xs QW5pbWF0b3ItPmhhbmRsZVdoZWVsRXZlbnQod2hlZWxFdmVudCk7CisgICAgc2Nyb2xsQW5pbWF0 b3IoKS0+aGFuZGxlV2hlZWxFdmVudCh3aGVlbEV2ZW50KTsKIH0KIAogI2lmIEVOQUJMRShHRVNU VVJFX0VWRU5UUykKIHZvaWQgU2Nyb2xsYWJsZUFyZWE6OmhhbmRsZUdlc3R1cmVFdmVudChjb25z dCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogewotICAgIG1fc2Nyb2xsQW5p bWF0b3ItPmhhbmRsZUdlc3R1cmVFdmVudChnZXN0dXJlRXZlbnQpOworICAgIHNjcm9sbEFuaW1h dG9yKCktPmhhbmRsZUdlc3R1cmVFdmVudChnZXN0dXJlRXZlbnQpOwogfQogI2VuZGlmCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oCmluZGV4IDMwZGI3ZDFkY2QwMmY3 ODI4NzI3YWVkNDA3NTFkYmFhNzI5ZWFiNGQuLmQ2MmMzNjYzMDVmZDQwYjBkNTRlNDkzMTM1ODFm MWI2YWI0NjNkNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFi bGVBcmVhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuaApA QCAtNzksNyArNzksNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBoYXNPdmVybGF5U2Nyb2xsYmFycygp IGNvbnN0OwogICAgIHZpcnR1YWwgU2Nyb2xsYmFyT3ZlcmxheVN0eWxlIHJlY29tbWVuZGVkU2Ny b2xsYmFyT3ZlcmxheVN0eWxlKCkgY29uc3QgeyByZXR1cm4gU2Nyb2xsYmFyT3ZlcmxheVN0eWxl RGVmYXVsdDsgfQogCi0gICAgU2Nyb2xsQW5pbWF0b3IqIHNjcm9sbEFuaW1hdG9yKCkgY29uc3Qg eyByZXR1cm4gbV9zY3JvbGxBbmltYXRvci5nZXQoKTsgfQorICAgIFNjcm9sbEFuaW1hdG9yKiBz Y3JvbGxBbmltYXRvcigpIGNvbnN0IHsgZW5zdXJlU2Nyb2xsQW5pbWF0b3IoKTsgcmV0dXJuIG1f c2Nyb2xsQW5pbWF0b3IuZ2V0KCk7IH0KICAgICBjb25zdCBJbnRQb2ludCYgc2Nyb2xsT3JpZ2lu KCkgY29uc3QgeyByZXR1cm4gbV9zY3JvbGxPcmlnaW47IH0KIAogICAgIHZpcnR1YWwgYm9vbCBp c0FjdGl2ZSgpIGNvbnN0ID0gMDsKQEAgLTEzOSw3ICsxMzksOSBAQCBwcml2YXRlOgogICAgIGZy aWVuZCBjbGFzcyBTY3JvbGxBbmltYXRvcjsKICAgICB2b2lkIHNldFNjcm9sbE9mZnNldEZyb21B bmltYXRpb24oY29uc3QgSW50UG9pbnQmKTsKIAotICAgIE93blB0cjxTY3JvbGxBbmltYXRvcj4g bV9zY3JvbGxBbmltYXRvcjsKKyAgICB2b2lkIGVuc3VyZVNjcm9sbEFuaW1hdG9yKCkgY29uc3Q7 CisgICAgCisgICAgbXV0YWJsZSBPd25QdHI8U2Nyb2xsQW5pbWF0b3I+IG1fc2Nyb2xsQW5pbWF0 b3I7CiAgICAgYm9vbCBtX2NvbnN0cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlOwogCiAgICAg Ym9vbCBtX2luTGl2ZVJlc2l6ZTsK