6032 2005-12-10 11:45:47 -0800 REGRESSION: Uncaught exception when image is dragged out of webpage 2005-12-10 12:38:50 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P1 Major --- 1 joost darin oldest_to_newest 25776 0 joost 2005-12-10 11:45:47 -0800 This results in a crash in development build. 25777 1 5021 darin 2005-12-10 11:47:26 -0800 Created attachment 5021 patch to straighten out NSImage vs. image renderer a bit more 25778 2 5021 sullivan 2005-12-10 12:22:34 -0800 Comment on attachment 5021 patch to straighten out NSImage vs. image renderer a bit more Looks good 5021 2005-12-10 11:47:26 -0800 2005-12-10 12:22:34 -0800 patch to straighten out NSImage vs. image renderer a bit more ImageRendererPatch.txt text/plain 7128 darin SW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5leHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L1dlYkNvcmUvV2ViQ29yZS5leHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDYKZGlmZiAtcCAt dSAtcjEuNDYgV2ViQ29yZS9XZWJDb3JlLmV4cAotLS0gV2ViQ29yZS9XZWJDb3JlLmV4cAk5IE9j dCAyMDA1IDA0OjE3OjMxIC0wMDAwCTEuNDYKKysrIFdlYkNvcmUvV2ViQ29yZS5leHAJMTAgRGVj IDIwMDUgMTk6NDI6MjMgLTAwMDAKQEAgLTEyMSw4ICsxMjEsOCBAQAogX1dlYkNvcmVFbGVtZW50 RE9NTm9kZUtleQogX1dlYkNvcmVFbGVtZW50RnJhbWVLZXkKIF9XZWJDb3JlRWxlbWVudEltYWdl QWx0U3RyaW5nS2V5Ci1fV2ViQ29yZUVsZW1lbnRJbWFnZUtleQogX1dlYkNvcmVFbGVtZW50SW1h Z2VSZWN0S2V5CitfV2ViQ29yZUVsZW1lbnRJbWFnZVJlbmRlcmVyS2V5CiBfV2ViQ29yZUVsZW1l bnRJbWFnZVVSTEtleQogX1dlYkNvcmVFbGVtZW50SXNTZWxlY3RlZEtleQogX1dlYkNvcmVFbGVt ZW50TGlua0xhYmVsS2V5CkluZGV4OiBXZWJDb3JlL2t3cS9XZWJDb3JlQnJpZGdlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva3dxL1dlYkNvcmVCcmlkZ2UuaCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4zNTMKZGlmZiAtcCAtdSAtcjEuMzUzIFdlYkNvcmUva3dxL1dl YkNvcmVCcmlkZ2UuaAotLS0gV2ViQ29yZS9rd3EvV2ViQ29yZUJyaWRnZS5oCTYgRGVjIDIwMDUg MDA6MjM6NDkgLTAwMDAJMS4zNTMKKysrIFdlYkNvcmUva3dxL1dlYkNvcmVCcmlkZ2UuaAkxMCBE ZWMgMjAwNSAxOTo0MjoyNiAtMDAwMApAQCAtNzMsNyArNzMsNyBAQCB0eXBlZGVmIGtodG1sOjpS ZW5kZXJQYXJ0IEtIVE1MUmVuZGVyUGFyCiBleHRlcm4gTlNTdHJpbmcgKldlYkNvcmVFbGVtZW50 RE9NTm9kZUtleTsKIGV4dGVybiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRGcmFtZUtleTsKIGV4 dGVybiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJbWFnZUFsdFN0cmluZ0tleTsKLWV4dGVybiBO U1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJbWFnZUtleTsKK2V4dGVybiBOU1N0cmluZyAqV2ViQ29y ZUVsZW1lbnRJbWFnZVJlbmRlcmVyS2V5OwogZXh0ZXJuIE5TU3RyaW5nICpXZWJDb3JlRWxlbWVu dEltYWdlUmVjdEtleTsKIGV4dGVybiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJbWFnZVVSTEtl eTsKIGV4dGVybiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJc1NlbGVjdGVkS2V5OwpJbmRleDog V2ViQ29yZS9rd3EvV2ViQ29yZUJyaWRnZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvV2ViQ29yZS9rd3EvV2ViQ29yZUJyaWRnZS5tbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40 NDAKZGlmZiAtcCAtdSAtcjEuNDQwIFdlYkNvcmUva3dxL1dlYkNvcmVCcmlkZ2UubW0KLS0tIFdl YkNvcmUva3dxL1dlYkNvcmVCcmlkZ2UubW0JMTAgRGVjIDIwMDUgMTc6MTQ6MzggLTAwMDAJMS40 NDAKKysrIFdlYkNvcmUva3dxL1dlYkNvcmVCcmlkZ2UubW0JMTAgRGVjIDIwMDUgMTk6NDI6Mjgg LTAwMDAKQEAgLTE0Nyw3ICsxNDcsNyBAQCB1c2luZyBLSlM6OkJpbmRpbmdzOjpSb290T2JqZWN0 OwogTlNTdHJpbmcgKldlYkNvcmVFbGVtZW50RE9NTm9kZUtleSA9ICAgICAgICAgICAgQCJXZWJF bGVtZW50RE9NTm9kZSI7CiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRGcmFtZUtleSA9ICAgICAg ICAgICAgICBAIldlYkVsZW1lbnRGcmFtZSI7CiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJbWFn ZUFsdFN0cmluZ0tleSA9IAlAIldlYkVsZW1lbnRJbWFnZUFsdFN0cmluZyI7Ci1OU1N0cmluZyAq V2ViQ29yZUVsZW1lbnRJbWFnZUtleSA9ICAgICAgICAgICAgICBAIldlYkVsZW1lbnRJbWFnZSI7 CitOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJbWFnZVJlbmRlcmVyS2V5ID0gICAgICBAIldlYkNv cmVFbGVtZW50SW1hZ2VSZW5kZXJlciI7CiBOU1N0cmluZyAqV2ViQ29yZUVsZW1lbnRJbWFnZVJl Y3RLZXkgPSAgICAgICAgICBAIldlYkVsZW1lbnRJbWFnZVJlY3QiOwogTlNTdHJpbmcgKldlYkNv cmVFbGVtZW50SW1hZ2VVUkxLZXkgPSAgICAgICAgICAgQCJXZWJFbGVtZW50SW1hZ2VVUkwiOwog TlNTdHJpbmcgKldlYkNvcmVFbGVtZW50SXNTZWxlY3RlZEtleSA9ICAgICAgICAgQCJXZWJFbGVt ZW50SXNTZWxlY3RlZCI7CkBAIC0xMTE3LDkgKzExMTcsOCBAQCBzdGF0aWMgSFRNTEZvcm1FbGVt ZW50SW1wbCAqZm9ybUVsZW1lbnRGCiAgICAgICAgICAgICBSZW5kZXJJbWFnZSAqciA9IHN0YXRp Y19jYXN0PFJlbmRlckltYWdlICo+KG5vZGUtPnJlbmRlcmVyKCkpOwogICAgICAgICAgICAgaWYg KCFyLT5pc0Rpc3BsYXlpbmdFcnJvcigpKSB7CiAgICAgICAgICAgICAgICAgUVBpeG1hcCBwID0g ci0+cGl4bWFwKCk7Ci0gICAgICAgICAgICAgICAgTlNJbWFnZSAqaW1hZ2UgPSBbcC5pbWFnZVJl bmRlcmVyKCkgaW1hZ2VdOwotICAgICAgICAgICAgICAgIGlmIChpbWFnZSkKLSAgICAgICAgICAg ICAgICAgICAgW2VsZW1lbnQgc2V0T2JqZWN0OmltYWdlIGZvcktleTpXZWJDb3JlRWxlbWVudElt YWdlS2V5XTsKKyAgICAgICAgICAgICAgICBpZiAocC5pbWFnZVJlbmRlcmVyKCkpCisgICAgICAg ICAgICAgICAgICAgIFtlbGVtZW50IHNldE9iamVjdDpwLmltYWdlUmVuZGVyZXIoKSBmb3JLZXk6 V2ViQ29yZUVsZW1lbnRJbWFnZVJlbmRlcmVyS2V5XTsKICAgICAgICAgICAgIH0KIAogICAgICAg ICAgICAgaW50IHgsIHk7CkBAIC0xODAxLDcgKzE4MDAsNyBAQCBzdGF0aWMgSFRNTEZvcm1FbGVt ZW50SW1wbCAqZm9ybUVsZW1lbnRGCiB9CiAKIC8vIERldGVybWluZXMgd2hldGhlciB3aGl0ZXNw YWNlIG5lZWRzIHRvIGJlIGFkZGVkIGFyb3VuZCBhU3RyaW5nIHRvIHByZXNlcnZlIHByb3BlciBz cGFjaW5nIGFuZAotLy8gcHVuY3R1YXRpb24gd2hlbiBpdNVzIGluc2VydGVkIGludG8gdGhlIHJl Y2VpdmVy1XMgdGV4dCBvdmVyIGNoYXJSYW5nZS4gUmV0dXJucyBieSByZWZlcmVuY2UKKy8vIHB1 bmN0dWF0aW9uIHdoZW4gaXTigJlzIGluc2VydGVkIGludG8gdGhlIHJlY2VpdmVy4oCZcyB0ZXh0 IG92ZXIgY2hhclJhbmdlLiBSZXR1cm5zIGJ5IHJlZmVyZW5jZQogLy8gaW4gYmVmb3JlU3RyaW5n IGFuZCBhZnRlclN0cmluZyBhbnkgd2hpdGVzcGFjZSB0aGF0IHNob3VsZCBiZSBhZGRlZCwgdW5s ZXNzIGVpdGhlciBvciBib3RoIGFyZQogLy8gbmlsLiBCb3RoIGFyZSByZXR1cm5lZCBhcyBuaWwg aWYgYVN0cmluZyBpcyBuaWwgb3IgaWYgc21hcnQgaW5zZXJ0aW9uIGFuZCBkZWxldGlvbiBhcmUg ZGlzYWJsZWQuCiAtICh2b2lkKXNtYXJ0SW5zZXJ0Rm9yU3RyaW5nOihOU1N0cmluZyAqKXBhc3Rl U3RyaW5nIHJlcGxhY2luZ1JhbmdlOihET01SYW5nZSAqKXJhbmdlVG9SZXBsYWNlIGJlZm9yZVN0 cmluZzooTlNTdHJpbmcgKiopYmVmb3JlU3RyaW5nIGFmdGVyU3RyaW5nOihOU1N0cmluZyAqKilh ZnRlclN0cmluZwpJbmRleDogV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkhU TUxWaWV3Lm0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDg4CmRpZmYgLXAgLXUgLXIxLjQ4OCBX ZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0KLS0tIFdlYktpdC9XZWJWaWV3LnN1 YnByb2ovV2ViSFRNTFZpZXcubQk5IERlYyAyMDA1IDAyOjEyOjM0IC0wMDAwCTEuNDg4CisrKyBX ZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0JMTAgRGVjIDIwMDUgMTk6NDI6NTcg LTAwMDAKQEAgLTEyNjAsNyArMTI2MCw3IEBAIHN0YXRpYyBXZWJIVE1MVmlldyAqbGFzdEhpdFZp ZXcgPSBuaWw7CiAgICAgCiAgICAgV2ViVmlldyAqd2ViVmlldyA9IFtzZWxmIF93ZWJWaWV3XTsK ICAgICBOU1Bhc3RlYm9hcmQgKnBhc3RlYm9hcmQgPSBbTlNQYXN0ZWJvYXJkIHBhc3RlYm9hcmRX aXRoTmFtZTpOU0RyYWdQYm9hcmRdOwotICAgIFdlYkltYWdlUmVuZGVyZXIgKmltYWdlID0gW2Vs ZW1lbnQgb2JqZWN0Rm9yS2V5OldlYkVsZW1lbnRJbWFnZUtleV07CisgICAgV2ViSW1hZ2VSZW5k ZXJlciAqaW1hZ2UgPSBbZWxlbWVudCBvYmplY3RGb3JLZXk6V2ViQ29yZUVsZW1lbnRJbWFnZVJl bmRlcmVyS2V5XTsKICAgICBCT09MIHN0YXJ0ZWREcmFnID0gWUVTOyAgLy8gb3B0aW1pc20gLSB3 ZSBhbG1vc3QgYWx3YXlzIG1hbmFnZSB0byBzdGFydCB0aGUgZHJhZwogCiAgICAgLy8gbm90ZSBw ZXIga3dlYnN0ZXIsIHRoZSBvZmZzZXQgYXJnIGJlbG93IGlzIGFsd2F5cyBpZ25vcmVkIGluIHBv c2l0aW9uaW5nIHRoZSBpbWFnZQpAQCAtMTI4MCw3ICsxMjgwLDcgQEAgc3RhdGljIFdlYkhUTUxW aWV3ICpsYXN0SGl0VmlldyA9IG5pbDsKICAgICAgICAgfQogICAgICAgICBbW3dlYlZpZXcgX1VJ RGVsZWdhdGVGb3J3YXJkZXJdIHdlYlZpZXc6d2ViVmlldyB3aWxsUGVyZm9ybURyYWdTb3VyY2VB Y3Rpb246V2ViRHJhZ1NvdXJjZUFjdGlvbkltYWdlIGZyb21Qb2ludDptb3VzZURvd25Qb2ludCB3 aXRoUGFzdGVib2FyZDpwYXN0ZWJvYXJkXTsKICAgICAgICAgaWYgKGRyYWdJbWFnZSA9PSBuaWwp IHsKLSAgICAgICAgICAgIFtzZWxmIF93ZWJfZHJhZ0ltYWdlOltlbGVtZW50IG9iamVjdEZvcktl eTpXZWJFbGVtZW50SW1hZ2VLZXldCisgICAgICAgICAgICBbc2VsZiBfd2ViX2RyYWdJbWFnZTpb ZWxlbWVudCBvYmplY3RGb3JLZXk6V2ViQ29yZUVsZW1lbnRJbWFnZVJlbmRlcmVyS2V5XQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJlY3Q6W1tlbGVtZW50IG9iamVjdEZvcktleTpXZWJF bGVtZW50SW1hZ2VSZWN0S2V5XSByZWN0VmFsdWVdCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICBldmVudDpfcHJpdmF0ZS0+bW91c2VEb3duRXZlbnQKICAgICAgICAgICAgICAgICAgICAgICBw YXN0ZWJvYXJkOnBhc3RlYm9hcmQKQEAgLTI4NjIsOSArMjg2MiwxMiBAQCBkb25lOgogICAgIE5T RGljdGlvbmFyeSAqZWxlbWVudEluZm9XQyA9IFtbc2VsZiBfYnJpZGdlXSBlbGVtZW50QXRQb2lu dDpwb2ludF07CiAgICAgTlNNdXRhYmxlRGljdGlvbmFyeSAqZWxlbWVudEluZm8gPSBbZWxlbWVu dEluZm9XQyBtdXRhYmxlQ29weV07CiAgICAgCi0gICAgLy8gQ29udmVydCBVUkwgc3RyaW5ncyB0 byBOU1VSTHMKKyAgICAvLyBDb252ZXJ0IFVSTCBzdHJpbmdzIHRvIE5TVVJMcy4KICAgICBbZWxl bWVudEluZm8gX3dlYl9zZXRPYmplY3RJZk5vdE5pbDpbTlNVUkwgX3dlYl9VUkxXaXRoRGF0YUFz U3RyaW5nOltlbGVtZW50SW5mb1dDIG9iamVjdEZvcktleTpXZWJFbGVtZW50TGlua1VSTEtleV1d IGZvcktleTpXZWJFbGVtZW50TGlua1VSTEtleV07CiAgICAgW2VsZW1lbnRJbmZvIF93ZWJfc2V0 T2JqZWN0SWZOb3ROaWw6W05TVVJMIF93ZWJfVVJMV2l0aERhdGFBc1N0cmluZzpbZWxlbWVudElu Zm9XQyBvYmplY3RGb3JLZXk6V2ViRWxlbWVudEltYWdlVVJMS2V5XV0gZm9yS2V5OldlYkVsZW1l bnRJbWFnZVVSTEtleV07CisKKyAgICAvLyBDb252ZXJ0IGltYWdlIHJlbmRlcmVyIHRvIE5TSW1h Z2UuCisgICAgW2VsZW1lbnRJbmZvIF93ZWJfc2V0T2JqZWN0SWZOb3ROaWw6W1tlbGVtZW50SW5m b1dDIG9iamVjdEZvcktleTpXZWJDb3JlRWxlbWVudEltYWdlUmVuZGVyZXJLZXldIGltYWdlXSBm b3JLZXk6V2ViRWxlbWVudEltYWdlS2V5XTsKICAgICAKICAgICBXZWJGcmFtZVZpZXcgKndlYkZy YW1lVmlldyA9IFtzZWxmIF93ZWJfcGFyZW50V2ViRnJhbWVWaWV3XTsKICAgICBBU1NFUlQod2Vi RnJhbWVWaWV3KTsKSW5kZXg6IFdlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViVmlldy5tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcu bSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMTUKZGlmZiAtcCAtdSAtcjEuMzE1IFdlYktpdC9X ZWJWaWV3LnN1YnByb2ovV2ViVmlldy5tCi0tLSBXZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlZp ZXcubQkxMCBEZWMgMjAwNSAwNDo1MjowMyAtMDAwMAkxLjMxNQorKysgV2ViS2l0L1dlYlZpZXcu c3VicHJvai9XZWJWaWV3Lm0JMTAgRGVjIDIwMDUgMTk6NDM6MDAgLTAwMDAKQEAgLTEzMDksNyAr MTMwOSw3IEBAIHN0YXRpYyBib29sIGRlYnVnV2lkZ2V0ID0gdHJ1ZTsKIC0gKHZvaWQpX3dyaXRl SW1hZ2VFbGVtZW50OihOU0RpY3Rpb25hcnkgKillbGVtZW50IHdpdGhQYXN0ZWJvYXJkVHlwZXM6 KE5TQXJyYXkgKil0eXBlcyB0b1Bhc3RlYm9hcmQ6KE5TUGFzdGVib2FyZCAqKXBhc3RlYm9hcmQK IHsKICAgICBOU1VSTCAqbGlua1VSTCA9IFtlbGVtZW50IG9iamVjdEZvcktleTpXZWJFbGVtZW50 TGlua1VSTEtleV07Ci0gICAgW3Bhc3RlYm9hcmQgX3dlYl93cml0ZUltYWdlOltlbGVtZW50IG9i amVjdEZvcktleTpXZWJFbGVtZW50SW1hZ2VLZXldIAorICAgIFtwYXN0ZWJvYXJkIF93ZWJfd3Jp dGVJbWFnZTpbZWxlbWVudCBvYmplY3RGb3JLZXk6V2ViQ29yZUVsZW1lbnRJbWFnZVJlbmRlcmVy S2V5XSAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBVUkw6bGlua1VSTCA/IGxpbmtVUkwg OiAoTlNVUkwgKilbZWxlbWVudCBvYmplY3RGb3JLZXk6V2ViRWxlbWVudEltYWdlVVJMS2V5XQog ICAgICAgICAgICAgICAgICAgICAgICAgICB0aXRsZTpbZWxlbWVudCBvYmplY3RGb3JLZXk6V2Vi RWxlbWVudEltYWdlQWx0U3RyaW5nS2V5XSAKICAgICAgICAgICAgICAgICAgICAgICAgIGFyY2hp dmU6W1tlbGVtZW50IG9iamVjdEZvcktleTpXZWJFbGVtZW50RE9NTm9kZUtleV0gd2ViQXJjaGl2 ZV0K