60310 2011-05-05 16:18:56 -0700 update-webkit should handle Internal using a different VCS than OpenSource. 2011-05-05 22:42:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes dbates oldest_to_newest 399151 0 aestes 2011-05-05 16:18:56 -0700 update-webkit should handle Internal using a different VCS than OpenSource. 399156 1 92492 aestes 2011-05-05 16:22:31 -0700 Created attachment 92492 Patch 399158 2 92492 abarth 2011-05-05 16:25:14 -0700 Comment on attachment 92492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review > Tools/ChangeLog:8 > + isGit() and isSVN() cache their results, so Internal will always be Are these methods used anywhere anymore? Maybe they can be removed? 399160 3 92492 dbates 2011-05-05 16:28:50 -0700 Comment on attachment 92492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review OK >> Tools/ChangeLog:8 >> + isGit() and isSVN() cache their results, so Internal will always be > > Are these methods used anywhere anymore? Maybe they can be removed? Yes, these functions are used in svn-apply and svn-unapply. 399161 4 aestes 2011-05-05 16:29:08 -0700 (In reply to comment #2) > (From update of attachment 92492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review > > > Tools/ChangeLog:8 > > + isGit() and isSVN() cache their results, so Internal will always be > > Are these methods used anywhere anymore? Maybe they can be removed? Yes, in svn-apply, svn-unapply and commit-log-editor. They could be removed and replaced with is(SVN|Git)Directory('.'), but that might slow down these commands if they make these checks repeatedly. 399339 5 dbates 2011-05-05 22:42:19 -0700 This was committed in changeset 85898 <http://trac.webkit.org/changeset/85898>. 92492 2011-05-05 16:22:31 -0700 2011-05-05 16:28:50 -0700 Patch bug-60310-20110505162230.patch text/plain 1588 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogODU4OTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODQ5ZTMyZWM2NDBlY2Y2ZjBkNjQ0YTgxNzJkZWJjMzIx NWIyYzg4Li4yMzA4OTcxMDFlMjU4Mjk1OWE4NTZlYTNhMDdmYmFkYzc5NWQ5NjY3IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDUtMDUgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHVwZGF0ZS13ZWJraXQgc2hv dWxkIGhhbmRsZSBJbnRlcm5hbCB1c2luZyBhIGRpZmZlcmVudCBWQ1MgdGhhbiBPcGVuU291cmNl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAzMTAK KworICAgICAgICBpc0dpdCgpIGFuZCBpc1NWTigpIGNhY2hlIHRoZWlyIHJlc3VsdHMsIHNvIElu dGVybmFsIHdpbGwgYWx3YXlzIGJlCisgICAgICAgIHVwZGF0ZWQgdXNpbmcgdGhlIFZDUyBjb21t YW5kcyB1c2VkIGZvciBPcGVuU291cmNlLiBJZiBJbnRlcm5hbCB1c2VzIGEKKyAgICAgICAgZGlm ZmVyZW50IFZDUywgdGhpcyB3aWxsIGZhaWwuIEZpeCB0aGlzIGJ5IGNhbGxpbmcgaXNHaXREaXJl Y3RvcnkoKSBhbmQKKyAgICAgICAgaXNTVk5EaXJlY3RvcnkoKSBpbnN0ZWFkLCB3aGljaCBkbyBu b3QgY2FjaGUgdGhlaXIgcmVzdWx0cy4KKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtp dDoKKwogMjAxMS0wNS0wNSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy91cGRhdGUtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CmluZGV4IDVhMWEw ZDcyYjIwNjU1MGIxNTA4NmIxMTg3OGUwNzZhNWU5NzZiOTkuLmUxOTI0MzhhMjFkNmVmMjMwYTUx ZDk2N2ZkMzNjODljM2QzNDBhOGQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdl YmtpdAorKysgYi9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQKQEAgLTg3LDggKzg3LDggQEAg cnVuR2l0VXBkYXRlKCkgaWYgaXNHaXQoKTsKIGlmICgtZCAiLi4vSW50ZXJuYWwiKSB7CiAgICAg Y2hkaXIoIi4uL0ludGVybmFsIik7CiAgICAgcHJpbnQgIlVwZGF0aW5nIEludGVybmFsXG4iIHVu bGVzcyAkcXVpZXQ7Ci0gICAgcnVuU3ZuVXBkYXRlKCkgaWYgaXNTVk4oKTsKLSAgICBydW5HaXRV cGRhdGUoKSBpZiBpc0dpdCgpOworICAgIHJ1blN2blVwZGF0ZSgpIGlmIGlzU1ZORGlyZWN0b3J5 KCIuIik7CisgICAgcnVuR2l0VXBkYXRlKCkgaWYgaXNHaXREaXJlY3RvcnkoIi4iKTsKIH0gZWxz aWYgKGlzQ2hyb21pdW0oKSkgewogICAgICMgV29ya2Fyb3VuZCBmb3IgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4OTI2CiAgICAgIyBXZSBzaG91bGQgcmVtb3ZlIHRo ZSBmb2xsb3dpbmcgImlmIiBibG9jayB3aGVuIHdlIGZpbmQgYSByaWdodCBmaXguCg==