60294 2011-05-05 13:08:47 -0700 WebKit2: Docking Web Inspector doesn't respect maximum inspector size 2011-05-05 16:07:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 bweinstein bweinstein abarth apavlov aroben bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 398956 0 bweinstein 2011-05-05 13:08:47 -0700 Docking the Web Inspector in WebKit2 doesn't respect the maximum inspector size (75% of the total window height). WebKit2 doesn't use the same way of attaching and detaching as WebKit1 on Mac and Windows, and so we need to call constrainAttachedWindowHeight when we lay out the inspector and inspected view's in WebInspectorProxyMac and WebInspectorProxyWin. <rdar://problem/9388518> 398958 1 92455 bweinstein 2011-05-05 13:11:40 -0700 Created attachment 92455 [PATCH] Fix 398959 2 92455 aroben 2011-05-05 13:13:22 -0700 Comment on attachment 92455 [PATCH] Fix Why do we need to do this calculation in WebKit? Doens't WebCore already constrain the height for us? 398960 3 webkit.review.bot 2011-05-05 13:13:41 -0700 Attachment 92455 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 398970 4 bweinstein 2011-05-05 13:22:57 -0700 (In reply to comment #2) > (From update of attachment 92455 [details]) > Why do we need to do this calculation in WebKit? Doens't WebCore already constrain the height for us? WebCore doesn't constrain the height when initially attaching. It constrains the height when opening attached (which we don't do - due to <rdar://problem/9353114>), and it constrains when changing the attached window height. Doing the calculation in WebKit also allows us to handle resizing the inspector when the whole window is resized. 398980 5 bweinstein 2011-05-05 13:31:53 -0700 Landed in r85874. 399140 6 webkit.review.bot 2011-05-05 16:07:01 -0700 http://trac.webkit.org/changeset/85874 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg 92455 2011-05-05 13:11:40 -0700 2011-05-05 13:28:09 -0700 [PATCH] Fix constrain_inspector_mac_win.patch text/plain 5790 bweinstein SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1ODY5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMDUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgYSBuZWVkZWQgZnVuY3Rpb24gcHVibGljIGFu ZCBleHBvcnQgaXQuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjogRXhwb3J0IGNvbnN0cmFp bmVkQXR0YWVjaGVkV2luZG93SGVpZ2h0LgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JG cm9udGVuZENsaWVudExvY2FsLmg6IE1ha2UgY29uc3RyYWluZWRBdHRhZWNoZWRXaW5kb3dIZWln aHQgcHVibGljLgorCiAyMDExLTA1LTA1ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZXhwLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluCShyZXZpc2lvbiA4NTg2NikKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3 b3JraW5nIGNvcHkpCkBAIC0xNTUzLDYgKzE1NTMsNyBAQCBfX1pON1dlYkNvcmUyOEluc3BlY3Rv ckZyb250ZW5kQ2xpZW50TG9jCiBfX1pON1dlYkNvcmUyOEluc3BlY3RvckZyb250ZW5kQ2xpZW50 TG9jYWwyMHNlbmRNZXNzYWdlVG9CYWNrZW5kRVJLTjNXVEY2U3RyaW5nRQogX19aTjdXZWJDb3Jl MjhJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsMjZjaGFuZ2VBdHRhY2hlZFdpbmRvd0hlaWdo dEVqCiBfX1pON1dlYkNvcmUyOEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwyN3Jlc3RvcmVB dHRhY2hlZFdpbmRvd0hlaWdodEV2CitfX1pON1dlYkNvcmUyOEluc3BlY3RvckZyb250ZW5kQ2xp ZW50TG9jYWwzMWNvbnN0cmFpbmVkQXR0YWNoZWRXaW5kb3dIZWlnaHRFamoKIF9fWk43V2ViQ29y ZTI4SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbEMyRVBOU18xOUluc3BlY3RvckNvbnRyb2xs ZXJFUE5TXzRQYWdlRU4zV1RGMTBQYXNzT3duUHRySU5TMF84U2V0dGluZ3NFRUUKIF9fWk43V2Vi Q29yZTI4SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbEQyRXYKIF9fWk5LN1dlYkNvcmUxOUlu c3BlY3RvckNvbnRyb2xsZXIxN2RyYXdOb2RlSGlnaGxpZ2h0RVJOU18xNUdyYXBoaWNzQ29udGV4 dEUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVu dExvY2FsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckZyb250ZW5kQ2xpZW50TG9jYWwuaAkocmV2aXNpb24gODU4NjYpCisrKyBTb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5oCSh3b3JraW5nIGNvcHkp CkBAIC03MiwxNCArNzIsMTQgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIHNlbmRNZXNz YWdlVG9CYWNrZW5kKGNvbnN0IFN0cmluZyYgbWVzc2FnZSk7CiAKKyAgICBzdGF0aWMgdW5zaWdu ZWQgY29uc3RyYWluZWRBdHRhY2hlZFdpbmRvd0hlaWdodCh1bnNpZ25lZCBwcmVmZXJyZWRIZWln aHQsIHVuc2lnbmVkIHRvdGFsV2luZG93SGVpZ2h0KTsKKwogcHJvdGVjdGVkOgogICAgIHZpcnR1 YWwgdm9pZCBzZXRBdHRhY2hlZFdpbmRvd0hlaWdodCh1bnNpZ25lZCkgPSAwOwogICAgIHZvaWQg c2V0QXR0YWNoZWRXaW5kb3coYm9vbCk7CiAgICAgdm9pZCByZXN0b3JlQXR0YWNoZWRXaW5kb3dI ZWlnaHQoKTsKIAogcHJpdmF0ZToKLSAgICBzdGF0aWMgdW5zaWduZWQgY29uc3RyYWluZWRBdHRh Y2hlZFdpbmRvd0hlaWdodCh1bnNpZ25lZCBwcmVmZXJyZWRIZWlnaHQsIHVuc2lnbmVkIHRvdGFs V2luZG93SGVpZ2h0KTsKLQogICAgIGZyaWVuZCBjbGFzcyBGcm9udGVuZE1lbnVQcm92aWRlcjsK ICAgICBJbnNwZWN0b3JDb250cm9sbGVyKiBtX2luc3BlY3RvckNvbnRyb2xsZXI7CiAgICAgUGFn ZSogbV9mcm9udGVuZFBhZ2U7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA4NTg2OSkKKysrIFNv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisy MDExLTA1LTA1ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQyOiBEb2Nr aW5nIFdlYiBJbnNwZWN0b3IgZG9lc24ndCByZXNwZWN0IG1heGltdW0gaW5zcGVjdG9yIHNpemUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMjk0Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS85Mzg4NTE4PgorICAgICAgICAKKyAgICAgICAgQmVmb3Jl IHdlIHBsYWNlIHRoZSBpbnNwZWN0b3IgYW5kIHRoZSBpbnNwZWN0ZWQgdmlld3MsIG1ha2Ugc3Vy ZSB0aGF0IHdlIGhhdmUgY29uc3RyYWluZWQgdGhlIGhlaWdodAorICAgICAgICBvZiB0aGUgZG9j a2VkIGluc3BlY3Rvci4gUHV0dGluZyB0aGUgY29kZSBoZXJlIGNvdmVycyBib3RoIHdoZW4gdGhl IGluc3BlY3RvciBpcyBpbml0aWFsbHkgYXR0YWNoZWQgCisgICAgICAgIGFuZCB3aGVuIGEgd2lu ZG93IHdpdGggdGhlIGRvY2tlZCBpbnNwZWN0b3IgaXMgcmVzaXplZC4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW06CisgICAgICAgIChXZWJLaXQ6Oldl Ykluc3BlY3RvclByb3h5OjppbnNwZWN0ZWRWaWV3RnJhbWVEaWRDaGFuZ2UpOiBDb25zdHJhaW4g dGhlIGhlaWdodCBiZWZvcmUgbGF5aW5nIG91dCB0aGUgdmlld3MuCisgICAgICAgICogVUlQcm9j ZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklu c3BlY3RvclByb3h5OjpvbldlYlZpZXdXaW5kb3dQb3NDaGFuZ2luZ0V2ZW50KTogRGl0dG8uCisK IDIwMTEtMDUtMDUgIENoYW5nIFNodSAgPGNzaHVAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCShyZXZpc2lvbiA4NTg2NikKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0JKHdv cmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAKICNpbXBvcnQgIldlYlBhZ2VQcm94eS5oIgog I2ltcG9ydCAiV2ViUHJvY2Vzc1Byb3h5LmgiCiAjaW1wb3J0IDxXZWJLaXRTeXN0ZW1JbnRlcmZh Y2UuaD4KKyNpbXBvcnQgPFdlYkNvcmUvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5oPgog I2ltcG9ydCA8V2ViQ29yZS9Mb2NhbGl6ZWRTdHJpbmdzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL05v dEltcGxlbWVudGVkLmg+CiAjaW1wb3J0IDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KQEAgLTE3Niw2 ICsxNzcsOSBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjppbnNwZWN0ZWRWaWV3RnJhCiAgICAg Q0dGbG9hdCBpbnNwZWN0ZWRUb3AgPSBOU01heFkoaW5zcGVjdGVkVmlld0ZyYW1lKTsKICAgICBD R0Zsb2F0IGluc3BlY3RlZFdpZHRoID0gTlNXaWR0aChpbnNwZWN0ZWRWaWV3RnJhbWUpOwogICAg IENHRmxvYXQgaW5zcGVjdG9ySGVpZ2h0ID0gTlNIZWlnaHQoW21faW5zcGVjdG9yVmlldy5nZXQo KSBmcmFtZV0pOworICAgIAorICAgIENHRmxvYXQgcGFyZW50SGVpZ2h0ID0gTlNIZWlnaHQoW1tp bnNwZWN0ZWRWaWV3IHN1cGVydmlld10gZnJhbWVdKTsKKyAgICBpbnNwZWN0b3JIZWlnaHQgPSBJ bnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpjb25zdHJhaW5lZEF0dGFjaGVkV2luZG93SGVp Z2h0KGluc3BlY3RvckhlaWdodCwgcGFyZW50SGVpZ2h0KTsKIAogICAgIFttX2luc3BlY3RvclZp ZXcuZ2V0KCkgc2V0RnJhbWU6TlNNYWtlUmVjdChpbnNwZWN0ZWRMZWZ0LCAwLjAsIGluc3BlY3Rl ZFdpZHRoLCBpbnNwZWN0b3JIZWlnaHQpXTsKICAgICBbaW5zcGVjdGVkVmlldyBzZXRGcmFtZTpO U01ha2VSZWN0KGluc3BlY3RlZExlZnQsIGluc3BlY3RvckhlaWdodCwgaW5zcGVjdGVkV2lkdGgs IGluc3BlY3RlZFRvcCAtIGluc3BlY3RvckhlaWdodCldOwpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHAJKHJldmlz aW9uIDg1ODY2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQ cm94eVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlICJX ZWJQYWdlUHJveHkuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzUHJveHkuaCIKICNpbmNsdWRlICJX ZWJWaWV3LmgiCisjaW5jbHVkZSA8V2ViQ29yZS9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2Fs Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9XZWJDb3JlSW5zdGFuY2VIYW5kbGUuaD4KICNpbmNsdWRl IDxXZWJDb3JlL1dpbmRvd01lc3NhZ2VCcm9hZGNhc3Rlci5oPgogI2luY2x1ZGUgPHd0Zi9QYXNz UmVmUHRyLmg+CkBAIC0xNzcsNiArMTc4LDEwIEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6Om9u V2ViVmlld1dpbmRvd1AKICAgICA6OkdldENsaWVudFJlY3QoaW5zcGVjdG9yV2luZG93LCAmaW5z cGVjdG9yUmVjdCk7CiAgICAgdW5zaWduZWQgaW5zcGVjdG9ySGVpZ2h0ID0gaW5zcGVjdG9yUmVj dC5ib3R0b20gLSBpbnNwZWN0b3JSZWN0LnRvcDsKIAorICAgIFJFQ1QgcGFyZW50UmVjdDsKKyAg ICA6OkdldENsaWVudFJlY3QoOjpHZXRQYXJlbnQoaW5zcGVjdG9yV2luZG93KSwgJnBhcmVudFJl Y3QpOworICAgIGluc3BlY3RvckhlaWdodCA9IEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6 OmNvbnN0cmFpbmVkQXR0YWNoZWRXaW5kb3dIZWlnaHQoaW5zcGVjdG9ySGVpZ2h0LCBwYXJlbnRS ZWN0LmJvdHRvbSAtIHBhcmVudFJlY3QudG9wKTsKKwogICAgIHdpbmRvd1Bvcy0+Y3kgLT0gaW5z cGVjdG9ySGVpZ2h0OwogCiAgICAgOjpTZXRXaW5kb3dQb3MoaW5zcGVjdG9yV2luZG93LCAwLCB3 aW5kb3dQb3MtPngsIHdpbmRvd1Bvcy0+eSArIHdpbmRvd1Bvcy0+Y3ksIHdpbmRvd1Bvcy0+Y3gs IGluc3BlY3RvckhlaWdodCwgU1dQX05PWk9SREVSKTsK