6029 2005-12-10 03:14:41 -0800 plainText() returns a partial result when the node contains RTL text 2005-12-11 08:24:33 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 mitz webkit-unassigned xslf oldest_to_newest 25761 0 mitz 2005-12-10 03:14:41 -0800 Summary: Copying a selection to the clipboard or calling innerText on a node results in only part of the expected text being copied or returned in certain cases if the node contains RTL text. To reproduce: open the attached testcase in Safari. Select the words "select and copy this sentence", choose Edit > Copy and then examine the clipboard contents. Result: only "select " is copied to the clipboard. The testcase also contains an example of how innerText returns only the text up to "select ". Analysis: plainText() fails due to a bug in TextIterator::handleTextBox(), where the comment says "Determine what the next text box will be, but don't advance yet", in the RTL case it does advance. Combined with the sequence of newline and space, this causes the iterator to reach the end prematurely. 25762 1 5015 mitz 2005-12-10 03:17:00 -0800 Created attachment 5015 testcase 25763 2 5016 mitz 2005-12-10 04:13:15 -0800 Created attachment 5016 Advance m_sortedTextBoxes only when necessary 25764 3 5016 darin 2005-12-10 07:10:49 -0800 Comment on attachment 5016 Advance m_sortedTextBoxes only when necessary r=me 5015 2005-12-10 03:17:00 -0800 2005-12-10 03:17:00 -0800 testcase innertext-rtl-partial-result.html text/html 654 mitz PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPg0KPGh0bWw+CjxoZWFkPg0KPHRpdGxlPnBsYWluVGV4dCgpIHJldHVybmluZyBwYXJ0 aWFsIHJlc3VsdDwvdGl0bGU+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKPC9zY3JpcHQ+DQo8L2hlYWQ+DQo8Ym9keT4KPHA+ClRoaXMgdGVzdHMgcGxhaW5U ZXh0KCkgd2hlbiByZXZlcnNlZCB0ZXh0IGlzIHByZXNlbnQuClRoZSBmb2xsb3dpbmcgbGluZXMg c2hvdWxkIGJlIGlkZW50aWNhbC4KPC9wPgo8aHI+DQo8cCBpZD0idGFyZ2V0Ij4mI3gwNWQxOyYj eDA1ZDE7JiN4MDVlNzsmI3gwNWU5OyYjeDA1ZDQ7IHNlbGVjdAogYW5kIGNvcHkgdGhpcyBzZW50 ZW5jZS48L3A+CjxwPjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgIGRvY3VtZW50 LndyaXRlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQnKS5pbm5lclRleHQpOwo8L3Nj cmlwdD48L3A+CjwvYm9keT4NCjwvaHRtbD4K 5016 2005-12-10 04:13:15 -0800 2005-12-10 07:10:49 -0800 Advance m_sortedTextBoxes only when necessary 6029_r1.patch text/plain 6979 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzMgpkaWZm IC1wIC11IC1yMS4xMzIgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCi0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJMTAgRGVjIDIwMDUgMDI6NTk6MTEgLTAwMDAJMS4xMzIKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkxMCBEZWMgMjAwNSAxMjowOTozNSAtMDAwMApAQCAtMSwzICsxLDEzIEBACisyMDA1 LTEyLSMjICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGVz dCBmb3I6IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAy OQorICAgICAgICBwbGFpblRleHQoKSByZXR1cm5zIGEgcGFydGlhbCByZXN1bHQgd2hlbiB0aGUg bm9kZSBjb250YWlucyBSVEwgdGV4dCAKKworICAgICAgICAqIGZhc3QvZG9tL2lubmVyLXRleHQt cnRsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vaW5uZXItdGV4dC1y dGwuaHRtbDogQWRkZWQuCisKIDIwMDUtMTItMDkgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2Fy Y2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXcgbGF5b3V0IHRlc3RzIGZvcjoKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZG9tL2lubmVyLXRleHQtcnRsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 CmRpZmYgLU5wdSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9pbm5lci10ZXh0LXJ0bC1leHBlY3RlZC50 eHQKLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2lubmVyLXRleHQtcnRsLWV4cGVjdGVkLnR4dAkx IEphbiAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9pbm5lci10 ZXh0LXJ0bC1leHBlY3RlZC50eHQJMTAgRGVjIDIwMDUgMTE6MjA6MzcgLTAwMDAKQEAgLTAsMCAr MSw5IEBACitUaGlzIGlzIGEgdGVzdCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3Jn L3Nob3dfYnVnLmNnaT9pZD02MDI5IHBsYWluVGV4dCgpIHJldHVybnMgYSBwYXJ0aWFsIHJlc3Vs dCB3aGVuIHRoZSBub2RlIGNvbnRhaW5zIFJUTCB0ZXh0LgorCitUaGUgZm9sbG93aW5nIGxpbmVz IHNob3VsZCBiZSBpZGVudGljYWwuCisKK9eR15HXp9ep15Qgc2VsZWN0IGFuZCBjb3B5IHRoaXMg c2VudGVuY2UuCisKK9eR15HXp9ep15Qgc2VsZWN0IGFuZCBjb3B5IHRoaXMgc2VudGVuY2UuCisK KwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vaW5uZXItdGV4dC1ydGwuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09CmRpZmYgLU5wdSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9pbm5lci10ZXh0LXJ0bC5odG1sCi0t LSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9pbm5lci10ZXh0LXJ0bC5odG1sCTEgSmFuIDE5NzAgMDA6 MDA6MDAgLTAwMDAKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2lubmVyLXRleHQtcnRsLmh0bWwJ MTAgRGVjIDIwMDUgMTE6MTg6NDEgLTAwMDAKQEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0 bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFsLy9FTiIgImh0dHA6 Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25hbC5kdGQiPg0KKzxo dG1sPgorPGhlYWQ+DQorPHRpdGxlPnBsYWluVGV4dCgpIHJldHVybmluZyBwYXJ0aWFsIHJlc3Vs dDwvdGl0bGU+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKzwvc2NyaXB0Pg0KKzwvaGVhZD4NCis8Ym9keT4KKzxwPgorVGhpcyBpcyBhIHRlc3QgZm9y IDxpPmh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAyOQor cGxhaW5UZXh0KCkgcmV0dXJucyBhIHBhcnRpYWwgcmVzdWx0IHdoZW4gdGhlIG5vZGUgY29udGFp bnMgUlRMIHRleHQ8L2k+LgorPC9wPgorPHA+CitUaGUgZm9sbG93aW5nIGxpbmVzIHNob3VsZCBi ZSBpZGVudGljYWwuCis8L3A+Cis8aHI+DQorPHAgaWQ9InRhcmdldCI+JiN4MDVkMTsmI3gwNWQx OyYjeDA1ZTc7JiN4MDVlOTsmI3gwNWQ0OyBzZWxlY3QKKyBhbmQgY29weSB0aGlzIHNlbnRlbmNl LjwvcD4KKzxwPjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICBkb2N1bWVudC53 cml0ZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGFyZ2V0JykuaW5uZXJUZXh0KTsKKzwvc2Ny aXB0PjwvcD4KKzwvYm9keT4NCis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9DaGFuZ2VMb2csdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuNDk3CmRpZmYgLXAgLXUgLXIxLjQ5NyBXZWJDb3JlL0NoYW5nZUxvZwotLS0g V2ViQ29yZS9DaGFuZ2VMb2cJMTAgRGVjIDIwMDUgMDI6NTk6MjUgLTAwMDAJMS40OTcKKysrIFdl YkNvcmUvQ2hhbmdlTG9nCTEwIERlYyAyMDA1IDEyOjExOjQ3IC0wMDAwCkBAIC0xLDMgKzEsMTkg QEAKKzIwMDUtMTItIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz dDogZmFzdC9kb20vaW5uZXItdGV4dC1ydGwuaHRtbAorCisgICAgICAgICoga2h0bWwvZWRpdGlu Zy92aXNpYmxlX3RleHQuY3BwOgorICAgICAgICAoa2h0bWw6OlRleHRJdGVyYXRvcjo6aGFuZGxl VGV4dEJveCk6IEF2b2lkIGFkdmFuY2luZyBtX3NvcnRlZFRleHRCb3hlcyBpZiB0ZXh0Qm94RW5k IHdhc24ndCByZWFjaGVkLgorICAgICAgICAqIGt3cS9LV1FMaXN0SW1wbC5oOgorICAgICAgICAq IGt3cS9LV1FMaXN0SW1wbC5tbToKKyAgICAgICAgKEtXUUxpc3RJbXBsOjpnZXROZXh0KTogQWRk ZWQuCisgICAgICAgIChLV1FMaXN0SW1wbDo6Z2V0UHJldik6IEFkZGVkLgorICAgICAgICAqIGt3 cS9LV1FQdHJMaXN0Lmg6CisgICAgICAgIChRUHRyTGlzdDo6Z2V0TmV4dCk6IEFkZGVkLgorICAg ICAgICAoUVB0ckxpc3Q6OmdldFByZXYpOiBBZGRlZC4KKwogMjAwNS0xMi0wOSAgSnVzdGluIEdh cmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80MzcwMjA5PiBSZXByb2R1Y2libGUgY3Jhc2ggd2hlbiBwYXN0aW5nIG92ZXIgd2hpdGVzcGFj ZTpwcmUgdGV4dApJbmRleDogV2ViQ29yZS9raHRtbC9lZGl0aW5nL3Zpc2libGVfdGV4dC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvZWRpdGluZy92aXNp YmxlX3RleHQuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQyCmRpZmYgLXAgLXUgLXIxLjQy IFdlYkNvcmUva2h0bWwvZWRpdGluZy92aXNpYmxlX3RleHQuY3BwCi0tLSBXZWJDb3JlL2todG1s L2VkaXRpbmcvdmlzaWJsZV90ZXh0LmNwcAkxIERlYyAyMDA1IDEwOjMyOjE1IC0wMDAwCTEuNDIK KysrIFdlYkNvcmUva2h0bWwvZWRpdGluZy92aXNpYmxlX3RleHQuY3BwCTEwIERlYyAyMDA1IDEy OjExOjU2IC0wMDAwCkBAIC0yODcsNyArMjg3LDcgQEAgdm9pZCBUZXh0SXRlcmF0b3I6OmhhbmRs ZVRleHRCb3goKQogICAgICAgICBpbnQgcnVuRW5kID0ga01pbih0ZXh0Qm94RW5kLCBlbmQpOwog ICAgICAgICAKICAgICAgICAgLy8gRGV0ZXJtaW5lIHdoYXQgdGhlIG5leHQgdGV4dCBib3ggd2ls bCBiZSwgYnV0IGRvbid0IGFkdmFuY2UgeWV0Ci0gICAgICAgIElubGluZVRleHRCb3ggKm5leHRU ZXh0Qm94ID0gcmVuZGVyZXItPmNvbnRhaW5zUmV2ZXJzZWRUZXh0KCkgPyBtX3NvcnRlZFRleHRC b3hlcy5uZXh0KCkgOiBtX3RleHRCb3gtPm5leHRUZXh0Qm94KCk7CisgICAgICAgIElubGluZVRl eHRCb3ggKm5leHRUZXh0Qm94ID0gcmVuZGVyZXItPmNvbnRhaW5zUmV2ZXJzZWRUZXh0KCkgPyBt X3NvcnRlZFRleHRCb3hlcy5nZXROZXh0KCkgOiBtX3RleHRCb3gtPm5leHRUZXh0Qm94KCk7CiAK ICAgICAgICAgaWYgKHJ1blN0YXJ0IDwgcnVuRW5kKSB7CiAgICAgICAgICAgICAvLyBIYW5kbGUg ZWl0aGVyIGEgc2luZ2xlIG5ld2xpbmUgY2hhcmFjdGVyICh3aGljaCBiZWNvbWVzIGEgc3BhY2Up LApAQCAtMzI3LDEwICszMjcsMTQgQEAgdm9pZCBUZXh0SXRlcmF0b3I6OmhhbmRsZVRleHRCb3go KQogICAgICAgICAgICAgICAgIG1fbGFzdFRleHROb2RlRW5kZWRXaXRoQ29sbGFwc2VkU3BhY2Ug PSB0cnVlOyAvLyBjb2xsYXBzZWQgc3BhY2UgYmV0d2VlbiBydW5zIG9yIGF0IHRoZSBlbmQKICAg ICAgICAgICAgIH0KICAgICAgICAgICAgIG1fdGV4dEJveCA9IG5leHRUZXh0Qm94OworICAgICAg ICAgICAgaWYgKHJlbmRlcmVyLT5jb250YWluc1JldmVyc2VkVGV4dCgpKQorICAgICAgICAgICAg ICAgIG1fc29ydGVkVGV4dEJveGVzLm5leHQoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQogICAgICAgICAvLyBBZHZhbmNlIGFuZCBjb250aW51ZQogICAgICAgICBtX3RleHRCb3gg PSBuZXh0VGV4dEJveDsKKyAgICAgICAgaWYgKHJlbmRlcmVyLT5jb250YWluc1JldmVyc2VkVGV4 dCgpKQorICAgICAgICAgICAgbV9zb3J0ZWRUZXh0Qm94ZXMubmV4dCgpOwogICAgIH0KIH0KIApJ bmRleDogV2ViQ29yZS9rd3EvS1dRTGlzdEltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvV2ViQ29yZS9rd3EvS1dRTGlzdEltcGwuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44 CmRpZmYgLXAgLXUgLXIxLjggV2ViQ29yZS9rd3EvS1dRTGlzdEltcGwuaAotLS0gV2ViQ29yZS9r d3EvS1dRTGlzdEltcGwuaAkzIEp1bCAyMDA1IDA5OjQ1OjA4IC0wMDAwCTEuOAorKysgV2ViQ29y ZS9rd3EvS1dRTGlzdEltcGwuaAkxMCBEZWMgMjAwNSAxMjoxMjowMSAtMDAwMApAQCAtNTYsNiAr NTYsOCBAQCBwdWJsaWM6CiAKICAgICB2b2lkICpnZXRGaXJzdCgpIGNvbnN0OwogICAgIHZvaWQg KmdldExhc3QoKSBjb25zdDsKKyAgICB2b2lkICpnZXROZXh0KCkgY29uc3Q7CisgICAgdm9pZCAq Z2V0UHJldigpIGNvbnN0OwogICAgIHZvaWQgKmN1cnJlbnQoKSBjb25zdDsKICAgICB2b2lkICpm aXJzdCgpOwogICAgIHZvaWQgKmxhc3QoKTsKSW5kZXg6IFdlYkNvcmUva3dxL0tXUUxpc3RJbXBs Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2t3cS9LV1FMaXN0SW1w bC5tbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMwpkaWZmIC1wIC11IC1yMS4yMyBXZWJDb3Jl L2t3cS9LV1FMaXN0SW1wbC5tbQotLS0gV2ViQ29yZS9rd3EvS1dRTGlzdEltcGwubW0JMyBPY3Qg MjAwNSAyMToxMzowNiAtMDAwMAkxLjIzCisrKyBXZWJDb3JlL2t3cS9LV1FMaXN0SW1wbC5tbQkx MCBEZWMgMjAwNSAxMjoxMjowMSAtMDAwMApAQCAtMzczLDYgKzM3MywxNiBAQCB2b2lkICpLV1FM aXN0SW1wbDo6Z2V0TGFzdCgpIGNvbnN0CiAgICAgcmV0dXJuIHRhaWwgPyB0YWlsLT5kYXRhIDog MDsKIH0KIAordm9pZCAqS1dRTGlzdEltcGw6OmdldE5leHQoKSBjb25zdAoreworICAgIHJldHVy biBjdXIgJiYgY3VyLT5uZXh0ID8gY3VyLT5uZXh0LT5kYXRhIDogMDsKK30KKwordm9pZCAqS1dR TGlzdEltcGw6OmdldFByZXYoKSBjb25zdAoreworICAgIHJldHVybiBjdXIgJiYgY3VyLT5wcmV2 ID8gY3VyLT5wcmV2LT5kYXRhIDogMDsKK30KKwogdm9pZCAqS1dRTGlzdEltcGw6OmN1cnJlbnQo KSBjb25zdAogewogICAgIGlmIChjdXIgIT0gTlVMTCkgewpJbmRleDogV2ViQ29yZS9rd3EvS1dR UHRyTGlzdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2t3cS9LV1FQ dHJMaXN0LmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzAKZGlmZiAtcCAtdSAtcjEuMzAgV2Vi Q29yZS9rd3EvS1dRUHRyTGlzdC5oCi0tLSBXZWJDb3JlL2t3cS9LV1FQdHJMaXN0LmgJMiBTZXAg MjAwNSAxMDowMzoxOSAtMDAwMAkxLjMwCisrKyBXZWJDb3JlL2t3cS9LV1FQdHJMaXN0LmgJMTAg RGVjIDIwMDUgMTI6MTI6MDIgLTAwMDAKQEAgLTYwLDYgKzYwLDggQEAgcHVibGljOgogCiAgICAg VCAqZ2V0Rmlyc3QoKSBjb25zdCB7IHJldHVybiAoVCAqKWltcGwuZ2V0Rmlyc3QoKTsgfQogICAg IFQgKmdldExhc3QoKSBjb25zdCB7IHJldHVybiAoVCAqKWltcGwuZ2V0TGFzdCgpOyB9CisgICAg VCAqZ2V0TmV4dCgpIGNvbnN0IHsgcmV0dXJuIChUICopaW1wbC5nZXROZXh0KCk7IH0KKyAgICBU ICpnZXRQcmV2KCkgY29uc3QgeyByZXR1cm4gKFQgKilpbXBsLmdldFByZXYoKTsgfQogICAgIFQg KmN1cnJlbnQoKSBjb25zdCB7IHJldHVybiAoVCAqKWltcGwuY3VycmVudCgpOyB9CiAgICAgVCAq Zmlyc3QoKSB7IHJldHVybiAoVCAqKWltcGwuZmlyc3QoKTsgfQogICAgIFQgKmxhc3QoKSB7IHJl dHVybiAoVCAqKWltcGwubGFzdCgpOyB9Cg==