6025 2005-12-09 14:23:19 -0800 CDF example renders SVG on top of text 2006-01-29 06:40:37 -0800 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric eric oldest_to_newest 25752 0 eric 2005-12-09 14:23:19 -0800 CDF example renders SVG on top of text See attached test case (already landed under LayoutTests/svg/custom/simpleCDF.xml). 25753 1 5013 eric 2005-12-09 14:24:04 -0800 Created attachment 5013 Simple cdf example 25754 2 hyatt 2005-12-09 14:25:25 -0800 My guess would be that you need to implement baselinePosition and lineHeight on <svg> as is done with images. 25905 3 eric 2005-12-13 03:45:19 -0800 Yes, hyatt's suggestion does fix the bug. However, now I'm seeing my svgs being translated manually using m_x and m_y in the svg error cases (where <svg> is embedded inside a <body> element right after some <h3> and <p> text elements). Those are causing me to hit asserts... which I'm not quite sure what to do with yet. 30188 4 eric 2006-01-26 15:48:22 -0800 This is our most basic CDF issue. This is also one which is very well understood and shoudn't take very long to solve. We would not want to ship WebKit SVG support w/o this CDF issue solved. Bumping to p2, and adding SVGHitList keyword. 30399 5 6044 eric 2006-01-28 04:50:22 -0800 Created attachment 6044 proposed patch Simple fix. 30426 6 6044 darin 2006-01-28 16:49:55 -0800 Comment on attachment 6044 proposed patch Generally we put spaces around "=" as in: isRootLineBox=false I'd rather see C++ casts, like static_cast, then C-style casts in this code. Since virtual function calls are never inlined, it's usually best to put the implementations of virtual functions in a .cpp file rather than a header. Is there a test that goes with this? r=me 30435 7 eric 2006-01-28 17:17:20 -0800 Fixed. This is already covered by svg/custom/simpleCDF.xml 30505 8 eric 2006-01-29 06:40:37 -0800 Fixed in r12454. 5013 2005-12-09 14:24:04 -0800 2005-12-09 14:24:04 -0800 Simple cdf example simpleCDF.xml application/xml 393 eric PD94bWwgdmVyc2lvbj0iMS4wIj8+CjxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5 L3hodG1sIj4KPGhlYWQ+Cjx0aXRsZT5YSFRNTCArIFNWRyBUZXN0PC90aXRsZT4KPC9oZWFkPgo8 Ym9keT4KPHA+VGhpcyBpcyBhIHRlc3Qgb2YgQ0RGOjwvcD4KPHN2ZyB4bWxucz0iaHR0cDovL3d3 dy53My5vcmcvMjAwMC9zdmciIAogICAgIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8x OTk5L3hsaW5rIiB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIwMCI+CjxyZWN0IHg9IjAiIHk9IjAiIHdp ZHRoPSIyMDAiIGhlaWdodD0iMjAwIiBmaWxsPSJibHVlIiAvPgo8L3N2Zz4KPHA+WW91IHNob3Vs ZCBzZWUgYW4gU1ZHIGltYWdlIGFib3ZlIHRoaXMhPC9wPgo8L2JvZHk+CjwvaHRtbD4K 6044 2006-01-28 04:50:22 -0800 2006-01-28 16:49:55 -0800 proposed patch cdf.patch text/plain 1475 eric SW5kZXg6IGtjYW52YXMvZGV2aWNlL3F1YXJ0ei9LQ2FudmFzSXRlbVF1YXJ0ei5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGtjYW52YXMvZGV2aWNlL3F1YXJ0ei9LQ2FudmFzSXRlbVF1YXJ0ei5oCShyZXZpc2lv biAxMjQyMikKKysrIGtjYW52YXMvZGV2aWNlL3F1YXJ0ei9LQ2FudmFzSXRlbVF1YXJ0ei5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zOCw2ICszOCw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIEludFJl Y3QgZ2V0QWJzb2x1dGVSZXBhaW50UmVjdCgpOwogICAgIAogICAgIHZpcnR1YWwgYm9vbCByZXF1 aXJlc0xheWVyKCkgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIHNob3J0IGxpbmVIZWln aHQoYm9vbCBiLCBib29sIGlzUm9vdExpbmVCb3g9ZmFsc2UpIGNvbnN0IHsgcmV0dXJuIChzaG9y dCliYm94Rm9yUGF0aCh0cnVlKS5oZWlnaHQoKTsgfQorICAgIHZpcnR1YWwgc2hvcnQgYmFzZWxp bmVQb3NpdGlvbihib29sIGIsIGJvb2wgaXNSb290TGluZUJveD1mYWxzZSkgY29uc3QgeyByZXR1 cm4gKHNob3J0KWJib3hGb3JQYXRoKHRydWUpLmhlaWdodCgpOyB9CisgICAgCiAgICAgdmlydHVh bCB2b2lkIGxheW91dCgpOwogICAgIHZpcnR1YWwgdm9pZCBwYWludChQYWludEluZm8mLCBpbnQg cGFyZW50WCwgaW50IHBhcmVudFkpOwogICAgIHZpcnR1YWwgYm9vbCBub2RlQXRQb2ludChOb2Rl SW5mbyYsIGludCB4LCBpbnQgeSwgaW50IHR4LCBpbnQgdHksIFdlYkNvcmU6OkhpdFRlc3RBY3Rp b24pOwpJbmRleDoga2NhbnZhcy9kZXZpY2UvcXVhcnR6L0tDYW52YXNSZXNvdXJjZXNRdWFydHou aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBrY2FudmFzL2RldmljZS9xdWFydHovS0NhbnZhc1Jlc291cmNlc1F1 YXJ0ei5oCShyZXZpc2lvbiAxMjQyMikKKysrIGtjYW52YXMvZGV2aWNlL3F1YXJ0ei9LQ2FudmFz UmVzb3VyY2VzUXVhcnR6LmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDggQEAgcHVibGlj OgogICAgIAogICAgIHZpcnR1YWwgYm9vbCByZXF1aXJlc0xheWVyKCkgeyByZXR1cm4gZmFsc2U7 IH0KICAgICB2aXJ0dWFsIHZvaWQgY2FsY01pbk1heFdpZHRoKCk7CisgICAgdmlydHVhbCBzaG9y dCBsaW5lSGVpZ2h0KGJvb2wgYiwgYm9vbCBpc1Jvb3RMaW5lQm94PWZhbHNlKSBjb25zdCB7IHJl dHVybiBoZWlnaHQoKTsgfQorICAgIHZpcnR1YWwgc2hvcnQgYmFzZWxpbmVQb3NpdGlvbihib29s IGIsIGJvb2wgaXNSb290TGluZUJveD1mYWxzZSkgY29uc3QgeyByZXR1cm4gaGVpZ2h0KCk7IH0K ICAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0KCk7CiAgICAgdmlydHVhbCB2b2lkIHBhaW50KFBhaW50 SW5mbyAmcGFpbnRJbmZvLCBpbnQgcGFyZW50WCwgaW50IHBhcmVudFkpOwogICAgIAo=