60229 2011-05-04 16:28:57 -0700 Workaround iTunes' incorrect registry entry for .m4a extensions. 2011-05-05 14:59:34 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jer.noble jer.noble commit-queue oldest_to_newest 398383 0 jer.noble 2011-05-04 16:28:57 -0700 When iTunes is installed, it adds a registry key: "HKCR\.m4a\Content Type" = "audio/m4a". QuickTime (without iTunes) installs the same registry key as "Content Type" = "audio/x-m4a". QuickTime explicitly does not support "audio/m4a" codecs MIME types on either Mac or Windows, so .m4a files fail to load in WebKit when iTunes is installed. 398385 1 jer.noble 2011-05-04 16:29:48 -0700 Work around this by adding a hard coded entry to the MIME type map of ".m4a"->"audio/x-m4a". 398402 2 92346 jer.noble 2011-05-04 16:49:18 -0700 Created attachment 92346 Patch 398406 3 jer.noble 2011-05-04 16:53:55 -0700 <rdar://problem/9385799> 398436 4 92346 darin 2011-05-04 17:24:23 -0700 Comment on attachment 92346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92346&action=review > Source/WebCore/platform/win/MIMETypeRegistryWin.cpp:100 > mimetypeMap.add("wmlc", "application/vnd.wap.wmlc"); > + mimetypeMap.add("m4a", "audio/x-m4a"); I think the existing list is sorted in alphabetical order by extension. 398437 5 jer.noble 2011-05-04 17:28:32 -0700 (In reply to comment #4) > (From update of attachment 92346 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92346&action=review > > > Source/WebCore/platform/win/MIMETypeRegistryWin.cpp:100 > > mimetypeMap.add("wmlc", "application/vnd.wap.wmlc"); > > + mimetypeMap.add("m4a", "audio/x-m4a"); > > I think the existing list is sorted in alphabetical order by extension. It looks like it's sorted in willy-nilly order. Would you like it to be sorted in alphabetical order? 399026 6 92346 jer.noble 2011-05-05 14:16:26 -0700 Comment on attachment 92346 Patch Adding cq+. 399077 7 92346 commit-queue 2011-05-05 14:59:29 -0700 Comment on attachment 92346 Patch Clearing flags on attachment: 92346 Committed r85886: <http://trac.webkit.org/changeset/85886> 399078 8 commit-queue 2011-05-05 14:59:34 -0700 All reviewed patches have been landed. Closing bug. 92346 2011-05-04 16:49:18 -0700 2011-05-05 14:59:29 -0700 Patch bug-60229-20110504164923.patch text/plain 1681 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODU3MTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4Nzc0NzU1NjY3ZjNjZDEx OThkZDJmNDM3ZmQ3MjI1OGVhNDMwOTkwLi5mMGMyYjAyZGYxNmRlNzk2YWIxYTkyZTIzNGQ2ZTc2 ZjY4ZWNkYTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDQgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV29ya2Fyb3VuZCBpVHVuZXMnIGluY29ycmVjdCByZWdpc3Ry eSBlbnRyeSBmb3IgLm00YSBleHRlbnNpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAyMjkKKworICAgICAgICBObyBuZXcgdGVzdHMsIGFzIGEg dGVzdCBhbHJlYWR5IGV4aXRzIGZvciAubTRhIHN1cHBvcnQgKExheW91dFRlc3RzL21lZGlhL2F1 ZGlvLW1wZWc0LXN1cHBvcnRlZC5odG1sKS4KKyAgICAgICAgVGhlIHRlc3QgZmFpbGVkIHRvIGNh dGNoIHRoaXMgcmVncmVzc2lvbiBiZWNhdXNlIHRoZSBidWlsZCBib3RzIGhhdmVuJ3QgaW5zdGFs bGVkIGlUdW5lcy4KKyAgICAgICAgCisgICAgICAgIEFkZCBhIGhhcmQtY29kZWQgTUlNRSB0eXBl IG1hcHBpbmcgZm9yICdtNGEnIC0+ICdhdWRpby94LW00YScuCisKKyAgICAgICAgKiBwbGF0Zm9y bS93aW4vTUlNRVR5cGVSZWdpc3RyeVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNSU1FVHlw ZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZvckV4dGVuc2lvbik6CisKIDIwMTEtMDQtMjkgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT ZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vTUlNRVR5cGVS ZWdpc3RyeVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vTUlNRVR5cGVSZWdp c3RyeVdpbi5jcHAKaW5kZXggNTZkZGFiMTBmMWIwYmJmMzNjZDAyM2FhOWE3ZjVkZDdiZGIzMzZi My4uOTYyZTEwYmRhZTFkNGE1MDYzZDExNzQ4NGRhMjFiYWRmNzA0OTM2MiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL01JTUVUeXBlUmVnaXN0cnlXaW4uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9NSU1FVHlwZVJlZ2lzdHJ5V2luLmNwcApAQCAt OTcsNiArOTcsNyBAQCBTdHJpbmcgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRl bnNpb24oY29uc3QgU3RyaW5nICZleHQpCiAgICAgICAgIG1pbWV0eXBlTWFwLmFkZCgiYm1wIiwg ImltYWdlL2JtcCIpOwogICAgICAgICBtaW1ldHlwZU1hcC5hZGQoIndtbCIsICJ0ZXh0L3ZuZC53 YXAud21sIik7CiAgICAgICAgIG1pbWV0eXBlTWFwLmFkZCgid21sYyIsICJhcHBsaWNhdGlvbi92 bmQud2FwLndtbGMiKTsKKyAgICAgICAgbWltZXR5cGVNYXAuYWRkKCJtNGEiLCAiYXVkaW8veC1t NGEiKTsKICAgICB9CiAgICAgU3RyaW5nIHJlc3VsdCA9IG1pbWV0eXBlTWFwLmdldChleHQpOwog ICAgIGlmIChyZXN1bHQuaXNFbXB0eSgpKSB7Cg==