60227 2011-05-04 16:25:59 -0700 Add bundle API for making a page paint as the background of another page 2011-05-04 16:42:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 398378 0 andersca 2011-05-04 16:25:59 -0700 Add bundle API for making a page paint as the background of another page 398384 1 92343 andersca 2011-05-04 16:29:07 -0700 Created attachment 92343 Patch 398391 2 92343 darin 2011-05-04 16:35:12 -0700 Comment on attachment 92343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92343&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:587 > + if (m_underlayPage && m_underlayPage->mainFrame()->coreFrame()->view()) > + m_underlayPage->mainFrame()->coreFrame()->view()->updateLayoutAndStyleIfNeededRecursive(); That’s a long common subexpression. Maybe use a local variable? 398395 3 andersca 2011-05-04 16:42:06 -0700 Committed r85806: <http://trac.webkit.org/changeset/85806> 92343 2011-05-04 16:29:07 -0700 2011-05-04 16:35:12 -0700 Patch bug-60227-20110504162906.patch text/plain 4826 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1ODAyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDUtMDQgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYnVuZGxlIEFQSSBmb3IgbWFraW5nIGEgcGFnZSBw YWludCBhcyB0aGUgYmFja2dyb3VuZCBvZiBhbm90aGVyIHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMjI3CisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHA6CisgICAgICAgIChXS0J1 bmRsZVBhZ2VTZXRVbmRlcmxheVBhZ2UpOgorICAgICAgICBDYWxsIFdlYlBhZ2U6OnNldFVuZGVy bGF5UGFnZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Y2xvc2UpOgorICAgICAgICBOdWxsIG91dCB0aGUgdW5k ZXJsYXkgcGFnZS4KKworICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpsYXlvdXRJZk5lZWRlZCk6 CisgICAgICAgIExheW91dCB0aGUgdW5kZXJsYXkgcGFnZSBpZiBuZWNlc3NhcnkuCisKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZTo6ZHJhd1JlY3QpOgorICAgICAgICBEcmF3IHRoZSB1bmRlcmxh eSBwYWdlLgorCiAyMDExLTA1LTA0ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBDbGlwIGFuZCByZXBvc2l0aW9uIHdpbmRvd2VkIHBsdWdpbnMgd2hlbiB0aGUgVUkg cHJvY2VzcyBwYWludHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAJKHJldmlz aW9uIDg1Nzg0KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvYy9XS0J1bmRsZVBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDcsNiArMjA3LDExIEBA IFdLQnVuZGxlQmFja0ZvcndhcmRMaXN0UmVmIFdLQnVuZGxlUGFnZUcKICAgICByZXR1cm4gdG9B UEkodG9JbXBsKHBhZ2VSZWYpLT5iYWNrRm9yd2FyZExpc3QoKSk7CiB9CiAKK3ZvaWQgV0tCdW5k bGVQYWdlU2V0VW5kZXJsYXlQYWdlKFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVmLCBXS0J1bmRsZVBh Z2VSZWYgcGFnZVVuZGVybGF5UmVmKQoreworICAgIHRvSW1wbChwYWdlUmVmKS0+c2V0VW5kZXJs YXlQYWdlKHRvSW1wbChwYWdlVW5kZXJsYXlSZWYpKTsKK30KKwogdm9pZCBXS0J1bmRsZVBhZ2VJ bnN0YWxsUGFnZU92ZXJsYXkoV0tCdW5kbGVQYWdlUmVmIHBhZ2VSZWYsIFdLQnVuZGxlUGFnZU92 ZXJsYXlSZWYgcGFnZU92ZXJsYXlSZWYpCiB7CiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5pbnN0YWxs UGFnZU92ZXJsYXkodG9JbXBsKHBhZ2VPdmVybGF5UmVmKSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tC dW5kbGVQYWdlLmgJKHJldmlzaW9uIDg1Nzg0KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAt Mjg1LDYgKzI4NSw4IEBAIFdLX0VYUE9SVCBXS0J1bmRsZUZyYW1lUmVmIFdLQnVuZGxlUGFnZUcK IAogV0tfRVhQT1JUIFdLQnVuZGxlQmFja0ZvcndhcmRMaXN0UmVmIFdLQnVuZGxlUGFnZUdldEJh Y2tGb3J3YXJkTGlzdChXS0J1bmRsZVBhZ2VSZWYgcGFnZSk7CiAKK1dLX0VYUE9SVCB2b2lkIFdL QnVuZGxlUGFnZVNldFVuZGVybGF5UGFnZShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tCdW5kbGVQ YWdlUmVmIHBhZ2VVbmRlcmxheSk7CisKIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlUGFnZUluc3Rh bGxQYWdlT3ZlcmxheShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tCdW5kbGVQYWdlT3ZlcmxheVJl ZiBwYWdlT3ZlcmxheSk7CiBXS19FWFBPUlQgdm9pZCBXS0J1bmRsZVBhZ2VVbmluc3RhbGxQYWdl T3ZlcmxheShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tCdW5kbGVQYWdlT3ZlcmxheVJlZiBwYWdl T3ZlcmxheSk7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHAJKHJldmlzaW9uIDg1Nzg0KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjMsMTIgKzQyMywxMSBA QCB2b2lkIFdlYlBhZ2U6OmNsb3NlKCkKIAogICAgIG1fc2FuZGJveEV4dGVuc2lvblRyYWNrZXIu aW52YWxpZGF0ZSgpOwogCisgICAgbV91bmRlcmxheVBhZ2UgPSBudWxscHRyOwogICAgIG1fcHJp bnRDb250ZXh0ID0gbnVsbHB0cjsKLQogICAgIG1fbWFpbkZyYW1lLT5jb3JlRnJhbWUoKS0+bG9h ZGVyKCktPmRldGFjaEZyb21QYXJlbnQoKTsKLSAgICBtX3BhZ2UuY2xlYXIoKTsKLQotICAgIG1f ZHJhd2luZ0FyZWEuY2xlYXIoKTsKKyAgICBtX3BhZ2UgPSBudWxscHRyOworICAgIG1fZHJhd2lu Z0FyZWEgPSBudWxscHRyOwogCiAgICAgYm9vbCBpc1J1bm5pbmdNb2RhbCA9IG1faXNSdW5uaW5n TW9kYWw7CiAgICAgbV9pc1J1bm5pbmdNb2RhbCA9IGZhbHNlOwpAQCAtNTgzLDYgKzU4Miw5IEBA IHZvaWQgV2ViUGFnZTo6bGF5b3V0SWZOZWVkZWQoKQogewogICAgIGlmIChtX21haW5GcmFtZS0+ Y29yZUZyYW1lKCktPnZpZXcoKSkKICAgICAgICAgbV9tYWluRnJhbWUtPmNvcmVGcmFtZSgpLT52 aWV3KCktPnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKTsKKworICAgIGlm IChtX3VuZGVybGF5UGFnZSAmJiBtX3VuZGVybGF5UGFnZS0+bWFpbkZyYW1lKCktPmNvcmVGcmFt ZSgpLT52aWV3KCkpCisgICAgICAgIG1fdW5kZXJsYXlQYWdlLT5tYWluRnJhbWUoKS0+Y29yZUZy YW1lKCktPnZpZXcoKS0+dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgpOwog fQogCiB2b2lkIFdlYlBhZ2U6OnNldFNpemUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgdmlld1Np emUpCkBAIC02NzYsNiArNjc4LDEyIEBAIHZvaWQgV2ViUGFnZTo6ZHJhd1JlY3QoR3JhcGhpY3ND b250ZXh0JiAKIHsKICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoZ3Jh cGhpY3NDb250ZXh0KTsKICAgICBncmFwaGljc0NvbnRleHQuY2xpcChyZWN0KTsKKworICAgIGlm IChtX3VuZGVybGF5UGFnZSkgeworICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0 YXRlU2F2ZXIoZ3JhcGhpY3NDb250ZXh0KTsKKyAgICAgICAgbV91bmRlcmxheVBhZ2UtPmRyYXdS ZWN0KGdyYXBoaWNzQ29udGV4dCwgcmVjdCk7CisgICAgfQorCiAgICAgbV9tYWluRnJhbWUtPmNv cmVGcmFtZSgpLT52aWV3KCktPnBhaW50KCZncmFwaGljc0NvbnRleHQsIHJlY3QpOwogfQogCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHJldmlz aW9uIDg1Nzg0KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu aAkod29ya2luZyBjb3B5KQpAQCAtMjEyLDYgKzIxMiw4IEBAIHB1YmxpYzoKICAgICBJbmplY3Rl ZEJ1bmRsZVBhZ2VGdWxsU2NyZWVuQ2xpZW50JiBpbmplY3RlZEJ1bmRsZUZ1bGxTY3JlZW5DbGll bnQoKSB7IHJldHVybiBtX2Z1bGxTY3JlZW5DbGllbnQ7IH0KICNlbmRpZgogCisgICAgdm9pZCBz ZXRVbmRlcmxheVBhZ2UoUGFzc1JlZlB0cjxXZWJQYWdlPiB1bmRlcmxheVBhZ2UpIHsgbV91bmRl cmxheVBhZ2UgPSB1bmRlcmxheVBhZ2U7IH0KKwogICAgIGJvb2wgZmluZFN0cmluZ0Zyb21Jbmpl Y3RlZEJ1bmRsZShjb25zdCBTdHJpbmcmLCBGaW5kT3B0aW9ucyk7CiAKICAgICBXZWJGcmFtZSog bWFpbkZyYW1lKCkgY29uc3QgeyByZXR1cm4gbV9tYWluRnJhbWUuZ2V0KCk7IH0KQEAgLTYyOSw2 ICs2MzEsOCBAQCBwcml2YXRlOgogICAgIEZpbmRDb250cm9sbGVyIG1fZmluZENvbnRyb2xsZXI7 CiAgICAgUmVmUHRyPFBhZ2VPdmVybGF5PiBtX3BhZ2VPdmVybGF5OwogCisgICAgUmVmUHRyPFdl YlBhZ2U+IG1fdW5kZXJsYXlQYWdlOworCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICBSZWZQ dHI8V2ViSW5zcGVjdG9yPiBtX2luc3BlY3RvcjsKICNlbmRpZgo=